release-it 20.0.0-1 → 20.0.0

package/lib/plugin/npm/npm.js

@@ -91,7 +91,7 @@ class npm extends Plugin {
       allowSameVersion && '--allow-same-version',
       ...fixArgs(versionArgs)
     ];
-    const task = () => this.exec(`npm version ${args.filter(Boolean).join(' ')}`, { options: getOptions() });
+    const task = () => this.exec(`npm version ${args.filter(Boolean).join(' ')}`, { options: { env: getNpmEnv() } });
     return this.spinner.show({ task, label: 'npm version' });
   }
 
@@ -232,9 +232,7 @@ class npm extends Plugin {
   async guessPreReleaseTag() {
     const distTags = await this.getRegistryDistTags();
     const latestVersion = this.getLatestVersion();
-    const match = Object.entries(distTags).find(
-      ([tag, version]) => tag !== DEFAULT_TAG && version === latestVersion
-    );
+    const match = Object.entries(distTags).find(([tag, version]) => tag !== DEFAULT_TAG && version === latestVersion);
     if (match) return match[0];
 
     const [tag] = Object.keys(distTags).filter(tag => tag !== DEFAULT_TAG);

package/lib/prompt.js

@@ -27,9 +27,7 @@ class Prompt {
     if ('validate' in prompt) options.validate = prompt.validate;
     if ('pageSize' in prompt) options.pageSize = prompt.pageSize;
 
-    const answer = await (this.createPrompt
-      ? this.createPrompt(prompt.type, options)
-      : types[prompt.type](options));
+    const answer = await (this.createPrompt ? this.createPrompt(prompt.type, options) : types[prompt.type](options));
 
     const doExecute = prompt.type === 'confirm' ? answer : true;
 

package/lib/util.js

@@ -95,7 +95,7 @@ export const parseGitUrl = remoteUrl => {
     .replace(/\\+/g, '/'); // Replace forward with backslashes
   const parsedUrl = gitUrlParse(normalizedUrl);
   const { resource: host, name: project, protocol, href: remote } = parsedUrl;
-  const owner = protocol === 'file' ? parsedUrl.owner.split('/').at(-1) : parsedUrl.owner; // Fix owner for file protocol
+  const owner = protocol === 'file' ? parsedUrl.owner.split('/').at(-1) : parsedUrl.owner?.replace(/^\/+/, ''); // Fix owner for file protocol
   const repository = `${owner}/${project}`;
   return { host, owner, project, protocol, remote, repository };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "20.0.0-1",
+  "version": "20.0.0",
   "description": "Generic CLI tool to automate versioning and package publishing-related tasks.",
   "keywords": [
     "build",

package/test/npm.js

@@ -52,7 +52,11 @@ describe('npm', async () => {
   test('should guess tag from registry for pre-release matching current version', async t => {
     const npmClient = await factory(npm);
     npmClient.setContext({ latestVersion: '1.0.0-0' });
-    t.mock.method(npmClient, 'getRegistryDistTags', () => ({ latest: '0.9.0', alpha: '1.0.0-alpha.1', next: '1.0.0-0' }));
+    t.mock.method(npmClient, 'getRegistryDistTags', () => ({
+      latest: '0.9.0',
+      alpha: '1.0.0-alpha.1',
+      next: '1.0.0-0'
+    }));
     const tag = await npmClient.resolveTag('1.0.0-1');
     assert.equal(tag, 'next');
   });
@@ -407,4 +411,16 @@ describe('npm', async () => {
     const versionArgs = getArgs(exec, 'npm version');
     assert.match(versionArgs[0], / --workspaces-update=false --allow-same-version/);
   });
+
+  test('should not bypass dry-run guard for `npm version`', async t => {
+    const options = { 'dry-run': true, npm: { skipChecks: true } };
+    const npmClient = await factory(npm, { options });
+    const exec = t.mock.method(npmClient.shell, 'exec', () => Promise.resolve());
+    await runTasks(npmClient);
+    const versionCall = exec.mock.calls.find(call =>
+      (typeof call.arguments[0] === 'string' ? call.arguments[0] : '').startsWith('npm version')
+    );
+    assert.ok(versionCall, 'expected `npm version` to be invoked');
+    assert.notEqual(versionCall.arguments[1]?.write, false);
+  });
 });