release-it 18.0.0-next.1 → 18.0.0-next.2

package/lib/plugin/github/util.js

@@ -1,10 +1,12 @@
 // Totally much borrowed from https://github.com/semantic-release/github/blob/master/lib/success.js
 import issueParser from 'issue-parser';
 
-const getSearchQueries = (base, commits, separator = '+') => {
+export const getSearchQueries = (base, commits, separator = '+') => {
+  const encodedSeparator = encodeURIComponent(separator);
+
   return commits.reduce((searches, commit) => {
     const lastSearch = searches[searches.length - 1];
-    if (lastSearch && lastSearch.length + commit.length <= 256 - separator.length) {
+    if (lastSearch && encodeURIComponent(lastSearch).length + commit.length <= 256 - encodedSeparator.length) {
       searches[searches.length - 1] = `${lastSearch}${separator}${commit}`;
     } else {
       searches.push(`${base}${separator}${commit}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "18.0.0-next.1",
+  "version": "18.0.0-next.2",
   "description": "Generic CLI tool to automate versioning and package publishing-related tasks.",
   "keywords": [
     "build",
@@ -125,7 +125,7 @@
     "prettier": "3.3.3",
     "remark-cli": "12.0.1",
     "remark-preset-webpro": "1.1.0",
-    "sinon": "18.0.1",
+    "sinon": "19.0.0",
     "strip-ansi": "7.1.0",
     "typescript": "5.6.2"
   },

package/test/github.js

@@ -2,6 +2,7 @@ import test from 'ava';
 import sinon from 'sinon';
 import { RequestError } from '@octokit/request-error';
 import GitHub from '../lib/plugin/github/GitHub.js';
+import { getSearchQueries } from '../lib/plugin/github/util.js';
 import { factory, runTasks } from './util/index.js';
 import {
   interceptAuthentication,
@@ -485,3 +486,25 @@ test.skip('should truncate long body', async t => {
   t.is(releaseUrl, 'https://github.com/user/repo/releases/tag/2.0.2');
   exec.restore();
 });
+
+test('should generate search queries correctly', t => {
+  const generateCommit = () => Math.random().toString(36).substring(2, 9);
+  const base = 'repo:owner/repo+type:pr+is:merged';
+  const commits = Array.from({ length: 5 }, generateCommit);
+  const separator = '+';
+
+  const result = getSearchQueries(base, commits, separator);
+
+  // Test case 1: Check if all commits are included in the search queries
+  const allCommitsIncluded = commits.every(commit => result.some(query => query.includes(commit)));
+  t.true(allCommitsIncluded, 'All commits should be included in the search queries');
+
+  // Test case 2: Check if the function respects the 256 character limit
+  const manyCommits = Array.from({ length: 100 }, generateCommit);
+  const longResult = getSearchQueries(base, manyCommits, separator);
+  t.true(longResult.length > 1, 'Many commits should be split into multiple queries');
+  t.true(
+    longResult.every(query => encodeURIComponent(query).length <= 256),
+    'Each query should not exceed 256 characters after encoding'
+  );
+});