release-it 18.0.0-next.0 → 18.0.0-next.2

package/lib/config.js

@@ -2,7 +2,7 @@ import util from 'node:util';
 import { cosmiconfigSync } from 'cosmiconfig';
 import parseToml from '@iarna/toml/parse-string.js';
 import _ from 'lodash';
-import isCI from 'is-ci';
+import { isCI } from 'ci-info';
 import { readJSON, getSystemInfo } from './util.js';
 
 const debug = util.debug('release-it:config');

package/lib/plugin/github/util.js

@@ -1,10 +1,12 @@
 // Totally much borrowed from https://github.com/semantic-release/github/blob/master/lib/success.js
 import issueParser from 'issue-parser';
 
-const getSearchQueries = (base, commits, separator = '+') => {
+export const getSearchQueries = (base, commits, separator = '+') => {
+  const encodedSeparator = encodeURIComponent(separator);
+
   return commits.reduce((searches, commit) => {
     const lastSearch = searches[searches.length - 1];
-    if (lastSearch && lastSearch.length + commit.length <= 256 - separator.length) {
+    if (lastSearch && encodeURIComponent(lastSearch).length + commit.length <= 256 - encodedSeparator.length) {
       searches[searches.length - 1] = `${lastSearch}${separator}${commit}`;
     } else {
       searches.push(`${base}${separator}${commit}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "18.0.0-next.0",
+  "version": "18.0.0-next.2",
   "description": "Generic CLI tool to automate versioning and package publishing-related tasks.",
   "keywords": [
     "build",
@@ -82,23 +82,23 @@
     "@octokit/rest": "21.0.2",
     "async-retry": "1.3.3",
     "chalk": "5.3.0",
+    "ci-info": "^4.0.0",
     "cosmiconfig": "9.0.0",
     "execa": "9.3.1",
     "git-url-parse": "15.0.0",
     "globby": "14.0.2",
-    "inquirer": "10.1.8",
-    "is-ci": "3.0.1",
+    "inquirer": "10.2.2",
     "issue-parser": "7.0.1",
     "lodash": "4.17.21",
     "mime-types": "2.1.35",
     "new-github-release-url": "2.0.0",
     "open": "10.1.0",
-    "ora": "8.0.1",
+    "ora": "8.1.0",
     "os-name": "6.0.0",
     "proxy-agent": "6.4.0",
     "semver": "7.6.3",
     "shelljs": "0.8.5",
-    "update-notifier": "7.2.0",
+    "update-notifier": "7.3.1",
     "url-join": "5.0.0",
     "wildcard-match": "5.1.3",
     "yargs-parser": "21.1.1"
@@ -106,28 +106,28 @@
   "devDependencies": {
     "@eslint/compat": "1.1.1",
     "@eslint/eslintrc": "3.1.0",
-    "@eslint/js": "9.9.1",
+    "@eslint/js": "9.10.0",
     "@octokit/request-error": "6.1.4",
-    "@types/node": "20.14.10",
+    "@types/node": "22.5.4",
     "ava": "6.1.3",
-    "eslint": "9.9.1",
+    "eslint": "9.10.0",
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-ava": "15.0.1",
-    "eslint-plugin-import-x": "3.1.0",
+    "eslint-plugin-import-x": "4.2.1",
     "eslint-plugin-prettier": "5.2.1",
     "fs-monkey": "1.0.6",
     "globals": "15.9.0",
     "installed-check": "9.3.0",
-    "knip": "5.27.3",
+    "knip": "5.30.1",
     "memfs": "4.11.1",
     "mock-stdio": "1.0.3",
     "nock": "14.0.0-beta.8",
     "prettier": "3.3.3",
     "remark-cli": "12.0.1",
     "remark-preset-webpro": "1.1.0",
-    "sinon": "18.0.0",
+    "sinon": "19.0.0",
     "strip-ansi": "7.1.0",
-    "typescript": "5.5.4"
+    "typescript": "5.6.2"
   },
   "overrides": {
     "pac-resolver": "7.0.1",

package/test/config.js

@@ -1,5 +1,5 @@
 import test from 'ava';
-import isCI from 'is-ci';
+import { isCI } from 'ci-info';
 import Config from '../lib/config.js';
 import { readJSON } from '../lib/util.js';
 

package/test/github.js

@@ -2,6 +2,7 @@ import test from 'ava';
 import sinon from 'sinon';
 import { RequestError } from '@octokit/request-error';
 import GitHub from '../lib/plugin/github/GitHub.js';
+import { getSearchQueries } from '../lib/plugin/github/util.js';
 import { factory, runTasks } from './util/index.js';
 import {
   interceptAuthentication,
@@ -485,3 +486,25 @@ test.skip('should truncate long body', async t => {
   t.is(releaseUrl, 'https://github.com/user/repo/releases/tag/2.0.2');
   exec.restore();
 });
+
+test('should generate search queries correctly', t => {
+  const generateCommit = () => Math.random().toString(36).substring(2, 9);
+  const base = 'repo:owner/repo+type:pr+is:merged';
+  const commits = Array.from({ length: 5 }, generateCommit);
+  const separator = '+';
+
+  const result = getSearchQueries(base, commits, separator);
+
+  // Test case 1: Check if all commits are included in the search queries
+  const allCommitsIncluded = commits.every(commit => result.some(query => query.includes(commit)));
+  t.true(allCommitsIncluded, 'All commits should be included in the search queries');
+
+  // Test case 2: Check if the function respects the 256 character limit
+  const manyCommits = Array.from({ length: 100 }, generateCommit);
+  const longResult = getSearchQueries(base, manyCommits, separator);
+  t.true(longResult.length > 1, 'Many commits should be split into multiple queries');
+  t.true(
+    longResult.every(query => encodeURIComponent(query).length <= 256),
+    'Each query should not exceed 256 characters after encoding'
+  );
+});