release-it 17.0.5 → 17.1.1

package/lib/plugin/github/GitHub.js

@@ -139,12 +139,16 @@ class GitHub extends Release {
       return this.step({ task, label: 'Generating link to GitHub Release web interface', prompt: 'release' });
     } else if (isCI) {
       await this.step({ task: () => this[publishMethod](), label: `GitHub ${type} release` });
-      return this.step({ enabled: assets, task: () => this.uploadAssets(), label: 'GitHub upload assets' });
+      await this.step({ enabled: assets, task: () => this.uploadAssets(), label: 'GitHub upload assets' });
+      return this.step({
+        task: () => (isUpdate ? Promise.resolve() : this.commentOnResolvedItems()),
+        label: 'GitHub comment on resolved items'
+      });
     } else {
       const release = async () => {
         await this[publishMethod]();
         await this.uploadAssets();
-        return isUpdate ? Promise.resolve() : this.commentOnResolvedItems();
+        return isUpdate ? Promise.resolve(true) : this.commentOnResolvedItems();
       };
       return this.step({ task: release, label: `GitHub ${type} release`, prompt: 'release' });
     }
@@ -373,10 +377,10 @@ class GitHub extends Release {
     const { owner, project: repo } = this.getContext('repo');
     const changelog = await this.getChangelog();
     const { comments } = this.options;
-    const { submit, issue, pr } = comments;
+    const { submit, issue, pr } = comments ?? {};
     const context = this.getContext();
 
-    if (!submit || !changelog) return;
+    if (!submit || !changelog) return true;
 
     const shas = getCommitsFromChangelog(changelog);
     const searchResults = await Promise.all(searchQueries(this.client, owner, repo, shas));
@@ -392,7 +396,7 @@ class GitHub extends Release {
 
       if (isDryRun) {
         this.log.exec(`octokit issues.createComment (${url})`, { isDryRun });
-        return;
+        return Promise.resolve();
       }
 
       try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "17.0.5",
+  "version": "17.1.1",
   "description": "Generic CLI tool to automate versioning and package publishing-related tasks.",
   "keywords": [
     "build",