release-it 15.7.0 → 15.8.0

package/lib/plugin/github/GitHub.js

@@ -31,6 +31,12 @@ const parseErrormsg = err => {
   return msg;
 };
 
+const truncateBody = body => {
+  // https://github.com/release-it/release-it/issues/965
+  if (body && body.length >= 124000) return body.substring(0, 124000) + '...';
+  return body;
+};
+
 class GitHub extends Release {
   constructor(...args) {
     super(...args);
@@ -200,7 +206,7 @@ class GitHub extends Release {
     const { version, releaseNotes, isUpdate } = this.getContext();
     const { isPreRelease } = parseVersion(version);
     const name = format(releaseName, this.config.getContext());
-    const body = autoGenerate ? (isUpdate ? null : '') : releaseNotes;
+    const body = autoGenerate ? (isUpdate ? null : '') : truncateBody(releaseNotes);
 
     return Object.assign(options, {
       owner,

package/lib/plugin/npm/npm.js

@@ -91,6 +91,7 @@ class npm extends Plugin {
 
   release() {
     if (this.options.publish === false) return false;
+    if (this.getContext('private')) return false;
     const publish = () => this.publish({ otpCallback });
     const otpCallback =
       this.config.isCI && !this.config.isPromptOnlyVersion ? null : task => this.step({ prompt: 'otp', task });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "15.7.0",
+  "version": "15.8.0",
   "description": "Generic CLI tool to automate versioning and package publishing related tasks.",
   "keywords": [
     "build",
@@ -67,7 +67,7 @@
     "execa": "7.0.0",
     "git-url-parse": "13.1.0",
     "globby": "13.1.3",
-    "got": "12.5.3",
+    "got": "12.6.0",
     "inquirer": "9.1.4",
     "is-ci": "3.0.1",
     "lodash": "4.17.21",
@@ -90,7 +90,7 @@
     "@octokit/request-error": "3.0.3",
     "ava": "5.2.0",
     "eslint": "8.35.0",
-    "eslint-config-prettier": "8.6.0",
+    "eslint-config-prettier": "8.7.0",
     "eslint-plugin-ava": "14.0.0",
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-prettier": "4.2.1",

package/test/github.js

@@ -425,3 +425,34 @@ test('should generate GitHub web release url for enterprise host', async t => {
   );
   exec.restore();
 });
+
+// eslint-disable-next-line ava/no-skip-test
+test.skip('should truncate long body', async t => {
+  const releaseNotes = 'a'.repeat(125001);
+  const body = 'a'.repeat(124000) + '...';
+  const options = {
+    git,
+    github: {
+      pushRepo,
+      tokenRef,
+      release: true,
+      releaseName: 'Release ${tagName}',
+      releaseNotes: 'echo ' + releaseNotes
+    }
+  };
+  const github = factory(GitHub, { options });
+  const exec = sinon.stub(github.shell, 'exec').callThrough();
+  exec.withArgs('git log --pretty=format:"* %s (%h)" ${from}...${to}').resolves('');
+  exec.withArgs('git describe --tags --match=* --abbrev=0').resolves('2.0.1');
+
+  interceptAuthentication();
+  interceptCollaborator();
+  interceptCreate({ body: { tag_name: '2.0.2', name: 'Release 2.0.2', body } });
+
+  await runTasks(github);
+
+  const { isReleased, releaseUrl } = github.getContext();
+  t.true(isReleased);
+  t.is(releaseUrl, 'https://github.com/user/repo/releases/tag/2.0.2');
+  exec.restore();
+});

package/test/tasks.js

@@ -384,7 +384,7 @@ test.serial('should handle private package correctly, bump lockfile', async t =>
   const npmArgs = getArgs(container.shell.exec.args, 'npm');
   t.deepEqual(npmArgs, ['npm version 1.0.1 --no-git-tag-version']);
   t.true(log.obtrusive.firstCall.args[0].endsWith(`release ${pkgName} (1.0.0...1.0.1)`));
-  t.is(log.warn.lastCall.args[0], 'Skip publish: package is private.');
+  t.is(log.warn.length, 0);
   t.regex(log.log.firstCall.args[0], /Done \(in [0-9]+s\.\)/);
 
   exec.restore();