release-it 15.4.0 → 15.4.2

package/lib/plugin/github/GitHub.js

@@ -286,7 +286,7 @@ class GitHub extends Release {
 
     this.log.exec('octokit repos.uploadReleaseAssets', patterns, { isDryRun });
 
-    if (!assets || !isReleased || isDryRun) {
+    if (!assets || !isReleased) {
       return true;
     }
 
@@ -294,6 +294,9 @@ class GitHub extends Release {
       if (!files.length) {
         this.log.warn(`octokit repos.uploadReleaseAssets: did not find "${assets}" relative to ${process.cwd()}`);
       }
+
+      if (isDryRun) return Promise.resolve();
+
       return Promise.all(files.map(filePath => this.uploadAsset(filePath)));
     });
   }

package/lib/plugin/gitlab/GitLab.js

@@ -257,7 +257,7 @@ class GitLab extends Release {
 
     this.log.exec('gitlab releases#uploadAssets', patterns, { isDryRun });
 
-    if (!assets || isDryRun) {
+    if (!assets) {
       return noop;
     }
 
@@ -265,6 +265,9 @@ class GitLab extends Release {
       if (!files.length) {
         this.log.warn(`gitlab releases#uploadAssets: could not find "${assets}" relative to ${process.cwd()}`);
       }
+
+      if (isDryRun) return Promise.resolve();
+
       return Promise.all(files.map(filePath => this.uploadAsset(filePath)));
     });
   }

package/lib/util.js

@@ -48,7 +48,10 @@ const rejectAfter = (ms, error) =>
 
 const parseGitUrl = remoteUrl => {
   if (!remoteUrl) return { host: null, owner: null, project: null, protocol: null, remote: null, repository: null };
-  const normalizedUrl = (remoteUrl || '').replace(/^[A-Z]:/, '').replace(/\\/g, '/'); // Hacky workaround for file protocol in Windows
+  const normalizedUrl = (remoteUrl || '')
+    .replace(/^[A-Z]:\\\\/, 'file://') // Assume file protocol for Windows drive letters
+    .replace(/^\//, 'file://') // Assume file protocol if only /path is given
+    .replace(/\\+/g, '/'); // Replace forward with backslashes
   const parsedUrl = gitUrlParse(normalizedUrl);
   const { resource: host, name: project, protocol, href: remote } = parsedUrl;
   const owner = protocol === 'file' ? _.last(parsedUrl.owner.split('/')) : parsedUrl.owner; // Fix owner for file protocol

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-it",
-  "version": "15.4.0",
+  "version": "15.4.2",
   "description": "Generic CLI tool to automate versioning and package publishing related tasks.",
   "keywords": [
     "build",
@@ -60,16 +60,16 @@
   "license": "MIT",
   "dependencies": {
     "@iarna/toml": "2.2.5",
-    "@octokit/rest": "19.0.3",
+    "@octokit/rest": "19.0.4",
     "async-retry": "1.3.3",
     "chalk": "5.0.1",
     "cosmiconfig": "7.0.1",
     "execa": "6.1.0",
     "form-data": "4.0.0",
-    "git-url-parse": "12.0.0",
+    "git-url-parse": "13.0.0",
     "globby": "13.1.2",
-    "got": "12.3.1",
-    "inquirer": "9.1.0",
+    "got": "12.4.1",
+    "inquirer": "9.1.1",
     "is-ci": "3.0.1",
     "lodash": "4.17.21",
     "mime-types": "2.1.35",
@@ -88,9 +88,9 @@
     "yargs-parser": "21.1.1"
   },
   "devDependencies": {
-    "@octokit/request-error": "3.0.0",
-    "ava": "4.3.1",
-    "eslint": "8.21.0",
+    "@octokit/request-error": "3.0.1",
+    "ava": "4.3.3",
+    "eslint": "8.23.1",
     "eslint-config-prettier": "8.5.0",
     "eslint-plugin-ava": "13.2.0",
     "eslint-plugin-import": "2.26.0",

package/test/git.js

@@ -274,7 +274,7 @@ test.serial('should reset files', async t => {
 
 test.serial('should roll back when cancelled', async t => {
   sh.exec('git init');
-  sh.exec(`git remote add origin foo`);
+  sh.exec(`git remote add origin file://foo`);
   const version = '1.2.3';
   gitAdd(`{"version":"${version}"}`, 'package.json', 'Add package.json');
   const options = { git: { requireCleanWorkingDir: true, commit: true, tag: true, tagName: 'v${version}' } };

package/test/utils.js

@@ -47,12 +47,39 @@ test('parseGitUrl', t => {
     repository: 'org/sub-group/repo-in-sub-group'
   });
 
+  t.deepEqual(parseGitUrl('git@github.com:org/example.com.git'), {
+    host: 'github.com',
+    owner: 'org',
+    project: 'example.com',
+    protocol: 'ssh',
+    remote: 'git@github.com:org/example.com.git',
+    repository: 'org/example.com'
+  });
+
+  t.deepEqual(parseGitUrl('file://Users/john/doe/owner/project'), {
+    host: 'users',
+    owner: 'owner',
+    project: 'project',
+    protocol: 'file',
+    remote: 'file://users/john/doe/owner/project',
+    repository: 'owner/project'
+  });
+
   t.deepEqual(parseGitUrl('/Users/john/doe/owner/project'), {
-    host: '',
+    host: 'users',
+    owner: 'owner',
+    project: 'project',
+    protocol: 'file',
+    remote: 'file://users/john/doe/owner/project',
+    repository: 'owner/project'
+  });
+
+  t.deepEqual(parseGitUrl('C:\\\\Users\\john\\doe\\owner\\project'), {
+    host: 'users',
     owner: 'owner',
     project: 'project',
     protocol: 'file',
-    remote: '/Users/john/doe/owner/project',
+    remote: 'file://users/john/doe/owner/project',
     repository: 'owner/project'
   });
 });