relay-runtime 4.0.0 → 5.0.0

package/lib/RelayModernQueryExecutor.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- *  strict-local
+ * 
  * @format
  * @emails oncall+relay
  */
@@ -16,8 +16,6 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 
 var RelayError = require("./RelayError");
 
-var RelayFeatureFlags = require("./RelayFeatureFlags");
-
 var RelayInMemoryRecordSource = require("./RelayInMemoryRecordSource");
 
 var RelayModernRecord = require("./RelayModernRecord");
@@ -28,6 +26,11 @@ var RelayResponseNormalizer = require("./RelayResponseNormalizer");
 
 var invariant = require("fbjs/lib/invariant");
 
+var stableCopy = require("./stableCopy"); // flowlint-next-line untyped-import:off
+
+
+var warning = require("fbjs/lib/warning");
+
 var _require = require("./ClientID"),
     generateClientID = _require.generateClientID;
 
@@ -62,8 +65,9 @@ function () {
         sink = _ref.sink,
         source = _ref.source,
         updater = _ref.updater,
-        operationTracker = _ref.operationTracker;
-    this._incrementalPlaceholders = new Map();
+        operationTracker = _ref.operationTracker,
+        getDataID = _ref.getDataID;
+    this._incrementalResults = new Map();
     this._nextSubscriptionId = 0;
     this._operation = operation;
     this._operationLoader = operationLoader;
@@ -76,13 +80,14 @@ function () {
     this._updater = updater;
     this._subscriptions = new Map();
     this._operationTracker = operationTracker;
+    this._getDataID = getDataID;
     var id = this._nextSubscriptionId++;
     source.subscribe({
       complete: function complete() {
         return _this._complete(id);
       },
       error: function error(_error2) {
-        return _this._error(id, _error2);
+        return _this._error(_error2);
       },
       next: function next(response) {
         try {
@@ -133,7 +138,7 @@ function () {
       this._publishQueue.run();
     }
 
-    this._incrementalPlaceholders.clear();
+    this._incrementalResults.clear();
 
     this._completeOperationTracker();
   };
@@ -163,7 +168,7 @@ function () {
           return _this2._complete(_id2);
         },
         error: function error(_error3) {
-          return _this2._error(_id2, _error3);
+          return _this2._error(_error3);
         },
         start: function start(subscription) {
           return _this2._start(_id2, subscription);
@@ -184,7 +189,7 @@ function () {
     }
   };
 
-  _proto._error = function _error(_id, error) {
+  _proto._error = function _error(error) {
     this.cancel();
 
     this._sink.error(error);
@@ -192,8 +197,8 @@ function () {
 
   _proto._start = function _start(id, subscription) {
     this._subscriptions.set(id, subscription);
-  }; // Handle a raw GraphQL response.
-
+  } // Handle a raw GraphQL response.
+  ;
 
   _proto._next = function _next(_id, response) {
     var _this3 = this;
@@ -245,10 +250,14 @@ function () {
           label = response.label;
 
       if (path != null || label != null) {
-        if (typeof label !== 'string' || !Array.isArray(path)) {
-          !false ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernQueryExecutor: invalid incremental payload, expected ' + '`path` and `label` to either both be null/undefined, or ' + '`path` to be an `Array<string | number>` and `label` to be a ' + '`string`.') : invariant(false) : void 0;
+        if (typeof label === 'string' && Array.isArray(path)) {
+          this._processIncrementalResponse({
+            path: path,
+            label: label,
+            response: responseWithData
+          });
         } else {
-          this._processIncrementalResponse(label, path, responseWithData);
+          !false ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernQueryExecutor: invalid incremental payload, expected ' + '`path` and `label` to either both be null/undefined, or ' + '`path` to be an `Array<string | number>` and `label` to be a ' + '`string`.') : invariant(false) : void 0;
         }
       } else {
         this._processResponse(responseWithData);
@@ -262,7 +271,7 @@ function () {
     !(this._optimisticUpdate === null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'environment.execute: only support one optimistic response per ' + 'execute.') : invariant(false) : void 0;
     var payload = normalizeResponse(response, this._operation.root, ROOT_TYPE, []
     /* path */
-    );
+    , this._getDataID);
     var incrementalPlaceholders = payload.incrementalPlaceholders,
         moduleImportPayloads = payload.moduleImportPayloads;
 
@@ -283,6 +292,8 @@ function () {
   };
 
   _proto._processResponse = function _processResponse(response) {
+    var _response$extensions2;
+
     if (this._optimisticUpdate !== null) {
       this._publishQueue.revertUpdate(this._optimisticUpdate);
 
@@ -291,9 +302,9 @@ function () {
 
     var payload = normalizeResponse(response, this._operation.root, ROOT_TYPE, []
     /* path */
-    );
+    , this._getDataID);
 
-    this._incrementalPlaceholders.clear();
+    this._incrementalResults.clear();
 
     this._source.clear();
 
@@ -304,12 +315,20 @@ function () {
     var updatedOwners = this._publishQueue.run();
 
     this._updateOperationTracker(updatedOwners);
-  };
+
+    if (payload.incrementalPlaceholders && payload.incrementalPlaceholders.length !== 0 && ((_response$extensions2 = response.extensions) === null || _response$extensions2 === void 0 ? void 0 : _response$extensions2.is_final) === true) {
+      // The query has defer/stream selections that are enabled, but the server
+      // indicated that this is a "final" payload: no incremental payloads will
+      // be delivered. Warn that the query was (likely) executed on the server
+      // in non-streaming mode, with incremental delivery disabled.
+      process.env.NODE_ENV !== "production" ? warning(false, 'RelayModernEnvironment: Operation `%s` contains @defer/@stream ' + 'directives but was executed in non-streaming mode. See ' + 'https://fburl.com/relay-incremental-delivery-non-streaming-warning.', this._operation.node.params.name) : void 0;
+    }
+  }
   /**
    * Handles any follow-up actions for a Relay payload for @match, @defer,
    * and (in the future) @stream directives.
    */
-
+  ;
 
   _proto._processPayloadFollowups = function _processPayloadFollowups(payload) {
     var _this4 = this;
@@ -326,12 +345,11 @@ function () {
     }
 
     if (incrementalPlaceholders && incrementalPlaceholders.length !== 0) {
-      !RelayFeatureFlags.ENABLE_INCREMENTAL_DELIVERY ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Unexpected use of @defer/@stream in ' + 'operation `%s`.', this._operation.node.params.name) : invariant(false) : void 0;
       incrementalPlaceholders.forEach(function (incrementalPlaceholder) {
         _this4._processIncrementalPlaceholder(payload, incrementalPlaceholder);
       });
     }
-  };
+  }
   /**
    * Processes a ModuleImportPayload, asynchronously resolving the normalization
    * AST and using it to normalize the field data into a RelayResponsePayload.
@@ -339,34 +357,47 @@ function () {
    * defer, stream, etc); these are handled by calling
    * `_processPayloadFollowups()`.
    */
-
+  ;
 
   _proto._processModuleImportPayload = function _processModuleImportPayload(moduleImportPayload, operationLoader) {
     var _this5 = this;
 
-    var id = this._nextSubscriptionId++; // Observable.from(operationLoader.load()) wouldn't catch synchronous errors
-    // thrown by the load function, which is user-defined. Guard against that
-    // with Observable.from(new Promise(<work>)).
+    var syncOperation = operationLoader.get(moduleImportPayload.operationReference);
 
-    RelayObservable.from(new Promise(function (resolve, reject) {
-      operationLoader.load(moduleImportPayload.operationReference).then(resolve, reject);
-    })).map(function (operation) {
-      if (operation != null) {
-        _this5._schedule(function () {
-          _this5._handleModuleImportPayload(moduleImportPayload, operation);
-        });
-      }
-    }).subscribe({
-      complete: function complete() {
-        return _this5._complete(id);
-      },
-      error: function error(_error4) {
-        return _this5._error(id, _error4);
-      },
-      start: function start(subscription) {
-        return _this5._start(id, subscription);
-      }
-    });
+    if (syncOperation != null) {
+      // If the operation module is available synchronously, normalize the
+      // data synchronously.
+      this._schedule(function () {
+        _this5._handleModuleImportPayload(moduleImportPayload, syncOperation);
+      });
+    } else {
+      // Otherwise load the operation module and schedule a task to normalize
+      // the data when the module is available.
+      var _id3 = this._nextSubscriptionId++; // Observable.from(operationLoader.load()) wouldn't catch synchronous
+      // errors thrown by the load function, which is user-defined. Guard
+      // against that with Observable.from(new Promise(<work>)).
+
+
+      RelayObservable.from(new Promise(function (resolve, reject) {
+        operationLoader.load(moduleImportPayload.operationReference).then(resolve, reject);
+      })).map(function (operation) {
+        if (operation != null) {
+          _this5._schedule(function () {
+            _this5._handleModuleImportPayload(moduleImportPayload, operation);
+          });
+        }
+      }).subscribe({
+        complete: function complete() {
+          return _this5._complete(_id3);
+        },
+        error: function error(_error4) {
+          return _this5._error(_error4);
+        },
+        start: function start(subscription) {
+          return _this5._start(_id3, subscription);
+        }
+      });
+    }
   };
 
   _proto._handleModuleImportPayload = function _handleModuleImportPayload(moduleImportPayload, operation) {
@@ -377,7 +408,7 @@ function () {
     };
     var relayPayload = normalizeResponse({
       data: moduleImportPayload.data
-    }, selector, moduleImportPayload.typeName, moduleImportPayload.path);
+    }, selector, moduleImportPayload.typeName, moduleImportPayload.path, this._getDataID);
 
     this._processPayloadFollowups(relayPayload);
 
@@ -386,39 +417,44 @@ function () {
     var updatedOwners = this._publishQueue.run();
 
     this._updateOperationTracker(updatedOwners);
-  };
+  }
   /**
-   * Stores a mapping of label => path => placeholder; at this point the
-   * executor knows *how* to process the incremental data and has to save
-   * this until the data is available. The placeholder contains the
-   * normalization selector, path (for nested defer/stream), and other metadata
-   * used to normalize the incremental response.
+   * The executor now knows that GraphQL responses are expected for a given
+   * label/path:
+   * - Store the placeholder in order to process any future responses that may
+   *   arrive.
+   * - Then process any responses that had already arrived.
+   *
+   * The placeholder contains the normalization selector, path (for nested
+   * defer/stream), and other metadata used to normalize the incremental
+   * response(s).
    */
-
+  ;
 
   _proto._processIncrementalPlaceholder = function _processIncrementalPlaceholder(relayPayload, placeholder) {
+    var _this6 = this;
+
     var _relayPayload$fieldPa;
 
     // Update the label => path => placeholder map
-    var kind = placeholder.kind,
-        label = placeholder.label,
+    var label = placeholder.label,
         path = placeholder.path;
     var pathKey = path.map(String).join('.');
 
-    var dataForLabel = this._incrementalPlaceholders.get(label);
+    var resultForLabel = this._incrementalResults.get(label);
 
-    if (dataForLabel == null) {
-      dataForLabel = {
-        kind: kind,
-        placeholdersByPath: new Map()
-      };
+    if (resultForLabel == null) {
+      resultForLabel = new Map();
 
-      this._incrementalPlaceholders.set(label, dataForLabel);
-    } else if (dataForLabel.kind !== kind) {
-      !false ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Received inconsistent data for label `%s`, ' + 'expected `@%s` data but got `@%s` data.', label, dataForLabel.kind, kind) : invariant(false) : void 0;
+      this._incrementalResults.set(label, resultForLabel);
     }
 
-    dataForLabel.placeholdersByPath.set(pathKey, placeholder); // Store references to the parent node to allow detecting concurrent
+    var resultForPath = resultForLabel.get(pathKey);
+    var pendingResponses = resultForPath != null && resultForPath.kind === 'response' ? resultForPath.responses : null;
+    resultForLabel.set(pathKey, {
+      kind: 'placeholder',
+      placeholder: placeholder
+    }); // Store references to the parent node to allow detecting concurrent
     // modifications to the parent before items arrive and to replay
     // handle field payloads to account for new information on source records.
 
@@ -438,34 +474,86 @@ function () {
         // ancestor.field links to the parent record (example: connections)
         fieldID === parentID
       );
-    }); // null-check is for flow; if an incremental payload exists for some id that
-    // record should also exist.
+    }); // If an incremental payload exists for some id that record should also
+    // exist.
+
+    !(parentRecord != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected record `%s` to exist.', parentID) : invariant(false) : void 0;
+    var nextParentRecord;
+    var nextParentPayloads;
+
+    var previousParentEntry = this._source.get(parentID);
+
+    if (previousParentEntry != null) {
+      // If a previous entry exists, merge the previous/next records and
+      // payloads together.
+      nextParentRecord = RelayModernRecord.update(previousParentEntry.record, parentRecord);
+      var handlePayloads = new Map();
+
+      var dedupePayload = function dedupePayload(payload) {
+        var key = stableStringify(payload);
+        handlePayloads.set(key, payload);
+      };
+
+      previousParentEntry.fieldPayloads.forEach(dedupePayload);
+      parentPayloads.forEach(dedupePayload);
+      nextParentPayloads = Array.from(handlePayloads.values());
+    } else {
+      nextParentRecord = parentRecord;
+      nextParentPayloads = parentPayloads;
+    }
 
-    if (parentRecord != null) {
-      this._source.set(parentID, {
-        record: parentRecord,
-        fieldPayloads: parentPayloads
+    this._source.set(parentID, {
+      record: nextParentRecord,
+      fieldPayloads: nextParentPayloads
+    }); // If there were any queued responses, process them now that placeholders
+    // are in place
+
+
+    if (pendingResponses != null) {
+      pendingResponses.forEach(function (incrementalResponse) {
+        _this6._schedule(function () {
+          _this6._processIncrementalResponse(incrementalResponse);
+        });
       });
     }
-  };
+  }
   /**
    * Lookup the placeholder the describes how to process an incremental
    * response, normalize/publish it, and process any nested defer/match/stream
    * metadata.
    */
+  ;
 
+  _proto._processIncrementalResponse = function _processIncrementalResponse(incrementalResponse) {
+    var label = incrementalResponse.label,
+        path = incrementalResponse.path,
+        response = incrementalResponse.response;
 
-  _proto._processIncrementalResponse = function _processIncrementalResponse(label, path, response) {
-    !RelayFeatureFlags.ENABLE_INCREMENTAL_DELIVERY ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Unexpected use of @defer/@stream in ' + 'operation `%s`.', this._operation.node.params.name) : invariant(false) : void 0;
+    var resultForLabel = this._incrementalResults.get(label);
 
-    var dataForLabel = this._incrementalPlaceholders.get(label);
+    if (resultForLabel == null) {
+      resultForLabel = new Map();
 
-    !(dataForLabel != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Received response for unknown label ' + "'".concat(label, "'. Known labels: ").concat(Array.from(this._incrementalPlaceholders.keys()).join(', '), ".")) : invariant(false) : void 0;
+      this._incrementalResults.set(label, resultForLabel);
+    }
 
-    if (dataForLabel.kind === 'defer') {
+    if (label.indexOf('$defer$') !== -1) {
       var pathKey = path.map(String).join('.');
-      var placeholder = dataForLabel.placeholdersByPath.get(pathKey);
-      !(placeholder != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Received response for unknown path `%s` ' + 'for label `%s`. Known paths: %s.', pathKey, label, Array.from(dataForLabel.placeholdersByPath.keys()).join(', ')) : invariant(false) : void 0;
+      var resultForPath = resultForLabel.get(pathKey);
+
+      if (resultForPath == null) {
+        resultForPath = {
+          kind: 'response',
+          responses: [incrementalResponse]
+        };
+        resultForLabel.set(pathKey, resultForPath);
+        return;
+      } else if (resultForPath.kind === 'response') {
+        resultForPath.responses.push(incrementalResponse);
+        return;
+      }
+
+      var placeholder = resultForPath.placeholder;
       !(placeholder.kind === 'defer') ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected data for path `%s` for label `%s` ' + 'to be data for @defer, was `@%s`.', pathKey, label, placeholder.kind) : invariant(false) : void 0;
 
       this._processDeferResponse(label, path, placeholder, response);
@@ -476,9 +564,22 @@ function () {
       // (the item index is used later to insert the element in the list)
       var _pathKey = path.slice(0, -2).map(String).join('.');
 
-      var _placeholder = dataForLabel.placeholdersByPath.get(_pathKey);
+      var _resultForPath = resultForLabel.get(_pathKey);
+
+      if (_resultForPath == null) {
+        _resultForPath = {
+          kind: 'response',
+          responses: [incrementalResponse]
+        };
+        resultForLabel.set(_pathKey, _resultForPath);
+        return;
+      } else if (_resultForPath.kind === 'response') {
+        _resultForPath.responses.push(incrementalResponse);
+
+        return;
+      }
 
-      !(_placeholder != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Received response for unknown path `%s` ' + 'for label `%s`. Known paths: %s.', _pathKey, label, Array.from(dataForLabel.placeholdersByPath.keys()).join(', ')) : invariant(false) : void 0;
+      var _placeholder = _resultForPath.placeholder;
       !(_placeholder.kind === 'stream') ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected data for path `%s` for label `%s` ' + 'to be data for @stream, was `@%s`.', _pathKey, label, _placeholder.kind) : invariant(false) : void 0;
 
       this._processStreamResponse(label, path, _placeholder, response);
@@ -487,7 +588,7 @@ function () {
 
   _proto._processDeferResponse = function _processDeferResponse(label, path, placeholder, response) {
     var parentID = placeholder.selector.dataID;
-    var relayPayload = normalizeResponse(response, placeholder.selector, placeholder.typeName, placeholder.path);
+    var relayPayload = normalizeResponse(response, placeholder.selector, placeholder.typeName, placeholder.path, this._getDataID);
 
     this._processPayloadFollowups(relayPayload);
 
@@ -515,14 +616,14 @@ function () {
     var updatedOwners = this._publishQueue.run();
 
     this._updateOperationTracker(updatedOwners);
-  };
+  }
   /**
    * Process the data for one item in a @stream field.
    */
-
+  ;
 
   _proto._processStreamResponse = function _processStreamResponse(label, path, placeholder, response) {
-    var _field$alias, _data$id, _field$concreteType;
+    var _field$alias, _field$concreteType, _this$_getDataID;
 
     var parentID = placeholder.parentID,
         node = placeholder.node,
@@ -549,10 +650,12 @@ function () {
 
     var finalPathEntry = path[path.length - 1];
     var itemIndex = parseInt(finalPathEntry, 10);
-    !(itemIndex === finalPathEntry && itemIndex >= 0) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected path for @stream to end in a ' + 'positive integer index, got `%s`', finalPathEntry) : invariant(false) : void 0; // Determine the __id of the new item: this must equal the value that would
+    !(itemIndex === finalPathEntry && itemIndex >= 0) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected path for @stream to end in a ' + 'positive integer index, got `%s`', finalPathEntry) : invariant(false) : void 0;
+    var typeName = (_field$concreteType = field.concreteType) !== null && _field$concreteType !== void 0 ? _field$concreteType : data[TYPENAME_KEY];
+    !(typeof typeName === 'string') ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected @stream field `%s` to have a ' + '__typename.', field.name) : invariant(false) : void 0; // Determine the __id of the new item: this must equal the value that would
     // be assigned had the item not been streamed
 
-    var itemID = ((_data$id = data.id) !== null && _data$id !== void 0 ? _data$id : prevIDs && prevIDs[itemIndex]) || // Reuse previously generated client IDs
+    var itemID = ((_this$_getDataID = this._getDataID(data, typeName)) !== null && _this$_getDataID !== void 0 ? _this$_getDataID : prevIDs && prevIDs[itemIndex]) || // Reuse previously generated client IDs
     generateClientID(parentID, storageKey, itemIndex);
     !(typeof itemID === 'string') ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected id of elements of field `%s` to ' + 'be strings.', storageKey) : invariant(false) : void 0; // Build a selector to normalize the item data with
 
@@ -560,9 +663,7 @@ function () {
       dataID: itemID,
       node: field,
       variables: variables
-    };
-    var typeName = (_field$concreteType = field.concreteType) !== null && _field$concreteType !== void 0 ? _field$concreteType : data[TYPENAME_KEY];
-    !(typeof typeName === 'string') ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernEnvironment: Expected @stream field `%s` to have a ' + '__typename.', field.name) : invariant(false) : void 0; // Update the cached version of the parent record to reflect the new item:
+    }; // Update the cached version of the parent record to reflect the new item:
     // this is used when subsequent stream payloads arrive to see if there
     // have been concurrent modifications to the list
 
@@ -579,7 +680,7 @@ function () {
     // modified.
 
 
-    var relayPayload = normalizeResponse(response, selector, typeName, (0, _toConsumableArray2["default"])(placeholder.path).concat([responseKey, String(itemIndex)]));
+    var relayPayload = normalizeResponse(response, selector, typeName, [].concat((0, _toConsumableArray2["default"])(placeholder.path), [responseKey, String(itemIndex)]), this._getDataID);
 
     this._processPayloadFollowups(relayPayload);
 
@@ -659,7 +760,7 @@ function () {
   return Executor;
 }();
 
-function normalizeResponse(response, selector, typeName, path) {
+function normalizeResponse(response, selector, typeName, path, getDataID) {
   var data = response.data,
       errors = response.errors;
   var source = new RelayInMemoryRecordSource();
@@ -667,7 +768,8 @@ function normalizeResponse(response, selector, typeName, path) {
   source.set(selector.dataID, record);
   var normalizeResult = RelayResponseNormalizer.normalize(source, selector, data, {
     handleStrippedNulls: true,
-    path: path
+    path: path,
+    getDataID: getDataID
   });
   return {
     errors: errors,
@@ -678,6 +780,12 @@ function normalizeResponse(response, selector, typeName, path) {
   };
 }
 
+function stableStringify(value) {
+  var _JSON$stringify;
+
+  return (_JSON$stringify = JSON.stringify(stableCopy(value))) !== null && _JSON$stringify !== void 0 ? _JSON$stringify : ''; // null-check for flow
+}
+
 module.exports = {
   execute: execute
 };

package/lib/RelayModernSelector.js

@@ -9,8 +9,6 @@
  */
 'use strict';
 
-var RelayFeatureFlags = require("./RelayFeatureFlags");
-
 var areEqual = require("fbjs/lib/areEqual");
 
 var invariant = require("fbjs/lib/invariant");
@@ -69,7 +67,11 @@ function getSingularSelector(operationVariables, fragment, item, explicitOwner)
     if (explicitOwner != null && typeof explicitOwner === 'object') {
       var ownerOperationVariables = explicitOwner.variables;
 
-      var _fragmentVariables = getFragmentVariables(fragment, ownerOperationVariables, argumentVariables);
+      var _fragmentVariables = getFragmentVariables(fragment, ownerOperationVariables,
+      /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+       * suppresses an error found when Flow v0.98 was deployed. To see the
+       * error delete this comment and run Flow. */
+      argumentVariables);
 
       return {
         owner: explicitOwner,
@@ -87,7 +89,11 @@ function getSingularSelector(operationVariables, fragment, item, explicitOwner)
 
 
     var owner = (_ref = (_explicitOwner = explicitOwner) !== null && _explicitOwner !== void 0 ? _explicitOwner : item[FRAGMENT_OWNER_KEY]) !== null && _ref !== void 0 ? _ref : null;
-    var fragmentVariables = getFragmentVariables(fragment, operationVariables, argumentVariables);
+    var fragmentVariables = getFragmentVariables(fragment, operationVariables,
+    /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+     * suppresses an error found when Flow v0.98 was deployed. To see the
+     * error delete this comment and run Flow. */
+    argumentVariables);
     return {
       // $FlowFixMe - TODO T39154660
       owner: owner,
@@ -152,9 +158,17 @@ function getSelector(operationVariables, fragment, item, explicitOwner) {
 
     if (explicitOwner !== undefined) {
       !Array.isArray(explicitOwner) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernSelector: Expected explcitly provided owner for ' + 'fragment `%s` to be an array, got `%s`.', fragment.name, JSON.stringify(explicitOwner)) : invariant(false) : void 0;
-      selectorOrSelectors = getPluralSelector(operationVariables, fragment, item, explicitOwner);
+      selectorOrSelectors = getPluralSelector(operationVariables, fragment,
+      /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+       * suppresses an error found when Flow v0.98 was deployed. To see the
+       * error delete this comment and run Flow. */
+      item, explicitOwner);
     } else {
-      selectorOrSelectors = getPluralSelector(operationVariables, fragment, item);
+      selectorOrSelectors = getPluralSelector(operationVariables, fragment,
+      /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+       * suppresses an error found when Flow v0.98 was deployed. To see the
+       * error delete this comment and run Flow. */
+      item);
     }
   } else {
     !!Array.isArray(item) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernSelector: Expected value for fragment `%s` to be an object, got `%s`. ' + 'Add `@relay(plural: true)` to fragment `%s` to allow the prop to be an array of items.', fragment.name, JSON.stringify(item), fragment.name) : invariant(false) : void 0;
@@ -233,6 +247,10 @@ function getDataIDsFromFragment(fragment, item) {
     idOrIDs = item;
   } else if (fragment.metadata && fragment.metadata.plural === true) {
     !Array.isArray(item) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernSelector: Expected value for fragment `%s` to be an array, got `%s`. ' + 'Remove `@relay(plural: true)` from fragment `%s` to allow the prop to be an object.', fragment.name, JSON.stringify(item), fragment.name) : invariant(false) : void 0;
+    /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+     * suppresses an error found when Flow v0.98 was deployed. To see the error
+     * delete this comment and run Flow. */
+
     idOrIDs = getDataIDs(fragment, item);
   } else {
     !!Array.isArray(item) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernFragmentSpecResolver: Expected value for fragment `%s` to be an object, got `%s`. ' + 'Add `@relay(plural: true)` to fragment `%s` to allow the prop to be an array of items.', fragment.name, JSON.stringify(item), fragment.name) : invariant(false) : void 0;
@@ -320,8 +338,15 @@ function getVariablesFromFragment(operationVariables, fragment, item, explicitOw
 
     if (explicitOwner !== undefined) {
       !Array.isArray(explicitOwner) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernSelector: Expected explcitly provided owner for ' + 'fragment `%s` to be an array, got `%s`.', fragment.name, JSON.stringify(explicitOwner)) : invariant(false) : void 0;
-      return getVariablesFromPluralFragment(operationVariables, fragment, item, explicitOwner);
+      return getVariablesFromPluralFragment(operationVariables, fragment,
+      /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+       * suppresses an error found when Flow v0.98 was deployed. To see the
+       * error delete this comment and run Flow. */
+      item, explicitOwner);
     } else {
+      /* $FlowFixMe(>=0.98.0 site=www,mobile,react_native_fb,oss) This comment
+       * suppresses an error found when Flow v0.98 was deployed. To see the
+       * error delete this comment and run Flow. */
       return getVariablesFromPluralFragment(operationVariables, fragment, item);
     }
   } else {
@@ -371,16 +396,11 @@ function getVariablesFromPluralFragment(operationVariables, fragment, items, own
 
 function areEqualSelectors(thisSelector, thatSelector) {
   var areVariablesEqual = areEqual(thisSelector.selector.variables, thatSelector.selector.variables);
-  var areReaderSelectorsEqual = thisSelector.selector.dataID === thatSelector.selector.dataID && thisSelector.selector.node === thatSelector.selector.node && areVariablesEqual;
-
-  if (RelayFeatureFlags.PREFER_FRAGMENT_OWNER_OVER_CONTEXT) {
-    // NOTE: If fragment ownership is enabled, we should also compare if
-    // the owners attached to the selectors are the same, otherwise we might
-    // skip setting a new selector that has a new owner.
-    return areReaderSelectorsEqual && thisSelector.owner === thatSelector.owner;
-  }
+  var areReaderSelectorsEqual = thisSelector.selector.dataID === thatSelector.selector.dataID && thisSelector.selector.node === thatSelector.selector.node && areVariablesEqual; // NOTE: With fragment ownership we need to also compare if
+  // the owners attached to the selectors are the same, otherwise we might
+  // skip setting a new selector that has a new owner.
 
-  return areReaderSelectorsEqual;
+  return areReaderSelectorsEqual && thisSelector.owner === thatSelector.owner;
 }
 
 module.exports = {