relay-runtime 20.1.1 → 21.0.0

package/mutations/RelayRecordProxy.js.flow

@@ -61,16 +61,16 @@ class RelayRecordProxy implements RecordProxy {
     return type;
   }
 
-  getValue(name: string, args?: ?Arguments): mixed {
+  getValue(name: string, args?: ?Arguments): unknown {
     const storageKey = getStableStorageKey(name, args);
     return this._mutator.getValue(this._dataID, storageKey);
   }
 
   setValue(
-    value: mixed,
+    value: unknown,
     name: string,
     args?: ?Arguments,
-    errors?: ?$ReadOnlyArray<TRelayFieldError>,
+    errors?: ?ReadonlyArray<TRelayFieldError>,
   ): RecordProxy {
     invariant(
       isValidLeafValue(value),
@@ -82,10 +82,7 @@ class RelayRecordProxy implements RecordProxy {
     return this.setValue__UNSAFE(value, name, args, errors);
   }
 
-  getErrors(
-    name: string,
-    args?: ?Arguments,
-  ): ?$ReadOnlyArray<TRelayFieldError> {
+  getErrors(name: string, args?: ?Arguments): ?ReadonlyArray<TRelayFieldError> {
     const storageKey = getStableStorageKey(name, args);
     return this._mutator.getErrors(this._dataID, storageKey);
   }
@@ -94,10 +91,10 @@ class RelayRecordProxy implements RecordProxy {
   // We already validated that the value has the correct type
   // so it should be safe to store complex structures as scalar values (custom scalars)
   setValue__UNSAFE(
-    value: mixed,
+    value: unknown,
     name: string,
     args?: ?Arguments,
-    errors?: ?$ReadOnlyArray<TRelayFieldError>,
+    errors?: ?ReadonlyArray<TRelayFieldError>,
   ): RecordProxy {
     const storageKey = getStableStorageKey(name, args);
     this._mutator.setValue(this._dataID, storageKey, value);
@@ -166,7 +163,7 @@ class RelayRecordProxy implements RecordProxy {
   }
 
   setLinkedRecords(
-    records: $ReadOnlyArray<?RecordProxy>,
+    records: ReadonlyArray<?RecordProxy>,
     name: string,
     args?: ?Arguments,
   ): RecordProxy {
@@ -186,7 +183,7 @@ class RelayRecordProxy implements RecordProxy {
   }
 }
 
-function isValidLeafValue(value: mixed): boolean {
+function isValidLeafValue(value: unknown): boolean {
   return (
     value == null ||
     typeof value !== 'object' ||

package/mutations/RelayRecordSourceMutator.js.flow

@@ -161,7 +161,7 @@ class RelayRecordSourceMutator {
     }
   }
 
-  getValue(dataID: DataID, storageKey: string): mixed {
+  getValue(dataID: DataID, storageKey: string): unknown {
     for (let ii = 0; ii < this.__sources.length; ii++) {
       const record = this.__sources[ii].get(dataID);
       if (record) {
@@ -175,7 +175,7 @@ class RelayRecordSourceMutator {
     }
   }
 
-  setValue(dataID: DataID, storageKey: string, value: mixed): void {
+  setValue(dataID: DataID, storageKey: string, value: unknown): void {
     const sinkRecord = this._getSinkRecord(dataID);
     RelayModernRecord.setValue(sinkRecord, storageKey, value);
   }
@@ -183,7 +183,7 @@ class RelayRecordSourceMutator {
   getErrors(
     dataID: DataID,
     storageKey: string,
-  ): ?$ReadOnlyArray<TRelayFieldError> {
+  ): ?ReadonlyArray<TRelayFieldError> {
     for (let ii = 0; ii < this.__sources.length; ii++) {
       const record = this.__sources[ii].get(dataID);
       if (record) {
@@ -200,7 +200,7 @@ class RelayRecordSourceMutator {
   setErrors(
     dataID: DataID,
     storageKey: string,
-    errors?: $ReadOnlyArray<TRelayFieldError>,
+    errors?: ReadonlyArray<TRelayFieldError>,
   ): void {
     const sinkRecord = this._getSinkRecord(dataID);
     RelayModernRecord.setErrors(sinkRecord, storageKey, errors);

package/mutations/RelayRecordSourceProxy.js.flow

@@ -53,14 +53,14 @@ class RelayRecordSourceProxy implements RecordSourceProxy {
   _getDataID: GetDataID;
   _invalidatedStore: boolean;
   _idsMarkedForInvalidation: DataIDSet;
-  _missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>;
+  _missingFieldHandlers: ReadonlyArray<MissingFieldHandler>;
   _log: LogFunction;
 
   constructor(
     mutator: RelayRecordSourceMutator,
     getDataID: GetDataID,
     handlerProvider?: ?HandlerProvider,
-    missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+    missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
     log: ?LogFunction,
   ) {
     this.__mutator = mutator;
@@ -176,7 +176,7 @@ class RelayRecordSourceProxy implements RecordSourceProxy {
     return this._idsMarkedForInvalidation;
   }
 
-  readUpdatableQuery<TVariables: Variables, TData>(
+  readUpdatableQuery<TVariables extends Variables, TData>(
     query: UpdatableQuery<TVariables, TData>,
     variables: TVariables,
   ): UpdatableData<TData> {
@@ -188,7 +188,7 @@ class RelayRecordSourceProxy implements RecordSourceProxy {
     );
   }
 
-  readUpdatableFragment<TFragmentType: FragmentType, TData>(
+  readUpdatableFragment<TFragmentType extends FragmentType, TData>(
     fragment: UpdatableFragment<TFragmentType, TData>,
     fragmentReference: HasUpdatableSpread<TFragmentType>,
   ): UpdatableData<TData> {

package/mutations/RelayRecordSourceSelectorProxy.js.flow

@@ -21,7 +21,7 @@ import type {
   SingularReaderSelector,
   UpdatableData,
 } from '../store/RelayStoreTypes';
-import type {ReaderLinkedField} from '../util/ReaderNode';
+import type {ReaderLinkedField, ReaderSelection} from '../util/ReaderNode';
 import type {
   DataID,
   UpdatableFragment,
@@ -47,13 +47,13 @@ class RelayRecordSourceSelectorProxy implements RecordSourceSelectorProxy {
   __mutator: RelayRecordSourceMutator;
   __recordSource: RecordSourceProxy;
   _readSelector: SingularReaderSelector;
-  _missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>;
+  _missingFieldHandlers: ReadonlyArray<MissingFieldHandler>;
 
   constructor(
     mutator: RelayRecordSourceMutator,
     recordSource: RecordSourceProxy,
     readSelector: SingularReaderSelector,
-    missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+    missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
   ) {
     this.__mutator = mutator;
     this.__recordSource = recordSource;
@@ -90,7 +90,7 @@ class RelayRecordSourceSelectorProxy implements RecordSourceSelectorProxy {
     fieldName: string,
     plural: boolean,
   ): ReaderLinkedField {
-    let field = selector.node.selections.find(
+    let field: ReaderSelection | void = selector.node.selections.find(
       selection =>
         (selection.kind === 'LinkedField' && selection.name === fieldName) ||
         (selection.kind === 'RequiredField' &&
@@ -132,7 +132,7 @@ class RelayRecordSourceSelectorProxy implements RecordSourceSelectorProxy {
     this.__recordSource.invalidateStore();
   }
 
-  readUpdatableQuery<TVariables: Variables, TData>(
+  readUpdatableQuery<TVariables extends Variables, TData>(
     query: UpdatableQuery<TVariables, TData>,
     variables: TVariables,
   ): UpdatableData<TData> {
@@ -144,7 +144,7 @@ class RelayRecordSourceSelectorProxy implements RecordSourceSelectorProxy {
     );
   }
 
-  readUpdatableFragment<TFragmentType: FragmentType, TData>(
+  readUpdatableFragment<TFragmentType extends FragmentType, TData>(
     fragment: UpdatableFragment<TFragmentType, TData>,
     fragmentReference: HasUpdatableSpread<TFragmentType>,
   ): UpdatableData<TData> {

package/mutations/applyOptimisticMutation.js.flow

@@ -28,7 +28,7 @@ const {
 const RelayDeclarativeMutationConfig = require('./RelayDeclarativeMutationConfig');
 const invariant = require('invariant');
 
-export type OptimisticMutationConfig<TMutation: MutationParameters> = {
+export type OptimisticMutationConfig<TMutation extends MutationParameters> = {
   configs?: ?Array<DeclarativeMutationConfig>,
   mutation: GraphQLTaggedNode,
   variables: Variables,
@@ -40,7 +40,7 @@ export type OptimisticMutationConfig<TMutation: MutationParameters> = {
  * Higher-level helper function to execute a mutation against a specific
  * environment.
  */
-function applyOptimisticMutation<TMutation: MutationParameters>(
+function applyOptimisticMutation<TMutation extends MutationParameters>(
   environment: IEnvironment,
   config: OptimisticMutationConfig<TMutation>,
 ): Disposable {

package/mutations/commitMutation.js.flow

@@ -37,7 +37,7 @@ const validateMutation = require('./validateMutation');
 const invariant = require('invariant');
 const warning = require('warning');
 
-export type MutationConfig<TMutation: MutationParameters> = $ReadOnly<{
+export type MutationConfig<TMutation extends MutationParameters> = Readonly<{
   cacheConfig?: CacheConfig,
   configs?: Array<DeclarativeMutationConfig>,
   mutation: GraphQLTaggedNode,
@@ -59,7 +59,7 @@ export type MutationConfig<TMutation: MutationParameters> = $ReadOnly<{
   variables: TMutation['variables'],
 }>;
 
-export type CommitMutationConfig<TVariables, TData, TRawResponse> = $ReadOnly<{
+export type CommitMutationConfig<TVariables, TData, TRawResponse> = Readonly<{
   cacheConfig?: CacheConfig,
   configs?: Array<DeclarativeMutationConfig>,
   mutation: Mutation<TVariables, TData, TRawResponse>,
@@ -78,7 +78,11 @@ export type CommitMutationConfig<TVariables, TData, TRawResponse> = $ReadOnly<{
  * Higher-level helper function to execute a mutation against a specific
  * environment.
  */
-function commitMutation<TVariables: Variables, TData, TRawResponse = {...}>(
+function commitMutation<
+  TVariables extends Variables,
+  TData,
+  TRawResponse = {...},
+>(
   environment: IEnvironment,
   config: CommitMutationConfig<TVariables, TData, TRawResponse>,
 ): Disposable {
@@ -122,7 +126,7 @@ function commitMutation<TVariables: Variables, TData, TRawResponse = {...}>(
   if (configs) {
     ({optimisticUpdater, updater} = RelayDeclarativeMutationConfig.convert<{
       variables: TVariables,
-      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
+      /* $FlowFixMe[incompatible-type] error exposed when improving flow typing
        * of commitMutation */
       response: TData,
     }>(configs, mutation, optimisticUpdater, updater));
@@ -131,7 +135,7 @@ function commitMutation<TVariables: Variables, TData, TRawResponse = {...}>(
   const subscription = environment
     .executeMutation<{
       variables: TVariables,
-      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
+      /* $FlowFixMe[incompatible-type] error exposed when improving flow typing
        * of commitMutation */
       response: TData,
     }>({
@@ -142,6 +146,17 @@ function commitMutation<TVariables: Variables, TData, TRawResponse = {...}>(
       uploadables,
     })
     .subscribe({
+      complete: () => {
+        const {onCompleted} = config;
+        if (onCompleted) {
+          const snapshot = environment.lookup(operation.fragment);
+          onCompleted(
+            snapshot.data as $FlowFixMe,
+            errors.length !== 0 ? errors : null,
+          );
+        }
+      },
+      error: onError,
       next: payload => {
         if (Array.isArray(payload)) {
           payload.forEach(item => {
@@ -156,17 +171,6 @@ function commitMutation<TVariables: Variables, TData, TRawResponse = {...}>(
         }
         config.onNext?.();
       },
-      complete: () => {
-        const {onCompleted} = config;
-        if (onCompleted) {
-          const snapshot = environment.lookup(operation.fragment);
-          onCompleted(
-            (snapshot.data: $FlowFixMe),
-            errors.length !== 0 ? errors : null,
-          );
-        }
-      },
-      error: onError,
       unsubscribe: onUnsubscribe,
     });
   return {dispose: subscription.unsubscribe};

package/mutations/createUpdatableProxy.js.flow

@@ -27,12 +27,12 @@ const {getArgumentValues} = require('../store/RelayStoreUtils');
 
 const nonUpdatableKeys = ['id', '__id', '__typename', 'js'];
 
-function createUpdatableProxy<TData: {...}>(
+function createUpdatableProxy<TData extends {...}>(
   updatableProxyRootRecord: RecordProxy,
   variables: Variables,
-  selections: $ReadOnlyArray<ReaderSelection>,
+  selections: ReadonlyArray<ReaderSelection>,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): TData {
   const mutableUpdatableProxy = {};
   updateProxyFromSelections(
@@ -49,16 +49,16 @@ function createUpdatableProxy<TData: {...}>(
   // unless ReaderSelection carries more type information, we will never be able
   // to flowtype mutableUpdatableProxy without a type assertion.
   // $FlowFixMe[unclear-type]
-  return ((mutableUpdatableProxy: any): TData);
+  return mutableUpdatableProxy as any as TData;
 }
 
 function updateProxyFromSelections<TData>(
   mutableUpdatableProxy: TData,
   updatableProxyRootRecord: RecordProxy,
   variables: Variables,
-  selections: $ReadOnlyArray<ReaderSelection>,
+  selections: ReadonlyArray<ReaderSelection>,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): void {
   for (const selection of selections) {
     switch (selection.kind) {
@@ -108,7 +108,7 @@ function updateProxyFromSelections<TData>(
       case 'ScalarField':
         const scalarFieldName = selection.alias ?? selection.name;
         Object.defineProperty(mutableUpdatableProxy, scalarFieldName, {
-          get: function () {
+          get() {
             const newVariables = getArgumentValues(
               selection.args ?? [],
               variables,
@@ -191,7 +191,7 @@ function updateProxyFromSelections<TData>(
           'Encountered an unexpected ReaderSelection variant in RelayRecordSourceProxy. This indicates a bug in Relay.',
         );
       default:
-        (selection.kind: empty);
+        selection.kind as empty;
         throw new Error(
           'Encountered an unexpected ReaderSelection variant in RelayRecordSourceProxy. This indicates a bug in Relay.',
         );
@@ -205,7 +205,7 @@ function createSetterForPluralLinkedField(
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
 ) {
-  return function set(newValue: $ReadOnlyArray<{__id: string, ...}>) {
+  return function set(newValue: ReadonlyArray<{__id: string, ...}>) {
     const newVariables = getArgumentValues(selection.args ?? [], variables);
     if (newValue == null) {
       throw new Error(
@@ -276,7 +276,7 @@ function createGetterForPluralLinkedField(
   variables: Variables,
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): () => $FlowFixMe {
   return function () {
     const newVariables = getArgumentValues(selection.args ?? [], variables);
@@ -296,7 +296,7 @@ function createGetterForPluralLinkedField(
     }
 
     if (linkedRecords != null) {
-      return (linkedRecords.map(linkedRecord => {
+      return linkedRecords.map(linkedRecord => {
         if (linkedRecord != null) {
           const updatableProxy = {};
           updateProxyFromSelections(
@@ -313,12 +313,12 @@ function createGetterForPluralLinkedField(
           // Flow incorrect assumes that the return value for the get method must match
           // the set parameter.
           // $FlowFixMe[unclear-type] Typed by the generated updatable query flow type
-          return (updatableProxy: any);
+          return updatableProxy as any;
         } else {
           return linkedRecord;
         }
         // $FlowFixMe[unclear-type] Typed by the generated updatable query flow type
-      }): any);
+      }) as any;
     } else {
       return linkedRecords;
     }
@@ -330,7 +330,7 @@ function createGetterForSingularLinkedField(
   variables: Variables,
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): () => ?$FlowFixMe {
   return function () {
     const newVariables = getArgumentValues(selection.args ?? [], variables);
@@ -364,7 +364,7 @@ function createGetterForSingularLinkedField(
       // Flow incorrect assumes that the return value for the get method must match
       // the set parameter.
       // $FlowFixMe[unclear-type] Typed by the generated updatable query flow type
-      return (updatableProxy: any);
+      return updatableProxy as any;
     } else {
       return linkedRecord;
     }
@@ -376,7 +376,7 @@ function getLinkedRecordUsingMissingFieldHandlers(
   newVariables: Variables,
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): ?RecordProxy {
   for (const handler of missingFieldHandlers) {
     if (handler.kind === 'linked') {
@@ -398,7 +398,7 @@ function getPluralLinkedRecordUsingMissingFieldHandlers(
   newVariables: Variables,
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): ?Array<?RecordProxy> {
   for (const handler of missingFieldHandlers) {
     if (handler.kind === 'pluralLinked') {
@@ -424,8 +424,8 @@ function getScalarUsingMissingFieldHandlers(
   newVariables: Variables,
   updatableProxyRootRecord: RecordProxy,
   recordSourceProxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
-): mixed {
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
+): unknown {
   for (const handler of missingFieldHandlers) {
     if (handler.kind === 'scalar') {
       const value = handler.handle(

package/mutations/readUpdatableFragment.js.flow

@@ -27,11 +27,11 @@ const {createUpdatableProxy} = require('./createUpdatableProxy');
 const invariant = require('invariant');
 
 // Note: plural fragment references are currently not supported
-function readUpdatableFragment<TFragmentType: FragmentType, TData>(
+function readUpdatableFragment<TFragmentType extends FragmentType, TData>(
   fragment: UpdatableFragment<TFragmentType, TData>,
   fragmentReference: HasUpdatableSpread<TFragmentType>,
   proxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): UpdatableData<TData> {
   const updatableFragment = getFragment(fragment);
   const fragmentVariables = getVariablesFromFragment(
@@ -48,7 +48,7 @@ function readUpdatableFragment<TFragmentType: FragmentType, TData>(
   );
 
   return {
-    // $FlowFixMe[incompatible-call]
+    // $FlowFixMe[incompatible-type]
     updatableData: createUpdatableProxy<TData>(
       fragmentRoot,
       fragmentVariables,

package/mutations/readUpdatableQuery.js.flow

@@ -21,16 +21,16 @@ import type {UpdatableQuery, Variables} from '../util/RelayRuntimeTypes';
 const {getUpdatableQuery} = require('../query/GraphQLTag');
 const {createUpdatableProxy} = require('./createUpdatableProxy');
 
-function readUpdatableQuery<TVariables: Variables, TData>(
+function readUpdatableQuery<TVariables extends Variables, TData>(
   query: UpdatableQuery<TVariables, TData>,
   variables: TVariables,
   proxy: RecordSourceProxy,
-  missingFieldHandlers: $ReadOnlyArray<MissingFieldHandler>,
+  missingFieldHandlers: ReadonlyArray<MissingFieldHandler>,
 ): UpdatableData<TData> {
   const updatableQuery = getUpdatableQuery(query);
 
   return {
-    // $FlowFixMe[incompatible-call]
+    // $FlowFixMe[incompatible-type]
     updatableData: createUpdatableProxy<TData>(
       proxy.getRoot(),
       variables,

package/mutations/validateMutation.js.flow

@@ -62,12 +62,12 @@ if (__DEV__) {
   ) => {
     const operationName = mutation.operation.name;
     const context: ValidationContext = {
-      path: 'ROOT',
-      visitedPaths: new Set(),
-      variables: variables || {},
-      missingDiff: {},
       extraDiff: {},
+      missingDiff: {},
       moduleImportPaths: new Set(),
+      path: 'ROOT',
+      variables: variables || {},
+      visitedPaths: new Set(),
     };
     validateSelections(
       optimisticResponse,
@@ -91,7 +91,7 @@ if (__DEV__) {
 
   const validateSelections = (
     optimisticResponse: Object,
-    selections: $ReadOnlyArray<NormalizationSelection>,
+    selections: ReadonlyArray<NormalizationSelection>,
     context: ValidationContext,
   ) => {
     selections.forEach(selection =>
@@ -156,7 +156,7 @@ if (__DEV__) {
         return;
       }
       default:
-        (selection: empty);
+        selection as empty;
         return;
     }
   };
@@ -261,4 +261,4 @@ if (__DEV__) {
   };
 }
 
-module.exports = (validateMutation: (Object, ConcreteRequest, ?Object) => void);
+module.exports = validateMutation as (Object, ConcreteRequest, ?Object) => void;

package/network/RelayNetworkTypes.js.flow

@@ -24,9 +24,9 @@ export interface INetwork {
   +execute: ExecuteFunction;
 }
 
-export type LogRequestInfoFunction = mixed => void;
+export type LogRequestInfoFunction = unknown => void;
 
-export type PayloadData = {+[key: string]: mixed};
+export type PayloadData = {+[key: string]: unknown};
 
 export type PayloadError = interface {
   message: string,
@@ -40,7 +40,7 @@ export type PayloadError = interface {
   severity?: 'CRITICAL' | 'ERROR' | 'WARNING',
 };
 
-export type PayloadExtensions = {[key: string]: mixed, ...};
+export type PayloadExtensions = {[key: string]: unknown, ...};
 
 /**
  * The shape of a GraphQL response as dictated by the
@@ -82,7 +82,7 @@ export type GraphQLSingularResponse =
 
 export type GraphQLResponse =
   | GraphQLSingularResponse
-  | $ReadOnlyArray<GraphQLSingularResponse>;
+  | ReadonlyArray<GraphQLSingularResponse>;
 
 /**
  * A function that pre-process the response at the network layer. This

package/network/RelayObservable.js.flow

@@ -23,7 +23,7 @@ export type Subscription = {
 };
 
 type SubscriptionFn = {
-  (): mixed,
+  (): unknown,
   +unsubscribe?: void,
   +closed?: void,
   ...
@@ -34,11 +34,11 @@ type SubscriptionFn = {
  * .subscribe(). Each callback function is invoked when that event occurs.
  */
 export type Observer<-T> = {
-  +start?: ?(Subscription) => mixed,
-  +next?: ?(T) => mixed,
-  +error?: ?(Error) => mixed,
-  +complete?: ?() => mixed,
-  +unsubscribe?: ?(Subscription) => mixed,
+  +start?: ?(Subscription) => unknown,
+  +next?: ?(T) => unknown,
+  +error?: ?(Error) => unknown,
+  +complete?: ?() => unknown,
+  +unsubscribe?: ?(Subscription) => unknown,
 };
 
 /**
@@ -74,7 +74,7 @@ export interface Subscribable<+T> {
 export type ObservableFromValue<+T> = Subscribable<T> | Promise<T> | T;
 
 let hostReportError:
-  | ((Error, isUncaughtThrownError: boolean) => mixed)
+  | ((Error, isUncaughtThrownError: boolean) => unknown)
   | ((_error: Error, _isUncaughtThrownError: boolean) => void) = swallowError;
 
 /**
@@ -92,7 +92,7 @@ class RelayObservable<+T> implements Subscribable<T> {
   +_source: Source<T>;
 
   static create<V>(source: Source<V>): RelayObservable<V> {
-    return new RelayObservable((source: any));
+    return new RelayObservable(source as any);
   }
 
   // Use RelayObservable.create()
@@ -103,7 +103,7 @@ class RelayObservable<+T> implements Subscribable<T> {
         throw new Error('Source must be a Function: ' + String(source));
       }
     }
-    (this: any)._source = source;
+    (this as any)._source = source;
   }
 
   /**
@@ -132,7 +132,7 @@ class RelayObservable<+T> implements Subscribable<T> {
    *    stack traces.
    */
   static onUnhandledError(
-    callback: (Error, isUncaughtThrownError: boolean) => mixed,
+    callback: (Error, isUncaughtThrownError: boolean) => unknown,
   ): void {
     hostReportError = callback;
   }
@@ -247,7 +247,7 @@ class RelayObservable<+T> implements Subscribable<T> {
    *
    * This is useful for cleanup such as resource finalization.
    */
-  finally(fn: () => mixed): RelayObservable<T> {
+  finally(fn: () => unknown): RelayObservable<T> {
     return RelayObservable.create(sink => {
       const subscription = this.subscribe(sink);
       return () => {
@@ -351,6 +351,8 @@ class RelayObservable<+T> implements Subscribable<T> {
       }
 
       function complete(this: ObservableContext) {
+        /* $FlowFixMe[incompatible-type] Error exposed after improved typing of
+         * Array.{includes,indexOf,lastIndexOf} */
         subscriptions.splice(subscriptions.indexOf(this._sub), 1);
         if (subscriptions.length === 0) {
           sink.complete();
@@ -445,9 +447,9 @@ class RelayObservable<+T> implements Subscribable<T> {
 }
 
 // Use declarations to teach Flow how to check isObservable.
-declare function isObservable<T>(obj: mixed): obj is Subscribable<T>;
+declare function isObservable<T>(obj: unknown): obj is Subscribable<T>;
 
-function isObservable(obj: mixed) {
+function isObservable(obj: unknown) {
   return (
     typeof obj === 'object' &&
     obj !== null &&
@@ -490,7 +492,7 @@ function subscribe<T>(
   // Relay to be used within will support property getters, and many minifier
   // tools still do not support ES5 syntax. Instead, we can use defineProperty.
   const withClosed: <O>(obj: O) => {...O, +closed: boolean} = (obj =>
-    Object.defineProperty(obj, 'closed', ({get: () => closed}: any)): any);
+    Object.defineProperty(obj, 'closed', {get: () => closed} as any)) as any;
 
   function doCleanup() {
     if (cleanup) {

package/network/RelayQueryResponseCache.js.flow

@@ -77,16 +77,16 @@ class RelayQueryResponseCache {
               ...payload.extensions,
               cacheTimestamp: response.fetchTime,
             },
-          }: GraphQLSingularResponse),
+          }) as GraphQLSingularResponse,
       );
     }
-    return ({
+    return {
       ...response.payload,
       extensions: {
         ...response.payload.extensions,
         cacheTimestamp: response.fetchTime,
       },
-    }: GraphQLSingularResponse);
+    } as GraphQLSingularResponse;
   }
 
   set(queryID: string, variables: Variables, payload: GraphQLResponse): void {

package/network/wrapNetworkWithLogObserver.js.flow

@@ -90,7 +90,7 @@ function wrapNetworkWithLogObserver(
           });
         },
       };
-      const logRequestInfo = (info: mixed) => {
+      const logRequestInfo = (info: unknown) => {
         env.__log({
           name: 'network.info',
           networkRequestId,