relay-runtime 13.0.1 → 13.1.1

package/util/withProvidedVariables.js.flow

@@ -13,19 +13,47 @@
 
 'use strict';
 
-import type {RequestParameters} from './RelayConcreteNode';
+import type {ProvidedVariablesType} from './RelayConcreteNode';
 import type {Variables} from './RelayRuntimeTypes';
 
+const areEqual = require('areEqual');
+const warning = require('warning');
+
+const WEAKMAP_SUPPORTED = typeof WeakMap === 'function';
+const debugCache = WEAKMAP_SUPPORTED ? new WeakMap() : new Map();
+
 function withProvidedVariables(
   userSuppliedVariables: Variables,
-  parameters: RequestParameters,
+  providedVariables: ?ProvidedVariablesType,
 ): Variables {
-  const providedVariables = parameters.providedVariables;
   if (providedVariables != null) {
     const operationVariables = {};
     Object.assign(operationVariables, userSuppliedVariables);
     Object.keys(providedVariables).forEach((varName: string) => {
-      operationVariables[varName] = providedVariables[varName].get();
+      const providerFunction = providedVariables[varName].get;
+      const providerResult = providerFunction();
+
+      // people like to ignore these warnings, so use the cache to
+      // enforce that we only compute the value the first time
+      if (!debugCache.has(providerFunction)) {
+        debugCache.set(providerFunction, providerResult);
+        operationVariables[varName] = providerResult;
+      } else {
+        const cachedResult = debugCache.get(providerFunction);
+
+        if (__DEV__) {
+          warning(
+            areEqual(providerResult, cachedResult),
+            'Relay: Expected function `%s` for provider `%s` to be a pure function, ' +
+              'but got conflicting return values `%s` and `%s`',
+            providerFunction.name,
+            varName,
+            providerResult,
+            cachedResult,
+          );
+        }
+        operationVariables[varName] = cachedResult;
+      }
     });
     return operationVariables;
   } else {