relay-runtime 11.0.2 → 13.0.0-rc.2

package/lib/store/RelayModernSelector.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -10,21 +10,21 @@
 // flowlint ambiguous-object-type:error
 'use strict';
 
-var areEqual = require("fbjs/lib/areEqual");
-
-var invariant = require('invariant');
-
-var warning = require("fbjs/lib/warning");
-
 var _require = require('./RelayConcreteVariables'),
     getFragmentVariables = _require.getFragmentVariables;
 
 var _require2 = require('./RelayStoreUtils'),
+    CLIENT_EDGE_TRAVERSAL_PATH = _require2.CLIENT_EDGE_TRAVERSAL_PATH,
     FRAGMENT_OWNER_KEY = _require2.FRAGMENT_OWNER_KEY,
     FRAGMENTS_KEY = _require2.FRAGMENTS_KEY,
     ID_KEY = _require2.ID_KEY,
     IS_WITHIN_UNMATCHED_TYPE_REFINEMENT = _require2.IS_WITHIN_UNMATCHED_TYPE_REFINEMENT;
 
+var areEqual = require("fbjs/lib/areEqual");
+
+var invariant = require('invariant');
+
+var warning = require("fbjs/lib/warning");
 /**
  * @public
  *
@@ -54,18 +54,22 @@ var _require2 = require('./RelayStoreUtils'),
  * const childData = environment.lookup(childSelector).data;
  * ```
  */
+
+
 function getSingularSelector(fragment, item) {
   !(typeof item === 'object' && item !== null && !Array.isArray(item)) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayModernSelector: Expected value for fragment `%s` to be an object, got ' + '`%s`.', fragment.name, JSON.stringify(item)) : invariant(false) : void 0;
   var dataID = item[ID_KEY];
   var fragments = item[FRAGMENTS_KEY];
   var mixedOwner = item[FRAGMENT_OWNER_KEY];
   var isWithinUnmatchedTypeRefinement = item[IS_WITHIN_UNMATCHED_TYPE_REFINEMENT] === true;
+  var mixedClientEdgeTraversalPath = item[CLIENT_EDGE_TRAVERSAL_PATH];
 
-  if (typeof dataID === 'string' && typeof fragments === 'object' && fragments !== null && typeof fragments[fragment.name] === 'object' && fragments[fragment.name] !== null && typeof mixedOwner === 'object' && mixedOwner !== null) {
+  if (typeof dataID === 'string' && typeof fragments === 'object' && fragments !== null && typeof fragments[fragment.name] === 'object' && fragments[fragment.name] !== null && typeof mixedOwner === 'object' && mixedOwner !== null && (mixedClientEdgeTraversalPath == null || Array.isArray(mixedClientEdgeTraversalPath))) {
     var owner = mixedOwner;
+    var clientEdgeTraversalPath = mixedClientEdgeTraversalPath;
     var argumentVariables = fragments[fragment.name];
     var fragmentVariables = getFragmentVariables(fragment, owner.variables, argumentVariables);
-    return createReaderSelector(fragment, dataID, fragmentVariables, owner, isWithinUnmatchedTypeRefinement);
+    return createReaderSelector(fragment, dataID, fragmentVariables, owner, isWithinUnmatchedTypeRefinement, clientEdgeTraversalPath);
   }
 
   if (process.env.NODE_ENV !== "production") {
@@ -295,10 +299,12 @@ function areEqualSelectors(thisSelector, thatSelector) {
 
 function createReaderSelector(fragment, dataID, variables, request) {
   var isWithinUnmatchedTypeRefinement = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : false;
+  var clientEdgeTraversalPath = arguments.length > 5 ? arguments[5] : undefined;
   return {
     kind: 'SingularReaderSelector',
     dataID: dataID,
     isWithinUnmatchedTypeRefinement: isWithinUnmatchedTypeRefinement,
+    clientEdgeTraversalPath: clientEdgeTraversalPath !== null && clientEdgeTraversalPath !== void 0 ? clientEdgeTraversalPath : null,
     node: fragment,
     variables: variables,
     owner: request

package/lib/store/RelayModernStore.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -16,10 +16,20 @@ var _createForOfIteratorHelper2 = _interopRequireDefault(require("@babel/runtime
 
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 
-var DataChecker = require('./DataChecker');
+var _require = require('../multi-actor-environment/ActorIdentifier'),
+    INTERNAL_ACTOR_IDENTIFIER_DO_NOT_USE = _require.INTERNAL_ACTOR_IDENTIFIER_DO_NOT_USE,
+    assertInternalActorIndentifier = _require.assertInternalActorIndentifier;
+
+var deepFreeze = require('../util/deepFreeze');
 
 var RelayFeatureFlags = require('../util/RelayFeatureFlags');
 
+var resolveImmediate = require('../util/resolveImmediate');
+
+var DataChecker = require('./DataChecker');
+
+var defaultGetDataID = require('./defaultGetDataID');
+
 var RelayModernRecord = require('./RelayModernRecord');
 
 var RelayOptimisticRecordSource = require('./RelayOptimisticRecordSource');
@@ -32,22 +42,17 @@ var RelayStoreReactFlightUtils = require('./RelayStoreReactFlightUtils');
 
 var RelayStoreSubscriptions = require('./RelayStoreSubscriptions');
 
-var RelayStoreSubscriptionsUsingMapByID = require('./RelayStoreSubscriptionsUsingMapByID');
-
 var RelayStoreUtils = require('./RelayStoreUtils');
 
-var deepFreeze = require('../util/deepFreeze');
+var _require2 = require('./RelayStoreUtils'),
+    ROOT_ID = _require2.ROOT_ID,
+    ROOT_TYPE = _require2.ROOT_TYPE;
 
-var defaultGetDataID = require('./defaultGetDataID');
+var _require3 = require('./ResolverCache'),
+    RecordResolverCache = _require3.RecordResolverCache;
 
 var invariant = require('invariant');
 
-var resolveImmediate = require('../util/resolveImmediate');
-
-var _require = require('./RelayStoreUtils'),
-    ROOT_ID = _require.ROOT_ID,
-    ROOT_TYPE = _require.ROOT_TYPE;
-
 var DEFAULT_RELEASE_BUFFER_SIZE = 10;
 /**
  * @public
@@ -108,7 +113,10 @@ var RelayModernStore = /*#__PURE__*/function () {
     this._releaseBuffer = [];
     this._roots = new Map();
     this._shouldScheduleGC = false;
-    this._storeSubscriptions = RelayFeatureFlags.ENABLE_STORE_SUBSCRIPTIONS_REFACTOR === true ? new RelayStoreSubscriptionsUsingMapByID(options === null || options === void 0 ? void 0 : options.log) : new RelayStoreSubscriptions(options === null || options === void 0 ? void 0 : options.log);
+    this._resolverCache = new RecordResolverCache(function () {
+      return _this._getMutableRecordSource();
+    });
+    this._storeSubscriptions = new RelayStoreSubscriptions(options === null || options === void 0 ? void 0 : options.log, this._resolverCache);
     this._updatedRecordIDs = new Set();
     this._shouldProcessClientComponents = options === null || options === void 0 ? void 0 : options.shouldProcessClientComponents;
     initializeRecordSource(this._recordSource);
@@ -122,11 +130,19 @@ var RelayModernStore = /*#__PURE__*/function () {
     return (_this$_optimisticSour = this._optimisticSource) !== null && _this$_optimisticSour !== void 0 ? _this$_optimisticSour : this._recordSource;
   };
 
+  _proto._getMutableRecordSource = function _getMutableRecordSource() {
+    var _this$_optimisticSour2;
+
+    return (_this$_optimisticSour2 = this._optimisticSource) !== null && _this$_optimisticSour2 !== void 0 ? _this$_optimisticSour2 : this._recordSource;
+  };
+
   _proto.check = function check(operation, options) {
-    var _this$_optimisticSour2, _options$target, _options$handlers;
+    var _options$handlers, _options$getSourceFor, _options$getTargetFor, _options$defaultActor;
 
     var selector = operation.root;
-    var source = (_this$_optimisticSour2 = this._optimisticSource) !== null && _this$_optimisticSour2 !== void 0 ? _this$_optimisticSour2 : this._recordSource;
+
+    var source = this._getMutableRecordSource();
+
     var globalInvalidationEpoch = this._globalInvalidationEpoch;
 
     var rootEntry = this._roots.get(operation.request.identifier);
@@ -135,7 +151,7 @@ var RelayModernStore = /*#__PURE__*/function () {
 
     if (globalInvalidationEpoch != null) {
       // If so, check if the operation we're checking was last written
-      // before or after invalidation occured.
+      // before or after invalidation occurred.
       if (operationLastWrittenAt == null || operationLastWrittenAt <= globalInvalidationEpoch) {
         // If the operation was written /before/ global invalidation occurred,
         // or if this operation has never been written to the store before,
@@ -147,9 +163,16 @@ var RelayModernStore = /*#__PURE__*/function () {
       }
     }
 
-    var target = (_options$target = options === null || options === void 0 ? void 0 : options.target) !== null && _options$target !== void 0 ? _options$target : source;
     var handlers = (_options$handlers = options === null || options === void 0 ? void 0 : options.handlers) !== null && _options$handlers !== void 0 ? _options$handlers : [];
-    var operationAvailability = DataChecker.check(source, target, selector, handlers, this._operationLoader, this._getDataID, this._shouldProcessClientComponents);
+    var getSourceForActor = (_options$getSourceFor = options === null || options === void 0 ? void 0 : options.getSourceForActor) !== null && _options$getSourceFor !== void 0 ? _options$getSourceFor : function (actorIdentifier) {
+      assertInternalActorIndentifier(actorIdentifier);
+      return source;
+    };
+    var getTargetForActor = (_options$getTargetFor = options === null || options === void 0 ? void 0 : options.getTargetForActor) !== null && _options$getTargetFor !== void 0 ? _options$getTargetFor : function (actorIdentifier) {
+      assertInternalActorIndentifier(actorIdentifier);
+      return source;
+    };
+    var operationAvailability = DataChecker.check(getSourceForActor, getTargetForActor, (_options$defaultActor = options === null || options === void 0 ? void 0 : options.defaultActorIdentifier) !== null && _options$defaultActor !== void 0 ? _options$defaultActor : INTERNAL_ACTOR_IDENTIFIER_DO_NOT_USE, selector, handlers, this._operationLoader, this._getDataID, this._shouldProcessClientComponents);
     return getAvailabilityStatus(operationAvailability, operationLastWrittenAt, rootEntry === null || rootEntry === void 0 ? void 0 : rootEntry.fetchTime, this._queryCacheExpirationTime);
   };
 
@@ -234,7 +257,7 @@ var RelayModernStore = /*#__PURE__*/function () {
 
   _proto.lookup = function lookup(selector) {
     var source = this.getSource();
-    var snapshot = RelayReader.read(source, selector);
+    var snapshot = RelayReader.read(source, selector, this._resolverCache);
 
     if (process.env.NODE_ENV !== "production") {
       deepFreeze(snapshot);
@@ -264,6 +287,14 @@ var RelayModernStore = /*#__PURE__*/function () {
       this._globalInvalidationEpoch = this._currentWriteEpoch;
     }
 
+    if (RelayFeatureFlags.ENABLE_RELAY_RESOLVERS) {
+      // When a record is updated, we need to also handle records that depend on it,
+      // specifically Relay Resolver result records containing results based on the
+      // updated records. This both adds to updatedRecordIDs and invalidates any
+      // cached data as needed.
+      this._resolverCache.invalidateDataIDs(this._updatedRecordIDs);
+    }
+
     var source = this.getSource();
     var updatedOwners = [];
 
@@ -322,9 +353,8 @@ var RelayModernStore = /*#__PURE__*/function () {
   };
 
   _proto.publish = function publish(source, idsMarkedForInvalidation) {
-    var _this$_optimisticSour3;
+    var target = this._getMutableRecordSource();
 
-    var target = (_this$_optimisticSour3 = this._optimisticSource) !== null && _this$_optimisticSour3 !== void 0 ? _this$_optimisticSour3 : this._recordSource;
     updateTargetFromSource(target, source, // We increment the current epoch at the end of the set of updates,
     // in notify(). Here, we pass what will be the incremented value of
     // the epoch to use to write to invalidated records.
@@ -375,6 +405,10 @@ var RelayModernStore = /*#__PURE__*/function () {
 
   _proto.toJSON = function toJSON() {
     return 'RelayModernStore()';
+  };
+
+  _proto.getEpoch = function getEpoch() {
+    return this._currentWriteEpoch;
   } // Internal API
   ;
 
@@ -646,8 +680,7 @@ function updateTargetFromSource(target, source, currentWriteEpoch, idsMarkedForI
       }
 
       RelayModernRecord.setValue(nextRecord, RelayStoreUtils.INVALIDATED_AT_KEY, currentWriteEpoch);
-      invalidatedRecordIDs.add(dataID); // $FlowFixMe[incompatible-call]
-
+      invalidatedRecordIDs.add(dataID);
       target.set(dataID, nextRecord);
     });
   } // Update the target based on the changes present in source

package/lib/store/RelayOperationTracker.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -18,9 +18,9 @@ var invariant = require('invariant');
 
 var RelayOperationTracker = /*#__PURE__*/function () {
   function RelayOperationTracker() {
-    this._ownersToPendingOperationsIdentifier = new Map();
-    this._pendingOperationsToOwnersIdentifier = new Map();
-    this._ownersIdentifierToPromise = new Map();
+    this._ownersToPendingOperations = new Map();
+    this._pendingOperationsToOwners = new Map();
+    this._ownersToPendingPromise = new Map();
   }
   /**
    * Update the map of current processing operations with the set of
@@ -46,19 +46,19 @@ var RelayOperationTracker = /*#__PURE__*/function () {
         var owner = _step.value;
         var ownerIdentifier = owner.identifier;
 
-        var pendingOperationsAffectingOwner = this._ownersToPendingOperationsIdentifier.get(ownerIdentifier);
+        var pendingOperationsAffectingOwner = this._ownersToPendingOperations.get(ownerIdentifier);
 
         if (pendingOperationsAffectingOwner != null) {
           // In this case the `ownerIdentifier` already affected by some operations
           // We just need to detect, is it the same operation that we already
           // have in the list, or it's a new operation
           if (!pendingOperationsAffectingOwner.has(pendingOperationIdentifier)) {
-            pendingOperationsAffectingOwner.add(pendingOperationIdentifier);
+            pendingOperationsAffectingOwner.set(pendingOperationIdentifier, pendingOperation);
             newlyAffectedOwnersIdentifier.add(ownerIdentifier);
           }
         } else {
           // This is a new `ownerIdentifier` that is affected by the operation
-          this._ownersToPendingOperationsIdentifier.set(ownerIdentifier, new Set([pendingOperationIdentifier]));
+          this._ownersToPendingOperations.set(ownerIdentifier, new Map([[pendingOperationIdentifier, pendingOperation]]));
 
           newlyAffectedOwnersIdentifier.add(ownerIdentifier);
         }
@@ -73,10 +73,10 @@ var RelayOperationTracker = /*#__PURE__*/function () {
     if (newlyAffectedOwnersIdentifier.size === 0) {
       return;
     } // But, if some owners were affected we need to add them to
-    // the `_pendingOperationsToOwnersIdentifier` set
+    // the `_pendingOperationsToOwners` set
 
 
-    var ownersAffectedByOperationIdentifier = this._pendingOperationsToOwnersIdentifier.get(pendingOperationIdentifier) || new Set();
+    var ownersAffectedByPendingOperation = this._pendingOperationsToOwners.get(pendingOperationIdentifier) || new Set();
 
     var _iterator2 = (0, _createForOfIteratorHelper2["default"])(newlyAffectedOwnersIdentifier),
         _step2;
@@ -87,7 +87,7 @@ var RelayOperationTracker = /*#__PURE__*/function () {
 
         this._resolveOwnerResolvers(_ownerIdentifier);
 
-        ownersAffectedByOperationIdentifier.add(_ownerIdentifier);
+        ownersAffectedByPendingOperation.add(_ownerIdentifier);
       }
     } catch (err) {
       _iterator2.e(err);
@@ -95,7 +95,7 @@ var RelayOperationTracker = /*#__PURE__*/function () {
       _iterator2.f();
     }
 
-    this._pendingOperationsToOwnersIdentifier.set(pendingOperationIdentifier, ownersAffectedByOperationIdentifier);
+    this._pendingOperationsToOwners.set(pendingOperationIdentifier, ownersAffectedByPendingOperation);
   }
   /**
    * Once pending operation is completed we need to remove it
@@ -106,7 +106,7 @@ var RelayOperationTracker = /*#__PURE__*/function () {
   _proto.complete = function complete(pendingOperation) {
     var pendingOperationIdentifier = pendingOperation.identifier;
 
-    var affectedOwnersIdentifier = this._pendingOperationsToOwnersIdentifier.get(pendingOperationIdentifier);
+    var affectedOwnersIdentifier = this._pendingOperationsToOwners.get(pendingOperationIdentifier);
 
     if (affectedOwnersIdentifier == null) {
       return;
@@ -125,7 +125,7 @@ var RelayOperationTracker = /*#__PURE__*/function () {
       for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
         var ownerIdentifier = _step3.value;
 
-        var pendingOperationsAffectingOwner = this._ownersToPendingOperationsIdentifier.get(ownerIdentifier);
+        var pendingOperationsAffectingOwner = this._ownersToPendingOperations.get(ownerIdentifier);
 
         if (!pendingOperationsAffectingOwner) {
           continue;
@@ -155,7 +155,7 @@ var RelayOperationTracker = /*#__PURE__*/function () {
 
         this._resolveOwnerResolvers(_ownerIdentifier2);
 
-        this._ownersToPendingOperationsIdentifier["delete"](_ownerIdentifier2);
+        this._ownersToPendingOperations["delete"](_ownerIdentifier2);
       } // Update all ownerIdentifier that were updated by `pendingOperationIdentifier` but still
       // are affected by other operations
 
@@ -181,30 +181,35 @@ var RelayOperationTracker = /*#__PURE__*/function () {
       _iterator5.f();
     }
 
-    this._pendingOperationsToOwnersIdentifier["delete"](pendingOperationIdentifier);
+    this._pendingOperationsToOwners["delete"](pendingOperationIdentifier);
   };
 
   _proto._resolveOwnerResolvers = function _resolveOwnerResolvers(ownerIdentifier) {
-    var promiseEntry = this._ownersIdentifierToPromise.get(ownerIdentifier);
+    var promiseEntry = this._ownersToPendingPromise.get(ownerIdentifier);
 
     if (promiseEntry != null) {
       promiseEntry.resolve();
     }
 
-    this._ownersIdentifierToPromise["delete"](ownerIdentifier);
+    this._ownersToPendingPromise["delete"](ownerIdentifier);
   };
 
-  _proto.getPromiseForPendingOperationsAffectingOwner = function getPromiseForPendingOperationsAffectingOwner(owner) {
+  _proto.getPendingOperationsAffectingOwner = function getPendingOperationsAffectingOwner(owner) {
     var ownerIdentifier = owner.identifier;
 
-    if (!this._ownersToPendingOperationsIdentifier.has(ownerIdentifier)) {
+    var pendingOperationsForOwner = this._ownersToPendingOperations.get(ownerIdentifier);
+
+    if (pendingOperationsForOwner == null || pendingOperationsForOwner.size === 0) {
       return null;
     }
 
-    var cachedPromiseEntry = this._ownersIdentifierToPromise.get(ownerIdentifier);
+    var cachedPromiseEntry = this._ownersToPendingPromise.get(ownerIdentifier);
 
     if (cachedPromiseEntry != null) {
-      return cachedPromiseEntry.promise;
+      return {
+        promise: cachedPromiseEntry.promise,
+        pendingOperations: cachedPromiseEntry.pendingOperations
+      };
     }
 
     var resolve;
@@ -212,13 +217,18 @@ var RelayOperationTracker = /*#__PURE__*/function () {
       resolve = r;
     });
     !(resolve != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'RelayOperationTracker: Expected resolver to be defined. If you' + 'are seeing this, it is likely a bug in Relay.') : invariant(false) : void 0;
+    var pendingOperations = Array.from(pendingOperationsForOwner.values());
 
-    this._ownersIdentifierToPromise.set(ownerIdentifier, {
+    this._ownersToPendingPromise.set(ownerIdentifier, {
       promise: promise,
-      resolve: resolve
+      resolve: resolve,
+      pendingOperations: pendingOperations
     });
 
-    return promise;
+    return {
+      promise: promise,
+      pendingOperations: pendingOperations
+    };
   };
 
   return RelayOperationTracker;

package/lib/store/RelayOptimisticRecordSource.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/lib/store/RelayPublishQueue.js

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -10,11 +10,7 @@
 // flowlint ambiguous-object-type:error
 'use strict';
 
-var _global$ErrorUtils$ap, _global$ErrorUtils;
-
-var RelayReader = require('./RelayReader');
-
-var RelayRecordSource = require('./RelayRecordSource');
+var _global$ErrorUtils$ap, _global, _global$ErrorUtils;
 
 var RelayRecordSourceMutator = require('../mutations/RelayRecordSourceMutator');
 
@@ -22,11 +18,15 @@ var RelayRecordSourceProxy = require('../mutations/RelayRecordSourceProxy');
 
 var RelayRecordSourceSelectorProxy = require('../mutations/RelayRecordSourceSelectorProxy');
 
+var RelayReader = require('./RelayReader');
+
+var RelayRecordSource = require('./RelayRecordSource');
+
 var invariant = require('invariant');
 
 var warning = require("fbjs/lib/warning");
 
-var applyWithGuard = (_global$ErrorUtils$ap = (_global$ErrorUtils = global.ErrorUtils) === null || _global$ErrorUtils === void 0 ? void 0 : _global$ErrorUtils.applyWithGuard) !== null && _global$ErrorUtils$ap !== void 0 ? _global$ErrorUtils$ap : function (callback, context, args, onError, name) {
+var applyWithGuard = (_global$ErrorUtils$ap = (_global = global) === null || _global === void 0 ? void 0 : (_global$ErrorUtils = _global.ErrorUtils) === null || _global$ErrorUtils === void 0 ? void 0 : _global$ErrorUtils.applyWithGuard) !== null && _global$ErrorUtils$ap !== void 0 ? _global$ErrorUtils$ap : function (callback, context, args, onError, name) {
   return callback.apply(context, args);
 };
 /**
@@ -45,9 +45,15 @@ var RelayPublishQueue = /*#__PURE__*/function () {
   // True if the next `run()` should apply the backup and rerun all optimistic
   // updates performing a rebase.
   // Payloads to apply or Sources to publish to the store with the next `run()`.
+  // $FlowFixMe[unclear-type] See explanation below.
   // Optimistic updaters to add with the next `run()`.
+  // $FlowFixMe[unclear-type] See explanation below.
   // Optimistic updaters that are already added and might be rerun in order to
   // rebase them.
+  // $FlowFixMe[unclear-type] See explanation below.
+  // For _pendingOptimisticUpdates, _appliedOptimisticUpdates, and _pendingData,
+  // we want to parametrize by "any" since the type is effectively
+  // "the union of all T's that PublishQueue's methods were called with".
   // Garbage collection hold, should rerun gc on dispose
   function RelayPublishQueue(store, handlerProvider, getDataID) {
     this._hasStoreSnapshot = false;
@@ -149,11 +155,25 @@ var RelayPublishQueue = /*#__PURE__*/function () {
   ;
 
   _proto.run = function run(sourceOperation) {
+    var runWillClearGcHold = this._appliedOptimisticUpdates === 0 && !!this._gcHold;
+    var runIsANoop = // this._pendingBackupRebase is true if an applied optimistic
+    // update has potentially been reverted or if this._pendingData is not empty.
+    !this._pendingBackupRebase && this._pendingOptimisticUpdates.size === 0 && !runWillClearGcHold;
+
     if (process.env.NODE_ENV !== "production") {
+      process.env.NODE_ENV !== "production" ? warning(!runIsANoop, 'RelayPublishQueue.run was called, but the call would have been a noop.') : void 0;
       process.env.NODE_ENV !== "production" ? warning(this._isRunning !== true, 'A store update was detected within another store update. Please ' + "make sure new store updates aren't being executed within an " + 'updater function for a different update.') : void 0;
       this._isRunning = true;
     }
 
+    if (runIsANoop) {
+      if (process.env.NODE_ENV !== "production") {
+        this._isRunning = false;
+      }
+
+      return [];
+    }
+
     if (this._pendingBackupRebase) {
       if (this._hasStoreSnapshot) {
         this._store.restore();
@@ -287,7 +307,7 @@ var RelayPublishQueue = /*#__PURE__*/function () {
 
     var sink = RelayRecordSource.create();
     var mutator = new RelayRecordSourceMutator(this._store.getSource(), sink);
-    var recordSourceProxy = new RelayRecordSourceProxy(mutator, this._getDataID, this._handlerProvider);
+    var recordSourceProxy = new RelayRecordSourceProxy(mutator, this._getDataID, this._handlerProvider); // $FlowFixMe[unclear-type] see explanation above.
 
     var processUpdate = function processUpdate(optimisticUpdate) {
       if (optimisticUpdate.storeUpdater) {
@@ -299,15 +319,19 @@ var RelayPublishQueue = /*#__PURE__*/function () {
             updater = optimisticUpdate.updater;
         var source = payload.source,
             fieldPayloads = payload.fieldPayloads;
-        var recordSourceSelectorProxy = new RelayRecordSourceSelectorProxy(mutator, recordSourceProxy, operation.fragment);
-        var selectorData;
 
         if (source) {
           recordSourceProxy.publishSource(source, fieldPayloads);
-          selectorData = lookupSelector(source, operation.fragment);
         }
 
         if (updater) {
+          var selectorData;
+
+          if (source) {
+            selectorData = lookupSelector(source, operation.fragment);
+          }
+
+          var recordSourceSelectorProxy = new RelayRecordSourceSelectorProxy(mutator, recordSourceProxy, operation.fragment);
           applyWithGuard(updater, null, [recordSourceSelectorProxy, selectorData], null, 'RelayPublishQueue:applyUpdates');
         }
       }