relay-runtime 0.0.0-main-d543a7a5 → 0.0.0-main-c844a5ba

package/store/RelayReader.js.flow

@@ -483,8 +483,7 @@ class RelayReader {
         if (!RelayFeatureFlags.ENABLE_RELAY_RESOLVERS) {
           throw new Error('Relay Resolver fields are not yet supported.');
         }
-        this._readResolverField(selection.field, record, data);
-        break;
+        return this._readResolverField(selection.field, record, data);
       default:
         (selection.field.kind: empty);
         invariant(
@@ -499,7 +498,7 @@ class RelayReader {
     field: ReaderRelayResolver,
     record: Record,
     data: SelectorData,
-  ): void {
+  ): mixed {
     const {resolverModule, fragment} = field;
     const storageKey = getStorageKey(field, this._variables);
     const resolverID = ClientID.generateClientID(
@@ -575,6 +574,7 @@ class RelayReader {
 
     const applicationName = field.alias ?? field.name;
     data[applicationName] = result;
+    return result;
   }
 
   _readClientEdge(

package/util/withProvidedVariables.js.flow

@@ -16,6 +16,12 @@
 import type {RequestParameters} from './RelayConcreteNode';
 import type {Variables} from './RelayRuntimeTypes';
 
+const areEqual = require('areEqual');
+const warning = require('warning');
+
+const WEAKMAP_SUPPORTED = typeof WeakMap === 'function';
+const debugCache = WEAKMAP_SUPPORTED ? new WeakMap() : new Map();
+
 function withProvidedVariables(
   userSuppliedVariables: Variables,
   parameters: RequestParameters,
@@ -25,7 +31,30 @@ function withProvidedVariables(
     const operationVariables = {};
     Object.assign(operationVariables, userSuppliedVariables);
     Object.keys(providedVariables).forEach((varName: string) => {
-      operationVariables[varName] = providedVariables[varName].get();
+      const providerFunction = providedVariables[varName].get;
+      const providerResult = providerFunction();
+
+      // people like to ignore these warnings, so use the cache to
+      // enforce that we only compute the value the first time
+      if (!debugCache.has(providerFunction)) {
+        debugCache.set(providerFunction, providerResult);
+        operationVariables[varName] = providerResult;
+      } else {
+        const cachedResult = debugCache.get(providerFunction);
+
+        if (__DEV__) {
+          warning(
+            areEqual(providerResult, cachedResult),
+            'Relay: Expected function `%s` for provider `%s` to be a pure function, ' +
+              'but got conflicting return values `%s` and `%s`',
+            providerFunction.name,
+            varName,
+            providerResult,
+            cachedResult,
+          );
+        }
+        operationVariables[varName] = cachedResult;
+      }
     });
     return operationVariables;
   } else {