relay-runtime 0.0.0-main-204ce14c → 0.0.0-main-e8bf0b68

package/index.js

@@ -1,5 +1,5 @@
 /**
- * Relay v0.0.0-main-204ce14c
+ * Relay v0.0.0-main-e8bf0b68
  *
  * Copyright (c) Meta Platforms, Inc. and affiliates.
  *

package/index.js.flow

@@ -46,6 +46,7 @@ const RelayModernStore = require('./store/RelayModernStore');
 const RelayOperationTracker = require('./store/RelayOperationTracker');
 const RelayRecordSource = require('./store/RelayRecordSource');
 const RelayStoreUtils = require('./store/RelayStoreUtils');
+const ResolverFragments = require('./store/ResolverFragments');
 const ViewerPattern = require('./store/ViewerPattern');
 const requestSubscription = require('./subscription/requestSubscription');
 const createPayloadFor3DField = require('./util/createPayloadFor3DField');
@@ -352,6 +353,7 @@ module.exports = {
   getPendingOperationsForFragment: getPendingOperationsForFragment,
   getValueAtPath: getValueAtPath,
   __internal: {
+    ResolverFragments,
     OperationTracker: RelayOperationTracker,
     createRelayContext: createRelayContext,
     getOperationVariables: RelayConcreteVariables.getOperationVariables,

package/lib/index.js

@@ -73,6 +73,8 @@ var RelayRecordSource = require('./store/RelayRecordSource');
 
 var RelayStoreUtils = require('./store/RelayStoreUtils');
 
+var ResolverFragments = require('./store/ResolverFragments');
+
 var ViewerPattern = require('./store/ViewerPattern');
 
 var requestSubscription = require('./subscription/requestSubscription');
@@ -230,6 +232,7 @@ module.exports = {
   getPendingOperationsForFragment: getPendingOperationsForFragment,
   getValueAtPath: getValueAtPath,
   __internal: {
+    ResolverFragments: ResolverFragments,
     OperationTracker: RelayOperationTracker,
     createRelayContext: createRelayContext,
     getOperationVariables: RelayConcreteVariables.getOperationVariables,

package/lib/mutations/readUpdatableQuery_EXPERIMENTAL.js

@@ -37,7 +37,7 @@ function readUpdatableQuery_EXPERIMENTAL(query, variables, proxy) {
 }
 
 function updateProxyFromSelections(mutableUpdatableProxy, recordProxy, queryVariables, selections, root) {
-  var _selection$alias, _selection$alias2;
+  var _selection$alias3;
 
   var _iterator = (0, _createForOfIteratorHelper2["default"])(selections),
       _step;
@@ -48,21 +48,23 @@ function updateProxyFromSelections(mutableUpdatableProxy, recordProxy, queryVari
 
       switch (selection.kind) {
         case 'LinkedField':
-          // Linked fields are assignable if they contain fragment spreads or
-          // read-only otherwise.
-          var isAssignable = selection.selections.some(function (item) {
-            return item.kind === 'FragmentSpread';
-          });
-          var set = !isAssignable ? undefined : selection.plural ? createSetterForPluralLinkedField(selection, queryVariables, recordProxy, root) : createSetterForSingularLinkedField(selection, queryVariables, recordProxy, root);
-          var get = selection.plural ? createGetterForPluralLinkedField(selection, queryVariables, recordProxy, root) : createGetterForSingularLinkedField(selection, queryVariables, recordProxy, root);
-          Object.defineProperty(mutableUpdatableProxy, (_selection$alias = selection.alias) !== null && _selection$alias !== void 0 ? _selection$alias : selection.name, {
-            get: get,
-            set: set
-          });
+          if (selection.plural) {
+            Object.defineProperty(mutableUpdatableProxy, (_selection$alias = selection.alias) !== null && _selection$alias !== void 0 ? _selection$alias : selection.name, {
+              // $FlowFixMe[incompatible-call] these getters and setters have different types on purpose
+              get: createGetterForPluralLinkedField(selection, queryVariables, recordProxy, root),
+              set: createSetterForPluralLinkedField(selection, queryVariables, recordProxy, root)
+            });
+          } else {
+            Object.defineProperty(mutableUpdatableProxy, (_selection$alias2 = selection.alias) !== null && _selection$alias2 !== void 0 ? _selection$alias2 : selection.name, {
+              get: createGetterForSingularLinkedField(selection, queryVariables, recordProxy, root),
+              set: createSetterForSingularLinkedField(selection, queryVariables, recordProxy, root)
+            });
+          }
+
           break;
 
         case 'ScalarField':
-          var scalarFieldName = (_selection$alias2 = selection.alias) !== null && _selection$alias2 !== void 0 ? _selection$alias2 : selection.name;
+          var scalarFieldName = (_selection$alias3 = selection.alias) !== null && _selection$alias3 !== void 0 ? _selection$alias3 : selection.name;
           Object.defineProperty(mutableUpdatableProxy, scalarFieldName, {
             get: function get() {
               var _selection$args;
@@ -106,6 +108,10 @@ function updateProxyFromSelections(mutableUpdatableProxy, recordProxy, queryVari
     };
 
     for (_iterator.s(); !(_step = _iterator.n()).done;) {
+      var _selection$alias;
+
+      var _selection$alias2;
+
       _loop();
     }
   } catch (err) {
@@ -122,8 +128,7 @@ function createSetterForPluralLinkedField(selection, queryVariables, recordProxy
     var variables = getArgumentValues((_selection$args3 = selection.args) !== null && _selection$args3 !== void 0 ? _selection$args3 : [], queryVariables);
 
     if (newValue == null) {
-      // $FlowFixMe[unclear-type] No good way to type these variables
-      recordProxy.setValue(null, selection.name, variables);
+      throw new Error('Do not assign null to plural linked fields; assign an empty array instead.');
     } else {
       var recordProxies = newValue.map(function (item) {
         if (item == null) {

package/lib/query/fetchQuery.js

@@ -122,6 +122,9 @@ function fetchQuery(environment, query, variables, options) {
     if (snapshot.missingRequiredFields != null) {
       reportMissingRequiredFields(environment, snapshot.missingRequiredFields);
     }
+    /* $FlowFixMe[incompatible-return] we assume readData returns the right
+     * data just having written it from network or checked availability. */
+
 
     return snapshot.data;
   }

package/lib/store/ResolverFragments.js

@@ -37,9 +37,9 @@ function withResolverContext(context, cb) {
 // The declarations ensure that the type of the returned data is:
 //   - non-nullable if the provided ref type is non-nullable
 //   - nullable if the provided ref type is nullable
-//   - array of non-nullable if the privoided ref type is an array of
+//   - array of non-nullable if the provided ref type is an array of
 //     non-nullable refs
-//   - array of nullable if the privoided ref type is an array of nullable refs
+//   - array of nullable if the provided ref type is an array of nullable refs
 
 
 function readFragment(fragmentInput, fragmentKey) {

package/mutations/readUpdatableQuery_EXPERIMENTAL.js.flow

@@ -55,50 +55,46 @@ function updateProxyFromSelections<TQuery: OperationType>(
   for (const selection of selections) {
     switch (selection.kind) {
       case 'LinkedField':
-        // Linked fields are assignable if they contain fragment spreads or
-        // read-only otherwise.
-        const isAssignable = selection.selections.some(
-          item => item.kind === 'FragmentSpread',
-        );
-
-        const set = !isAssignable
-          ? undefined
-          : selection.plural
-          ? createSetterForPluralLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            )
-          : createSetterForSingularLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            );
-
-        const get = selection.plural
-          ? createGetterForPluralLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            )
-          : createGetterForSingularLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            );
-
-        Object.defineProperty(
-          mutableUpdatableProxy,
-          selection.alias ?? selection.name,
-          {
-            get,
-            set,
-          },
-        );
+        if (selection.plural) {
+          Object.defineProperty(
+            mutableUpdatableProxy,
+            selection.alias ?? selection.name,
+            {
+              // $FlowFixMe[incompatible-call] these getters and setters have different types on purpose
+              get: createGetterForPluralLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+              set: createSetterForPluralLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+            },
+          );
+        } else {
+          Object.defineProperty(
+            mutableUpdatableProxy,
+            selection.alias ?? selection.name,
+            {
+              get: createGetterForSingularLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+              set: createSetterForSingularLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+            },
+          );
+        }
         break;
       case 'ScalarField':
         const scalarFieldName = selection.alias ?? selection.name;
@@ -171,11 +167,12 @@ function createSetterForPluralLinkedField<TQuery: OperationType>(
   recordProxy: RecordProxy,
   root: RecordSourceProxy,
 ) {
-  return function set(newValue: ?$ReadOnlyArray<{__id: string, ...}>) {
+  return function set(newValue: $ReadOnlyArray<{__id: string, ...}>) {
     const variables = getArgumentValues(selection.args ?? [], queryVariables);
     if (newValue == null) {
-      // $FlowFixMe[unclear-type] No good way to type these variables
-      recordProxy.setValue(null, selection.name, (variables: any));
+      throw new Error(
+        'Do not assign null to plural linked fields; assign an empty array instead.',
+      );
     } else {
       const recordProxies = newValue.map(item => {
         if (item == null) {
@@ -206,6 +203,7 @@ function createSetterForPluralLinkedField<TQuery: OperationType>(
     }
   };
 }
+
 function createSetterForSingularLinkedField<TQuery: OperationType>(
   selection: ReaderLinkedField,
   queryVariables: TQuery['variables'],

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "relay-runtime",
   "description": "A core runtime for building GraphQL-driven applications.",
-  "version": "0.0.0-main-204ce14c",
+  "version": "0.0.0-main-e8bf0b68",
   "keywords": [
     "graphql",
     "relay"

package/query/fetchQuery.js.flow

@@ -22,9 +22,9 @@ import type {
   CacheConfig,
   FetchQueryFetchPolicy,
   OperationType,
-  VariablesOf,
+  Query,
+  Variables,
 } from '../util/RelayRuntimeTypes';
-import type {GraphQLTaggedNode} from './GraphQLTag';
 
 const RelayObservable = require('../network/RelayObservable');
 const {
@@ -112,15 +112,15 @@ const invariant = require('invariant');
  * ```
  * NOTE: When using .toPromise(), the request cannot be cancelled.
  */
-function fetchQuery<TQuery: OperationType>(
+function fetchQuery<TVariables: Variables, TData, TRawResponse>(
   environment: IEnvironment,
-  query: GraphQLTaggedNode,
-  variables: VariablesOf<TQuery>,
+  query: Query<TVariables, TData, TRawResponse>,
+  variables: TVariables,
   options?: $ReadOnly<{|
     fetchPolicy?: FetchQueryFetchPolicy,
     networkCacheConfig?: CacheConfig,
   |}>,
-): RelayObservable<TQuery['response']> {
+): RelayObservable<TData> {
   const queryNode = getRequest(query);
   invariant(
     queryNode.params.operationKind === 'query',
@@ -137,10 +137,12 @@ function fetchQuery<TQuery: OperationType>(
   );
   const fetchPolicy = options?.fetchPolicy ?? 'network-only';
 
-  function readData(snapshot: Snapshot) {
+  function readData(snapshot: Snapshot): TData {
     if (snapshot.missingRequiredFields != null) {
       reportMissingRequiredFields(environment, snapshot.missingRequiredFields);
     }
+    /* $FlowFixMe[incompatible-return] we assume readData returns the right
+     * data just having written it from network or checked availability. */
     return snapshot.data;
   }