relay-flow 0.3.9-alpha → 0.3.11-alpha

package/internal/workflow/workflow.go

@@ -65,9 +65,15 @@ type Node struct {
 	Agent       string           `yaml:"agent,omitempty" json:"agent,omitempty"`
 	Description string           `yaml:"description,omitempty" json:"description,omitempty"`
 	NudgePrompt string           `yaml:"nudgePrompt,omitempty" json:"nudgePrompt,omitempty"`
+	AutoReject  bool             `yaml:"autoReject,omitempty" json:"autoReject,omitempty"`
 	TaskConfig  config.RawValues `yaml:"taskConfig,omitempty" json:"taskConfig,omitempty"`
 	OnSuccess   []Route          `yaml:"onSuccess,omitempty" json:"onSuccess,omitempty"`
 	OnFailure   []Route          `yaml:"onFailure,omitempty" json:"onFailure,omitempty"`
+
+	// autoRejectSet lets validation distinguish an explicitly configured false
+	// from an omitted field. The marker is parser metadata and is not part of
+	// the workflow snapshot or JSON/YAML representation.
+	autoRejectSet bool
 }
 
 type Route struct {
@@ -119,6 +125,10 @@ func Parse(name string, yamlBytes []byte) (*Workflow, error) {
 	rawNodes, _ := raw["nodes"].(map[string]any)
 	for nodeName, n := range wf.Nodes {
 		if rn, ok := rawNodes[nodeName].(map[string]any); ok {
+			if _, present := rn["autoReject"]; present {
+				n.autoRejectSet = true
+				wf.Nodes[nodeName] = n
+			}
 			if v, present := rn["taskConfig"]; present && v == nil {
 				return nil, fmt.Errorf("parse workflow %q node %q: taskConfig: explicit null is not allowed", name, nodeName)
 			}
@@ -216,6 +226,9 @@ func (w *Workflow) Validate() error {
 }
 
 func validateStart(n Node) error {
+	if n.AutoReject || n.autoRejectSet {
+		return fmt.Errorf("autoReject is valid only on hitl nodes")
+	}
 	if n.Type != "" || n.Agent != "" || n.Description != "" || n.NudgePrompt != "" {
 		return fmt.Errorf("start must not declare type, agent, description, or nudgePrompt")
 	}
@@ -229,6 +242,9 @@ func validateStart(n Node) error {
 }
 
 func validateEnd(n Node) error {
+	if n.AutoReject || n.autoRejectSet {
+		return fmt.Errorf("autoReject is valid only on hitl nodes")
+	}
 	if n.Type != "" || n.Agent != "" || n.Description != "" || n.NudgePrompt != "" {
 		return fmt.Errorf("end must not declare type, agent, description, or nudgePrompt")
 	}
@@ -242,6 +258,9 @@ func validateWorkNode(wfName, name string, n Node) error {
 	if n.Type != NodeAgent && n.Type != NodeHITL {
 		return fmt.Errorf("workflow %q node %q: type must be %q or %q", wfName, name, NodeAgent, NodeHITL)
 	}
+	if n.Type != NodeHITL && (n.AutoReject || n.autoRejectSet) {
+		return fmt.Errorf("workflow %q node %q: autoReject is valid only on hitl nodes", wfName, name)
+	}
 	if n.Agent == "" {
 		return fmt.Errorf("workflow %q node %q: agent is required", wfName, name)
 	}
@@ -254,6 +273,11 @@ func validateWorkNode(wfName, name string, n Node) error {
 	if len(n.OnFailure) == 0 {
 		return fmt.Errorf("workflow %q node %q: at least one failure route is required", wfName, name)
 	}
+	for _, route := range n.OnFailure {
+		if route.Target == EndNode {
+			return fmt.Errorf("workflow %q node %q: failure routes cannot target %q", wfName, name, EndNode)
+		}
+	}
 	for _, m := range nudgeVarPattern.FindAllStringSubmatch(n.NudgePrompt, -1) {
 		if !knownNudgeVars[m[1]] {
 			return fmt.Errorf("workflow %q node %q: unknown nudge template variable {{%s}}", wfName, name, m[1])

package/internal/workflow/workflow_test.go

@@ -221,6 +221,63 @@ func TestValidateEndNode(t *testing.T) {
 	})
 }
 
+func TestAutoRejectPolicy(t *testing.T) {
+	t.Run("defaults false on HITL", func(t *testing.T) {
+		yaml := strings.Replace(minimalValid, "    type: agent", "    type: hitl", 1)
+		wf := parse(t, "basicFlow", yaml)
+		if err := wf.Validate(); err != nil {
+			t.Fatalf("HITL workflow rejected: %v", err)
+		}
+		if wf.Nodes["coding"].AutoReject {
+			t.Fatal("omitted autoReject defaulted to true")
+		}
+	})
+
+	t.Run("accepts true on HITL", func(t *testing.T) {
+		yaml := strings.Replace(minimalValid, "    type: agent", "    type: hitl\n    autoReject: true", 1)
+		wf := parse(t, "basicFlow", yaml)
+		if err := wf.Validate(); err != nil {
+			t.Fatalf("HITL autoReject workflow rejected: %v", err)
+		}
+		if !wf.Nodes["coding"].AutoReject {
+			t.Fatal("autoReject true was not parsed")
+		}
+	})
+
+	for _, tc := range []struct {
+		name string
+		yaml string
+	}{
+		{
+			name: "agent",
+			yaml: strings.Replace(minimalValid, "    type: agent", "    type: agent\n    autoReject: false", 1),
+		},
+		{
+			name: "start",
+			yaml: strings.Replace(minimalValid, "  start:\n    onSuccess:", "  start:\n    autoReject: false\n    onSuccess:", 1),
+		},
+		{
+			name: "end",
+			yaml: strings.Replace(minimalValid, "  end: {}", "  end:\n    autoReject: false", 1),
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			wf := parse(t, "basicFlow", tc.yaml)
+			if err := wf.Validate(); err == nil {
+				t.Fatal("autoReject accepted outside a HITL node")
+			}
+		})
+	}
+
+	t.Run("rejects failure route to end", func(t *testing.T) {
+		yaml := strings.Replace(minimalValid, "    onFailure:\n      - target: coding", "    onFailure:\n      - target: end", 1)
+		wf := parse(t, "basicFlow", yaml)
+		if err := wf.Validate(); err == nil {
+			t.Fatal("failure route to end accepted")
+		}
+	})
+}
+
 func TestValidateWorkNodes(t *testing.T) {
 	replaceCoding := func(node string) string {
 		return strings.Replace(minimalValid, "  coding:\n    type: agent\n    agent: build\n    description: Do the coding work.\n    onSuccess:\n      - target: end\n    onFailure:\n      - target: coding", node, 1)
@@ -303,7 +360,7 @@ func TestValidateRoutes(t *testing.T) {
 		}
 	})
 	t.Run("several routes for one outcome", func(t *testing.T) {
-		yaml := strings.Replace(minimalValid, "    onFailure:\n      - target: coding", "    onFailure:\n      - target: coding\n        when: retry\n      - target: end\n        when: give up", 1)
+		yaml := strings.Replace(minimalValid, "    onFailure:\n      - target: coding", "    onFailure:\n      - target: coding\n        when: retry\n      - target: coding\n        when: try again", 1)
 		wf := parse(t, "basicFlow", yaml)
 		if err := wf.Validate(); err != nil {
 			t.Fatalf("two failure routes rejected: %v", err)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "relay-flow",
-  "version": "0.3.9-alpha",
+  "version": "0.3.11-alpha",
   "description": "Graph-based agent workflow engine — tracker-agnostic, pluggable runners",
   "bin": {
     "relay-flow": "./bin/relay-flow.js",