relay-flow 0.1.0-alpha.0 → 0.2.1-alpha

package/internal/task/jira/rest/client_test.go

@@ -0,0 +1,381 @@
+package rest
+
+import (
+	"context"
+	"encoding/json"
+	"fmt"
+	"io"
+	"net/http"
+	"net/http/httptest"
+	"strings"
+	"sync"
+	"testing"
+)
+
+type requestRecord struct {
+	Method string
+	Path   string
+	Body   []byte
+}
+
+type jiraServer struct {
+	t       *testing.T
+	server  *httptest.Server
+	mu      sync.Mutex
+	records []requestRecord
+	handle  func(http.ResponseWriter, *http.Request, []byte)
+}
+
+func newJiraServer(t *testing.T, handle func(http.ResponseWriter, *http.Request, []byte)) *jiraServer {
+	t.Helper()
+	s := &jiraServer{t: t, handle: handle}
+	s.server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		body, err := io.ReadAll(r.Body)
+		if err != nil {
+			t.Fatal(err)
+		}
+		user, token, ok := r.BasicAuth()
+		if !ok || user != "bot@example.com" || token != "secret" {
+			http.Error(w, "bad auth", http.StatusUnauthorized)
+			return
+		}
+		s.mu.Lock()
+		s.records = append(s.records, requestRecord{Method: r.Method, Path: r.URL.Path, Body: body})
+		s.mu.Unlock()
+		handle(w, r, body)
+	}))
+	t.Cleanup(s.server.Close)
+	return s
+}
+
+func (s *jiraServer) client(t *testing.T) *HTTPClient {
+	t.Helper()
+	c, err := New(s.server.URL, "bot@example.com", "secret")
+	if err != nil {
+		t.Fatal(err)
+	}
+	return c
+}
+
+func (s *jiraServer) count(method, path string) int {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+	n := 0
+	for _, record := range s.records {
+		if record.Method == method && record.Path == path {
+			n++
+		}
+	}
+	return n
+}
+
+func writeJSON(w http.ResponseWriter, value any) {
+	w.Header().Set("Content-Type", "application/json")
+	_ = json.NewEncoder(w).Encode(value)
+}
+
+func TestValidateCredentialsUsesMyselfAndBasicAuth(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, _ []byte) {
+		if r.Method != http.MethodGet || r.URL.Path != "/rest/api/3/myself" {
+			http.NotFound(w, r)
+			return
+		}
+		writeJSON(w, map[string]any{"accountId": "abc"})
+	})
+	if err := s.client(t).ValidateCredentials(context.Background()); err != nil {
+		t.Fatal(err)
+	}
+}
+
+func TestNewRejectsNonHTTPSRemoteSite(t *testing.T) {
+	if _, err := New("http://jira.example.com", "bot@example.com", "secret"); err == nil {
+		t.Fatal("insecure remote Jira site accepted")
+	}
+}
+
+func TestSearchPaginatesAndRequestsIssueLinks(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		if r.URL.Path != "/rest/api/3/search/jql" || r.Method != http.MethodPost {
+			http.NotFound(w, r)
+			return
+		}
+		var request struct {
+			Fields        []string `json:"fields"`
+			NextPageToken string   `json:"nextPageToken"`
+		}
+		if err := json.Unmarshal(body, &request); err != nil {
+			t.Fatal(err)
+		}
+		if !contains(request.Fields, "issuelinks") {
+			t.Fatalf("search fields = %v, missing issuelinks", request.Fields)
+		}
+		if request.NextPageToken == "" {
+			writeJSON(w, map[string]any{"issues": []any{issue("PAY-1")}, "nextPageToken": "next", "isLast": false})
+			return
+		}
+		writeJSON(w, map[string]any{"issues": []any{issue("PAY-2")}, "isLast": true})
+	})
+	raw, err := s.client(t).Search(context.Background(), "project = PAY")
+	if err != nil {
+		t.Fatal(err)
+	}
+	var issues []json.RawMessage
+	if err := json.Unmarshal(raw, &issues); err != nil || len(issues) != 2 {
+		t.Fatalf("issues = %s, err=%v", raw, err)
+	}
+	if s.count(http.MethodPost, "/rest/api/3/search/jql") != 2 {
+		t.Fatal("search did not use exactly one call per page")
+	}
+}
+
+func issue(key string) map[string]any {
+	return map[string]any{"id": key, "key": key, "fields": map[string]any{
+		"summary": key, "status": map[string]any{"name": "To Do"}, "issuetype": map[string]any{"name": "Task"}, "labels": []string{},
+	}}
+}
+
+func TestCreateSubtasksBatchesAndIncludesADFParentAndLabel(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		if r.URL.Path != "/rest/api/3/issue/bulk" {
+			http.NotFound(w, r)
+			return
+		}
+		var request struct {
+			IssueUpdates []struct {
+				Fields map[string]json.RawMessage `json:"fields"`
+			} `json:"issueUpdates"`
+		}
+		if err := json.Unmarshal(body, &request); err != nil {
+			t.Fatal(err)
+		}
+		created := make([]any, len(request.IssueUpdates))
+		for i, update := range request.IssueUpdates {
+			for _, field := range []string{"parent", "description", "labels"} {
+				if len(update.Fields[field]) == 0 {
+					t.Fatalf("bulk create missing %s: %s", field, body)
+				}
+			}
+			if !strings.Contains(string(update.Fields["description"]), `"type":"doc"`) {
+				t.Fatalf("description is not ADF: %s", update.Fields["description"])
+			}
+			created[i] = map[string]any{"id": fmt.Sprint(i + 1), "key": fmt.Sprintf("PAY-%d", i+2)}
+		}
+		writeJSON(w, map[string]any{"issues": created, "errors": []any{}})
+	})
+	client := s.client(t)
+	client.subtaskTypes["PAY"] = "10001"
+	specs := make([]SubtaskSpec, 51)
+	for i := range specs {
+		specs[i] = SubtaskSpec{Title: fmt.Sprintf("PAY-1:n%d", i), Description: "Work:\nDo it"}
+	}
+	created, err := client.CreateSubtasks(context.Background(), "PAY-1", "PAY", "wf:flow", specs)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(created) != 51 || s.count(http.MethodPost, "/rest/api/3/issue/bulk") != 2 {
+		t.Fatalf("created=%d calls=%d, want 51/2", len(created), s.count(http.MethodPost, "/rest/api/3/issue/bulk"))
+	}
+}
+
+func TestTransitionCombinesAssigneeAndCachesLookups(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		switch {
+		case r.URL.Path == "/rest/api/3/search/jql":
+			writeJSON(w, map[string]any{"issues": []any{issue("PAY-1")}, "isLast": true})
+		case r.URL.Path == "/rest/api/3/issue/PAY-1/transitions" && r.Method == http.MethodGet:
+			writeJSON(w, map[string]any{"transitions": []any{map[string]any{
+				"id": "21", "to": map[string]any{"name": "In Progress"}, "fields": map[string]any{"assignee": map[string]any{}},
+			}}})
+		case r.URL.Path == "/rest/api/3/user/assignable/search":
+			writeJSON(w, []any{map[string]any{"accountId": "acct", "emailAddress": "worker@example.com"}})
+		case r.URL.Path == "/rest/api/3/issue/PAY-1/transitions" && r.Method == http.MethodPost:
+			if !strings.Contains(string(body), `"assignee":{"accountId":"acct"}`) {
+				t.Fatalf("transition did not include assignee: %s", body)
+			}
+			w.WriteHeader(http.StatusNoContent)
+		default:
+			http.NotFound(w, r)
+		}
+	})
+	c := s.client(t)
+	if _, err := c.Search(context.Background(), "key = PAY-1"); err != nil {
+		t.Fatal(err)
+	}
+	if err := c.Transition(context.Background(), "PAY-1", "In Progress", "worker@example.com"); err != nil {
+		t.Fatal(err)
+	}
+	if s.count(http.MethodPut, "/rest/api/3/issue/PAY-1/assignee") != 0 {
+		t.Fatal("assignment used a separate call despite transition-screen support")
+	}
+}
+
+func TestTransitionFallsBackToSeparateAssignment(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, _ []byte) {
+		switch {
+		case r.URL.Path == "/rest/api/3/search/jql":
+			writeJSON(w, map[string]any{"issues": []any{issue("PAY-1")}, "isLast": true})
+		case r.URL.Path == "/rest/api/3/issue/PAY-1/transitions" && r.Method == http.MethodGet:
+			writeJSON(w, map[string]any{"transitions": []any{map[string]any{
+				"id": "21", "to": map[string]any{"name": "In Progress"}, "fields": map[string]any{},
+			}}})
+		case r.URL.Path == "/rest/api/3/user/assignable/search":
+			writeJSON(w, []any{map[string]any{"accountId": "acct", "emailAddress": "worker@example.com"}})
+		case r.URL.Path == "/rest/api/3/issue/PAY-1/assignee" && r.Method == http.MethodPut:
+			w.WriteHeader(http.StatusNoContent)
+		case r.URL.Path == "/rest/api/3/issue/PAY-1/transitions" && r.Method == http.MethodPost:
+			w.WriteHeader(http.StatusNoContent)
+		default:
+			http.NotFound(w, r)
+		}
+	})
+	c := s.client(t)
+	if _, err := c.Search(context.Background(), "key = PAY-1"); err != nil {
+		t.Fatal(err)
+	}
+	if err := c.Transition(context.Background(), "PAY-1", "In Progress", "worker@example.com"); err != nil {
+		t.Fatal(err)
+	}
+	if s.count(http.MethodPut, "/rest/api/3/issue/PAY-1/assignee") != 1 {
+		t.Fatal("transition without assignee field did not use assignment fallback")
+	}
+}
+
+func TestUpdateMailboxIsOneCall(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		if r.Method != http.MethodPut || r.URL.Path != "/rest/api/3/issue/PAY-2" {
+			http.NotFound(w, r)
+			return
+		}
+		if !strings.Contains(string(body), `"description"`) || !strings.Contains(string(body), `"labels"`) {
+			t.Fatalf("combined update missing fields: %s", body)
+		}
+		w.WriteHeader(http.StatusNoContent)
+	})
+	if err := s.client(t).UpdateMailbox(context.Background(), "PAY-2", "Work:\nDo it", "wf:flow"); err != nil {
+		t.Fatal(err)
+	}
+	if s.count(http.MethodPut, "/rest/api/3/issue/PAY-2") != 1 {
+		t.Fatal("mailbox reconciliation was not one call")
+	}
+}
+
+func TestEnsureLabelIsOneAddCall(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		if r.Method != http.MethodPut || r.URL.Path != "/rest/api/3/issue/PAY-1" {
+			http.NotFound(w, r)
+			return
+		}
+		if !strings.Contains(string(body), `"add":"wf:flow"`) {
+			t.Fatalf("label update = %s", body)
+		}
+		w.WriteHeader(http.StatusNoContent)
+	})
+	if err := s.client(t).EnsureLabel(context.Background(), "PAY-1", "wf:flow"); err != nil {
+		t.Fatal(err)
+	}
+	if s.count(http.MethodPut, "/rest/api/3/issue/PAY-1") != 1 {
+		t.Fatal("claim label was not one call")
+	}
+}
+
+func TestTransitionAlreadyAtTargetMakesNoTransitionCall(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, _ []byte) {
+		if r.URL.Path == "/rest/api/3/search/jql" {
+			item := issue("PAY-1")
+			item["fields"].(map[string]any)["status"] = map[string]any{"name": "Done"}
+			writeJSON(w, map[string]any{"issues": []any{item}, "isLast": true})
+			return
+		}
+		http.NotFound(w, r)
+	})
+	c := s.client(t)
+	if _, err := c.Search(context.Background(), "key = PAY-1"); err != nil {
+		t.Fatal(err)
+	}
+	if err := c.Transition(context.Background(), "PAY-1", "Done", ""); err != nil {
+		t.Fatal(err)
+	}
+	if s.count(http.MethodGet, "/rest/api/3/issue/PAY-1/transitions") != 0 {
+		t.Fatal("already-completed issue queried transitions")
+	}
+}
+
+func TestCommentsUseADFAndParseMarker(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, body []byte) {
+		if r.URL.Path != "/rest/api/3/issue/PAY-2/comment" {
+			http.NotFound(w, r)
+			return
+		}
+		if r.Method == http.MethodGet {
+			writeJSON(w, map[string]any{"comments": []any{map[string]any{"body": ADF("summary\n\n<!-- visit:summary -->")}}, "startAt": 0, "total": 1})
+			return
+		}
+		if !strings.Contains(string(body), `"type":"doc"`) {
+			t.Fatalf("comment is not ADF: %s", body)
+		}
+		w.WriteHeader(http.StatusCreated)
+	})
+	c := s.client(t)
+	comments, err := c.ListComments(context.Background(), "PAY-2")
+	if err != nil || len(comments) != 1 || !strings.Contains(comments[0], "visit:summary") {
+		t.Fatalf("comments=%v err=%v", comments, err)
+	}
+	if err := c.AddComment(context.Background(), "PAY-2", "SUMMARY:\nDone"); err != nil {
+		t.Fatal(err)
+	}
+}
+
+func TestRetries429WithoutExposingCredentials(t *testing.T) {
+	calls := 0
+	s := newJiraServer(t, func(w http.ResponseWriter, r *http.Request, _ []byte) {
+		calls++
+		if calls == 1 {
+			w.Header().Set("Retry-After", "0")
+			http.Error(w, "limited", http.StatusTooManyRequests)
+			return
+		}
+		writeJSON(w, map[string]any{"accountId": "abc"})
+	})
+	if err := s.client(t).ValidateCredentials(context.Background()); err != nil {
+		t.Fatal(err)
+	}
+	if calls != 2 {
+		t.Fatalf("calls=%d, want one retry", calls)
+	}
+}
+
+func TestErrorRedactsToken(t *testing.T) {
+	s := newJiraServer(t, func(w http.ResponseWriter, _ *http.Request, _ []byte) {
+		http.Error(w, "rejected secret for bot@example.com", http.StatusUnauthorized)
+	})
+	err := s.client(t).ValidateCredentials(context.Background())
+	if err == nil || strings.Contains(err.Error(), "secret") || strings.Contains(err.Error(), "bot@example.com") {
+		t.Fatalf("error did not redact Jira credentials: %v", err)
+	}
+}
+
+func TestADFFormatsHeadingsListsAndRoundTripsMarker(t *testing.T) {
+	doc := ADF("SUMMARY\n\nNode: implement\n\n- first\n- second\n\n```\ngo test ./...\n```\n\n<!-- visit:summary -->")
+	raw, err := json.Marshal(doc)
+	if err != nil {
+		t.Fatal(err)
+	}
+	text := string(raw)
+	for _, want := range []string{`"type":"heading"`, `"type":"bulletList"`, `"type":"codeBlock"`, `"type":"strong"`} {
+		if !strings.Contains(text, want) {
+			t.Fatalf("ADF %s missing %s", text, want)
+		}
+	}
+	if got := ADFText(raw); !strings.Contains(got, "visit:summary") {
+		t.Fatalf("ADF marker round trip = %q", got)
+	}
+}
+
+func contains(values []string, want string) bool {
+	for _, value := range values {
+		if value == want {
+			return true
+		}
+	}
+	return false
+}

package/internal/task/jira/testdata/jira_search_issues.json

@@ -0,0 +1,120 @@
+[
+  {
+    "changelog": null,
+    "editmeta": null,
+    "expand": "renderedFields,names,schema,operations,editmeta,changelog,versionedRepresentations",
+    "fields": {
+      "assignee": {
+        "accountId": "712020:dad5df85-a7bd-4337-b858-0faf9012a009",
+        "accountType": "atlassian",
+        "active": true,
+        "avatarUrls": {
+          "16x16": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "24x24": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "32x32": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "48x48": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png"
+        },
+        "displayName": "Raj Popat",
+        "emailAddress": "raj.popat@wolterskluwer.com",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/user?accountId=712020%3Adad5df85-a7bd-4337-b858-0faf9012a009",
+        "timeZone": "America/New_York"
+      },
+      "issuetype": {
+        "avatarId": 10318,
+        "description": "A small, distinct piece of work.",
+        "hierarchyLevel": 0,
+        "iconUrl": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10318?size=medium",
+        "id": "10017",
+        "name": "Task",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/issuetype/10017",
+        "subtask": false
+      },
+      "labels": [],
+      "status": {
+        "description": "",
+        "iconUrl": "https://jira-prod-us-26-3.prod.atl-paas.net/",
+        "id": "10007",
+        "name": "To Do",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/status/10007",
+        "statusCategory": {
+          "colorName": "blue-gray",
+          "id": 2,
+          "key": "new",
+          "name": "To Do",
+          "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/statuscategory/2"
+        }
+      },
+      "summary": "e2e: hello world program in python"
+    },
+    "fieldsToInclude": null,
+    "id": "157320",
+    "key": "GHCOS-41242",
+    "names": null,
+    "operations": null,
+    "properties": null,
+    "renderedFields": null,
+    "schema": null,
+    "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/issue/157320",
+    "transitions": null,
+    "versionedRepresentations": null
+  },
+  {
+    "changelog": null,
+    "editmeta": null,
+    "expand": "renderedFields,names,schema,operations,editmeta,changelog,versionedRepresentations",
+    "fields": {
+      "assignee": {
+        "accountId": "712020:dad5df85-a7bd-4337-b858-0faf9012a009",
+        "accountType": "atlassian",
+        "active": true,
+        "avatarUrls": {
+          "16x16": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "24x24": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "32x32": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png",
+          "48x48": "https://secure.gravatar.com/avatar/09110b9326675e772c94aa61fc89195b?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FRP-6.png"
+        },
+        "displayName": "Raj Popat",
+        "emailAddress": "raj.popat@wolterskluwer.com",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/user?accountId=712020%3Adad5df85-a7bd-4337-b858-0faf9012a009",
+        "timeZone": "America/New_York"
+      },
+      "issuetype": {
+        "avatarId": 10303,
+        "description": "A problem or error.",
+        "hierarchyLevel": 0,
+        "iconUrl": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium",
+        "id": "10019",
+        "name": "Bug",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/issuetype/10019",
+        "subtask": false
+      },
+      "labels": [],
+      "status": {
+        "description": "",
+        "iconUrl": "https://jira-prod-us-26-3.prod.atl-paas.net/",
+        "id": "10007",
+        "name": "To Do",
+        "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/status/10007",
+        "statusCategory": {
+          "colorName": "blue-gray",
+          "id": 2,
+          "key": "new",
+          "name": "To Do",
+          "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/statuscategory/2"
+        }
+      },
+      "summary": "OpsDB Sync Validation Bug"
+    },
+    "fieldsToInclude": null,
+    "id": "155110",
+    "key": "GHCOS-41175",
+    "names": null,
+    "operations": null,
+    "properties": null,
+    "renderedFields": null,
+    "schema": null,
+    "self": "https://jira-prod-us-26-3.prod.atl-paas.net/rest/api/3/issue/155110",
+    "transitions": null,
+    "versionedRepresentations": null
+  }
+]

package/internal/task/jira/transition_defaults_test.go

@@ -0,0 +1,158 @@
+package jira
+
+import (
+	"context"
+	"errors"
+	"testing"
+
+	"github.com/rajpopat27/relay-flow/internal/config"
+	"github.com/rajpopat27/relay-flow/internal/task"
+)
+
+// 3.5: Jira transition defaults per specs/workflow-definition "Jira
+// transition defaults are deterministic": omitted transitions default to
+// parent In Progress at start, mailbox In Progress at agent/HITL work
+// nodes, and parent Done at end; an omitted work-node parent transition
+// leaves the parent unchanged.
+//
+// This test is package-local (package jira) so it can drive the adapter's
+// ApplyTaskConfig against a test-local fake client without inventing an
+// exported production constructor seam. The adapter resolves defaults
+// internally; the fake records the transitions the adapter issues.
+
+// fakeJira is a test-local fakeable Jira boundary recording transitions and
+// serving a fixed search batch for Poll.
+type fakeJira struct {
+	parentTransitions []string
+	taskTransitions   []string
+	assignments       []string
+	assignErr         error
+	events            []string
+	// searchJSON is the raw Jira search response Poll serves.
+	searchJSON    []byte
+	comments      []string
+	addedComments []string
+	labelCalls    []string
+}
+
+func (f *fakeJira) transition(key, status string) {
+	if key == "PAY-101" {
+		f.parentTransitions = append(f.parentTransitions, status)
+	} else {
+		f.taskTransitions = append(f.taskTransitions, status)
+	}
+}
+
+// newSystemWithFake builds the adapter around the test-local Jira client.
+func newSystemWithFake(t *testing.T, fake *fakeJira) task.System {
+	t.Helper()
+	sys, err := newSystemForTest(fake)
+	if err != nil {
+		t.Fatalf("adapter construction failed: %v", err)
+	}
+	return sys
+}
+
+func TestStartDefaultParentInProgress(t *testing.T) {
+	fake := &fakeJira{}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+
+	// start: omitted transitionTo, parent-only target.
+	if err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent}, config.RawValues{}); err != nil {
+		t.Fatalf("ApplyTaskConfig start failed: %v", err)
+	}
+	if len(fake.parentTransitions) != 1 || fake.parentTransitions[0] != "In Progress" {
+		t.Fatalf("start parent transitions = %v, want [In Progress]", fake.parentTransitions)
+	}
+}
+
+func TestWorkNodeDefaultMailboxInProgressParentUnchanged(t *testing.T) {
+	fake := &fakeJira{}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+	mb := task.Mailbox{ID: "2", Key: "PAY-102", Node: "coding"}
+
+	if err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent, Mailbox: &mb}, config.RawValues{}); err != nil {
+		t.Fatalf("ApplyTaskConfig failed: %v", err)
+	}
+	if len(fake.taskTransitions) != 1 || fake.taskTransitions[0] != "In Progress" {
+		t.Fatalf("mailbox transitions = %v, want [In Progress]", fake.taskTransitions)
+	}
+	if len(fake.parentTransitions) != 0 {
+		t.Fatalf("parent transitions = %v, want none (parent unchanged when omitted)", fake.parentTransitions)
+	}
+	if len(fake.assignments) != 0 {
+		t.Fatalf("mailbox assignments = %v, want none when assignee omitted", fake.assignments)
+	}
+}
+
+func TestWorkNodeAssignsMailboxBeforeTransition(t *testing.T) {
+	fake := &fakeJira{}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+	mb := task.Mailbox{ID: "2", Key: "PAY-102", Node: "coding"}
+
+	err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent, Mailbox: &mb}, config.RawValues{
+		"assignee": "reviewer@example.com",
+	})
+	if err != nil {
+		t.Fatalf("ApplyTaskConfig failed: %v", err)
+	}
+	if len(fake.assignments) != 1 || fake.assignments[0] != "PAY-102:reviewer@example.com" {
+		t.Fatalf("mailbox assignments = %v, want [PAY-102:reviewer@example.com]", fake.assignments)
+	}
+	if len(fake.events) != 1 || fake.events[0] != "transition" {
+		t.Fatalf("mailbox events = %v, want one combined transition", fake.events)
+	}
+}
+
+func TestWorkNodeAssignmentFailurePreventsTransition(t *testing.T) {
+	fake := &fakeJira{assignErr: errors.New("assignment failed")}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+	mb := task.Mailbox{ID: "2", Key: "PAY-102", Node: "coding"}
+
+	err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent, Mailbox: &mb}, config.RawValues{
+		"assignee": "reviewer@example.com",
+	})
+	if err == nil || len(fake.taskTransitions) != 0 {
+		t.Fatalf("ApplyTaskConfig error = %v, transitions = %v", err, fake.taskTransitions)
+	}
+}
+
+func TestEndDefaultParentDone(t *testing.T) {
+	fake := &fakeJira{}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+
+	// end: omitted transitionTo. The end effective config carries no
+	// transition; the adapter must still default the parent to Done. Run
+	// orchestration applies the end node config to the parent target.
+	if err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent}, endConfig(config.RawValues{})); err != nil {
+		t.Fatalf("ApplyTaskConfig end failed: %v", err)
+	}
+	if len(fake.parentTransitions) != 1 || fake.parentTransitions[0] != "Done" {
+		t.Fatalf("end parent transitions = %v, want [Done]", fake.parentTransitions)
+	}
+}
+
+func TestExplicitTransitionsWin(t *testing.T) {
+	fake := &fakeJira{}
+	sys := newSystemWithFake(t, fake)
+	parent := task.TicketRef{ID: "1", Key: "PAY-101", Title: "parent"}
+	mb := task.Mailbox{ID: "2", Key: "PAY-102", Node: "review"}
+
+	err := sys.ApplyTaskConfig(context.Background(), task.Target{Parent: parent, Mailbox: &mb}, config.RawValues{
+		"transitionTo": map[string]any{"parentStatus": "In Review", "taskStatus": "In Review"},
+	})
+	if err != nil {
+		t.Fatalf("ApplyTaskConfig failed: %v", err)
+	}
+	if len(fake.parentTransitions) != 1 || fake.parentTransitions[0] != "In Review" {
+		t.Fatalf("parent transitions = %v, want [In Review]", fake.parentTransitions)
+	}
+	if len(fake.taskTransitions) != 1 || fake.taskTransitions[0] != "In Review" {
+		t.Fatalf("mailbox transitions = %v, want [In Review]", fake.taskTransitions)
+	}
+}