refacil-sdd-ai 4.2.4 → 4.4.0

package/lib/hooks.js

@@ -1,236 +1,236 @@
-'use strict';
-
-const fs = require('fs');
-const path = require('path');
-
-// ── Cursor: todos los hooks en .cursor/hooks.json ────────────────────────────
-
-function readCursorHooksJson(projectRoot) {
-  const p = path.join(projectRoot, '.cursor', 'hooks.json');
-  if (!fs.existsSync(p)) return { version: 1, hooks: {} };
-  try {
-    const c = JSON.parse(fs.readFileSync(p, 'utf8'));
-    if (!c.hooks) c.hooks = {};
-    return c;
-  } catch (_) {
-    return { version: 1, hooks: {} };
-  }
-}
-
-function writeCursorHooksJson(projectRoot, config) {
-  const dir = path.join(projectRoot, '.cursor');
-  fs.mkdirSync(dir, { recursive: true });
-  fs.writeFileSync(path.join(dir, 'hooks.json'), JSON.stringify(config, null, 2) + '\n');
-}
-
-function installCursorHooks(projectRoot) {
-  cleanLegacySettingsHooks(projectRoot);
-  const config = readCursorHooksJson(projectRoot);
-  let changed = false;
-
-  function ensure(event, marker, entry) {
-    if (!config.hooks[event]) config.hooks[event] = [];
-    if (!config.hooks[event].some((h) => h[marker] === true)) {
-      config.hooks[event].push(entry);
-      changed = true;
-    }
-  }
-
-  ensure('sessionStart', '_sdd', {
-    _sdd: true,
-    command: 'refacil-sdd-ai check-update',
-  });
-
-  // compact-bash debe ir ANTES de check-review
-  if (!config.hooks.preToolUse) config.hooks.preToolUse = [];
-  if (!config.hooks.preToolUse.some((h) => h._sdd_compact === true)) {
-    config.hooks.preToolUse.unshift({ _sdd_compact: true, command: 'refacil-sdd-ai compact-bash', matcher: 'Bash' });
-    changed = true;
-  }
-  if (!config.hooks.preToolUse.some((h) => h._sdd_review === true)) {
-    config.hooks.preToolUse.push({ _sdd_review: true, command: 'refacil-sdd-ai check-review', matcher: 'Bash' });
-    changed = true;
-  }
-
-  ensure('beforeSubmitPrompt', '_sdd_notify', {
-    _sdd_notify: true,
-    command: 'refacil-sdd-ai notify-update --cursor',
-  });
-
-  if (!changed) {
-    console.log('  Hooks SDD-AI ya configurados en .cursor/hooks.json.');
-    return false;
-  }
-
-  writeCursorHooksJson(projectRoot, config);
-  return true;
-}
-
-function uninstallCursorHooks(projectRoot) {
-  const hooksJsonPath = path.join(projectRoot, '.cursor', 'hooks.json');
-  let changed = false;
-
-  if (fs.existsSync(hooksJsonPath)) {
-    let config;
-    try { config = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8')); } catch (_) { config = null; }
-
-    if (config && config.hooks) {
-      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
-      for (const event of Object.keys(config.hooks)) {
-        if (!Array.isArray(config.hooks[event])) continue;
-        const before = config.hooks[event].length;
-        config.hooks[event] = config.hooks[event].filter(
-          (h) => !sddMarkers.some((m) => h[m] === true),
-        );
-        if (config.hooks[event].length !== before) changed = true;
-        if (config.hooks[event].length === 0) delete config.hooks[event];
-      }
-      if (changed) writeCursorHooksJson(projectRoot, config);
-    }
-  }
-
-  // Limpiar vestigios en settings.json de instalaciones previas
-  const settingsPath = path.join(projectRoot, '.cursor', 'settings.json');
-  if (fs.existsSync(settingsPath)) {
-    let settings;
-    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = null; }
-    if (settings && settings.hooks) {
-      const evts = ['SessionStart', 'PreToolUse', 'UserPromptSubmit', 'beforeSubmitPrompt', 'Stop', 'afterAgentResponse'];
-      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
-      for (const evt of evts) {
-        if (!Array.isArray(settings.hooks[evt])) continue;
-        const before = settings.hooks[evt].length;
-        settings.hooks[evt] = settings.hooks[evt].filter((h) => !sddMarkers.some((m) => h[m] === true));
-        if (settings.hooks[evt].length !== before) changed = true;
-        if (settings.hooks[evt].length === 0) delete settings.hooks[evt];
-      }
-      if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
-      if (changed) fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
-    }
-  }
-
-  return changed;
-}
-
-// ── Claude Code: todos los hooks en .claude/settings.json ───────────────────
-
-function installClaudeHooks(projectRoot) {
-  const settingsDir = path.join(projectRoot, '.claude');
-  const settingsPath = path.join(settingsDir, 'settings.json');
-  let settings = {};
-
-  if (fs.existsSync(settingsPath)) {
-    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = {}; }
-  }
-
-  if (!settings.hooks) settings.hooks = {};
-  let changed = false;
-
-  if (!settings.hooks.SessionStart) settings.hooks.SessionStart = [];
-  if (!settings.hooks.SessionStart.some((h) => h._sdd === true)) {
-    settings.hooks.SessionStart.push({ _sdd: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-update' }] });
-    changed = true;
-  }
-
-  if (!settings.hooks.UserPromptSubmit) settings.hooks.UserPromptSubmit = [];
-  if (!settings.hooks.UserPromptSubmit.some((h) => h._sdd_notify === true)) {
-    settings.hooks.UserPromptSubmit.push({ _sdd_notify: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai notify-update' }] });
-    changed = true;
-  }
-
-  if (!settings.hooks.PreToolUse) settings.hooks.PreToolUse = [];
-  if (!settings.hooks.PreToolUse.some((h) => h._sdd_compact === true)) {
-    settings.hooks.PreToolUse.unshift({ _sdd_compact: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai compact-bash' }] });
-    changed = true;
-  }
-  if (!settings.hooks.PreToolUse.some((h) => h._sdd_review === true)) {
-    settings.hooks.PreToolUse.push({ _sdd_review: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-review' }] });
-    changed = true;
-  }
-
-  if (!changed) {
-    console.log('  Hooks SDD-AI ya configurados en .claude/settings.json.');
-    return false;
-  }
-
-  fs.mkdirSync(settingsDir, { recursive: true });
-  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
-  return true;
-}
-
-function uninstallClaudeHooks(projectRoot) {
-  const settingsPath = path.join(projectRoot, '.claude', 'settings.json');
-  if (!fs.existsSync(settingsPath)) return false;
-
-  let settings;
-  try {
-    settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
-  } catch (_) {
-    console.log('  No se pudieron remover hooks: .claude/settings.json invalido.');
-    return false;
-  }
-
-  if (!settings.hooks) return false;
-
-  let changed = false;
-  const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
-
-  for (const event of Object.keys(settings.hooks)) {
-    if (!Array.isArray(settings.hooks[event])) continue;
-    const before = settings.hooks[event].length;
-    settings.hooks[event] = settings.hooks[event].filter((h) => !sddMarkers.some((m) => h[m] === true));
-    if (settings.hooks[event].length !== before) changed = true;
-    if (settings.hooks[event].length === 0) delete settings.hooks[event];
-  }
-
-  if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
-  if (!changed) return false;
-
-  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
-  return true;
-}
-
-// ── Limpieza de hooks SDD en settings.json (migracion legacy) ───────────────
-
-function cleanLegacySettingsHooks(projectRoot) {
-  const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
-  const evts = ['SessionStart', 'PreToolUse', 'UserPromptSubmit', 'beforeSubmitPrompt', 'Stop', 'afterAgentResponse'];
-
-  for (const ideDir of ['.cursor']) {
-    const settingsPath = path.join(projectRoot, ideDir, 'settings.json');
-    if (!fs.existsSync(settingsPath)) continue;
-
-    let settings;
-    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { continue; }
-    if (!settings || !settings.hooks) continue;
-
-    let changed = false;
-    for (const evt of evts) {
-      if (!Array.isArray(settings.hooks[evt])) continue;
-      const before = settings.hooks[evt].length;
-      settings.hooks[evt] = settings.hooks[evt].filter((h) => !sddMarkers.some((m) => h[m] === true));
-      if (settings.hooks[evt].length !== before) changed = true;
-      if (settings.hooks[evt].length === 0) delete settings.hooks[evt];
-    }
-    if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
-    if (changed) {
-      try { fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n'); } catch (_) {}
-    }
-  }
-}
-
-// ── Fachada pública ──────────────────────────────────────────────────────────
-
-function installHooks(ideDir, projectRoot) {
-  return ideDir === '.cursor'
-    ? installCursorHooks(projectRoot)
-    : installClaudeHooks(projectRoot);
-}
-
-function uninstallHooks(ideDir, projectRoot) {
-  return ideDir === '.cursor'
-    ? uninstallCursorHooks(projectRoot)
-    : uninstallClaudeHooks(projectRoot);
-}
-
-module.exports = { installHooks, uninstallHooks, cleanLegacySettingsHooks };
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+// ── Cursor: todos los hooks en .cursor/hooks.json ────────────────────────────
+
+function readCursorHooksJson(projectRoot) {
+  const p = path.join(projectRoot, '.cursor', 'hooks.json');
+  if (!fs.existsSync(p)) return { version: 1, hooks: {} };
+  try {
+    const c = JSON.parse(fs.readFileSync(p, 'utf8'));
+    if (!c.hooks) c.hooks = {};
+    return c;
+  } catch (_) {
+    return { version: 1, hooks: {} };
+  }
+}
+
+function writeCursorHooksJson(projectRoot, config) {
+  const dir = path.join(projectRoot, '.cursor');
+  fs.mkdirSync(dir, { recursive: true });
+  fs.writeFileSync(path.join(dir, 'hooks.json'), JSON.stringify(config, null, 2) + '\n');
+}
+
+function installCursorHooks(projectRoot) {
+  cleanLegacySettingsHooks(projectRoot);
+  const config = readCursorHooksJson(projectRoot);
+  let changed = false;
+
+  function ensure(event, marker, entry) {
+    if (!config.hooks[event]) config.hooks[event] = [];
+    if (!config.hooks[event].some((h) => h[marker] === true)) {
+      config.hooks[event].push(entry);
+      changed = true;
+    }
+  }
+
+  ensure('sessionStart', '_sdd', {
+    _sdd: true,
+    command: 'refacil-sdd-ai check-update',
+  });
+
+  // compact-bash debe ir ANTES de check-review
+  if (!config.hooks.preToolUse) config.hooks.preToolUse = [];
+  if (!config.hooks.preToolUse.some((h) => h._sdd_compact === true)) {
+    config.hooks.preToolUse.unshift({ _sdd_compact: true, command: 'refacil-sdd-ai compact-bash', matcher: 'Bash' });
+    changed = true;
+  }
+  if (!config.hooks.preToolUse.some((h) => h._sdd_review === true)) {
+    config.hooks.preToolUse.push({ _sdd_review: true, command: 'refacil-sdd-ai check-review', matcher: 'Bash' });
+    changed = true;
+  }
+
+  ensure('beforeSubmitPrompt', '_sdd_notify', {
+    _sdd_notify: true,
+    command: 'refacil-sdd-ai notify-update --cursor',
+  });
+
+  if (!changed) {
+    console.log('  Hooks SDD-AI ya configurados en .cursor/hooks.json.');
+    return false;
+  }
+
+  writeCursorHooksJson(projectRoot, config);
+  return true;
+}
+
+function uninstallCursorHooks(projectRoot) {
+  const hooksJsonPath = path.join(projectRoot, '.cursor', 'hooks.json');
+  let changed = false;
+
+  if (fs.existsSync(hooksJsonPath)) {
+    let config;
+    try { config = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8')); } catch (_) { config = null; }
+
+    if (config && config.hooks) {
+      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+      for (const event of Object.keys(config.hooks)) {
+        if (!Array.isArray(config.hooks[event])) continue;
+        const before = config.hooks[event].length;
+        config.hooks[event] = config.hooks[event].filter(
+          (h) => !sddMarkers.some((m) => h[m] === true),
+        );
+        if (config.hooks[event].length !== before) changed = true;
+        if (config.hooks[event].length === 0) delete config.hooks[event];
+      }
+      if (changed) writeCursorHooksJson(projectRoot, config);
+    }
+  }
+
+  // Limpiar vestigios en settings.json de instalaciones previas
+  const settingsPath = path.join(projectRoot, '.cursor', 'settings.json');
+  if (fs.existsSync(settingsPath)) {
+    let settings;
+    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = null; }
+    if (settings && settings.hooks) {
+      const evts = ['SessionStart', 'PreToolUse', 'UserPromptSubmit', 'beforeSubmitPrompt', 'Stop', 'afterAgentResponse'];
+      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+      for (const evt of evts) {
+        if (!Array.isArray(settings.hooks[evt])) continue;
+        const before = settings.hooks[evt].length;
+        settings.hooks[evt] = settings.hooks[evt].filter((h) => !sddMarkers.some((m) => h[m] === true));
+        if (settings.hooks[evt].length !== before) changed = true;
+        if (settings.hooks[evt].length === 0) delete settings.hooks[evt];
+      }
+      if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
+      if (changed) fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+    }
+  }
+
+  return changed;
+}
+
+// ── Claude Code: todos los hooks en .claude/settings.json ───────────────────
+
+function installClaudeHooks(projectRoot) {
+  const settingsDir = path.join(projectRoot, '.claude');
+  const settingsPath = path.join(settingsDir, 'settings.json');
+  let settings = {};
+
+  if (fs.existsSync(settingsPath)) {
+    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = {}; }
+  }
+
+  if (!settings.hooks) settings.hooks = {};
+  let changed = false;
+
+  if (!settings.hooks.SessionStart) settings.hooks.SessionStart = [];
+  if (!settings.hooks.SessionStart.some((h) => h._sdd === true)) {
+    settings.hooks.SessionStart.push({ _sdd: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-update' }] });
+    changed = true;
+  }
+
+  if (!settings.hooks.UserPromptSubmit) settings.hooks.UserPromptSubmit = [];
+  if (!settings.hooks.UserPromptSubmit.some((h) => h._sdd_notify === true)) {
+    settings.hooks.UserPromptSubmit.push({ _sdd_notify: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai notify-update' }] });
+    changed = true;
+  }
+
+  if (!settings.hooks.PreToolUse) settings.hooks.PreToolUse = [];
+  if (!settings.hooks.PreToolUse.some((h) => h._sdd_compact === true)) {
+    settings.hooks.PreToolUse.unshift({ _sdd_compact: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai compact-bash' }] });
+    changed = true;
+  }
+  if (!settings.hooks.PreToolUse.some((h) => h._sdd_review === true)) {
+    settings.hooks.PreToolUse.push({ _sdd_review: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-review' }] });
+    changed = true;
+  }
+
+  if (!changed) {
+    console.log('  Hooks SDD-AI ya configurados en .claude/settings.json.');
+    return false;
+  }
+
+  fs.mkdirSync(settingsDir, { recursive: true });
+  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+  return true;
+}
+
+function uninstallClaudeHooks(projectRoot) {
+  const settingsPath = path.join(projectRoot, '.claude', 'settings.json');
+  if (!fs.existsSync(settingsPath)) return false;
+
+  let settings;
+  try {
+    settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
+  } catch (_) {
+    console.log('  No se pudieron remover hooks: .claude/settings.json invalido.');
+    return false;
+  }
+
+  if (!settings.hooks) return false;
+
+  let changed = false;
+  const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+
+  for (const event of Object.keys(settings.hooks)) {
+    if (!Array.isArray(settings.hooks[event])) continue;
+    const before = settings.hooks[event].length;
+    settings.hooks[event] = settings.hooks[event].filter((h) => !sddMarkers.some((m) => h[m] === true));
+    if (settings.hooks[event].length !== before) changed = true;
+    if (settings.hooks[event].length === 0) delete settings.hooks[event];
+  }
+
+  if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
+  if (!changed) return false;
+
+  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+  return true;
+}
+
+// ── Limpieza de hooks SDD en settings.json (migracion legacy) ───────────────
+
+function cleanLegacySettingsHooks(projectRoot) {
+  const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+  const evts = ['SessionStart', 'PreToolUse', 'UserPromptSubmit', 'beforeSubmitPrompt', 'Stop', 'afterAgentResponse'];
+
+  for (const ideDir of ['.cursor']) {
+    const settingsPath = path.join(projectRoot, ideDir, 'settings.json');
+    if (!fs.existsSync(settingsPath)) continue;
+
+    let settings;
+    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { continue; }
+    if (!settings || !settings.hooks) continue;
+
+    let changed = false;
+    for (const evt of evts) {
+      if (!Array.isArray(settings.hooks[evt])) continue;
+      const before = settings.hooks[evt].length;
+      settings.hooks[evt] = settings.hooks[evt].filter((h) => !sddMarkers.some((m) => h[m] === true));
+      if (settings.hooks[evt].length !== before) changed = true;
+      if (settings.hooks[evt].length === 0) delete settings.hooks[evt];
+    }
+    if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
+    if (changed) {
+      try { fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n'); } catch (_) {}
+    }
+  }
+}
+
+// ── Fachada pública ──────────────────────────────────────────────────────────
+
+function installHooks(ideDir, projectRoot) {
+  return ideDir === '.cursor'
+    ? installCursorHooks(projectRoot)
+    : installClaudeHooks(projectRoot);
+}
+
+function uninstallHooks(ideDir, projectRoot) {
+  return ideDir === '.cursor'
+    ? uninstallCursorHooks(projectRoot)
+    : uninstallClaudeHooks(projectRoot);
+}
+
+module.exports = { installHooks, uninstallHooks, cleanLegacySettingsHooks };

package/lib/installer.js

@@ -71,10 +71,12 @@ function installSkills(packageRoot, projectRoot) {
 // Claude Code: tools allowlist granular, model: sonnet|opus|haiku
 // Cursor: readonly: true|false (booleano), model: inherit (default)
 function transformFrontmatterForCursor(content) {
-  const match = content.match(/^---\n([\s\S]*?)\n---\n([\s\S]*)$/);
+  const normalized = content.replace(/\r\n/g, '\n');
+  const match = normalized.match(/^---\n([\s\S]*?)\n---\n([\s\S]*)$/);
   if (!match) return content;
 
   const [, frontmatterRaw, body] = match;
+  // work with normalized content from here on
   const lines = frontmatterRaw.split('\n');
   const out = [];
   let toolsLine = null;
@@ -214,6 +216,59 @@ function removeSkills(projectRoot) {
   return removed;
 }
 
+function removeOpenspecLegacyAssets(projectRoot) {
+  let removed = 0;
+
+  // Remove .claude/skills/openspec-*/ and .cursor/skills/openspec-*/
+  for (const ideDir of ['.claude', '.cursor']) {
+    const skillsDir = path.join(projectRoot, ideDir, 'skills');
+    if (!fs.existsSync(skillsDir)) continue;
+    let entries;
+    try {
+      entries = fs.readdirSync(skillsDir, { withFileTypes: true });
+    } catch (_) {
+      continue;
+    }
+    for (const entry of entries) {
+      if (entry.isDirectory() && entry.name.startsWith('openspec-')) {
+        fs.rmSync(path.join(skillsDir, entry.name), { recursive: true });
+        removed++;
+      }
+    }
+  }
+
+  // Remove .claude/commands/opsx/ directory
+  const claudeOpsx = path.join(projectRoot, '.claude', 'commands', 'opsx');
+  if (fs.existsSync(claudeOpsx)) {
+    fs.rmSync(claudeOpsx, { recursive: true });
+    removed++;
+  }
+
+  // Remove .cursor/commands/opsx/ directory and opsx-*.md loose files
+  const cursorCommandsDir = path.join(projectRoot, '.cursor', 'commands');
+  const cursorOpsx = path.join(cursorCommandsDir, 'opsx');
+  if (fs.existsSync(cursorOpsx)) {
+    fs.rmSync(cursorOpsx, { recursive: true });
+    removed++;
+  }
+  if (fs.existsSync(cursorCommandsDir)) {
+    let entries;
+    try {
+      entries = fs.readdirSync(cursorCommandsDir, { withFileTypes: true });
+    } catch (_) {
+      entries = [];
+    }
+    for (const entry of entries) {
+      if (entry.isFile() && entry.name.startsWith('opsx-') && entry.name.endsWith('.md')) {
+        fs.unlinkSync(path.join(cursorCommandsDir, entry.name));
+        removed++;
+      }
+    }
+  }
+
+  return removed;
+}
+
 function checkClaudeCodeVersion() {
   const { execSync } = require('child_process');
   try {
@@ -244,7 +299,7 @@ function checkNodeVersion() {
 
   if (major < 20 || (major === 20 && minor < 19)) {
     console.log(`\n  ADVERTENCIA: Node.js ${version} detectado.`);
-    console.log('  OpenSpec requiere Node.js >= 20.19.0.');
+    console.log('  refacil-sdd-ai requiere Node.js >= 20.19.0.');
     console.log('  Las skills se instalaran pero /refacil:setup podria fallar al instalar OpenSpec.\n');
     return false;
   }
@@ -264,6 +319,7 @@ module.exports = {
   writeRepoVersion,
   getPackageVersion,
   removeSkills,
+  removeOpenspecLegacyAssets,
   checkClaudeCodeVersion,
   checkNodeVersion,
 };