refacil-sdd-ai 4.0.3 → 4.0.5

package/README.md

@@ -72,7 +72,7 @@ npm uninstall -g refacil-sdd-ai
 | Comando | Descripcion |
 |---|---|
 | `refacil-sdd-ai check-update` | (`SessionStart`) Verifica nueva version, sincroniza skills y `compact-guidance` en AGENTS.md |
-| `refacil-sdd-ai notify-update` | (`Stop` / `afterAgentResponse`) Notifica al LLM sobre migraciones pendientes al finalizar la primera respuesta; el agente ejecuta `/refacil:update` automaticamente |
+| `refacil-sdd-ai notify-update` | (`UserPromptSubmit` / `beforeSubmitPrompt`) Pregunta al usuario si desea ejecutar `/refacil:update` cuando hay migraciones pendientes |
 | `refacil-sdd-ai check-review` | (`PreToolUse`) Bloquea `git push` si falta `.review-passed` en algun cambio activo |
 | `refacil-sdd-ai compact-bash` | (`PreToolUse`) Reescribe comandos Bash bare via `updatedInput` |
 
@@ -234,13 +234,13 @@ Se instalan en `.claude/settings.json` **y** `.cursor/settings.json` durante `in
 | Hook | Evento | Que hace |
 |---|---|---|
 | `check-update` | `SessionStart` | Chequea nueva version en npm, la instala, sincroniza skills y **sincroniza el bloque `compact-guidance`** en `AGENTS.md`. Si hubo actualizacion, escribe un flag de notificacion para el siguiente hook. |
-| `notify-update` | `Stop` (Claude Code) / `afterAgentResponse` (Cursor) | Al finalizar la primera respuesta del agente, lee el flag de actualizacion pendiente. Si existe, inyecta la instruccion de ejecutar `/refacil:update` — el agente la ejecuta automaticamente y el usuario ve el resultado al final. El flag se borra tras notificar. |
+| `notify-update` | `UserPromptSubmit` (Claude Code) / `beforeSubmitPrompt` (Cursor) | Antes de procesar el siguiente mensaje del usuario, lee el flag de actualizacion pendiente. Si existe, inyecta la instruccion para que el agente pregunte al usuario si desea ejecutar `/refacil:update`. El flag se borra tras notificar. |
 | `compact-bash` | `PreToolUse` (Bash) | Reescribe silenciosamente comandos Bash bare via `updatedInput`. Sin turnos extra, sin que el IDE vea el cambio. Requiere Claude Code >= 2.1.89. |
 | `check-review` | `PreToolUse` (Bash) | Intercepta `git push` y bloquea si falta `.review-passed` en algun cambio activo. |
 
 Los cuatro hooks se instalan en `.claude/settings.json` (Claude Code) y `.cursor/settings.json` (Cursor) con la misma logica parametrica.
 
-> **Por que dos hooks para el update?** `SessionStart` hace el sync silencioso al abrir la sesion sin interaccion del usuario. `notify-update` en `Stop` se dispara al finalizar la primera respuesta del agente — la instruccion queda al final visible para el usuario y Claude la ejecuta automaticamente en el siguiente turno.
+> **Por que dos hooks para el update?** `SessionStart` hace el sync silencioso al abrir la sesion sin interaccion del usuario. `notify-update` en `UserPromptSubmit` / `beforeSubmitPrompt` inyecta la instruccion justo antes de que el agente procese el siguiente mensaje del usuario, garantizando que no se ignore.
 
 ### Gate de review en el push
 

package/bin/cli.js

@@ -53,13 +53,16 @@ function notifyUpdate() {
 
   let info = {};
   try { info = JSON.parse(fs.readFileSync(flagPath, 'utf8')); } catch (_) {}
-  try { fs.unlinkSync(flagPath); } catch (_) {}
 
-  const fromLabel = info.from ? `v${info.from}` : 'version desconocida';
-  console.log(
-    `[refacil-sdd-ai] La metodologia fue actualizada (${fromLabel} → v${info.to}). ` +
-    'Ejecuta /refacil:update ahora para aplicar las migraciones pendientes e informa el resultado al usuario.',
-  );
+  const fromLabel = info.from ? `v${info.from}` : 'version anterior';
+  const msg =
+    `[refacil-sdd-ai] Actualizacion de metodologia detectada (${fromLabel} → v${info.to}).\n` +
+    `Tu mensaje fue pausado. ¿Deseas aplicar las migraciones pendientes antes de continuar?\n` +
+    `  • Si: ejecuta /refacil:update\n` +
+    `  • No: reenvía tu mensaje anterior para continuar sin actualizar.`;
+  process.stdout.write(msg + '\n');
+  process.stderr.write(msg + '\n');
+  process.exit(2);
 }
 
 function repoIsInitialized() {

package/lib/hooks.js

@@ -1,130 +1,206 @@
-'use strict';
-
-const fs = require('fs');
-const path = require('path');
-
-function installHooks(ideDir, projectRoot) {
-  const settingsDir = path.join(projectRoot, ideDir);
-  const settingsPath = path.join(settingsDir, 'settings.json');
-  let settings = {};
-
-  if (fs.existsSync(settingsPath)) {
-    try {
-      settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
-    } catch (_) {
-      settings = {};
-    }
-  }
-
-  if (!settings.hooks) settings.hooks = {};
-  if (!settings.hooks.SessionStart) settings.hooks.SessionStart = [];
-
-  let changed = false;
-
-  const hasUpdateHook = settings.hooks.SessionStart.some((h) => h._sdd === true);
-  if (!hasUpdateHook) {
-    settings.hooks.SessionStart.push({
-      _sdd: true,
-      matcher: '',
-      hooks: [{ type: 'command', command: 'refacil-sdd-ai check-update' }],
-    });
-    changed = true;
-  }
-
-  // Claude Code usa "Stop"; Cursor usa "afterAgentResponse" (equivalente al fin de turno del agente)
-  const notifyEvent = ideDir === '.cursor' ? 'afterAgentResponse' : 'Stop';
-  if (!settings.hooks[notifyEvent]) settings.hooks[notifyEvent] = [];
-
-  const hasNotifyHook = settings.hooks[notifyEvent].some((h) => h._sdd_notify === true);
-  if (!hasNotifyHook) {
-    settings.hooks[notifyEvent].push({
-      _sdd_notify: true,
-      matcher: '',
-      hooks: [{ type: 'command', command: 'refacil-sdd-ai notify-update' }],
-    });
-    changed = true;
-  }
-
-  if (!settings.hooks.PreToolUse) settings.hooks.PreToolUse = [];
-
-  // compact-bash debe correr ANTES de check-review para que el rewrite sea visible
-  const hasCompactHook = settings.hooks.PreToolUse.some((h) => h._sdd_compact === true);
-  if (!hasCompactHook) {
-    settings.hooks.PreToolUse.unshift({
-      _sdd_compact: true,
-      matcher: 'Bash',
-      hooks: [{ type: 'command', command: 'refacil-sdd-ai compact-bash' }],
-    });
-    changed = true;
-  }
-
-  const hasReviewHook = settings.hooks.PreToolUse.some((h) => h._sdd_review === true);
-  if (!hasReviewHook) {
-    settings.hooks.PreToolUse.push({
-      _sdd_review: true,
-      matcher: 'Bash',
-      hooks: [{ type: 'command', command: 'refacil-sdd-ai check-review' }],
-    });
-    changed = true;
-  }
-
-  if (!changed) {
-    console.log(`  Hooks SDD-AI ya configurados en ${ideDir}/settings.json.`);
-    return false;
-  }
-
-  fs.mkdirSync(settingsDir, { recursive: true });
-  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
-  return true;
-}
-
-function uninstallHooks(ideDir, projectRoot) {
-  const settingsPath = path.join(projectRoot, ideDir, 'settings.json');
-  if (!fs.existsSync(settingsPath)) return false;
-
-  let settings;
-  try {
-    settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
-  } catch (_) {
-    console.log(`  No se pudieron remover hooks: ${ideDir}/settings.json invalido.`);
-    return false;
-  }
-
-  if (!settings.hooks) return false;
-
-  let changed = false;
-
-  if (Array.isArray(settings.hooks.SessionStart)) {
-    const original = settings.hooks.SessionStart.length;
-    settings.hooks.SessionStart = settings.hooks.SessionStart.filter((h) => h._sdd !== true);
-    if (settings.hooks.SessionStart.length !== original) changed = true;
-    if (settings.hooks.SessionStart.length === 0) delete settings.hooks.SessionStart;
-  }
-
-  for (const notifyEvent of ['Stop', 'afterAgentResponse']) {
-    if (Array.isArray(settings.hooks[notifyEvent])) {
-      const original = settings.hooks[notifyEvent].length;
-      settings.hooks[notifyEvent] = settings.hooks[notifyEvent].filter((h) => h._sdd_notify !== true);
-      if (settings.hooks[notifyEvent].length !== original) changed = true;
-      if (settings.hooks[notifyEvent].length === 0) delete settings.hooks[notifyEvent];
-    }
-  }
-
-  if (Array.isArray(settings.hooks.PreToolUse)) {
-    const original = settings.hooks.PreToolUse.length;
-    settings.hooks.PreToolUse = settings.hooks.PreToolUse.filter(
-      (h) => h._sdd_review !== true && h._sdd_compact !== true,
-    );
-    if (settings.hooks.PreToolUse.length !== original) changed = true;
-    if (settings.hooks.PreToolUse.length === 0) delete settings.hooks.PreToolUse;
-  }
-
-  if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
-
-  if (!changed) return false;
-
-  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
-  return true;
-}
-
-module.exports = { installHooks, uninstallHooks };
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+// ── Cursor: todos los hooks en .cursor/hooks.json ────────────────────────────
+
+function readCursorHooksJson(projectRoot) {
+  const p = path.join(projectRoot, '.cursor', 'hooks.json');
+  if (!fs.existsSync(p)) return { version: 1, hooks: {} };
+  try {
+    const c = JSON.parse(fs.readFileSync(p, 'utf8'));
+    if (!c.hooks) c.hooks = {};
+    return c;
+  } catch (_) {
+    return { version: 1, hooks: {} };
+  }
+}
+
+function writeCursorHooksJson(projectRoot, config) {
+  const dir = path.join(projectRoot, '.cursor');
+  fs.mkdirSync(dir, { recursive: true });
+  fs.writeFileSync(path.join(dir, 'hooks.json'), JSON.stringify(config, null, 2) + '\n');
+}
+
+function installCursorHooks(projectRoot) {
+  const config = readCursorHooksJson(projectRoot);
+  let changed = false;
+
+  function ensure(event, marker, entry) {
+    if (!config.hooks[event]) config.hooks[event] = [];
+    if (!config.hooks[event].some((h) => h[marker] === true)) {
+      config.hooks[event].push(entry);
+      changed = true;
+    }
+  }
+
+  ensure('sessionStart', '_sdd', {
+    _sdd: true,
+    command: 'refacil-sdd-ai check-update',
+  });
+
+  // compact-bash debe ir ANTES de check-review
+  if (!config.hooks.preToolUse) config.hooks.preToolUse = [];
+  if (!config.hooks.preToolUse.some((h) => h._sdd_compact === true)) {
+    config.hooks.preToolUse.unshift({ _sdd_compact: true, command: 'refacil-sdd-ai compact-bash', matcher: 'Bash' });
+    changed = true;
+  }
+  if (!config.hooks.preToolUse.some((h) => h._sdd_review === true)) {
+    config.hooks.preToolUse.push({ _sdd_review: true, command: 'refacil-sdd-ai check-review', matcher: 'Bash' });
+    changed = true;
+  }
+
+  ensure('beforeSubmitPrompt', '_sdd_notify', {
+    _sdd_notify: true,
+    command: 'refacil-sdd-ai notify-update',
+  });
+
+  if (!changed) {
+    console.log('  Hooks SDD-AI ya configurados en .cursor/hooks.json.');
+    return false;
+  }
+
+  writeCursorHooksJson(projectRoot, config);
+  return true;
+}
+
+function uninstallCursorHooks(projectRoot) {
+  const hooksJsonPath = path.join(projectRoot, '.cursor', 'hooks.json');
+  let changed = false;
+
+  if (fs.existsSync(hooksJsonPath)) {
+    let config;
+    try { config = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8')); } catch (_) { config = null; }
+
+    if (config && config.hooks) {
+      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+      for (const event of Object.keys(config.hooks)) {
+        if (!Array.isArray(config.hooks[event])) continue;
+        const before = config.hooks[event].length;
+        config.hooks[event] = config.hooks[event].filter(
+          (h) => !sddMarkers.some((m) => h[m] === true),
+        );
+        if (config.hooks[event].length !== before) changed = true;
+        if (config.hooks[event].length === 0) delete config.hooks[event];
+      }
+      if (changed) writeCursorHooksJson(projectRoot, config);
+    }
+  }
+
+  // Limpiar vestigios en settings.json de instalaciones previas
+  const settingsPath = path.join(projectRoot, '.cursor', 'settings.json');
+  if (fs.existsSync(settingsPath)) {
+    let settings;
+    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = null; }
+    if (settings && settings.hooks) {
+      const evts = ['SessionStart', 'PreToolUse', 'UserPromptSubmit', 'beforeSubmitPrompt', 'Stop', 'afterAgentResponse'];
+      const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+      for (const evt of evts) {
+        if (!Array.isArray(settings.hooks[evt])) continue;
+        const before = settings.hooks[evt].length;
+        settings.hooks[evt] = settings.hooks[evt].filter((h) => !sddMarkers.some((m) => h[m] === true));
+        if (settings.hooks[evt].length !== before) changed = true;
+        if (settings.hooks[evt].length === 0) delete settings.hooks[evt];
+      }
+      if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
+      if (changed) fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+    }
+  }
+
+  return changed;
+}
+
+// ── Claude Code: todos los hooks en .claude/settings.json ───────────────────
+
+function installClaudeHooks(projectRoot) {
+  const settingsDir = path.join(projectRoot, '.claude');
+  const settingsPath = path.join(settingsDir, 'settings.json');
+  let settings = {};
+
+  if (fs.existsSync(settingsPath)) {
+    try { settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8')); } catch (_) { settings = {}; }
+  }
+
+  if (!settings.hooks) settings.hooks = {};
+  let changed = false;
+
+  if (!settings.hooks.SessionStart) settings.hooks.SessionStart = [];
+  if (!settings.hooks.SessionStart.some((h) => h._sdd === true)) {
+    settings.hooks.SessionStart.push({ _sdd: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-update' }] });
+    changed = true;
+  }
+
+  if (!settings.hooks.UserPromptSubmit) settings.hooks.UserPromptSubmit = [];
+  if (!settings.hooks.UserPromptSubmit.some((h) => h._sdd_notify === true)) {
+    settings.hooks.UserPromptSubmit.push({ _sdd_notify: true, matcher: '', hooks: [{ type: 'command', command: 'refacil-sdd-ai notify-update' }] });
+    changed = true;
+  }
+
+  if (!settings.hooks.PreToolUse) settings.hooks.PreToolUse = [];
+  if (!settings.hooks.PreToolUse.some((h) => h._sdd_compact === true)) {
+    settings.hooks.PreToolUse.unshift({ _sdd_compact: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai compact-bash' }] });
+    changed = true;
+  }
+  if (!settings.hooks.PreToolUse.some((h) => h._sdd_review === true)) {
+    settings.hooks.PreToolUse.push({ _sdd_review: true, matcher: 'Bash', hooks: [{ type: 'command', command: 'refacil-sdd-ai check-review' }] });
+    changed = true;
+  }
+
+  if (!changed) {
+    console.log('  Hooks SDD-AI ya configurados en .claude/settings.json.');
+    return false;
+  }
+
+  fs.mkdirSync(settingsDir, { recursive: true });
+  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+  return true;
+}
+
+function uninstallClaudeHooks(projectRoot) {
+  const settingsPath = path.join(projectRoot, '.claude', 'settings.json');
+  if (!fs.existsSync(settingsPath)) return false;
+
+  let settings;
+  try {
+    settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
+  } catch (_) {
+    console.log('  No se pudieron remover hooks: .claude/settings.json invalido.');
+    return false;
+  }
+
+  if (!settings.hooks) return false;
+
+  let changed = false;
+  const sddMarkers = ['_sdd', '_sdd_compact', '_sdd_review', '_sdd_notify'];
+
+  for (const event of Object.keys(settings.hooks)) {
+    if (!Array.isArray(settings.hooks[event])) continue;
+    const before = settings.hooks[event].length;
+    settings.hooks[event] = settings.hooks[event].filter((h) => !sddMarkers.some((m) => h[m] === true));
+    if (settings.hooks[event].length !== before) changed = true;
+    if (settings.hooks[event].length === 0) delete settings.hooks[event];
+  }
+
+  if (Object.keys(settings.hooks).length === 0) delete settings.hooks;
+  if (!changed) return false;
+
+  fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+  return true;
+}
+
+// ── Fachada pública ──────────────────────────────────────────────────────────
+
+function installHooks(ideDir, projectRoot) {
+  return ideDir === '.cursor'
+    ? installCursorHooks(projectRoot)
+    : installClaudeHooks(projectRoot);
+}
+
+function uninstallHooks(ideDir, projectRoot) {
+  return ideDir === '.cursor'
+    ? uninstallCursorHooks(projectRoot)
+    : uninstallClaudeHooks(projectRoot);
+}
+
+module.exports = { installHooks, uninstallHooks };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "refacil-sdd-ai",
-  "version": "4.0.3",
+  "version": "4.0.5",
   "description": "SDD-AI: Specification-Driven Development with AI — metodologia de desarrollo con IA usando OpenSpec, Claude Code y Cursor",
   "bin": {
     "refacil-sdd-ai": "./bin/cli.js"

package/skills/update/SKILL.md

@@ -94,7 +94,15 @@ Conjunto requerido de commands: `.claude/commands/opsx/` → `apply.md`, `archiv
 4. Elimina skills y commands sobrantes.
 5. Ejecuta `openspec init --tools claude,cursor` para dejar el estado limpio.
 
-## Paso 4: Resumen
+## Paso 4: Limpiar flag de actualizacion pendiente
+
+Eliminar el archivo de flag si existe (puede estar en `.claude/` o `.cursor/`):
+
+```bash
+rm -f .claude/.refacil-pending-update .cursor/.refacil-pending-update
+```
+
+## Paso 5: Resumen
 
 Informar que archivos se crearon o modificaron. Mencionar que el bloque `compact-guidance` se sincronizara automaticamente en el proximo SessionStart.