redsys-easy 5.2.7 → 5.2.8

package/lib/errors.d.ts

@@ -23,14 +23,14 @@ export declare class ValidationError extends RedsysError {
  */
 export declare class ParseError extends RedsysError {
     value: unknown;
-    location: unknown | undefined;
+    location: unknown;
     description: string | undefined;
-    constructor(message: string, value?: unknown | undefined, location?: unknown | undefined);
+    constructor(message: string, value?: unknown, location?: unknown);
 }
 interface HTTPErrorOptions {
     message?: string | undefined;
     code: number;
-    response?: unknown | undefined;
+    response?: unknown;
 }
 /**
  * HTTP Error
@@ -39,13 +39,13 @@ interface HTTPErrorOptions {
  */
 export declare class HTTPError extends RedsysError {
     code: number | undefined;
-    response: unknown | undefined;
+    response: unknown;
     constructor({ message, code, response }: HTTPErrorOptions);
 }
 interface GatewayErrorOptions {
     message?: string | undefined;
     code: string;
-    response?: unknown | undefined;
+    response?: unknown;
 }
 /**
  * Request could not be processed by Redsys
@@ -54,13 +54,13 @@ interface GatewayErrorOptions {
  */
 export declare class GatewayError extends RedsysError {
     code: string | undefined;
-    response: unknown | undefined;
+    response: unknown;
     constructor({ message, code, response }: GatewayErrorOptions);
 }
 interface ResponseErrorOptions {
     message?: string | undefined;
     code: number;
-    response?: unknown | undefined;
+    response?: unknown;
 }
 /**
  * Response contained an error code
@@ -69,7 +69,7 @@ interface ResponseErrorOptions {
  */
 export declare class ResponseError extends RedsysError {
     code: number | undefined;
-    response: unknown | undefined;
+    response: unknown;
     constructor({ message, code, response }: ResponseErrorOptions);
 }
 export {};

package/lib/index.esm.js

@@ -1756,9 +1756,7 @@ const getSISErrorCodeMessage = (code) => {
     }
     return SIS_ERROR_CODES[code.trim()];
 };
-const getHTTPErrorCodeMessage = (code) => {
-    return STATUS_CODES[code];
-};
+const getHTTPErrorCodeMessage = (code) => STATUS_CODES[code];
 
 /**
  * Error superclass for all redsys-easy specific errors
@@ -1834,7 +1832,9 @@ class ParseError extends RedsysError {
 class HTTPError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getHTTPErrorCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1865,7 +1865,9 @@ class HTTPError extends RedsysError {
 class GatewayError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getSISErrorCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1896,7 +1898,9 @@ class GatewayError extends RedsysError {
 class ResponseError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getResponseCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1927,17 +1931,17 @@ const deserializeJSONMerchantParams = (strPayload) => {
     if (typeof strPayload !== 'string') {
         throw new ParseError('Payload must be a base-64 encoded string');
     }
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
     const payload = JSON.parse(Buffer.from(strPayload, 'base64').toString('utf8'));
     if (typeof payload !== 'object' || payload == null) {
         throw new ParseError('Cannot parse notification payload');
     }
     return payload;
 };
-const serializeJSONMerchantParams = (requestParams) => {
-    // Official redsys docs escape "/" because they use php json_encode. I think
-    // this is wrong and it also works without escaping.
-    return Buffer.from(JSON.stringify(requestParams), 'utf8').toString('base64');
-};
+const serializeJSONMerchantParams = (requestParams) => 
+// Official redsys docs escape "/" because they use php json_encode. I think
+// this is wrong and it also works without escaping.
+Buffer.from(JSON.stringify(requestParams), 'utf8').toString('base64');
 
 /**
  * Adds padding to a buffer.
@@ -1971,7 +1975,7 @@ const encrypt3DES = (key, message) => {
     ]);
     // Make sure that encrypted buffer is not longer than the padded message
     const maxLength = Math.ceil(messageBuf.length / 8) * 8;
-    return encryptedBuf.slice(0, maxLength);
+    return encryptedBuf.subarray(0, maxLength);
 };
 /**
  * Compute HMAC_SHA256_V1 signature
@@ -1991,9 +1995,7 @@ const sha256Sign = (merchantKey, order, params) => {
 /**
  * Discrete uniform distribution with domain (0 to *max*)
  */
-const drawPositiveDiscreteUniform = (max) => {
-    return randomInt(max + 1);
-};
+const drawPositiveDiscreteUniform = (max) => randomInt(max + 1);
 const alphanumeric = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
 /**
  * Generates a random order ID following redsys requirements
@@ -2014,7 +2016,6 @@ const randomTransactionId = () => {
     return `${numStr}${alphanumStr}`;
 };
 const extractAndAssertOrderFromRequestParams = (requestParams) => {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
     const order = requestParams['DS_MERCHANT_ORDER'] ||
         requestParams['Ds_Merchant_Order'];
     if (typeof order !== 'string' || !order) {
@@ -2023,7 +2024,6 @@ const extractAndAssertOrderFromRequestParams = (requestParams) => {
     return order;
 };
 const extractAndAssertOrderFromResponseParams = (responseParams) => {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
     const order = responseParams['Ds_Order'] ||
         responseParams['DS_ORDER'];
     if (typeof order !== 'string' || !order) {
@@ -2086,11 +2086,7 @@ const isStringNotEmpty = (str) => str != null && str.length > 0;
  *
  * If value is defined apply function and return output, otherwise return undefined.
  */
-const mapMaybeMonad = (value, fn) => {
-    return value !== undefined
-        ? fn(value)
-        : undefined;
-};
+const mapMaybeMonad = (value, fn) => (value !== undefined ? fn(value) : undefined);
 
 const sha256VerifyJSONResponse = (merchantKey, response, responseParams) => {
     if (response.Ds_SignatureVersion !== 'HMAC_SHA256_V1') {
@@ -2129,27 +2125,27 @@ const serializeAndSignJSONRequest = (merchantKey, requestParams) => {
 /**
  * Tries to decode x-www-form-urlencoded values of an object
  */
-const decodeUrlEntries = (params) => {
-    return Object.fromEntries(Object.entries(params).map((entry) => {
-        let processedValue = entry[1];
-        if (typeof entry[1] === 'string') {
-            try {
-                processedValue = decodeURIComponent(entry[1].replaceAll('+', ' '));
-            }
-            catch (_) { }
+const decodeUrlEntries = (params) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- type is unchanged
+Object.fromEntries(Object.entries(params).map((entry) => {
+    let processedValue = entry[1];
+    if (typeof entry[1] === 'string') {
+        try {
+            processedValue = decodeURIComponent(entry[1].replaceAll('+', ' '));
         }
-        return [entry[0], processedValue];
-    }));
-};
+        catch (_) { }
+    }
+    return [entry[0], processedValue];
+}));
 
 const serializeSoapNotificationResponse = ({ allow: allowOperation }) => {
     const answer = allowOperation ? 'OK' : 'KO';
     return `<Response Ds_Version="0.0"><Ds_Response_Merchant>${answer}</Ds_Response_Merchant></Response>`;
 };
 const xmlParser = new XMLParser({ parseTagValue: false });
-const deserializeSoapNotification = (xml) => {
-    return xmlParser.parse(xml).Message;
-};
+const deserializeSoapNotification = (xml) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume xml matches schema
+xmlParser.parse(xml).Message;
 
 const verifySoapNotification = (merchantKey, xml, msg) => {
     const startToken = '<Request';
@@ -2162,6 +2158,7 @@ const verifySoapNotification = (merchantKey, xml, msg) => {
     const signedStr = xml.slice(startPos, endPos + endToken.length);
     const signature = msg.Signature;
     const order = msg.Request.Ds_Order;
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness check
     if (order == null || !order) {
         throw new ParseError('Invalid notification response');
     }
@@ -2195,6 +2192,7 @@ const jsonRequest = async ({ fetch, url, merchantKey, rawRequestParams }) => {
         },
         body: JSON.stringify(payload)
     });
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume correct format
     const responseData = await response.json();
     if (!response.ok) {
         throw new HTTPError({
@@ -2246,6 +2244,7 @@ const createRedsysAPI = (config) => {
         throw new RedsysError('A secretKey key must be provided');
     }
     if (typeof config.urls !== 'object' ||
+        // eslint-disable-next-line @typescript-eslint/prefer-optional-chain, @typescript-eslint/no-unnecessary-condition -- robustness
         config.urls == null ||
         !config.urls.restIniciaPeticion ||
         !config.urls.restTrataPeticion ||
@@ -2255,14 +2254,12 @@ const createRedsysAPI = (config) => {
     /**
      * Sends a iniciaPeticion request using REST interface
      */
-    const restIniciaPeticion = async (paramsInput) => {
-        return await jsonRequest({
-            fetch: fetch$1,
-            url: config.urls.restIniciaPeticion,
-            merchantKey: config.secretKey,
-            rawRequestParams: paramsInput
-        });
-    };
+    const restIniciaPeticion = async (paramsInput) => await jsonRequest({
+        fetch: fetch$1,
+        url: config.urls.restIniciaPeticion,
+        merchantKey: config.secretKey,
+        rawRequestParams: paramsInput
+    });
     /**
      * Sends a trataPeticion request using REST interface
      */
@@ -2300,10 +2297,9 @@ const createRedsysAPI = (config) => {
      */
     const processDirectRestNotification = (
     /** Body of JSON notification, as a POJO (Plain Old Javascript Object) */
-    body) => {
-        // A notification can't contain a gateway error, it didn't initiate the request
-        return deserializeAndVerifyJSONResponse(config.secretKey, body);
-    };
+    body) => 
+    // A notification can't contain a gateway error, it didn't initiate the request
+    deserializeAndVerifyJSONResponse(config.secretKey, body);
     /**
      * Processes either a URLOK/URLKO query or a JSON REST notification
      *
@@ -2329,9 +2325,7 @@ const createRedsysAPI = (config) => {
      */
     const processSoapNotification = (
     /** SOAP notification as a XML string */
-    xml) => {
-        return deserializeAndVerifySoapNotification(config.secretKey, xml);
-    };
+    xml) => deserializeAndVerifySoapNotification(config.secretKey, xml);
     /**
      * Creates an answer for a SOAP notification, serializes and signs it
      */
@@ -2339,12 +2333,10 @@ const createRedsysAPI = (config) => {
     /** Order identifier */
     order, 
     /** Indicates if the payment is allowed to proceed */
-    allow) => {
-        return serializeAndSignSoapNotificationResponse(config.secretKey, {
-            order,
-            allow
-        });
-    };
+    allow) => serializeAndSignSoapNotificationResponse(config.secretKey, {
+        order,
+        allow
+    });
     return {
         restIniciaPeticion,
         restTrataPeticion,
@@ -2382,45 +2374,41 @@ const create3DSMethodForm = (emv3dsParams, notificationURL) => {
  *
  * @public
  */
-const create3DSv1ChallengeForm = (emv3dsV1Challenge, challengeNotificationUrl) => {
-    return {
-        url: emv3dsV1Challenge.acsURL,
-        body: {
-            PaReq: emv3dsV1Challenge.PAReq,
-            MD: emv3dsV1Challenge.MD,
-            TermUrl: challengeNotificationUrl
-        }
-    };
-};
+const create3DSv1ChallengeForm = (emv3dsV1Challenge, challengeNotificationUrl) => ({
+    url: emv3dsV1Challenge.acsURL,
+    body: {
+        PaReq: emv3dsV1Challenge.PAReq,
+        MD: emv3dsV1Challenge.MD,
+        TermUrl: challengeNotificationUrl
+    }
+});
 /**
  * Creates parameters for a 3DS v2 challenge form
  *
  * @public
  */
-const create3DSv2ChallengeForm = (emv3dsV2Challenge) => {
-    return {
-        url: emv3dsV2Challenge.acsURL,
-        body: {
-            creq: emv3dsV2Challenge.creq
-        }
-    };
-};
+const create3DSv2ChallengeForm = (emv3dsV2Challenge) => ({
+    url: emv3dsV2Challenge.acsURL,
+    body: {
+        creq: emv3dsV2Challenge.creq
+    }
+});
 /**
  * Deserialize threeDSMethodData
  *
  * @public
  */
-const deserializeThreeDSMethodData = (threeDSMethodData) => {
-    return JSON.parse(base64url.decode(threeDSMethodData));
-};
+const deserializeThreeDSMethodData = (threeDSMethodData) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
+JSON.parse(base64url.decode(threeDSMethodData));
 /**
  * Deserialize `cres` field of a 3DS v2 challenge
  *
  * @public
  */
-const deserializeCres = (cres) => {
-    return JSON.parse(Buffer.from(cres, 'base64').toString('utf8'));
-};
+const deserializeCres = (cres) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
+JSON.parse(Buffer.from(cres, 'base64').toString('utf8'));
 
 const unescapeXML = (str) => {
     const xml = str.replace(/&(lt|#60|gt|#62|quot|#34|amp|#38|apos|#39);/g, (_match, p1) => {
@@ -2761,10 +2749,11 @@ const CURRENCIES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_CURRENCIES = {};
 for (const [key, value] of Object.entries(CURRENCIES)) {
     REV_CURRENCIES[value.num] = {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
         code: key,
         decimals: value.decimals
     };
@@ -2820,8 +2809,9 @@ const LANGUAGES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_LANGUAGES = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(LANGUAGES)) {
     REV_LANGUAGES[value] = key;
 }
@@ -3095,8 +3085,9 @@ const COUNTRIES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_COUNTRIES = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(COUNTRIES)) {
     REV_COUNTRIES[value] = key;
 }
@@ -3124,8 +3115,9 @@ const CARDBRANDS = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_CARDBRANDS = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(CARDBRANDS)) {
     REV_CARDBRANDS[value] = key;
 }
@@ -3191,29 +3183,23 @@ const TRANSACTION_TYPES = {
  *
  * @public
  */
-const useSingleInputFormatter = (fn, inputFormatter) => {
-    return (input, ...otherArgs) => fn(inputFormatter(input), ...otherArgs);
-};
+const useSingleInputFormatter = (fn, inputFormatter) => (input, ...otherArgs) => fn(inputFormatter(input), ...otherArgs);
 /**
  * Applies an output formatter to a function
  *
  * @public
  */
-const useOutputFormatter = (fn, outputFormatter) => {
-    return (a) => outputFormatter(fn(a));
-};
+const useOutputFormatter = (fn, outputFormatter) => (a) => outputFormatter(fn(a));
 /**
  * Applies an output formatter to the resolved ouput promise of a function
  *
  * @public
  */
-const usePromiseOutputFormatter = (fn, outputFormatter) => {
-    return async (a) => outputFormatter(await fn(a));
-};
+const usePromiseOutputFormatter = (fn, outputFormatter) => async (a) => outputFormatter(await fn(a));
 
+/* eslint-disable @typescript-eslint/no-unnecessary-condition -- robustness handling inputs */
 const formatInputCurrency = (input) => {
     const currencyData = CURRENCIES[input];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
     if (!(currencyData === null || currencyData === void 0 ? void 0 : currencyData.num)) {
         throw new ValidationError('Unsupported currency', { currency: input });
     }
@@ -3237,8 +3223,7 @@ const formatAmount = (value, context) => {
         throw new ValidationError('Missing currency', { currency });
     }
     const currencyData = CURRENCIES[currency];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
-    if (!(currencyData === null || currencyData === void 0 ? void 0 : currencyData.decimals)) {
+    if (!Number.isFinite(currencyData === null || currencyData === void 0 ? void 0 : currencyData.decimals)) {
         throw new ValidationError('Unsupported currency', { currency });
     }
     const rawValue = typeof value === 'number'
@@ -3396,10 +3381,12 @@ const restTrataPeticionInputFormatter = (raw) => {
 dayjs.extend(timezone);
 dayjs.extend(utc);
 const formatCountry = (rawCountry) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const countryInt = Number.parseInt(rawCountry).toString();
     return REV_COUNTRIES[countryInt];
 };
 const formatCardBrand = (rawCardBrand) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const cardBrandInt = Number.parseInt(rawCardBrand).toString();
     return REV_CARDBRANDS[cardBrandInt];
 };
@@ -3431,9 +3418,10 @@ const baseOutputFormatter = (raw) => {
 };
 const formatPrice = (params) => {
     const { Ds_Amount: rawAmount, Ds_Currency: rawCurrency } = params;
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const currencyInt = Number.parseInt(rawCurrency).toString();
     const currencyInfo = REV_CURRENCIES[currencyInt];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
+    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/no-unnecessary-condition -- proper object
     if (!currencyInfo) {
         throw new ParseError('Unknown currency', rawCurrency);
     }
@@ -3447,6 +3435,7 @@ const formatPrice = (params) => {
     };
 };
 const formatLang = (rawLang) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const langInt = Number.parseInt(rawLang).toString();
     return REV_LANGUAGES[langInt];
 };
@@ -3496,7 +3485,9 @@ const soapNotificationOutputFormatter = (raw) => {
     };
 };
 const requestOutputFormatter = (raw) => {
-    const { Ds_CardNumber: deprecatedCardNumber, Ds_Card_Number: newCardNumber, Ds_Merchant_Identifier: identifier, Ds_ExpiryDate: rawExpiryDate, Ds_UrlPago2Fases: payURL, Ds_Language: rawLang } = raw;
+    const { 
+    // eslint-disable-next-line @typescript-eslint/no-deprecated -- robust to old format
+    Ds_CardNumber: deprecatedCardNumber, Ds_Card_Number: newCardNumber, Ds_Merchant_Identifier: identifier, Ds_ExpiryDate: rawExpiryDate, Ds_UrlPago2Fases: payURL, Ds_Language: rawLang } = raw;
     const cardNumber = newCardNumber !== null && newCardNumber !== void 0 ? newCardNumber : deprecatedCardNumber;
     return {
         ...baseOutputFormatter(raw),

package/lib/index.js

@@ -1758,9 +1758,7 @@ const getSISErrorCodeMessage = (code) => {
     }
     return SIS_ERROR_CODES[code.trim()];
 };
-const getHTTPErrorCodeMessage = (code) => {
-    return http.STATUS_CODES[code];
-};
+const getHTTPErrorCodeMessage = (code) => http.STATUS_CODES[code];
 
 /**
  * Error superclass for all redsys-easy specific errors
@@ -1836,7 +1834,9 @@ class ParseError extends RedsysError {
 class HTTPError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getHTTPErrorCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1867,7 +1867,9 @@ class HTTPError extends RedsysError {
 class GatewayError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getSISErrorCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1898,7 +1900,9 @@ class GatewayError extends RedsysError {
 class ResponseError extends RedsysError {
     constructor({ message, code, response }) {
         const codeDescription = getResponseCodeMessage(code);
-        const codeInfo = code !== undefined
+        const codeInfo = 
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness
+        code !== undefined
             ? ` ${code}${codeDescription != null ? `: ${codeDescription}` : ''}`
             : '';
         const augmentationLine = message != null && message ? `\n${message}` : '';
@@ -1929,17 +1933,17 @@ const deserializeJSONMerchantParams = (strPayload) => {
     if (typeof strPayload !== 'string') {
         throw new ParseError('Payload must be a base-64 encoded string');
     }
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
     const payload = JSON.parse(Buffer.from(strPayload, 'base64').toString('utf8'));
     if (typeof payload !== 'object' || payload == null) {
         throw new ParseError('Cannot parse notification payload');
     }
     return payload;
 };
-const serializeJSONMerchantParams = (requestParams) => {
-    // Official redsys docs escape "/" because they use php json_encode. I think
-    // this is wrong and it also works without escaping.
-    return Buffer.from(JSON.stringify(requestParams), 'utf8').toString('base64');
-};
+const serializeJSONMerchantParams = (requestParams) => 
+// Official redsys docs escape "/" because they use php json_encode. I think
+// this is wrong and it also works without escaping.
+Buffer.from(JSON.stringify(requestParams), 'utf8').toString('base64');
 
 /**
  * Adds padding to a buffer.
@@ -1973,7 +1977,7 @@ const encrypt3DES = (key, message) => {
     ]);
     // Make sure that encrypted buffer is not longer than the padded message
     const maxLength = Math.ceil(messageBuf.length / 8) * 8;
-    return encryptedBuf.slice(0, maxLength);
+    return encryptedBuf.subarray(0, maxLength);
 };
 /**
  * Compute HMAC_SHA256_V1 signature
@@ -1993,9 +1997,7 @@ const sha256Sign = (merchantKey, order, params) => {
 /**
  * Discrete uniform distribution with domain (0 to *max*)
  */
-const drawPositiveDiscreteUniform = (max) => {
-    return node_crypto.randomInt(max + 1);
-};
+const drawPositiveDiscreteUniform = (max) => node_crypto.randomInt(max + 1);
 const alphanumeric = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
 /**
  * Generates a random order ID following redsys requirements
@@ -2016,7 +2018,6 @@ const randomTransactionId = () => {
     return `${numStr}${alphanumStr}`;
 };
 const extractAndAssertOrderFromRequestParams = (requestParams) => {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
     const order = requestParams['DS_MERCHANT_ORDER'] ||
         requestParams['Ds_Merchant_Order'];
     if (typeof order !== 'string' || !order) {
@@ -2025,7 +2026,6 @@ const extractAndAssertOrderFromRequestParams = (requestParams) => {
     return order;
 };
 const extractAndAssertOrderFromResponseParams = (responseParams) => {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
     const order = responseParams['Ds_Order'] ||
         responseParams['DS_ORDER'];
     if (typeof order !== 'string' || !order) {
@@ -2088,11 +2088,7 @@ const isStringNotEmpty = (str) => str != null && str.length > 0;
  *
  * If value is defined apply function and return output, otherwise return undefined.
  */
-const mapMaybeMonad = (value, fn) => {
-    return value !== undefined
-        ? fn(value)
-        : undefined;
-};
+const mapMaybeMonad = (value, fn) => (value !== undefined ? fn(value) : undefined);
 
 const sha256VerifyJSONResponse = (merchantKey, response, responseParams) => {
     if (response.Ds_SignatureVersion !== 'HMAC_SHA256_V1') {
@@ -2131,27 +2127,27 @@ const serializeAndSignJSONRequest = (merchantKey, requestParams) => {
 /**
  * Tries to decode x-www-form-urlencoded values of an object
  */
-const decodeUrlEntries = (params) => {
-    return Object.fromEntries(Object.entries(params).map((entry) => {
-        let processedValue = entry[1];
-        if (typeof entry[1] === 'string') {
-            try {
-                processedValue = decodeURIComponent(entry[1].replaceAll('+', ' '));
-            }
-            catch (_) { }
+const decodeUrlEntries = (params) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- type is unchanged
+Object.fromEntries(Object.entries(params).map((entry) => {
+    let processedValue = entry[1];
+    if (typeof entry[1] === 'string') {
+        try {
+            processedValue = decodeURIComponent(entry[1].replaceAll('+', ' '));
         }
-        return [entry[0], processedValue];
-    }));
-};
+        catch (_) { }
+    }
+    return [entry[0], processedValue];
+}));
 
 const serializeSoapNotificationResponse = ({ allow: allowOperation }) => {
     const answer = allowOperation ? 'OK' : 'KO';
     return `<Response Ds_Version="0.0"><Ds_Response_Merchant>${answer}</Ds_Response_Merchant></Response>`;
 };
 const xmlParser = new fastXmlParser.XMLParser({ parseTagValue: false });
-const deserializeSoapNotification = (xml) => {
-    return xmlParser.parse(xml).Message;
-};
+const deserializeSoapNotification = (xml) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume xml matches schema
+xmlParser.parse(xml).Message;
 
 const verifySoapNotification = (merchantKey, xml, msg) => {
     const startToken = '<Request';
@@ -2164,6 +2160,7 @@ const verifySoapNotification = (merchantKey, xml, msg) => {
     const signedStr = xml.slice(startPos, endPos + endToken.length);
     const signature = msg.Signature;
     const order = msg.Request.Ds_Order;
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- robustness check
     if (order == null || !order) {
         throw new ParseError('Invalid notification response');
     }
@@ -2197,6 +2194,7 @@ const jsonRequest = async ({ fetch, url, merchantKey, rawRequestParams }) => {
         },
         body: JSON.stringify(payload)
     });
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume correct format
     const responseData = await response.json();
     if (!response.ok) {
         throw new HTTPError({
@@ -2248,6 +2246,7 @@ const createRedsysAPI = (config) => {
         throw new RedsysError('A secretKey key must be provided');
     }
     if (typeof config.urls !== 'object' ||
+        // eslint-disable-next-line @typescript-eslint/prefer-optional-chain, @typescript-eslint/no-unnecessary-condition -- robustness
         config.urls == null ||
         !config.urls.restIniciaPeticion ||
         !config.urls.restTrataPeticion ||
@@ -2257,14 +2256,12 @@ const createRedsysAPI = (config) => {
     /**
      * Sends a iniciaPeticion request using REST interface
      */
-    const restIniciaPeticion = async (paramsInput) => {
-        return await jsonRequest({
-            fetch,
-            url: config.urls.restIniciaPeticion,
-            merchantKey: config.secretKey,
-            rawRequestParams: paramsInput
-        });
-    };
+    const restIniciaPeticion = async (paramsInput) => await jsonRequest({
+        fetch,
+        url: config.urls.restIniciaPeticion,
+        merchantKey: config.secretKey,
+        rawRequestParams: paramsInput
+    });
     /**
      * Sends a trataPeticion request using REST interface
      */
@@ -2302,10 +2299,9 @@ const createRedsysAPI = (config) => {
      */
     const processDirectRestNotification = (
     /** Body of JSON notification, as a POJO (Plain Old Javascript Object) */
-    body) => {
-        // A notification can't contain a gateway error, it didn't initiate the request
-        return deserializeAndVerifyJSONResponse(config.secretKey, body);
-    };
+    body) => 
+    // A notification can't contain a gateway error, it didn't initiate the request
+    deserializeAndVerifyJSONResponse(config.secretKey, body);
     /**
      * Processes either a URLOK/URLKO query or a JSON REST notification
      *
@@ -2331,9 +2327,7 @@ const createRedsysAPI = (config) => {
      */
     const processSoapNotification = (
     /** SOAP notification as a XML string */
-    xml) => {
-        return deserializeAndVerifySoapNotification(config.secretKey, xml);
-    };
+    xml) => deserializeAndVerifySoapNotification(config.secretKey, xml);
     /**
      * Creates an answer for a SOAP notification, serializes and signs it
      */
@@ -2341,12 +2335,10 @@ const createRedsysAPI = (config) => {
     /** Order identifier */
     order, 
     /** Indicates if the payment is allowed to proceed */
-    allow) => {
-        return serializeAndSignSoapNotificationResponse(config.secretKey, {
-            order,
-            allow
-        });
-    };
+    allow) => serializeAndSignSoapNotificationResponse(config.secretKey, {
+        order,
+        allow
+    });
     return {
         restIniciaPeticion,
         restTrataPeticion,
@@ -2384,45 +2376,41 @@ const create3DSMethodForm = (emv3dsParams, notificationURL) => {
  *
  * @public
  */
-const create3DSv1ChallengeForm = (emv3dsV1Challenge, challengeNotificationUrl) => {
-    return {
-        url: emv3dsV1Challenge.acsURL,
-        body: {
-            PaReq: emv3dsV1Challenge.PAReq,
-            MD: emv3dsV1Challenge.MD,
-            TermUrl: challengeNotificationUrl
-        }
-    };
-};
+const create3DSv1ChallengeForm = (emv3dsV1Challenge, challengeNotificationUrl) => ({
+    url: emv3dsV1Challenge.acsURL,
+    body: {
+        PaReq: emv3dsV1Challenge.PAReq,
+        MD: emv3dsV1Challenge.MD,
+        TermUrl: challengeNotificationUrl
+    }
+});
 /**
  * Creates parameters for a 3DS v2 challenge form
  *
  * @public
  */
-const create3DSv2ChallengeForm = (emv3dsV2Challenge) => {
-    return {
-        url: emv3dsV2Challenge.acsURL,
-        body: {
-            creq: emv3dsV2Challenge.creq
-        }
-    };
-};
+const create3DSv2ChallengeForm = (emv3dsV2Challenge) => ({
+    url: emv3dsV2Challenge.acsURL,
+    body: {
+        creq: emv3dsV2Challenge.creq
+    }
+});
 /**
  * Deserialize threeDSMethodData
  *
  * @public
  */
-const deserializeThreeDSMethodData = (threeDSMethodData) => {
-    return JSON.parse(base64url.decode(threeDSMethodData));
-};
+const deserializeThreeDSMethodData = (threeDSMethodData) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
+JSON.parse(base64url.decode(threeDSMethodData));
 /**
  * Deserialize `cres` field of a 3DS v2 challenge
  *
  * @public
  */
-const deserializeCres = (cres) => {
-    return JSON.parse(Buffer.from(cres, 'base64').toString('utf8'));
-};
+const deserializeCres = (cres) => 
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- assume it satisfies format
+JSON.parse(Buffer.from(cres, 'base64').toString('utf8'));
 
 const unescapeXML = (str) => {
     const xml = str.replace(/&(lt|#60|gt|#62|quot|#34|amp|#38|apos|#39);/g, (_match, p1) => {
@@ -2763,10 +2751,11 @@ const CURRENCIES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_CURRENCIES = {};
 for (const [key, value] of Object.entries(CURRENCIES)) {
     REV_CURRENCIES[value.num] = {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
         code: key,
         decimals: value.decimals
     };
@@ -2822,8 +2811,9 @@ const LANGUAGES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_LANGUAGES = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(LANGUAGES)) {
     REV_LANGUAGES[value] = key;
 }
@@ -3097,8 +3087,9 @@ const COUNTRIES = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_COUNTRIES = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(COUNTRIES)) {
     REV_COUNTRIES[value] = key;
 }
@@ -3126,8 +3117,9 @@ const CARDBRANDS = {
  *
  * @public
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+// eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 const REV_CARDBRANDS = {};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- known deterministically
 for (const [key, value] of Object.entries(CARDBRANDS)) {
     REV_CARDBRANDS[value] = key;
 }
@@ -3193,29 +3185,23 @@ const TRANSACTION_TYPES = {
  *
  * @public
  */
-const useSingleInputFormatter = (fn, inputFormatter) => {
-    return (input, ...otherArgs) => fn(inputFormatter(input), ...otherArgs);
-};
+const useSingleInputFormatter = (fn, inputFormatter) => (input, ...otherArgs) => fn(inputFormatter(input), ...otherArgs);
 /**
  * Applies an output formatter to a function
  *
  * @public
  */
-const useOutputFormatter = (fn, outputFormatter) => {
-    return (a) => outputFormatter(fn(a));
-};
+const useOutputFormatter = (fn, outputFormatter) => (a) => outputFormatter(fn(a));
 /**
  * Applies an output formatter to the resolved ouput promise of a function
  *
  * @public
  */
-const usePromiseOutputFormatter = (fn, outputFormatter) => {
-    return async (a) => outputFormatter(await fn(a));
-};
+const usePromiseOutputFormatter = (fn, outputFormatter) => async (a) => outputFormatter(await fn(a));
 
+/* eslint-disable @typescript-eslint/no-unnecessary-condition -- robustness handling inputs */
 const formatInputCurrency = (input) => {
     const currencyData = CURRENCIES[input];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
     if (!(currencyData === null || currencyData === void 0 ? void 0 : currencyData.num)) {
         throw new ValidationError('Unsupported currency', { currency: input });
     }
@@ -3239,8 +3225,7 @@ const formatAmount = (value, context) => {
         throw new ValidationError('Missing currency', { currency });
     }
     const currencyData = CURRENCIES[currency];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
-    if (!(currencyData === null || currencyData === void 0 ? void 0 : currencyData.decimals)) {
+    if (!Number.isFinite(currencyData === null || currencyData === void 0 ? void 0 : currencyData.decimals)) {
         throw new ValidationError('Unsupported currency', { currency });
     }
     const rawValue = typeof value === 'number'
@@ -3398,10 +3383,12 @@ const restTrataPeticionInputFormatter = (raw) => {
 dayjs.extend(timezone);
 dayjs.extend(utc);
 const formatCountry = (rawCountry) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const countryInt = Number.parseInt(rawCountry).toString();
     return REV_COUNTRIES[countryInt];
 };
 const formatCardBrand = (rawCardBrand) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const cardBrandInt = Number.parseInt(rawCardBrand).toString();
     return REV_CARDBRANDS[cardBrandInt];
 };
@@ -3433,9 +3420,10 @@ const baseOutputFormatter = (raw) => {
 };
 const formatPrice = (params) => {
     const { Ds_Amount: rawAmount, Ds_Currency: rawCurrency } = params;
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const currencyInt = Number.parseInt(rawCurrency).toString();
     const currencyInfo = REV_CURRENCIES[currencyInt];
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
+    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/no-unnecessary-condition -- proper object
     if (!currencyInfo) {
         throw new ParseError('Unknown currency', rawCurrency);
     }
@@ -3449,6 +3437,7 @@ const formatPrice = (params) => {
     };
 };
 const formatLang = (rawLang) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- dealth within scope
     const langInt = Number.parseInt(rawLang).toString();
     return REV_LANGUAGES[langInt];
 };
@@ -3498,7 +3487,9 @@ const soapNotificationOutputFormatter = (raw) => {
     };
 };
 const requestOutputFormatter = (raw) => {
-    const { Ds_CardNumber: deprecatedCardNumber, Ds_Card_Number: newCardNumber, Ds_Merchant_Identifier: identifier, Ds_ExpiryDate: rawExpiryDate, Ds_UrlPago2Fases: payURL, Ds_Language: rawLang } = raw;
+    const { 
+    // eslint-disable-next-line @typescript-eslint/no-deprecated -- robust to old format
+    Ds_CardNumber: deprecatedCardNumber, Ds_Card_Number: newCardNumber, Ds_Merchant_Identifier: identifier, Ds_ExpiryDate: rawExpiryDate, Ds_UrlPago2Fases: payURL, Ds_Language: rawLang } = raw;
     const cardNumber = newCardNumber !== null && newCardNumber !== void 0 ? newCardNumber : deprecatedCardNumber;
     return {
         ...baseOutputFormatter(raw),

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "redsys-easy",
   "description": "Node JS interface for Redsys payment gateway",
-  "version": "5.2.7",
+  "version": "5.2.8",
   "author": "Javier Garcia <javiertury@gmail.com>",
   "license": "MIT",
   "keywords": [
@@ -59,22 +59,15 @@
     "@types/koa": "^2.13.8",
     "@types/koa-bodyparser": "^4.3.10",
     "@types/koa__router": "^12.0.0",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
     "cheerio": "1.0.0-rc.12",
     "commit-and-tag-version": "^12.5.0",
-    "eslint": "^8.46.0",
-    "eslint-config-prettier": "^8.10.0",
-    "eslint-config-standard-with-typescript": "^37.0.0",
-    "eslint-plugin-html": "^7.1.0",
-    "eslint-plugin-import": "^2.28.0",
-    "eslint-plugin-jest": "^27.2.3",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^6.1.1",
+    "eslint": "^9.17.0",
+    "eslint-config-love": "^114.0.0",
+    "eslint-plugin-jest": "^28.10.0",
     "jest": "^29.6.2",
     "koa": "^2.14.2",
     "koa-bodyparser": "^4.4.1",
-    "lint-staged": "^13.2.3",
+    "lint-staged": "^15.3.0",
     "markdown-magic": "^2.6.1",
     "rimraf": "^5.0.1",
     "rollup": "^3.29.5",
@@ -105,7 +98,7 @@
     }
   },
   "scripts": {
-    "lint": "eslint --ext js,ts .",
+    "lint": "eslint .",
     "build:clean": "rimraf lib",
     "build:code": "rollup -c rollup.config.mjs",
     "build:api": "api-extractor run --local",