redis 2.6.4 → 2.6.5

package/changelog.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## v.2.6.5 - 15 Jan, 2017
+
+Bugfixes
+
+-  Fixed parser not being reset in case the redis connection closed ASAP for overcoming of output buffer limits
+-  Fixed parser reset if (p)message_buffer listener is attached
+
 ## v.2.6.4 - 12 Jan, 2017
 
 Bugfixes

package/index.js

@@ -156,8 +156,6 @@ function RedisClient (options, stream) {
     this.buffers = options.return_buffers || options.detect_buffers;
     this.options = options;
     this.reply = 'ON'; // Returning replies is the default
-    // Init parser
-    this.reply_parser = create_parser(this);
     this.create_stream();
     // The listeners will not be attached right away, so let's print the deprecation message while the listener is attached
     this.on('newListener', function (event) {
@@ -171,10 +169,16 @@ function RedisClient (options, stream) {
                 'The drain event listener is deprecated and will be removed in v.3.0.0.\n' +
                 'If you want to keep on listening to this event please listen to the stream drain event directly.'
             );
-        } else if (event === 'message_buffer' || event === 'pmessage_buffer' || event === 'messageBuffer' || event === 'pmessageBuffer' && !this.buffers) {
+        } else if ((event === 'message_buffer' || event === 'pmessage_buffer' || event === 'messageBuffer' || event === 'pmessageBuffer') && !this.buffers && !this.message_buffers) {
+            if (this.reply_parser.name !== 'javascript') {
+                return this.warn(
+                    'You attached the ' + event + ' without the hiredis parser without the returnBuffers option set to true.\n' +
+                    'Please use the JavaScript parser or set the returnBuffers option to true to return buffers.'
+                );
+            }
+            this.reply_parser.optionReturnBuffers = true;
             this.message_buffers = true;
             this.handle_reply = handle_detect_buffers_reply;
-            this.reply_parser = create_parser(this);
         }
     });
 }
@@ -224,6 +228,9 @@ function create_parser (self) {
 RedisClient.prototype.create_stream = function () {
     var self = this;
 
+    // Init parser
+    this.reply_parser = create_parser(this);
+
     if (this.options.stream) {
         // Only add the listeners once in case of a reconnect try (that won't work)
         if (this.stream) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "redis",
-  "version": "2.6.4",
+  "version": "2.6.5",
   "description": "Redis client library",
   "keywords": [
     "database",