redhotmagma-visualization 1.44.1 → 1.44.2

package/Three/Three3DScene.js

@@ -13,7 +13,6 @@ var _RGBELoader = require("three/examples/jsm/loaders/RGBELoader");
 var _get = _interopRequireDefault(require("lodash/get"));
 var _size = _interopRequireDefault(require("lodash/size"));
 var _isPlainObject = _interopRequireDefault(require("lodash/isPlainObject"));
-var _isEqual = _interopRequireDefault(require("lodash/isEqual"));
 var _glTFExporter = require("./Exporters/glTFExporter");
 var _findIndex = _interopRequireDefault(require("lodash/findIndex"));
 var _merge = _interopRequireDefault(require("lodash/merge"));
@@ -1189,6 +1188,17 @@ var Three3DScene = exports.Three3DScene = /*#__PURE__*/function (_Three3D) {
       }
       this.screenshotViews = this.calculateRelativeViews(this.relativeScreenshotViews, center, (this.controls.minDistance + this.controls.maxDistance) * 0.5);
     }
+  }, {
+    key: "getCameraViewRatio",
+    value: function getCameraViewRatio(view1, view2) {
+      return view2.lookat.distanceTo(view2.position) / view1.lookat.distanceTo(view1.position);
+    }
+  }, {
+    key: "shouldViewChangeTriggerJumpToView",
+    value: function shouldViewChangeTriggerJumpToView(view1, view2) {
+      var tolerance = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : 0.5;
+      return Math.abs(this.getCameraViewRatio(view1, view2) - 1) > tolerance;
+    }
   }, {
     key: "initCameraViews",
     value: function initCameraViews(cameras) {
@@ -1209,7 +1219,7 @@ var Three3DScene = exports.Three3DScene = /*#__PURE__*/function (_Three3D) {
         this._firstCameraInitDone = true;
         this.currentCameraView = null;
         this.jumpToView("default", false);
-      } else if (previousCameraView && this.cameraViews[currentCameraName] && !(0, _isEqual["default"])(previousCameraView, this.cameraViews[currentCameraName])) {
+      } else if (previousCameraView && this.cameraViews[currentCameraName] && this.shouldViewChangeTriggerJumpToView(previousCameraView, this.cameraViews[currentCameraName])) {
         this.currentCameraView = null;
         this.jumpToView(currentCameraName, true);
       }
@@ -1354,9 +1364,13 @@ var Three3DScene = exports.Three3DScene = /*#__PURE__*/function (_Three3D) {
       controls.maxDistance = maxDistance;
       camera.near = minDistance * 0.01;
       camera.far = maxDistance * 100;
-      camera.position.copy(camera.position.normalize().multiplyScalar(maxDistance * 0.75));
+      // update current position only if it does not fit into the distance range
+      var currentDistance = sphere.center.distanceTo(camera.position);
+      if (currentDistance < minDistance || currentDistance > maxDistance) {
+        camera.position.copy(camera.position.normalize().multiplyScalar(maxDistance * 0.75));
+        controls.target = sphere.center;
+      }
       camera.updateProjectionMatrix();
-      controls.target = sphere.center;
       controls.update();
     }
   }, {

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "redhotmagma-visualization",
-  "version": "1.44.1",
+  "version": "1.44.2",
   "license": "UNLICENSED",
   "private": false,
   "main": "./index.js",
   "dependencies": {
     "@babel/polyfill": "^7.12.1",
-    "@configuratorware/scripts": "1.44.1",
+    "@configuratorware/scripts": "1.44.2",
     "@tweenjs/tween.js": "^17.6.0",
     "console-polyfill": "^0.3.0",
     "css-element-queries": "^1.2.3",

package/src/Three/Three3DScene.js

@@ -35,7 +35,6 @@ import { RGBELoader } from "three/examples/jsm/loaders/RGBELoader";
 import get from "lodash/get";
 import size from "lodash/size";
 import isPlainObject from "lodash/isPlainObject";
-import isEqual from "lodash/isEqual";
 import { exportGLTF } from "./Exporters/glTFExporter";
 import findIndex from "lodash/findIndex";
 import merge from "lodash/merge";
@@ -967,6 +966,14 @@ export class Three3DScene extends Three3D {
     );
   }
 
+  getCameraViewRatio(view1, view2) {
+    return view2.lookat.distanceTo(view2.position) / view1.lookat.distanceTo(view1.position);
+  }
+
+  shouldViewChangeTriggerJumpToView(view1, view2, tolerance = 0.5) {
+    return Math.abs(this.getCameraViewRatio(view1, view2) - 1) > tolerance;
+  }
+
   initCameraViews(cameras) {
     if (!this.sceneContainer?.children?.length) {
       return;
@@ -991,7 +998,10 @@ export class Three3DScene extends Three3D {
     } else if (
       previousCameraView &&
       this.cameraViews[currentCameraName] &&
-      !isEqual(previousCameraView, this.cameraViews[currentCameraName])
+      this.shouldViewChangeTriggerJumpToView(
+        previousCameraView,
+        this.cameraViews[currentCameraName]
+      )
     ) {
       this.currentCameraView = null;
       this.jumpToView(currentCameraName, true);
@@ -1120,9 +1130,13 @@ export class Three3DScene extends Three3D {
     controls.maxDistance = maxDistance;
     camera.near = minDistance * 0.01;
     camera.far = maxDistance * 100;
-    camera.position.copy(camera.position.normalize().multiplyScalar(maxDistance * 0.75));
+    // update current position only if it does not fit into the distance range
+    const currentDistance = sphere.center.distanceTo(camera.position);
+    if (currentDistance < minDistance || currentDistance > maxDistance) {
+      camera.position.copy(camera.position.normalize().multiplyScalar(maxDistance * 0.75));
+      controls.target = sphere.center;
+    }
     camera.updateProjectionMatrix();
-    controls.target = sphere.center;
 
     controls.update();
   }