rechrome 1.31.3 → 1.31.5

package/README.md

@@ -74,6 +74,8 @@ between calls; another worktree gets its own. `-s=<name>` opens a named sub-sess
 `<project>` is the git worktree root (submodules count as their parent project), or the current
 directory outside git. rechrome reads `RECHROME_URL` from the nearest `.rechrome/.env.local` or
 `.env.local` walking up from the current directory; an explicit environment variable wins.
+When editing a file by hand, quote the URL (`RECHROME_URL="…#key=…"`): unquoted, a `#` starts a
+comment for some .env loaders. rech quotes it when it saves one.
 
 ### 4. Use it from another machine
 
@@ -106,7 +108,7 @@ rech open https://example.com
 `.rechrome/.env.local`. Remote listeners allow navigation, tabs, snapshots, screenshots and basic
 interactions, but not `eval`/`run-code` or filesystem commands (see [Remote access](#remote-access)).
 
-**Share several profiles in one link.** `rech share work@example.com taku2 symval-dev` puts
+**Share several profiles in one link.** `rech share work@example.com personal team-dev` puts
 exactly those profiles on one listener (its own key; running it again reuses it). Add
 `--listener <name>` to use a listener that already has a proxy route. Its links then reach
 exactly this list, and `rech listener rotate-key <name>` issues a fresh key if old links shouldn't.
@@ -262,7 +264,7 @@ the last working configuration. Each listener has its own bearer key. Use `rech
 to see configured exposure, and `rech listener ls` to list bindings without credentials.
 
 ```bash
-rech listener add qa --listen tailscale --profile qamac-remote --port 13776
+rech listener add qa --listen tailscale --profile qa-remote --port 13776
 rech listener remove qa
 ```
 

package/listeners.ts

@@ -142,7 +142,7 @@ const profileIdentity = (e: RegisteredProfile) => `${e.userDataDir ?? ""}\0${e.p
 
 /**
  * One registry key per Chrome profile (a profile can be registered under several aliases,
- * e.g. "Profile 5" and "taku2"): prefer an email, else the alphabetically first key.
+ * e.g. "Profile 5" and "personal"): prefer an email, else the alphabetically first key.
  */
 export function canonicalProfileKeys(registry: Record<string, RegisteredProfile>): string[] {
   const byProfile = new Map<string, string>();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rechrome",
-  "version": "1.31.3",
+  "version": "1.31.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/snomiao/rechrome.git"

package/rechrome.js

@@ -88,7 +88,44 @@ const globalEnvFile = join(HOME || "~", ".env.local");
 
 // Capture inherited values once so explicit environment overrides survive reloads,
 // while values loaded from files can still change when those files are edited.
-const inheritedEnvKeys = new Set(Object.keys(process.env));
+/**
+ * A KEY=value line for an env file. A value with "#" (every connection URL's #key=…) or
+ * whitespace is double-quoted: Bun's own .env loader treats an unquoted "#" as a comment and
+ * would drop the key. rech's loader strips the quotes again.
+ */
+export function envAssignment(key: string, value: string): string {
+  return /[#\s]/.test(value) ? `${key}="${value}"` : `${key}=${value}`;
+}
+
+/** Parse KEY=value lines the way Bun's .env loader does (unquoted values end at "#"). */
+function parseBunEnvFile(text: string): Record<string, string> {
+  const out: Record<string, string> = {};
+  for (const line of text.split("\n")) {
+    const m = line.match(/^\s*(?:export\s+)?([A-Za-z_][A-Za-z0-9_.-]*)\s*=\s*(.*)$/);
+    if (!m) continue;
+    const raw = m[2].trim();
+    const quoted = raw.match(/^(["'`])(.*)\1/);
+    out[m[1]] = quoted ? quoted[2] : raw.replace(/\s*#.*$/, "").trim();
+  }
+  return out;
+}
+
+/**
+ * Keys Bun itself loaded from the current folder's .env files before rech started. They look
+ * like shell exports, but are file values: counting them as inherited would let a folder's
+ * .env.local beat its .rechrome/.env.local, and a keyless (cut at "#") URL beat a good one.
+ */
+export function bunAutoloadedKeys(env: Record<string, string | undefined>, files: string[]): Set<string> {
+  const keys = new Set<string>();
+  for (const text of files)
+    for (const [key, value] of Object.entries(parseBunEnvFile(text))) if (env[key] === value) keys.add(key);
+  return keys;
+}
+
+const bunLoaded = bunAutoloadedKeys(process.env,
+  [".env", `.env.${process.env.NODE_ENV || "development"}`, ".env.local", `.env.${process.env.NODE_ENV || "development"}.local`]
+    .map(name => { try { return readFileSync(join(process.cwd(), name), "utf8"); } catch { return ""; } }));
+const inheritedEnvKeys = new Set(Object.keys(process.env).filter(key => !bunLoaded.has(key)));
 
 // Walk CWD→root loading env files nearest-first; inherited environment wins over files.
 // At each level .rechrome/.env.local is checked before .env.local (rechrome-specific overrides general).
@@ -437,7 +474,7 @@ export async function getOrCreateUrl(persist = true): Promise<string> {
   const key = randomBytes(12).toString("base64url"); // 16 chars
   const url = `http://${key}@127.0.0.1:${DEFAULT_PORT}`;
   if (persist) {
-    const newLine = `${ENV_KEY}=${url}`;
+    const newLine = envAssignment(ENV_KEY, url);
     // Write to ~/.env.local so it's not shadowed by project .env.local
     const envRaw = await file(globalEnvFile).text().catch(() => "");
     const lines = envRaw.trimEnd().split("\n").filter(l => !l.startsWith(`${ENV_KEY}=`));
@@ -905,16 +942,135 @@ export function buildProfileRows(cache: Record<string, ChromeProfileInfo> | null
   return rows;
 }
 
-/** PIDs of browser processes (not helpers) running on a Chrome user-data dir. POSIX only. */
-function browsersUsing(userDataDir: string): number[] {
-  if (process.platform === "win32") return [];
+/**
+ * Split a Windows command line into arguments the way the C runtime does (CommandLineToArgvW
+ * rules): whitespace separates outside quotes; quotes toggle and may sit mid-argument
+ * (`--x="C:\a"b` is `--x=C:\ab`); 2n backslashes before a quote are n backslashes and the quote
+ * toggles, 2n+1 are n and a literal quote; `""` inside quotes is a literal quote.
+ */
+export function splitWindowsCommandLine(commandLine: string): string[] {
+  const args: string[] = [];
+  let current = "", quoted = false, started = false;
+  for (let i = 0; i < commandLine.length; i++) {
+    const c = commandLine[i];
+    if (c === "\\") {
+      let n = 0;
+      while (commandLine[i] === "\\") { n++; i++; }
+      if (commandLine[i] === '"') {
+        current += "\\".repeat(n >> 1);
+        if (n % 2) current += '"'; else quoted = !quoted;
+      } else { current += "\\".repeat(n); i--; }
+      started = true;
+    } else if (c === '"') {
+      if (quoted && commandLine[i + 1] === '"') { current += '"'; i++; } else quoted = !quoted;
+      started = true;
+    } else if (!quoted && (c === " " || c === "\t")) {
+      if (started) { args.push(current); current = ""; started = false; }
+    } else { current += c; started = true; }
+  }
+  if (started) args.push(current);
+  return args;
+}
+
+/** The `--user-data-dir` value among exact arguments, or null. */
+export function userDataDirArg(args: string[]): string | null {
+  const arg = args.find(a => a.startsWith("--user-data-dir="));
+  return arg === undefined ? null : arg.slice("--user-data-dir=".length);
+}
+
+/** Same folder: exact path, ignoring trailing separators (and case on Windows). */
+export function sameDataDir(a: string, b: string, windows = process.platform === "win32"): boolean {
+  const norm = (p: string) => { const t = p.replace(/[\\/]+$/, ""); return windows ? t.replaceAll("/", "\\").toLowerCase() : t; };
+  return norm(a) === norm(b);
+}
+
+/**
+ * Match a flattened POSIX `ps` command line (no quotes, argument boundaries lost) against a
+ * user-data dir: "exact" only when the path is the last thing on the line; "ambiguous" when
+ * more text follows (another flag, or a sibling folder like `qa -backup`); else "none".
+ */
+export function flatUserDataDirMatch(command: string, userDataDir: string): "exact" | "ambiguous" | "none" {
+  const flag = `--user-data-dir=${userDataDir.replace(/\/+$/, "")}`;
+  const at = command.indexOf(flag);
+  if (at < 0 || (at > 0 && !/\s/.test(command[at - 1]))) return "none";
+  const rest = command.slice(at + flag.length);
+  if (/^\/*\s*$/.test(rest)) return "exact";
+  return /^\/*\s/.test(rest) ? "ambiguous" : "none";   // `qa2` / `qa-x` are other folders
+}
+
+/**
+ * Browser processes (not helpers) on this Chrome user-data dir. `exact`: certainly this folder
+ * (Windows command lines are split with the C runtime's rules; Linux reads argv from /proc).
+ * `ambiguous`: flattened `ps` output that may name a sibling folder — never killed.
+ */
+function browsersUsing(userDataDir: string): { exact: number[]; ambiguous: number[] } {
+  const exact: number[] = [], ambiguous: number[] = [];
+  const isHelper = (args: string[]) => args.some(a => a.startsWith("--type="));
+  if (process.platform === "win32") {
+    const out = Bun.spawnSync(["powershell", "-NoProfile", "-NonInteractive", "-Command",
+      "Get-CimInstance Win32_Process | ForEach-Object { \"$($_.ProcessId)`t$($_.CommandLine)\" }"], { windowsHide: true }).stdout.toString();
+    for (const line of out.split(/\r?\n/)) {
+      const tab = line.indexOf("\t"), pid = Number(line.slice(0, tab));
+      if (!pid || pid === process.pid) continue;
+      const args = splitWindowsCommandLine(line.slice(tab + 1));
+      const dir = userDataDirArg(args);
+      if (dir !== null && !isHelper(args) && sameDataDir(dir, userDataDir)) exact.push(pid);
+    }
+    return { exact, ambiguous };
+  }
   const ps = Bun.spawnSync(["ps", "ax", "-o", "pid=,command="]).stdout.toString();
-  return ps.split("\n").filter(line => line.includes(`--user-data-dir=${userDataDir}`) && !line.includes("--type="))
-    .map(line => Number(line.trim().split(/\s+/)[0])).filter(Boolean);
+  for (const line of ps.split("\n")) {
+    const m = /^\s*(\d+)\s+(.*)$/.exec(line);
+    if (!m || Number(m[1]) === process.pid || !m[2].includes("--user-data-dir=")) continue;
+    const pid = Number(m[1]);
+    let argv: string[] | null = null;
+    try { argv = readFileSync(`/proc/${pid}/cmdline`, "utf8").split("\0").filter(Boolean); } catch { /* not Linux, or gone */ }
+    if (argv) {
+      const dir = userDataDirArg(argv);
+      if (dir !== null && !isHelper(argv) && sameDataDir(dir, userDataDir, false)) exact.push(pid);
+      continue;
+    }
+    if (/(?:^|\s)--type=/.test(m[2])) continue;
+    const match = flatUserDataDirMatch(m[2], userDataDir);
+    if (match === "exact") exact.push(pid);
+    else if (match === "ambiguous") ambiguous.push(pid);
+  }
+  return { exact, ambiguous };
 }
 
 /** Move a folder to the user's Trash (recoverable). Returns where it went, or null if unsupported here. */
 function moveToTrash(dir: string): string | null {
+  // An explicit trash folder (tests use it to keep the real Trash / Recycle Bin clean).
+  const override = process.env.RECH_TRASH_DIR;
+  if (override) {
+    mkdirSync(override, { recursive: true });
+    let dest = join(override, basename(dir));
+    if (existsSync(dest)) dest = `${dest} ${new Date().toISOString().replace(/[:.]/g, "-")}`;
+    renameSync(dir, dest);
+    return dest;
+  }
+  if (process.platform === "win32") {
+    // SHFileOperation with ALLOWUNDO sends it to the Recycle Bin, with no prompts or progress UI.
+    // WANTNUKEWARNING makes Windows ask rather than silently delete for good when the item
+    // cannot be recycled. (.NET's FileSystem.DeleteDirectory(..., SendToRecycleBin) deleted
+    // permanently here.) The path goes through the environment so quoting can't break it.
+    const source = [
+      "using System; using System.Runtime.InteropServices;",
+      "public static class RechRecycle {",
+      "  [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]",
+      "  struct Op { public IntPtr hwnd; public uint wFunc; public string pFrom; public string pTo; public ushort fFlags; public bool aborted; public IntPtr mappings; public string title; }",
+      "  [DllImport(\"shell32.dll\", CharSet = CharSet.Unicode)] static extern int SHFileOperation(ref Op op);",
+      "  public static int Recycle(string path) {",
+      "    var op = new Op { wFunc = 3, pFrom = path + \"\\0\\0\", fFlags = 0x0040 | 0x0010 | 0x0004 | 0x0400 | 0x4000 };",
+      "    int r = SHFileOperation(ref op); return op.aborted ? -1 : r;",
+      "  }",
+      "}",
+    ].join("\n");
+    const r = Bun.spawnSync(["powershell", "-NoProfile", "-NonInteractive", "-Command",
+      "Add-Type -TypeDefinition $env:RECH_RECYCLE_SOURCE; exit [RechRecycle]::Recycle($env:RECH_RECYCLE_PATH)"],
+      { env: { ...process.env, RECH_RECYCLE_SOURCE: source, RECH_RECYCLE_PATH: dir.replaceAll("/", "\\").replace(/\\+$/, "") }, windowsHide: true }); // SHFileOperation rejects `/` and a trailing `\`
+    return r.exitCode === 0 && !existsSync(dir) ? "the Recycle Bin" : null;
+  }
   const trash = process.platform === "darwin" ? join(HOME, ".Trash") : process.platform === "linux" ? join(HOME, ".local", "share", "Trash", "files") : null;
   if (!trash) return null;
   mkdirSync(trash, { recursive: true });
@@ -935,13 +1091,17 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
   const key = (await resolveGlobalProfile(registry, cache, selector)).email;
   const config = await readListeners();
   const plan = planProfileRemoval(key, registry, config?.listeners ?? [], join(RECH_DIR, "profiles"));
-  const running = plan.dataDir ? browsersUsing(plan.dataDir) : [];
+  const using = plan.dataDir ? browsersUsing(plan.dataDir) : { exact: [], ambiguous: [] };
+  const running = using.exact;
   console.log(`Remove profile "${key}"${plan.keys.length > 1 ? ` (registered as ${plan.keys.join(", ")})` : ""}:`);
   for (const edit of plan.listeners) console.log(edit.drop ? `  - remove listener "${edit.name}" (it serves only this profile)` : `  - stop sharing it on listener "${edit.name}"`);
   console.log(`  - unregister it from rech (~/.rechrome/profiles.yaml)`);
   if (plan.dataDir) console.log(`  - move its data folder to the Trash: ${plan.dataDir}`);
   else console.log(`  - its Chrome data is left alone (this only unregisters it from rech)`);
   if (running.length) console.log(`  - close its browser window, which is running now (pid ${running.join(", ")})`);
+  // A process that may be on this folder or on a sibling one: never killed, and nothing changes.
+  if (using.ambiguous.length)
+    throw new Error(`A process that may be using ${plan.dataDir} is running (pid ${using.ambiguous.join(", ")}), and rech can't tell it from one on a similarly named folder. Close it yourself, then run this again. Nothing changed.`);
   const interactive = isInteractive();
   if (!opts.yes) {
     if (!interactive) throw new Error("Not removed. Re-run with --yes to confirm" + (running.length ? " and --close to close its running window." : "."));
@@ -952,8 +1112,8 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
     // In a terminal, confirming the plan above (which lists closing it) is the consent; otherwise --close.
     if (!interactive && !opts.close) throw new Error("Its window is running; re-run with --close to close it, or close it yourself first.");
     for (const pid of running) process.kill(pid, "SIGTERM");
-    for (let i = 0; i < 40 && browsersUsing(plan.dataDir!).length; i++) await Bun.sleep(250);
-    if (browsersUsing(plan.dataDir!).length) throw new Error("Its window did not close; close it and run this again. Nothing else changed.");
+    for (let i = 0; i < 40 && browsersUsing(plan.dataDir!).exact.length; i++) await Bun.sleep(250);
+    if (browsersUsing(plan.dataDir!).exact.length) throw new Error("Its window did not close; close it and run this again. Nothing else changed.");
   }
   if (config && plan.listeners.length) {
     for (const edit of plan.listeners) {
@@ -974,7 +1134,7 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
   }
   let moved: string | null = null;
   if (plan.dataDir && existsSync(plan.dataDir)) moved = moveToTrash(plan.dataDir);
-  console.log(`Removed "${key}".${moved ? ` Its data folder is in the Trash: ${moved}` : plan.dataDir ? ` Its data folder was left at ${plan.dataDir}; delete it yourself if you like.` : ""}`);
+  console.log(`Removed "${key}".${moved ? ` Its data folder was moved to ${moved}.` : plan.dataDir ? ` Its data folder was left at ${plan.dataDir}; delete it yourself if you like.` : ""}`);
 }
 
 /** On a client of a remote host, `rech profile` lists what that host's link shares. */
@@ -2048,7 +2208,7 @@ export async function daemonInstall(serveUrl: string): Promise<void> {
   const envRaw = await file(globalEnvFile).text().catch(() => "");
   const lines = envRaw.trimEnd().split("\n");
   const filtered = lines.filter(l => !l.startsWith(`${ENV_KEY}=`));
-  await Bun.write(globalEnvFile, [...filtered, `${ENV_KEY}=${keepProfileParam(serveUrl, lines.find(l => l.startsWith(`${ENV_KEY}=`))?.slice(ENV_KEY.length + 1))}`, ""].join("\n"));
+  await Bun.write(globalEnvFile, [...filtered, envAssignment(ENV_KEY, keepProfileParam(serveUrl, lines.find(l => l.startsWith(`${ENV_KEY}=`))?.slice(ENV_KEY.length + 1))), ""].join("\n"));
 
   const home = HOME;
   const bunBin = Bun.which("bun") ?? process.execPath;
@@ -2434,14 +2594,15 @@ async function provisionProfile(name: string, opts: { headed?: boolean } = {}):
   rechUrl.searchParams.set("load_extension", dist);
 
 
-  const newLine = `RECHROME_URL=${registeredProfileUrl(rechUrl.toString())}`;
+  const profileUrl = registeredProfileUrl(rechUrl.toString());
+  const newLine = envAssignment(ENV_KEY, profileUrl);
 
   // [3/3] Register in the token registry so `rech status` lists it and the daemon can resolve it.
   await saveTokenEntry(name, { extensionId: EXTENSION_ID, token, profileDir: name, userDataDir, loadExtension: dist });
   console.log(`\n[3/3] Registered "${name}" in ${TOKENS_FILE}`);
 
   console.log(`\nDone! RECHROME_URL for "${name}":\n\n  ${newLine}\n`);
-  console.log(`Use it per-call:\n  ${newLine.replace("RECHROME_URL=", "RECHROME_URL='")}' rech open https://example.com\n`);
+  console.log(`Use it per-call:\n  ${ENV_KEY}='${profileUrl}' rech open https://example.com\n`);
   console.log(`Or save it to a project .env.local to make it the default.`);
 }
 
@@ -2598,7 +2759,7 @@ async function saveProjectUrl(url: string): Promise<string> {
   if (!existsSync(gitignore)) await Bun.write(gitignore, "*\n");
   const envPath = join(dataDir, ".env.local");
   const lines = (await file(envPath).text().catch(() => "")).split("\n").filter(l => l.trim() && !l.startsWith(`${ENV_KEY}=`));
-  await writeFile(envPath, [...lines, `${ENV_KEY}=${url}`, ""].join("\n"), { mode: 0o600 });
+  await writeFile(envPath, [...lines, envAssignment(ENV_KEY, url), ""].join("\n"), { mode: 0o600 });
   await chmod(envPath, 0o600);
   return envPath;
 }
@@ -2948,7 +3109,7 @@ async function setup(opts: SetupOptions = {}): Promise<void> {
     console.log(`        rech setup --profile ${JSON.stringify(profileEmail)} --listen local --prefix=rechrome`);
     console.log(`      then expose it with tailscale serve (setup prints the command and the remote URL).`);
   }
-  const newLine = `RECHROME_URL=${registeredProfileUrl(rechUrl.toString())}`;
+  const newLine = envAssignment(ENV_KEY, registeredProfileUrl(rechUrl.toString()));
 
   console.log("\n○ [5/5] Connection verified. Save connection configuration:");
   console.log(`\n${newLine}\n`);

package/rechrome.ts

@@ -88,7 +88,44 @@ const globalEnvFile = join(HOME || "~", ".env.local");
 
 // Capture inherited values once so explicit environment overrides survive reloads,
 // while values loaded from files can still change when those files are edited.
-const inheritedEnvKeys = new Set(Object.keys(process.env));
+/**
+ * A KEY=value line for an env file. A value with "#" (every connection URL's #key=…) or
+ * whitespace is double-quoted: Bun's own .env loader treats an unquoted "#" as a comment and
+ * would drop the key. rech's loader strips the quotes again.
+ */
+export function envAssignment(key: string, value: string): string {
+  return /[#\s]/.test(value) ? `${key}="${value}"` : `${key}=${value}`;
+}
+
+/** Parse KEY=value lines the way Bun's .env loader does (unquoted values end at "#"). */
+function parseBunEnvFile(text: string): Record<string, string> {
+  const out: Record<string, string> = {};
+  for (const line of text.split("\n")) {
+    const m = line.match(/^\s*(?:export\s+)?([A-Za-z_][A-Za-z0-9_.-]*)\s*=\s*(.*)$/);
+    if (!m) continue;
+    const raw = m[2].trim();
+    const quoted = raw.match(/^(["'`])(.*)\1/);
+    out[m[1]] = quoted ? quoted[2] : raw.replace(/\s*#.*$/, "").trim();
+  }
+  return out;
+}
+
+/**
+ * Keys Bun itself loaded from the current folder's .env files before rech started. They look
+ * like shell exports, but are file values: counting them as inherited would let a folder's
+ * .env.local beat its .rechrome/.env.local, and a keyless (cut at "#") URL beat a good one.
+ */
+export function bunAutoloadedKeys(env: Record<string, string | undefined>, files: string[]): Set<string> {
+  const keys = new Set<string>();
+  for (const text of files)
+    for (const [key, value] of Object.entries(parseBunEnvFile(text))) if (env[key] === value) keys.add(key);
+  return keys;
+}
+
+const bunLoaded = bunAutoloadedKeys(process.env,
+  [".env", `.env.${process.env.NODE_ENV || "development"}`, ".env.local", `.env.${process.env.NODE_ENV || "development"}.local`]
+    .map(name => { try { return readFileSync(join(process.cwd(), name), "utf8"); } catch { return ""; } }));
+const inheritedEnvKeys = new Set(Object.keys(process.env).filter(key => !bunLoaded.has(key)));
 
 // Walk CWD→root loading env files nearest-first; inherited environment wins over files.
 // At each level .rechrome/.env.local is checked before .env.local (rechrome-specific overrides general).
@@ -437,7 +474,7 @@ export async function getOrCreateUrl(persist = true): Promise<string> {
   const key = randomBytes(12).toString("base64url"); // 16 chars
   const url = `http://${key}@127.0.0.1:${DEFAULT_PORT}`;
   if (persist) {
-    const newLine = `${ENV_KEY}=${url}`;
+    const newLine = envAssignment(ENV_KEY, url);
     // Write to ~/.env.local so it's not shadowed by project .env.local
     const envRaw = await file(globalEnvFile).text().catch(() => "");
     const lines = envRaw.trimEnd().split("\n").filter(l => !l.startsWith(`${ENV_KEY}=`));
@@ -905,16 +942,135 @@ export function buildProfileRows(cache: Record<string, ChromeProfileInfo> | null
   return rows;
 }
 
-/** PIDs of browser processes (not helpers) running on a Chrome user-data dir. POSIX only. */
-function browsersUsing(userDataDir: string): number[] {
-  if (process.platform === "win32") return [];
+/**
+ * Split a Windows command line into arguments the way the C runtime does (CommandLineToArgvW
+ * rules): whitespace separates outside quotes; quotes toggle and may sit mid-argument
+ * (`--x="C:\a"b` is `--x=C:\ab`); 2n backslashes before a quote are n backslashes and the quote
+ * toggles, 2n+1 are n and a literal quote; `""` inside quotes is a literal quote.
+ */
+export function splitWindowsCommandLine(commandLine: string): string[] {
+  const args: string[] = [];
+  let current = "", quoted = false, started = false;
+  for (let i = 0; i < commandLine.length; i++) {
+    const c = commandLine[i];
+    if (c === "\\") {
+      let n = 0;
+      while (commandLine[i] === "\\") { n++; i++; }
+      if (commandLine[i] === '"') {
+        current += "\\".repeat(n >> 1);
+        if (n % 2) current += '"'; else quoted = !quoted;
+      } else { current += "\\".repeat(n); i--; }
+      started = true;
+    } else if (c === '"') {
+      if (quoted && commandLine[i + 1] === '"') { current += '"'; i++; } else quoted = !quoted;
+      started = true;
+    } else if (!quoted && (c === " " || c === "\t")) {
+      if (started) { args.push(current); current = ""; started = false; }
+    } else { current += c; started = true; }
+  }
+  if (started) args.push(current);
+  return args;
+}
+
+/** The `--user-data-dir` value among exact arguments, or null. */
+export function userDataDirArg(args: string[]): string | null {
+  const arg = args.find(a => a.startsWith("--user-data-dir="));
+  return arg === undefined ? null : arg.slice("--user-data-dir=".length);
+}
+
+/** Same folder: exact path, ignoring trailing separators (and case on Windows). */
+export function sameDataDir(a: string, b: string, windows = process.platform === "win32"): boolean {
+  const norm = (p: string) => { const t = p.replace(/[\\/]+$/, ""); return windows ? t.replaceAll("/", "\\").toLowerCase() : t; };
+  return norm(a) === norm(b);
+}
+
+/**
+ * Match a flattened POSIX `ps` command line (no quotes, argument boundaries lost) against a
+ * user-data dir: "exact" only when the path is the last thing on the line; "ambiguous" when
+ * more text follows (another flag, or a sibling folder like `qa -backup`); else "none".
+ */
+export function flatUserDataDirMatch(command: string, userDataDir: string): "exact" | "ambiguous" | "none" {
+  const flag = `--user-data-dir=${userDataDir.replace(/\/+$/, "")}`;
+  const at = command.indexOf(flag);
+  if (at < 0 || (at > 0 && !/\s/.test(command[at - 1]))) return "none";
+  const rest = command.slice(at + flag.length);
+  if (/^\/*\s*$/.test(rest)) return "exact";
+  return /^\/*\s/.test(rest) ? "ambiguous" : "none";   // `qa2` / `qa-x` are other folders
+}
+
+/**
+ * Browser processes (not helpers) on this Chrome user-data dir. `exact`: certainly this folder
+ * (Windows command lines are split with the C runtime's rules; Linux reads argv from /proc).
+ * `ambiguous`: flattened `ps` output that may name a sibling folder — never killed.
+ */
+function browsersUsing(userDataDir: string): { exact: number[]; ambiguous: number[] } {
+  const exact: number[] = [], ambiguous: number[] = [];
+  const isHelper = (args: string[]) => args.some(a => a.startsWith("--type="));
+  if (process.platform === "win32") {
+    const out = Bun.spawnSync(["powershell", "-NoProfile", "-NonInteractive", "-Command",
+      "Get-CimInstance Win32_Process | ForEach-Object { \"$($_.ProcessId)`t$($_.CommandLine)\" }"], { windowsHide: true }).stdout.toString();
+    for (const line of out.split(/\r?\n/)) {
+      const tab = line.indexOf("\t"), pid = Number(line.slice(0, tab));
+      if (!pid || pid === process.pid) continue;
+      const args = splitWindowsCommandLine(line.slice(tab + 1));
+      const dir = userDataDirArg(args);
+      if (dir !== null && !isHelper(args) && sameDataDir(dir, userDataDir)) exact.push(pid);
+    }
+    return { exact, ambiguous };
+  }
   const ps = Bun.spawnSync(["ps", "ax", "-o", "pid=,command="]).stdout.toString();
-  return ps.split("\n").filter(line => line.includes(`--user-data-dir=${userDataDir}`) && !line.includes("--type="))
-    .map(line => Number(line.trim().split(/\s+/)[0])).filter(Boolean);
+  for (const line of ps.split("\n")) {
+    const m = /^\s*(\d+)\s+(.*)$/.exec(line);
+    if (!m || Number(m[1]) === process.pid || !m[2].includes("--user-data-dir=")) continue;
+    const pid = Number(m[1]);
+    let argv: string[] | null = null;
+    try { argv = readFileSync(`/proc/${pid}/cmdline`, "utf8").split("\0").filter(Boolean); } catch { /* not Linux, or gone */ }
+    if (argv) {
+      const dir = userDataDirArg(argv);
+      if (dir !== null && !isHelper(argv) && sameDataDir(dir, userDataDir, false)) exact.push(pid);
+      continue;
+    }
+    if (/(?:^|\s)--type=/.test(m[2])) continue;
+    const match = flatUserDataDirMatch(m[2], userDataDir);
+    if (match === "exact") exact.push(pid);
+    else if (match === "ambiguous") ambiguous.push(pid);
+  }
+  return { exact, ambiguous };
 }
 
 /** Move a folder to the user's Trash (recoverable). Returns where it went, or null if unsupported here. */
 function moveToTrash(dir: string): string | null {
+  // An explicit trash folder (tests use it to keep the real Trash / Recycle Bin clean).
+  const override = process.env.RECH_TRASH_DIR;
+  if (override) {
+    mkdirSync(override, { recursive: true });
+    let dest = join(override, basename(dir));
+    if (existsSync(dest)) dest = `${dest} ${new Date().toISOString().replace(/[:.]/g, "-")}`;
+    renameSync(dir, dest);
+    return dest;
+  }
+  if (process.platform === "win32") {
+    // SHFileOperation with ALLOWUNDO sends it to the Recycle Bin, with no prompts or progress UI.
+    // WANTNUKEWARNING makes Windows ask rather than silently delete for good when the item
+    // cannot be recycled. (.NET's FileSystem.DeleteDirectory(..., SendToRecycleBin) deleted
+    // permanently here.) The path goes through the environment so quoting can't break it.
+    const source = [
+      "using System; using System.Runtime.InteropServices;",
+      "public static class RechRecycle {",
+      "  [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]",
+      "  struct Op { public IntPtr hwnd; public uint wFunc; public string pFrom; public string pTo; public ushort fFlags; public bool aborted; public IntPtr mappings; public string title; }",
+      "  [DllImport(\"shell32.dll\", CharSet = CharSet.Unicode)] static extern int SHFileOperation(ref Op op);",
+      "  public static int Recycle(string path) {",
+      "    var op = new Op { wFunc = 3, pFrom = path + \"\\0\\0\", fFlags = 0x0040 | 0x0010 | 0x0004 | 0x0400 | 0x4000 };",
+      "    int r = SHFileOperation(ref op); return op.aborted ? -1 : r;",
+      "  }",
+      "}",
+    ].join("\n");
+    const r = Bun.spawnSync(["powershell", "-NoProfile", "-NonInteractive", "-Command",
+      "Add-Type -TypeDefinition $env:RECH_RECYCLE_SOURCE; exit [RechRecycle]::Recycle($env:RECH_RECYCLE_PATH)"],
+      { env: { ...process.env, RECH_RECYCLE_SOURCE: source, RECH_RECYCLE_PATH: dir.replaceAll("/", "\\").replace(/\\+$/, "") }, windowsHide: true }); // SHFileOperation rejects `/` and a trailing `\`
+    return r.exitCode === 0 && !existsSync(dir) ? "the Recycle Bin" : null;
+  }
   const trash = process.platform === "darwin" ? join(HOME, ".Trash") : process.platform === "linux" ? join(HOME, ".local", "share", "Trash", "files") : null;
   if (!trash) return null;
   mkdirSync(trash, { recursive: true });
@@ -935,13 +1091,17 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
   const key = (await resolveGlobalProfile(registry, cache, selector)).email;
   const config = await readListeners();
   const plan = planProfileRemoval(key, registry, config?.listeners ?? [], join(RECH_DIR, "profiles"));
-  const running = plan.dataDir ? browsersUsing(plan.dataDir) : [];
+  const using = plan.dataDir ? browsersUsing(plan.dataDir) : { exact: [], ambiguous: [] };
+  const running = using.exact;
   console.log(`Remove profile "${key}"${plan.keys.length > 1 ? ` (registered as ${plan.keys.join(", ")})` : ""}:`);
   for (const edit of plan.listeners) console.log(edit.drop ? `  - remove listener "${edit.name}" (it serves only this profile)` : `  - stop sharing it on listener "${edit.name}"`);
   console.log(`  - unregister it from rech (~/.rechrome/profiles.yaml)`);
   if (plan.dataDir) console.log(`  - move its data folder to the Trash: ${plan.dataDir}`);
   else console.log(`  - its Chrome data is left alone (this only unregisters it from rech)`);
   if (running.length) console.log(`  - close its browser window, which is running now (pid ${running.join(", ")})`);
+  // A process that may be on this folder or on a sibling one: never killed, and nothing changes.
+  if (using.ambiguous.length)
+    throw new Error(`A process that may be using ${plan.dataDir} is running (pid ${using.ambiguous.join(", ")}), and rech can't tell it from one on a similarly named folder. Close it yourself, then run this again. Nothing changed.`);
   const interactive = isInteractive();
   if (!opts.yes) {
     if (!interactive) throw new Error("Not removed. Re-run with --yes to confirm" + (running.length ? " and --close to close its running window." : "."));
@@ -952,8 +1112,8 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
     // In a terminal, confirming the plan above (which lists closing it) is the consent; otherwise --close.
     if (!interactive && !opts.close) throw new Error("Its window is running; re-run with --close to close it, or close it yourself first.");
     for (const pid of running) process.kill(pid, "SIGTERM");
-    for (let i = 0; i < 40 && browsersUsing(plan.dataDir!).length; i++) await Bun.sleep(250);
-    if (browsersUsing(plan.dataDir!).length) throw new Error("Its window did not close; close it and run this again. Nothing else changed.");
+    for (let i = 0; i < 40 && browsersUsing(plan.dataDir!).exact.length; i++) await Bun.sleep(250);
+    if (browsersUsing(plan.dataDir!).exact.length) throw new Error("Its window did not close; close it and run this again. Nothing else changed.");
   }
   if (config && plan.listeners.length) {
     for (const edit of plan.listeners) {
@@ -974,7 +1134,7 @@ async function removeProfile(selector: string, opts: { yes?: boolean; close?: bo
   }
   let moved: string | null = null;
   if (plan.dataDir && existsSync(plan.dataDir)) moved = moveToTrash(plan.dataDir);
-  console.log(`Removed "${key}".${moved ? ` Its data folder is in the Trash: ${moved}` : plan.dataDir ? ` Its data folder was left at ${plan.dataDir}; delete it yourself if you like.` : ""}`);
+  console.log(`Removed "${key}".${moved ? ` Its data folder was moved to ${moved}.` : plan.dataDir ? ` Its data folder was left at ${plan.dataDir}; delete it yourself if you like.` : ""}`);
 }
 
 /** On a client of a remote host, `rech profile` lists what that host's link shares. */
@@ -2048,7 +2208,7 @@ export async function daemonInstall(serveUrl: string): Promise<void> {
   const envRaw = await file(globalEnvFile).text().catch(() => "");
   const lines = envRaw.trimEnd().split("\n");
   const filtered = lines.filter(l => !l.startsWith(`${ENV_KEY}=`));
-  await Bun.write(globalEnvFile, [...filtered, `${ENV_KEY}=${keepProfileParam(serveUrl, lines.find(l => l.startsWith(`${ENV_KEY}=`))?.slice(ENV_KEY.length + 1))}`, ""].join("\n"));
+  await Bun.write(globalEnvFile, [...filtered, envAssignment(ENV_KEY, keepProfileParam(serveUrl, lines.find(l => l.startsWith(`${ENV_KEY}=`))?.slice(ENV_KEY.length + 1))), ""].join("\n"));
 
   const home = HOME;
   const bunBin = Bun.which("bun") ?? process.execPath;
@@ -2434,14 +2594,15 @@ async function provisionProfile(name: string, opts: { headed?: boolean } = {}):
   rechUrl.searchParams.set("load_extension", dist);
 
 
-  const newLine = `RECHROME_URL=${registeredProfileUrl(rechUrl.toString())}`;
+  const profileUrl = registeredProfileUrl(rechUrl.toString());
+  const newLine = envAssignment(ENV_KEY, profileUrl);
 
   // [3/3] Register in the token registry so `rech status` lists it and the daemon can resolve it.
   await saveTokenEntry(name, { extensionId: EXTENSION_ID, token, profileDir: name, userDataDir, loadExtension: dist });
   console.log(`\n[3/3] Registered "${name}" in ${TOKENS_FILE}`);
 
   console.log(`\nDone! RECHROME_URL for "${name}":\n\n  ${newLine}\n`);
-  console.log(`Use it per-call:\n  ${newLine.replace("RECHROME_URL=", "RECHROME_URL='")}' rech open https://example.com\n`);
+  console.log(`Use it per-call:\n  ${ENV_KEY}='${profileUrl}' rech open https://example.com\n`);
   console.log(`Or save it to a project .env.local to make it the default.`);
 }
 
@@ -2598,7 +2759,7 @@ async function saveProjectUrl(url: string): Promise<string> {
   if (!existsSync(gitignore)) await Bun.write(gitignore, "*\n");
   const envPath = join(dataDir, ".env.local");
   const lines = (await file(envPath).text().catch(() => "")).split("\n").filter(l => l.trim() && !l.startsWith(`${ENV_KEY}=`));
-  await writeFile(envPath, [...lines, `${ENV_KEY}=${url}`, ""].join("\n"), { mode: 0o600 });
+  await writeFile(envPath, [...lines, envAssignment(ENV_KEY, url), ""].join("\n"), { mode: 0o600 });
   await chmod(envPath, 0o600);
   return envPath;
 }
@@ -2948,7 +3109,7 @@ async function setup(opts: SetupOptions = {}): Promise<void> {
     console.log(`        rech setup --profile ${JSON.stringify(profileEmail)} --listen local --prefix=rechrome`);
     console.log(`      then expose it with tailscale serve (setup prints the command and the remote URL).`);
   }
-  const newLine = `RECHROME_URL=${registeredProfileUrl(rechUrl.toString())}`;
+  const newLine = envAssignment(ENV_KEY, registeredProfileUrl(rechUrl.toString()));
 
   console.log("\n○ [5/5] Connection verified. Save connection configuration:");
   console.log(`\n${newLine}\n`);

package/skills/rechrome-setup/SKILL.md

@@ -11,12 +11,12 @@ Use this workflow when the user requests rechrome setup for an existing Chrome p
 
 - Preserve the user's browser choice. Installed Google Chrome profiles belong to the user; do not rename, create, delete, or replace them as part of setup.
 - If the user wants an isolated Playwright browser, do not send them through real-Chrome extension installation. Playwright can control its own browser directly. Check the current CLI help for available managed-browser support: the legacy `provision-profile --experimental` flow still uses a bridge and may require the vendored relay patch described in the repo's `AGENTS.md`. Do not present a proposed direct-browser mode as implemented.
-- Run `rech profile ls` and resolve the exact email, display name, or folder. For no-email profiles, use the folder (for example `Profile 7`) to avoid ambiguity. A requested display name such as `taku3` is also accepted with `--profile`.
+- Run `rech profile ls` and resolve the exact email, display name, or folder. For no-email profiles, use the folder (for example `Profile 7`) to avoid ambiguity. A requested display name such as `Work 2` is also accepted with `--profile`.
 - Use `rech` or `rechrome` if installed; from a checkout use `bun rechrome.ts`. The package is `rechrome`, not `rech`: use `bunx rechrome`, never `bunx rech`.
 
 ## Start and retain the setup process
 
-Run `rech setup --profile "<selector>"` in a retained terminal session, preferably with a TTY. A bare positional selector such as `rech setup taku3` is not supported by the current CLI.
+Run `rech setup --profile "<selector>"` in a retained terminal session, preferably with a TTY. A bare positional selector such as `rech setup work-2` is not supported by the current CLI.
 
 - The listen choice applies to the selected profile. Local is the default and removes that profile from remote allowlists; choose LAN or Tailscale when requested. Other profiles keep their exposure. The menu shows Tailscale only when detected. Use `rech listener ls` and `rech profile ls` to review configured bindings. Listener changes reload in one daemon without restarting Chrome; first migration may restart only the daemon.
 - Keep the terminal session handle and poll it while working in Chrome. Non-TTY mode also works, but input is read until EOF before setup starts: provide all prompt answers and close stdin. EOF does not stop the guide server.