rebrowser-playwright-core 1.48.2 → 1.49.1

package/lib/server/chromium/crConnection.js

@@ -183,6 +183,159 @@ class CRSession extends _events.EventEmitter {
     }
     this._callbacks.clear();
   }
+  async __re__emitExecutionContext({
+    world,
+    targetId,
+    frame = null
+  }) {
+    const fixMode = process.env['REBROWSER_PATCHES_RUNTIME_FIX_MODE'] || 'addBinding';
+    const utilityWorldName = process.env['REBROWSER_PATCHES_UTILITY_WORLD_NAME'] !== '0' ? process.env['REBROWSER_PATCHES_UTILITY_WORLD_NAME'] || 'util' : '__playwright_utility_world__';
+    process.env['REBROWSER_PATCHES_DEBUG'] && console.log(`[rebrowser-patches][crSession] targetId = ${targetId}, world = ${world}, frame = ${frame ? 'Y' : 'N'}, fixMode = ${fixMode}`);
+    let getWorldPromise;
+    if (fixMode === 'addBinding') {
+      if (world === 'utility') {
+        getWorldPromise = this.__re__getIsolatedWorld({
+          client: this,
+          frameId: targetId,
+          worldName: utilityWorldName
+        }).then(contextId => {
+          return {
+            id: contextId,
+            // use UTILITY_WORLD_NAME value from crPage.ts otherwise _onExecutionContextCreated will ignore it
+            name: '__playwright_utility_world__',
+            auxData: {
+              frameId: targetId,
+              isDefault: false
+            }
+          };
+        });
+      } else if (world === 'main') {
+        getWorldPromise = this.__re__getMainWorld({
+          client: this,
+          frameId: targetId,
+          isWorker: frame === null
+        }).then(contextId => {
+          return {
+            id: contextId,
+            name: '',
+            auxData: {
+              frameId: targetId,
+              isDefault: true
+            }
+          };
+        });
+      }
+    } else if (fixMode === 'alwaysIsolated') {
+      // use only utility context
+      getWorldPromise = this.__re__getIsolatedWorld({
+        client: this,
+        frameId: targetId,
+        worldName: utilityWorldName
+      }).then(contextId => {
+        // make it look as main world
+        return {
+          id: contextId,
+          name: '',
+          auxData: {
+            frameId: targetId,
+            isDefault: true
+          }
+        };
+      });
+    }
+    const contextPayload = await getWorldPromise;
+    this.emit('Runtime.executionContextCreated', {
+      context: contextPayload
+    });
+  }
+  async __re__getMainWorld({
+    client,
+    frameId,
+    isWorker = false
+  }) {
+    let contextId;
+
+    // random name to make it harder to detect for any 3rd party script by watching window object and events
+    const randomName = [...Array(Math.floor(Math.random() * (10 + 1)) + 10)].map(() => Math.random().toString(36)[2]).join('');
+    process.env['REBROWSER_PATCHES_DEBUG'] && console.log(`[rebrowser-patches][getMainWorld] binding name = ${randomName}`);
+
+    // add the binding
+    await client.send('Runtime.addBinding', {
+      name: randomName
+    });
+
+    // listen for 'Runtime.bindingCalled' event
+    const bindingCalledHandler = ({
+      name,
+      payload,
+      executionContextId
+    }) => {
+      process.env['REBROWSER_PATCHES_DEBUG'] && console.log('[rebrowser-patches][bindingCalledHandler]', {
+        name,
+        payload,
+        executionContextId
+      });
+      if (contextId > 0) {
+        // already acquired the id
+        return;
+      }
+      if (name !== randomName) {
+        // ignore irrelevant bindings
+        return;
+      }
+      if (payload !== frameId) {
+        // ignore irrelevant frames
+        return;
+      }
+      contextId = executionContextId;
+      // remove this listener
+      client.off('Runtime.bindingCalled', bindingCalledHandler);
+    };
+    client.on('Runtime.bindingCalled', bindingCalledHandler);
+    if (isWorker) {
+      // workers don't support `Page.addScriptToEvaluateOnNewDocument` and `Page.createIsolatedWorld`, but there are no iframes inside of them, so it's safe to just use Runtime.evaluate
+      await client.send('Runtime.evaluate', {
+        expression: `this['${randomName}']('${frameId}')`
+      });
+    } else {
+      // we could call the binding right from `addScriptToEvaluateOnNewDocument`, but this way it will be called in all existing frames and it's hard to distinguish children from the parent
+      await client.send('Page.addScriptToEvaluateOnNewDocument', {
+        source: `document.addEventListener('${randomName}', (e) => self['${randomName}'](e.detail.frameId))`,
+        runImmediately: true
+      });
+
+      // create new isolated world for this frame
+      const createIsolatedWorldResult = await client.send('Page.createIsolatedWorld', {
+        frameId,
+        // use randomName for worldName to distinguish from normal utility world
+        worldName: randomName,
+        grantUniveralAccess: true
+      });
+
+      // emit event in the specific frame from the isolated world
+      await client.send('Runtime.evaluate', {
+        expression: `document.dispatchEvent(new CustomEvent('${randomName}', { detail: { frameId: '${frameId}' } }))`,
+        contextId: createIsolatedWorldResult.executionContextId
+      });
+    }
+    process.env['REBROWSER_PATCHES_DEBUG'] && console.log(`[rebrowser-patches][getMainWorld] result:`, {
+      contextId
+    });
+    return contextId;
+  }
+  async __re__getIsolatedWorld({
+    client,
+    frameId,
+    worldName
+  }) {
+    const createIsolatedWorldResult = await client.send('Page.createIsolatedWorld', {
+      frameId,
+      worldName,
+      grantUniveralAccess: true
+    });
+    process.env['REBROWSER_PATCHES_DEBUG'] && console.log(`[rebrowser-patches][getIsolatedWorld] result:`, createIsolatedWorldResult);
+    return createIsolatedWorldResult.executionContextId;
+  }
 }
 exports.CRSession = CRSession;
 class CDPSession extends _events.EventEmitter {

package/lib/server/chromium/crExecutionContext.js

@@ -58,19 +58,6 @@ class CRExecutionContext {
     if (exceptionDetails) throw new js.JavaScriptErrorInEvaluate((0, _crProtocolHelper.getExceptionMessage)(exceptionDetails));
     return remoteObject.objectId;
   }
-  rawCallFunctionNoReply(func, ...args) {
-    this._client.send('Runtime.callFunctionOn', {
-      functionDeclaration: func.toString(),
-      arguments: args.map(a => a instanceof js.JSHandle ? {
-        objectId: a._objectId
-      } : {
-        value: a
-      }),
-      returnByValue: true,
-      executionContextId: this._contextId,
-      userGesture: true
-    }).catch(() => {});
-  }
   async evaluateWithArguments(expression, returnByValue, utilityScript, values, objectIds) {
     const {
       exceptionDetails,

package/lib/server/chromium/crPage.js

@@ -318,7 +318,10 @@ class CRPage {
   async inputActionEpilogue() {
     await this._mainFrameSession._client.send('Page.enable').catch(e => {});
   }
-  async resetForReuse() {}
+  async resetForReuse() {
+    // See https://github.com/microsoft/playwright/issues/22432.
+    await this.rawMouse.move(-1, -1, 'none', new Set(), new Set(), true);
+  }
   async pdf(options) {
     return this._pdf.generate(options);
   }
@@ -625,7 +628,7 @@ class FrameSession {
       return;
     }
     const url = event.targetInfo.url;
-    const worker = new _page.Worker(this._page, url);
+    const worker = new _page.Worker(this._page, url, event.targetInfo.targetId, session);
     this._page._addWorker(event.sessionId, worker);
     this._workerSessions.set(event.sessionId, session);
     session.once('Runtime.executionContextCreated', async event => {
@@ -717,6 +720,8 @@ class FrameSession {
   _onDialog(event) {
     if (!this._page._frameManager.frame(this._targetId)) return; // Our frame/subtree may be gone already.
     this._page.emitOnContext(_browserContext.BrowserContext.Events.Dialog, new dialog.Dialog(this._page, event.type, event.message, async (accept, promptText) => {
+      // TODO: this should actually be a CDP event that notifies about a cancelled navigation attempt.
+      if (this._isMainFrame() && event.type === 'beforeunload' && !accept) this._page._frameManager.frameAbortedNavigation(this._page.mainFrame()._id, 'navigation cancelled by beforeunload dialog');
       await this._client.send('Page.handleJavaScriptDialog', {
         accept,
         promptText
@@ -1061,16 +1066,9 @@ class FrameSession {
     return this._adoptBackendNodeId(nodeInfo.node.backendNodeId, to);
   }
   async _adoptBackendNodeId(backendNodeId, to) {
-    let executionContextId;
-    if (process.env['REBROWSER_PATCHES_RUNTIME_FIX_MODE'] === '0') {
-      executionContextId = to[contextDelegateSymbol]._contextId;
-    } else {
-      // contextDelegateSymbol isn't used if fix is enabled
-      executionContextId = to._delegate._contextId;
-    }
     const result = await this._client._sendMayFail('DOM.resolveNode', {
       backendNodeId,
-      executionContextId
+      executionContextId: to[contextDelegateSymbol]._contextId
     });
     if (!result || result.object.subtype === 'null') throw new Error(dom.kUnableToAdoptErrorMessage);
     return to.createHandle(result.object).asElement();

package/lib/server/codegen/csharp.js

@@ -130,6 +130,8 @@ class CSharpLanguageGenerator {
           const assertion = action.value ? `ToHaveValueAsync(${quote(action.value)})` : `ToBeEmptyAsync()`;
           return `await Expect(${subject}.${this._asLocator(action.selector)}).${assertion};`;
         }
+      case 'assertSnapshot':
+        return `await Expect(${subject}.${this._asLocator(action.selector)}).ToMatchAriaSnapshotAsync(${quote(action.snapshot)});`;
     }
   }
   _asLocator(selector) {
@@ -149,6 +151,7 @@ class CSharpLanguageGenerator {
       using var playwright = await Playwright.CreateAsync();
       await using var browser = await playwright.${toPascal(options.browserName)}.LaunchAsync(${formatObject(options.launchOptions, '    ', 'BrowserTypeLaunchOptions')});
       var context = await browser.NewContextAsync(${formatContextOptions(options.contextOptions, options.deviceName)});`);
+    if (options.contextOptions.recordHar) formatter.add(`      await context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)});`);
     formatter.newLine();
     return formatter.format();
   }
@@ -173,6 +176,7 @@ class CSharpLanguageGenerator {
     formatter.add(`    [${this._mode === 'nunit' ? 'Test' : 'TestMethod'}]
     public async Task MyTest()
     {`);
+    if (options.contextOptions.recordHar) formatter.add(`    await context.RouteFromHARAsync(${quote(options.contextOptions.recordHar.path)});`);
     return formatter.format();
   }
   generateFooter(saveStorage) {
@@ -238,29 +242,20 @@ function getPropertyName(key) {
 function toPascal(value) {
   return value[0].toUpperCase() + value.slice(1);
 }
-function convertContextOptions(options) {
-  const result = {
-    ...options
+function formatContextOptions(contextOptions, deviceName) {
+  let options = {
+    ...contextOptions
   };
-  if (options.recordHar) {
-    result['recordHarPath'] = options.recordHar.path;
-    result['recordHarContent'] = options.recordHar.content;
-    result['recordHarMode'] = options.recordHar.mode;
-    result['recordHarOmitContent'] = options.recordHar.omitContent;
-    result['recordHarUrlFilter'] = options.recordHar.urlFilter;
-    delete result.recordHar;
-  }
-  return result;
-}
-function formatContextOptions(options, deviceName) {
+  // recordHAR is replaced with routeFromHAR in the generated code.
+  delete options.recordHar;
   const device = deviceName && _deviceDescriptors.deviceDescriptors[deviceName];
   if (!device) {
     if (!Object.entries(options).length) return '';
-    return formatObject(convertContextOptions(options), '    ', 'BrowserNewContextOptions');
+    return formatObject(options, '    ', 'BrowserNewContextOptions');
   }
   options = (0, _language.sanitizeDeviceOptions)(device, options);
   if (!Object.entries(options).length) return `playwright.Devices[${quote(deviceName)}]`;
-  return formatObject(convertContextOptions(options), '    ', `BrowserNewContextOptions(playwright.Devices[${quote(deviceName)}])`);
+  return formatObject(options, '    ', `BrowserNewContextOptions(playwright.Devices[${quote(deviceName)}])`);
 }
 class CSharpFormatter {
   constructor(offset = 0) {

package/lib/server/codegen/java.js

@@ -108,7 +108,7 @@ class JavaLanguageGenerator {
       case 'navigate':
         return `${subject}.navigate(${quote(action.url)});`;
       case 'select':
-        return `${subject}.${this._asLocator(action.selector, inFrameLocator)}.selectOption(${formatSelectOption(action.options.length > 1 ? action.options : action.options[0])});`;
+        return `${subject}.${this._asLocator(action.selector, inFrameLocator)}.selectOption(${formatSelectOption(action.options.length === 1 ? action.options[0] : action.options)});`;
       case 'assertText':
         return `assertThat(${subject}.${this._asLocator(action.selector, inFrameLocator)}).${action.substring ? 'containsText' : 'hasText'}(${quote(action.text)});`;
       case 'assertChecked':
@@ -120,6 +120,8 @@ class JavaLanguageGenerator {
           const assertion = action.value ? `hasValue(${quote(action.value)})` : `isEmpty()`;
           return `assertThat(${subject}.${this._asLocator(action.selector, inFrameLocator)}).${assertion};`;
         }
+      case 'assertSnapshot':
+        return `assertThat(${subject}.${this._asLocator(action.selector, inFrameLocator)}).matchesAriaSnapshot(${quote(action.snapshot)});`;
     }
   }
   _asLocator(selector, inFrameLocator) {
@@ -153,6 +155,7 @@ class JavaLanguageGenerator {
         try (Playwright playwright = Playwright.create()) {
           Browser browser = playwright.${options.browserName}().launch(${formatLaunchOptions(options.launchOptions)});
           BrowserContext context = browser.newContext(${formatContextOptions(options.contextOptions, options.deviceName)});`);
+    if (options.contextOptions.recordHar) formatter.add(`          context.routeFromHAR(${quote(options.contextOptions.recordHar.path)});`);
     return formatter.format();
   }
   generateFooter(saveStorage) {
@@ -190,7 +193,6 @@ function formatLaunchOptions(options) {
   return lines.join('\n');
 }
 function formatContextOptions(contextOptions, deviceName) {
-  var _options$recordHar, _options$recordHar2, _options$recordHar3, _options$recordHar4, _options$recordHar5, _options$recordHar6, _options$recordHar7;
   const lines = [];
   if (!Object.keys(contextOptions).length && !deviceName) return '';
   const device = deviceName ? _deviceDescriptors.deviceDescriptors[deviceName] : {};
@@ -208,11 +210,6 @@ function formatContextOptions(contextOptions, deviceName) {
   if (options.isMobile) lines.push(`  .setIsMobile(${options.isMobile})`);
   if (options.locale) lines.push(`  .setLocale(${quote(options.locale)})`);
   if (options.proxy) lines.push(`  .setProxy(new Proxy(${quote(options.proxy.server)}))`);
-  if ((_options$recordHar = options.recordHar) !== null && _options$recordHar !== void 0 && _options$recordHar.content) lines.push(`  .setRecordHarContent(HarContentPolicy.${(_options$recordHar2 = options.recordHar) === null || _options$recordHar2 === void 0 ? void 0 : _options$recordHar2.content.toUpperCase()})`);
-  if ((_options$recordHar3 = options.recordHar) !== null && _options$recordHar3 !== void 0 && _options$recordHar3.mode) lines.push(`  .setRecordHarMode(HarMode.${(_options$recordHar4 = options.recordHar) === null || _options$recordHar4 === void 0 ? void 0 : _options$recordHar4.mode.toUpperCase()})`);
-  if ((_options$recordHar5 = options.recordHar) !== null && _options$recordHar5 !== void 0 && _options$recordHar5.omitContent) lines.push(`  .setRecordHarOmitContent(true)`);
-  if ((_options$recordHar6 = options.recordHar) !== null && _options$recordHar6 !== void 0 && _options$recordHar6.path) lines.push(`  .setRecordHarPath(Paths.get(${quote(options.recordHar.path)}))`);
-  if ((_options$recordHar7 = options.recordHar) !== null && _options$recordHar7 !== void 0 && _options$recordHar7.urlFilter) lines.push(`  .setRecordHarUrlFilter(${quote(options.recordHar.urlFilter)})`);
   if (options.serviceWorkers) lines.push(`  .setServiceWorkers(ServiceWorkerPolicy.${options.serviceWorkers.toUpperCase()})`);
   if (options.storageState) lines.push(`  .setStorageStatePath(Paths.get(${quote(options.storageState)}))`);
   if (options.timezoneId) lines.push(`  .setTimezoneId(${quote(options.timezoneId)})`);

package/lib/server/codegen/javascript.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.JavaScriptLanguageGenerator = exports.JavaScriptFormatter = void 0;
+exports.quoteMultiline = quoteMultiline;
 var _language = require("./language");
 var _deviceDescriptors = require("../deviceDescriptors");
 var _utils = require("../../utils");
@@ -92,7 +93,7 @@ class JavaScriptLanguageGenerator {
       case 'navigate':
         return `await ${subject}.goto(${quote(action.url)});`;
       case 'select':
-        return `await ${subject}.${this._asLocator(action.selector)}.selectOption(${formatObject(action.options.length > 1 ? action.options : action.options[0])});`;
+        return `await ${subject}.${this._asLocator(action.selector)}.selectOption(${formatObject(action.options.length === 1 ? action.options[0] : action.options)});`;
       case 'assertText':
         return `${this._isTest ? '' : '// '}await expect(${subject}.${this._asLocator(action.selector)}).${action.substring ? 'toContainText' : 'toHaveText'}(${quote(action.text)});`;
       case 'assertChecked':
@@ -104,6 +105,8 @@ class JavaScriptLanguageGenerator {
           const assertion = action.value ? `toHaveValue(${quote(action.value)})` : `toBeEmpty()`;
           return `${this._isTest ? '' : '// '}await expect(${subject}.${this._asLocator(action.selector)}).${assertion};`;
         }
+      case 'assertSnapshot':
+        return `${this._isTest ? '' : '// '}await expect(${subject}.${this._asLocator(action.selector)}).toMatchAriaSnapshot(${quoteMultiline(action.snapshot)});`;
     }
   }
   _asLocator(selector) {
@@ -119,11 +122,12 @@ class JavaScriptLanguageGenerator {
   }
   generateTestHeader(options) {
     const formatter = new JavaScriptFormatter();
-    const useText = formatContextOptions(options.contextOptions, options.deviceName);
+    const useText = formatContextOptions(options.contextOptions, options.deviceName, this._isTest);
     formatter.add(`
       import { test, expect${options.deviceName ? ', devices' : ''} } from '@playwright/test';
 ${useText ? '\ntest.use(' + useText + ');\n' : ''}
       test('test', async ({ page }) => {`);
+    if (options.contextOptions.recordHar) formatter.add(`  await page.routeFromHAR(${quote(options.contextOptions.recordHar.path)});`);
     return formatter.format();
   }
   generateTestFooter(saveStorage) {
@@ -136,7 +140,8 @@ ${useText ? '\ntest.use(' + useText + ');\n' : ''}
 
       (async () => {
         const browser = await ${options.browserName}.launch(${formatObjectOrVoid(options.launchOptions)});
-        const context = await browser.newContext(${formatContextOptions(options.contextOptions, options.deviceName)});`);
+        const context = await browser.newContext(${formatContextOptions(options.contextOptions, options.deviceName, false)});`);
+    if (options.contextOptions.recordHar) formatter.add(`        await context.routeFromHAR(${quote(options.contextOptions.recordHar.path)});`);
     return formatter.format();
   }
   generateStandaloneFooter(saveStorage) {
@@ -169,8 +174,13 @@ function formatObjectOrVoid(value, indent = '  ') {
   const result = formatObject(value, indent);
   return result === '{}' ? '' : result;
 }
-function formatContextOptions(options, deviceName) {
+function formatContextOptions(options, deviceName, isTest) {
   const device = deviceName && _deviceDescriptors.deviceDescriptors[deviceName];
+  // recordHAR is replaced with routeFromHAR in the generated code.
+  options = {
+    ...options,
+    recordHar: undefined
+  };
   if (!device) return formatObjectOrVoid(options);
   // Filter out all the properties from the device descriptor.
   let serializedObject = formatObjectOrVoid((0, _language.sanitizeDeviceOptions)(device, options));
@@ -189,10 +199,12 @@ class JavaScriptFormatter {
     this._baseOffset = ' '.repeat(offset);
   }
   prepend(text) {
-    this._lines = text.trim().split('\n').map(line => line.trim()).concat(this._lines);
+    const trim = isMultilineString(text) ? line => line : line => line.trim();
+    this._lines = text.trim().split('\n').map(trim).concat(this._lines);
   }
   add(text) {
-    this._lines.push(...text.trim().split('\n').map(line => line.trim()));
+    const trim = isMultilineString(text) ? line => line : line => line.trim();
+    this._lines.push(...text.trim().split('\n').map(trim));
   }
   newLine() {
     this._lines.push('');
@@ -220,4 +232,14 @@ function wrapWithStep(description, body) {
   return description ? `await test.step(\`${description}\`, async () => {
 ${body}
 });` : body;
+}
+function quoteMultiline(text, indent = '  ') {
+  const escape = text => text.replace(/\\/g, '\\\\').replace(/`/g, '\\`').replace(/\$\{/g, '\\${');
+  const lines = text.split('\n');
+  if (lines.length === 1) return '`' + escape(text) + '`';
+  return '`\n' + lines.map(line => indent + escape(line).replace(/\${/g, '\\${')).join('\n') + `\n${indent}\``;
+}
+function isMultilineString(text) {
+  var _text$match;
+  return (_text$match = text.match(/`[\S\s]*`/)) === null || _text$match === void 0 ? void 0 : _text$match[0].includes('\n');
 }

package/lib/server/codegen/python.js

@@ -114,6 +114,8 @@ class PythonLanguageGenerator {
           const assertion = action.value ? `to_have_value(${quote(action.value)})` : `to_be_empty()`;
           return `expect(${subject}.${this._asLocator(action.selector)}).${assertion};`;
         }
+      case 'assertSnapshot':
+        return `expect(${subject}.${this._asLocator(action.selector)}).to_match_aria_snapshot(${quote(action.snapshot)})`;
     }
   }
   _asLocator(selector) {
@@ -135,6 +137,7 @@ from playwright.sync_api import Page, expect
 ${fixture}
 
 def test_example(page: Page) -> None {`);
+      if (options.contextOptions.recordHar) formatter.add(`    page.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
     } else if (this._isAsync) {
       formatter.add(`
 import asyncio
@@ -145,6 +148,7 @@ from playwright.async_api import Playwright, async_playwright, expect
 async def run(playwright: Playwright) -> None {
     browser = await playwright.${options.browserName}.launch(${formatOptions(options.launchOptions, false)})
     context = await browser.new_context(${formatContextOptions(options.contextOptions, options.deviceName)})`);
+      if (options.contextOptions.recordHar) formatter.add(`    await page.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
     } else {
       formatter.add(`
 import re
@@ -154,6 +158,7 @@ from playwright.sync_api import Playwright, sync_playwright, expect
 def run(playwright: Playwright) -> None {
     browser = playwright.${options.browserName}.launch(${formatOptions(options.launchOptions, false)})
     context = browser.new_context(${formatContextOptions(options.contextOptions, options.deviceName)})`);
+      if (options.contextOptions.recordHar) formatter.add(`    context.route_from_har(${quote(options.contextOptions.recordHar.path)})`);
     }
     return formatter.format();
   }
@@ -205,24 +210,15 @@ function formatOptions(value, hasArguments, asDict) {
     return `${(0, _utils.toSnakeCase)(key)}=${formatValue(value[key])}`;
   }).join(', ');
 }
-function convertContextOptions(options) {
-  const result = {
-    ...options
-  };
-  if (options.recordHar) {
-    result['record_har_path'] = options.recordHar.path;
-    result['record_har_content'] = options.recordHar.content;
-    result['record_har_mode'] = options.recordHar.mode;
-    result['record_har_omit_content'] = options.recordHar.omitContent;
-    result['record_har_url_filter'] = options.recordHar.urlFilter;
-    delete result.recordHar;
-  }
-  return result;
-}
 function formatContextOptions(options, deviceName, asDict) {
+  // recordHAR is replaced with routeFromHAR in the generated code.
+  options = {
+    ...options,
+    recordHar: undefined
+  };
   const device = deviceName && _deviceDescriptors.deviceDescriptors[deviceName];
-  if (!device) return formatOptions(convertContextOptions(options), false, asDict);
-  return `**playwright.devices[${quote(deviceName)}]` + formatOptions(convertContextOptions((0, _language.sanitizeDeviceOptions)(device, options)), true, asDict);
+  if (!device) return formatOptions(options, false, asDict);
+  return `**playwright.devices[${quote(deviceName)}]` + formatOptions((0, _language.sanitizeDeviceOptions)(device, options), true, asDict);
 }
 class PythonFormatter {
   constructor(offset = 0) {

package/lib/server/debugController.js

@@ -9,6 +9,7 @@ var _instrumentation = require("./instrumentation");
 var _recorder = require("./recorder");
 var _recorderApp = require("./recorder/recorderApp");
 var _utils = require("../utils");
+var _ariaSnapshot = require("./ariaSnapshot");
 /**
  * Copyright (c) Microsoft Corporation.
  *
@@ -118,8 +119,10 @@ class DebugController extends _instrumentation.SdkObject {
     };
     this._autoCloseTimer = setTimeout(heartBeat, 30000);
   }
-  async highlight(selector) {
-    for (const recorder of await this._allRecorders()) recorder.setHighlightedSelector(this._sdkLanguage, selector);
+  async highlight(params) {
+    for (const recorder of await this._allRecorders()) {
+      if (params.ariaTemplate) recorder.setHighlightedAriaTemplate((0, _ariaSnapshot.parseYamlForAriaSnapshot)(params.ariaTemplate));else if (params.selector) recorder.setHighlightedSelector(this._sdkLanguage, params.selector);
+    }
   }
   async hideHighlight() {
     // Hide all active recorder highlights.
@@ -197,10 +200,10 @@ class InspectingRecorderApp extends _recorderApp.EmptyRecorderApp {
     this._debugController = void 0;
     this._debugController = debugController;
   }
-  async setSelector(selector) {
-    const locator = (0, _utils.asLocator)(this._debugController._sdkLanguage, selector);
+  async elementPicked(elementInfo) {
+    const locator = (0, _utils.asLocator)(this._debugController._sdkLanguage, elementInfo.selector);
     this._debugController.emit(DebugController.Events.InspectRequested, {
-      selector,
+      selector: elementInfo.selector,
       locator
     });
   }