react 0.2.3 → 0.2.4

package/README.md

@@ -242,6 +242,7 @@ fn(2, 3, function (err, m, s) {
 
 ## Status
 
+ - 2012-01-11 - Provide warning/error when name is skipped in default DSL (v0.2.4)
  - 2012-01-10 - Create default DSL for react(), create error for missing variables, list remaining tasks when flow won't complete
  - 2011-12-21 - Refactor from ground up with tests, changes to the interfaces
  - 2011-10-26 - React is in active development and interface may change frequently in these early stages. Current code is functional but does not perform validation yet.  Additional interfaces are planned to make it easy to define flows in a variety of ways. Documentation and examples forthcoming.

package/lib/dsl.js

@@ -6,9 +6,11 @@ var core = require('./core.js');
 var parse = require('./parse.js');
 var tutil = require('./task.js');
 
+var MISSING_NAME = 'param[0] should be the flow name, instead found in/out def: %s';
 var INOUT_PARAMS_NO_MATCH = 'params in wrong format, wanted "foo, bar cb -> err, baz" - found: %s';
 var EXTRA_TASKARG = 'extra unmatched task arg: %s';
 
+var INOUT_RE = /\->/;  // used to detect missing name, in/out as first arg
 var CB_NAMES_RE = /^cb|callback$/i;  //cb, Cb, CB, callback, Callback
 var ERR_NAMES_RE = /^err$/i; // err, ERR, Err, ...
 
@@ -81,6 +83,7 @@ function parseVargs(vargs) {
 
 function dslDefine(name, arg1, arg2, argN) {
   var reactFn = core();
+  if (name && INOUT_RE.test(name)) throw new Error(sprintf(MISSING_NAME, name));
   var defObj = parseVargs(Array.prototype.slice.call(arguments, 1)); // name, already used 
   var inOutDef = parseInOutParams(defObj.inOutParamStr);
   var ast = {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "react",
   "description": "React is a javascript module to make it easier to work with asynchronous code, by reducing boilerplate code and improving error and exception handling while allowing variable and task dependencies when defining flow.",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "author": "Jeff Barczewski <jeff.barczewski@gmail.com>",
   "repository": { "type": "git", "url": "http://github.com/jeffbski/react.git" },
   "bugs" : { "url": "http://github.com/jeffbski/react/issues" },

package/test/dsl.test.js

@@ -191,6 +191,19 @@ test('object prop task params', function (t) {
   t.end();  
 });
 
+// Errors
+
+test('missing name, throws error', function (t) {
+  var fn = function () {
+    var r = react('cb -> err, c',
+                  falpha, 'cb -> err, c'
+                 );
+  };
+  t.throws(fn, new Error('param[0] should be the flow name, instead found in/out def: cb -> err, c'));
+  t.end();
+});
+
+
 test('extra arg throws error', function (t) {
   var fn = function () {
     var r = react('myName', 'a, b, cb -> err, c, d',