react-x11 2.8.0 → 2.8.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-x11",
-  "version": "2.8.0",
+  "version": "2.8.2",
   "description": "react renderer with X11 as a target",
   "main": "./src/index.js",
   "files": [
@@ -98,7 +98,7 @@
     "yoga-layout": "^3.2.1"
   },
   "optionalDependencies": {
-    "@windowkit/appkit": "^0.5.1",
+    "@windowkit/appkit": "^0.6.0",
     "dbus-native": "^0.15.1",
     "x11-dri": "^0.7.0"
   },

package/src/cocoa/app.js

@@ -612,9 +612,15 @@ export class CocoaApp {
     );
   }
 
-  _tickFrames() {
+  /**
+   * Run every frame that is due at `now`. The pump tick and the frame
+   * timer read the clock; a test names the moment, so that what a tick
+   * decides is a fact about that moment and not about how long the test
+   * took to ask — a shared runner stalls for milliseconds between two
+   * lines.
+   */
+  _tickFrames(now = performance.now()) {
     if (!this._rafQueue.length) return;
-    const now = performance.now();
     // Each window keeps its own clock, so a window on a 120Hz panel paints
     // every refresh while one on a 60Hz monitor paints every other pump
     // tick. Decided once per clock per tick: every frame a window queued

package/src/cocoa/window.js

@@ -68,6 +68,16 @@ export class CocoaWindow {
       attributes.visual !== undefined || attributes.transparent;
     this._transparentWindow = Boolean(transparent);
     if (transparent) options.opaque = false;
+    // A `<popup dragPreview>` follows the pointer, so for the whole gesture
+    // it is the window the window server finds under it — and AppKit does
+    // not look past a window that registered no dragged types: the drag
+    // simply has no destination, and the window beneath never hears of it.
+    // Transparent to the pointer, the preview is passed over and the hit
+    // reaches what it covers (#488; @windowkit/appkit >= 0.6.0, an older
+    // bridge ignores the option). The drop side is excluded separately:
+    // nodes.js `_initDnd` gives a preview no DropSession and registers
+    // nothing.
+    if (attributes.dragPreview) options.ignoresMouseEvents = true;
     // The root layer's background is the "what newly exposed area shows"
     // attribute an X window has — worth seeding on an opaque window so a
     // resize flashes the right colour. On a transparent one it would sit

package/src/nodes.js

@@ -10473,8 +10473,20 @@ export class WindowNode extends Scrollable(Node) {
    * and advertising lazily would race sources that cache the window list
    * at drag start. A window with no registered drop targets answers "not
    * accepting" once per entry instead (DropSession).
+   *
+   * The one exception is a `<popup dragPreview>`. It follows the pointer,
+   * so for the whole gesture it is the frontmost window under it, and it
+   * must never be what the drag is over. Where react-x11 picks the target
+   * itself (src/dnd.js `topLevelAt`) it is skipped by name. Where the OS
+   * picks, registering nothing is not enough: AppKit finds the window
+   * under the pointer first and does not look past one with no dragged
+   * types — the drag then has no destination at all — so the cocoa window
+   * is made transparent to the pointer instead (src/cocoa/window.js,
+   * `ignoresMouseEvents`, #488). A preview still gets none of this: no
+   * session, no registry entry, no property, nothing to refuse with.
    */
   _initDnd() {
+    if (this.props.dragPreview) return;
     const wnd = this.window;
     const X = this.app?.X;
     // A backend with drop machinery of its own (the cocoa backend's

package/src/types/elements.d.ts

@@ -436,8 +436,12 @@ export interface WindowProps
   xi2?: boolean | 'auto';
   /**
    * Mark this window as a drag preview: the drag router never treats it as
-   * the window under the pointer, so a `<popup dragPreview>` can follow the
-   * pointer without swallowing its own drag. See `useDragSource`.
+   * the window under the pointer, it is never a drop destination, and on
+   * the cocoa backend — where the window server picks the window under the
+   * pointer — it is made transparent to the pointer, so a drop reaches the
+   * window beneath it. A `<popup dragPreview>` can therefore follow the
+   * pointer without swallowing its own drag. Read when the window is
+   * created. See `useDragSource`.
    */
   dragPreview?: boolean;
   /**