react-three-game 0.0.22 → 0.0.24

package/dist/tools/prefabeditor/InstanceProvider.d.ts

@@ -1,30 +1,29 @@
 import React from "react";
-import { Object3D, Group } from "three";
+import { RigidBodyProps } from "@react-three/rapier";
+import { Object3D } from "three";
 export type InstanceData = {
     id: string;
+    meshPath: string;
     position: [number, number, number];
     rotation: [number, number, number];
     scale: [number, number, number];
-    meshPath: string;
     physics?: {
-        type: 'dynamic' | 'fixed';
+        type: RigidBodyProps['type'];
     };
 };
 export declare function GameInstanceProvider({ children, models, onSelect, registerRef }: {
     children: React.ReactNode;
-    models: {
-        [filename: string]: Object3D;
-    };
+    models: Record<string, Object3D>;
     onSelect?: (id: string | null) => void;
     registerRef?: (id: string, obj: Object3D | null) => void;
 }): import("react/jsx-runtime").JSX.Element;
-export declare const GameInstance: React.ForwardRefExoticComponent<{
+export declare function GameInstance({ id, modelUrl, position, rotation, scale, physics }: {
     id: string;
     modelUrl: string;
     position: [number, number, number];
     rotation: [number, number, number];
     scale: [number, number, number];
     physics?: {
-        type: "dynamic" | "fixed";
+        type: RigidBodyProps['type'];
     };
-} & React.RefAttributes<Group<import("three").Object3DEventMap>>>;
+}): null;

package/dist/tools/prefabeditor/InstanceProvider.js

@@ -1,165 +1,120 @@
 import { jsx as _jsx, jsxs as _jsxs, Fragment as _Fragment } from "react/jsx-runtime";
-import React, { createContext, useContext, useMemo, useRef, useState, useEffect, useCallback } from "react";
+import { createContext, useContext, useMemo, useRef, useState, useEffect, useCallback } from "react";
 import { Merged } from '@react-three/drei';
 import { InstancedRigidBodies } from "@react-three/rapier";
 import { Mesh, Matrix4 } from "three";
-// Helper functions for comparison
-function arrayEquals(a, b) {
-    if (a === b)
-        return true;
-    if (a.length !== b.length)
-        return false;
-    for (let i = 0; i < a.length; i++) {
-        if (a[i] !== b[i])
-            return false;
-    }
-    return true;
-}
-function instanceEquals(a, b) {
+// --- Helpers ---
+const tupleEqual = (a, b) => a.length === b.length && a.every((v, i) => v === b[i]);
+const instanceChanged = (a, b) => {
     var _a, _b;
-    return a.id === b.id &&
-        a.meshPath === b.meshPath &&
-        arrayEquals(a.position, b.position) &&
-        arrayEquals(a.rotation, b.rotation) &&
-        arrayEquals(a.scale, b.scale) &&
-        ((_a = a.physics) === null || _a === void 0 ? void 0 : _a.type) === ((_b = b.physics) === null || _b === void 0 ? void 0 : _b.type);
+    return a.meshPath !== b.meshPath ||
+        ((_a = a.physics) === null || _a === void 0 ? void 0 : _a.type) !== ((_b = b.physics) === null || _b === void 0 ? void 0 : _b.type) ||
+        !tupleEqual(a.position, b.position) ||
+        !tupleEqual(a.rotation, b.rotation) ||
+        !tupleEqual(a.scale, b.scale);
+};
+function extractMeshParts(model) {
+    model.updateWorldMatrix(false, true);
+    const rootInverse = new Matrix4().copy(model.matrixWorld).invert();
+    const parts = [];
+    model.traverse(child => {
+        if (child.isMesh) {
+            const mesh = child;
+            const geometry = mesh.geometry.clone();
+            geometry.applyMatrix4(mesh.matrixWorld.clone().premultiply(rootInverse));
+            parts.push(new Mesh(geometry, mesh.material));
+        }
+    });
+    return parts;
 }
+// --- Context ---
 const GameInstanceContext = createContext(null);
+// --- Provider ---
 export function GameInstanceProvider({ children, models, onSelect, registerRef }) {
     const [instances, setInstances] = useState([]);
     const addInstance = useCallback((instance) => {
         setInstances(prev => {
             const idx = prev.findIndex(i => i.id === instance.id);
-            if (idx !== -1) {
-                // Update existing if changed
-                if (instanceEquals(prev[idx], instance)) {
-                    return prev;
-                }
-                const copy = [...prev];
-                copy[idx] = instance;
-                return copy;
-            }
-            // Add new
-            return [...prev, instance];
+            if (idx === -1)
+                return [...prev, instance];
+            if (!instanceChanged(prev[idx], instance))
+                return prev;
+            const updated = [...prev];
+            updated[idx] = instance;
+            return updated;
         });
     }, []);
     const removeInstance = useCallback((id) => {
-        setInstances(prev => {
-            if (!prev.find(i => i.id === id))
-                return prev;
-            return prev.filter(i => i.id !== id);
-        });
+        setInstances(prev => prev.filter(i => i.id !== id));
     }, []);
-    // Flatten all model meshes once (models → flat mesh parts)
-    // Note: Geometry is cloned with baked transforms for instancing
-    const { flatMeshes, modelParts } = useMemo(() => {
-        const flatMeshes = {};
-        const modelParts = {};
+    // Extract mesh parts from models with baked local transforms
+    const { meshParts, partCounts } = useMemo(() => {
+        const meshParts = {};
+        const partCounts = {};
         Object.entries(models).forEach(([modelKey, model]) => {
-            model.updateWorldMatrix(false, true);
-            const rootInverse = new Matrix4().copy(model.matrixWorld).invert();
-            let partIndex = 0;
-            model.traverse((obj) => {
-                if (obj.isMesh) {
-                    // Clone geometry and bake relative transform
-                    const geom = obj.geometry.clone();
-                    geom.applyMatrix4(obj.matrixWorld.clone().premultiply(rootInverse));
-                    const partKey = `${modelKey}__${partIndex}`;
-                    flatMeshes[partKey] = new Mesh(geom, obj.material);
-                    partIndex++;
-                }
+            const parts = extractMeshParts(model);
+            parts.forEach((mesh, i) => {
+                meshParts[`${modelKey}__${i}`] = mesh;
             });
-            modelParts[modelKey] = partIndex;
+            partCounts[modelKey] = parts.length;
         });
-        return { flatMeshes, modelParts };
+        return { meshParts, partCounts };
     }, [models]);
-    // Cleanup geometries when models change
-    useEffect(() => {
-        return () => {
-            Object.values(flatMeshes).forEach(mesh => mesh.geometry.dispose());
-        };
-    }, [flatMeshes]);
-    // Group instances by meshPath + physics type for batch rendering
+    // Cleanup cloned geometries
+    useEffect(() => () => {
+        Object.values(meshParts).forEach(mesh => mesh.geometry.dispose());
+    }, [meshParts]);
+    // Group instances by model + physics type
     const grouped = useMemo(() => {
-        var _a;
         const groups = {};
-        for (const inst of instances) {
-            const type = ((_a = inst.physics) === null || _a === void 0 ? void 0 : _a.type) || 'none';
-            const key = `${inst.meshPath}__${type}`;
-            if (!groups[key])
-                groups[key] = { physicsType: type, instances: [] };
+        instances.forEach(inst => {
+            var _a, _b, _c;
+            const physicsType = (_b = (_a = inst.physics) === null || _a === void 0 ? void 0 : _a.type) !== null && _b !== void 0 ? _b : 'none';
+            const key = `${inst.meshPath}__${physicsType}`;
+            (_c = groups[key]) !== null && _c !== void 0 ? _c : (groups[key] = { physicsType, instances: [] });
             groups[key].instances.push(inst);
-        }
+        });
         return groups;
     }, [instances]);
-    return (_jsxs(GameInstanceContext.Provider, { value: {
-            addInstance,
-            removeInstance,
-            instances,
-            meshes: flatMeshes,
-            modelParts
-        }, children: [children, Object.entries(grouped).map(([key, group]) => {
-                if (group.physicsType === 'none')
-                    return null;
-                const modelKey = group.instances[0].meshPath;
-                const partCount = modelParts[modelKey] || 0;
-                if (partCount === 0)
-                    return null;
-                return (_jsx(InstancedRigidGroup, { group: group, modelKey: modelKey, partCount: partCount, flatMeshes: flatMeshes }, key));
-            }), Object.entries(grouped).map(([key, group]) => {
-                if (group.physicsType !== 'none')
-                    return null;
+    const contextValue = useMemo(() => ({ addInstance, removeInstance }), [addInstance, removeInstance]);
+    return (_jsxs(GameInstanceContext.Provider, { value: contextValue, children: [children, Object.entries(grouped).map(([key, group]) => {
+                var _a;
                 const modelKey = group.instances[0].meshPath;
-                const partCount = modelParts[modelKey] || 0;
+                const partCount = (_a = partCounts[modelKey]) !== null && _a !== void 0 ? _a : 0;
                 if (partCount === 0)
                     return null;
-                // Create mesh subset for this specific model
-                const meshesForModel = {};
-                for (let i = 0; i < partCount; i++) {
-                    const partKey = `${modelKey}__${i}`;
-                    meshesForModel[partKey] = flatMeshes[partKey];
+                if (group.physicsType !== 'none') {
+                    return (_jsx(PhysicsInstances, { instances: group.instances, physicsType: group.physicsType, modelKey: modelKey, partCount: partCount, meshParts: meshParts }, key));
                 }
-                return (_jsx(Merged, { meshes: meshesForModel, castShadow: true, receiveShadow: true, children: (instancesMap) => (_jsx(NonPhysicsInstancedGroup, { modelKey: modelKey, group: group, partCount: partCount, instancesMap: instancesMap, onSelect: onSelect, registerRef: registerRef })) }, key));
+                const modelMeshes = Object.fromEntries(Array.from({ length: partCount }, (_, i) => [`${modelKey}__${i}`, meshParts[`${modelKey}__${i}`]]));
+                return (_jsx(Merged, { meshes: modelMeshes, castShadow: true, receiveShadow: true, children: (Components) => (_jsx(StaticInstances, { instances: group.instances, modelKey: modelKey, partCount: partCount, Components: Components, onSelect: onSelect, registerRef: registerRef })) }, key));
             })] }));
 }
-// Render physics-enabled instances using InstancedRigidBodies
-function InstancedRigidGroup({ group, modelKey, partCount, flatMeshes }) {
-    const instances = useMemo(() => group.instances.map(inst => ({
-        key: inst.id,
-        position: inst.position,
-        rotation: inst.rotation,
-        scale: inst.scale,
-    })), [group.instances]);
-    const colliders = group.physicsType === 'fixed' ? 'trimesh' : 'hull';
-    return (_jsx(InstancedRigidBodies, { instances: instances, colliders: colliders, type: group.physicsType, children: Array.from({ length: partCount }).map((_, i) => {
-            const mesh = flatMeshes[`${modelKey}__${i}`];
-            if (!mesh)
-                return null;
-            return (_jsx("instancedMesh", { args: [mesh.geometry, mesh.material, group.instances.length], castShadow: true, receiveShadow: true, frustumCulled: false }, i));
+// --- Physics Instances ---
+// InstancedRigidBodies handles position/rotation/scale via the instances prop.
+// We pass scale in instances and let the library manage matrix updates.
+function PhysicsInstances({ instances, physicsType, modelKey, partCount, meshParts }) {
+    // InstancedRigidBodies expects { key, position, rotation, scale }
+    const rigidBodyInstances = useMemo(() => instances.map(({ id, position, rotation, scale }) => ({ key: id, position, rotation, scale })), [instances]);
+    return (_jsx(InstancedRigidBodies, { instances: rigidBodyInstances, type: physicsType, colliders: physicsType === 'fixed' ? 'trimesh' : 'hull', children: Array.from({ length: partCount }, (_, i) => {
+            const mesh = meshParts[`${modelKey}__${i}`];
+            return mesh ? (_jsx("instancedMesh", { args: [mesh.geometry, mesh.material, instances.length], frustumCulled: false, castShadow: true, receiveShadow: true }, i)) : null;
         }) }));
 }
-// Render non-physics instances using Merged's per-instance groups
-function NonPhysicsInstancedGroup({ modelKey, group, partCount, instancesMap, onSelect, registerRef }) {
-    // Pre-compute which Instance components exist for this model
-    const InstanceComponents = useMemo(() => Array.from({ length: partCount }, (_, i) => instancesMap[`${modelKey}__${i}`]).filter(Boolean), [instancesMap, modelKey, partCount]);
-    return (_jsx(_Fragment, { children: group.instances.map(inst => (_jsx(InstanceGroupItem, { instance: inst, InstanceComponents: InstanceComponents, onSelect: onSelect, registerRef: registerRef }, inst.id))) }));
+// --- Static Instances (non-physics) ---
+function StaticInstances({ instances, modelKey, partCount, Components, onSelect, registerRef }) {
+    const Parts = useMemo(() => Array.from({ length: partCount }, (_, i) => Components[`${modelKey}__${i}`]).filter(Boolean), [Components, modelKey, partCount]);
+    return (_jsx(_Fragment, { children: instances.map(inst => (_jsx(InstanceItem, { instance: inst, Parts: Parts, onSelect: onSelect, registerRef: registerRef }, inst.id))) }));
 }
-// Individual instance item with its own click state
-function InstanceGroupItem({ instance, InstanceComponents, onSelect, registerRef }) {
-    const clickValid = useRef(false);
-    return (_jsx("group", { ref: (el) => registerRef === null || registerRef === void 0 ? void 0 : registerRef(instance.id, el), position: instance.position, rotation: instance.rotation, scale: instance.scale, onPointerDown: (e) => { e.stopPropagation(); clickValid.current = true; }, onPointerMove: () => { clickValid.current = false; }, onPointerUp: (e) => {
-            if (clickValid.current) {
-                e.stopPropagation();
-                onSelect === null || onSelect === void 0 ? void 0 : onSelect(instance.id);
-            }
-            clickValid.current = false;
-        }, children: InstanceComponents.map((Instance, i) => _jsx(Instance, {}, i)) }));
+// --- Single Instance ---
+function InstanceItem({ instance, Parts, onSelect, registerRef }) {
+    const moved = useRef(false);
+    return (_jsx("group", { ref: el => registerRef === null || registerRef === void 0 ? void 0 : registerRef(instance.id, el), position: instance.position, rotation: instance.rotation, scale: instance.scale, onPointerDown: e => { e.stopPropagation(); moved.current = false; }, onPointerMove: () => { moved.current = true; }, onPointerUp: e => { e.stopPropagation(); if (!moved.current)
+            onSelect === null || onSelect === void 0 ? void 0 : onSelect(instance.id); }, children: Parts.map((Part, i) => _jsx(Part, {}, i)) }));
 }
-// GameInstance component: registers an instance for batch rendering (renders nothing itself)
-export const GameInstance = React.forwardRef(({ id, modelUrl, position, rotation, scale, physics = undefined, }, ref) => {
+// --- GameInstance (declarative registration) ---
+export function GameInstance({ id, modelUrl, position, rotation, scale, physics }) {
     const ctx = useContext(GameInstanceContext);
-    const addInstance = ctx === null || ctx === void 0 ? void 0 : ctx.addInstance;
-    const removeInstance = ctx === null || ctx === void 0 ? void 0 : ctx.removeInstance;
     const instance = useMemo(() => ({
         id,
         meshPath: modelUrl,
@@ -169,13 +124,10 @@ export const GameInstance = React.forwardRef(({ id, modelUrl, position, rotation
         physics,
     }), [id, modelUrl, position, rotation, scale, physics]);
     useEffect(() => {
-        if (!addInstance || !removeInstance)
+        if (!ctx)
             return;
-        addInstance(instance);
-        return () => {
-            removeInstance(instance.id);
-        };
-    }, [addInstance, removeInstance, instance]);
-    // No visual rendering - provider handles all instanced visuals
+        ctx.addInstance(instance);
+        return () => ctx.removeInstance(id);
+    }, [ctx, instance, id]);
     return null;
-});
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-three-game",
-  "version": "0.0.22",
+  "version": "0.0.24",
   "description": "Batteries included React Three Fiber game engine",
   "main": "dist/index.js",
   "module": "dist/index.js",

package/src/tools/prefabeditor/InstanceProvider.tsx

@@ -1,191 +1,157 @@
 import React, { createContext, useContext, useMemo, useRef, useState, useEffect, useCallback } from "react";
 import { Merged } from '@react-three/drei';
-import { InstancedRigidBodies } from "@react-three/rapier";
-import { Mesh, Matrix4, Object3D, Group } from "three";
+import { InstancedRigidBodies, RigidBodyProps } from "@react-three/rapier";
+import { Mesh, Matrix4, Object3D } from "three";
 
 // --- Types ---
 export type InstanceData = {
     id: string;
+    meshPath: string;
     position: [number, number, number];
     rotation: [number, number, number];
     scale: [number, number, number];
-    meshPath: string;
-    physics?: { type: 'dynamic' | 'fixed' };
+    physics?: { type: RigidBodyProps['type'] };
 };
 
-// Helper functions for comparison
-function arrayEquals(a: number[], b: number[]): boolean {
-    if (a === b) return true;
-    if (a.length !== b.length) return false;
-    for (let i = 0; i < a.length; i++) {
-        if (a[i] !== b[i]) return false;
-    }
-    return true;
-}
-
-function instanceEquals(a: InstanceData, b: InstanceData): boolean {
-    return a.id === b.id &&
-        a.meshPath === b.meshPath &&
-        arrayEquals(a.position, b.position) &&
-        arrayEquals(a.rotation, b.rotation) &&
-        arrayEquals(a.scale, b.scale) &&
-        a.physics?.type === b.physics?.type;
-}
+type GroupedInstances = Record<string, {
+    physicsType: string;
+    instances: InstanceData[];
+}>;
 
-// --- Context ---
 type GameInstanceContextType = {
     addInstance: (instance: InstanceData) => void;
     removeInstance: (id: string) => void;
-    instances: InstanceData[];
-    meshes: Record<string, Mesh>;
-    instancesMap?: Record<string, React.ComponentType<any>>;
-    modelParts?: Record<string, number>;
 };
+
+// --- Helpers ---
+const tupleEqual = (a: readonly number[], b: readonly number[]) =>
+    a.length === b.length && a.every((v, i) => v === b[i]);
+
+const instanceChanged = (a: InstanceData, b: InstanceData) =>
+    a.meshPath !== b.meshPath ||
+    a.physics?.type !== b.physics?.type ||
+    !tupleEqual(a.position, b.position) ||
+    !tupleEqual(a.rotation, b.rotation) ||
+    !tupleEqual(a.scale, b.scale);
+
+function extractMeshParts(model: Object3D): Mesh[] {
+    model.updateWorldMatrix(false, true);
+    const rootInverse = new Matrix4().copy(model.matrixWorld).invert();
+    const parts: Mesh[] = [];
+
+    model.traverse(child => {
+        if ((child as Mesh).isMesh) {
+            const mesh = child as Mesh;
+            const geometry = mesh.geometry.clone();
+            geometry.applyMatrix4(mesh.matrixWorld.clone().premultiply(rootInverse));
+            parts.push(new Mesh(geometry, mesh.material));
+        }
+    });
+
+    return parts;
+}
+
+// --- Context ---
 const GameInstanceContext = createContext<GameInstanceContextType | null>(null);
 
+// --- Provider ---
 export function GameInstanceProvider({
     children,
     models,
     onSelect,
     registerRef
 }: {
-    children: React.ReactNode,
-    models: { [filename: string]: Object3D },
-    onSelect?: (id: string | null) => void,
-    registerRef?: (id: string, obj: Object3D | null) => void,
+    children: React.ReactNode;
+    models: Record<string, Object3D>;
+    onSelect?: (id: string | null) => void;
+    registerRef?: (id: string, obj: Object3D | null) => void;
 }) {
     const [instances, setInstances] = useState<InstanceData[]>([]);
 
     const addInstance = useCallback((instance: InstanceData) => {
         setInstances(prev => {
             const idx = prev.findIndex(i => i.id === instance.id);
-            if (idx !== -1) {
-                // Update existing if changed
-                if (instanceEquals(prev[idx], instance)) {
-                    return prev;
-                }
-                const copy = [...prev];
-                copy[idx] = instance;
-                return copy;
-            }
-            // Add new
-            return [...prev, instance];
+            if (idx === -1) return [...prev, instance];
+            if (!instanceChanged(prev[idx], instance)) return prev;
+            const updated = [...prev];
+            updated[idx] = instance;
+            return updated;
         });
     }, []);
 
     const removeInstance = useCallback((id: string) => {
-        setInstances(prev => {
-            if (!prev.find(i => i.id === id)) return prev;
-            return prev.filter(i => i.id !== id);
-        });
+        setInstances(prev => prev.filter(i => i.id !== id));
     }, []);
 
-    // Flatten all model meshes once (models → flat mesh parts)
-    // Note: Geometry is cloned with baked transforms for instancing
-    const { flatMeshes, modelParts } = useMemo(() => {
-        const flatMeshes: Record<string, Mesh> = {};
-        const modelParts: Record<string, number> = {};
+    // Extract mesh parts from models with baked local transforms
+    const { meshParts, partCounts } = useMemo(() => {
+        const meshParts: Record<string, Mesh> = {};
+        const partCounts: Record<string, number> = {};
 
         Object.entries(models).forEach(([modelKey, model]) => {
-            model.updateWorldMatrix(false, true);
-            const rootInverse = new Matrix4().copy(model.matrixWorld).invert();
-
-            let partIndex = 0;
-            model.traverse((obj: any) => {
-                if (obj.isMesh) {
-                    // Clone geometry and bake relative transform
-                    const geom = obj.geometry.clone();
-                    geom.applyMatrix4(obj.matrixWorld.clone().premultiply(rootInverse));
-
-                    const partKey = `${modelKey}__${partIndex}`;
-                    flatMeshes[partKey] = new Mesh(geom, obj.material);
-                    partIndex++;
-                }
+            const parts = extractMeshParts(model);
+            parts.forEach((mesh, i) => {
+                meshParts[`${modelKey}__${i}`] = mesh;
             });
-            modelParts[modelKey] = partIndex;
+            partCounts[modelKey] = parts.length;
         });
 
-        return { flatMeshes, modelParts };
+        return { meshParts, partCounts };
     }, [models]);
 
-    // Cleanup geometries when models change
-    useEffect(() => {
-        return () => {
-            Object.values(flatMeshes).forEach(mesh => mesh.geometry.dispose());
-        };
-    }, [flatMeshes]);
-
-    // Group instances by meshPath + physics type for batch rendering
-    const grouped = useMemo(() => {
-        const groups: Record<string, { physicsType: string, instances: InstanceData[] }> = {};
-        for (const inst of instances) {
-            const type = inst.physics?.type || 'none';
-            const key = `${inst.meshPath}__${type}`;
-            if (!groups[key]) groups[key] = { physicsType: type, instances: [] };
+    // Cleanup cloned geometries
+    useEffect(() => () => {
+        Object.values(meshParts).forEach(mesh => mesh.geometry.dispose());
+    }, [meshParts]);
+
+    // Group instances by model + physics type
+    const grouped = useMemo<GroupedInstances>(() => {
+        const groups: GroupedInstances = {};
+        instances.forEach(inst => {
+            const physicsType = inst.physics?.type ?? 'none';
+            const key = `${inst.meshPath}__${physicsType}`;
+            groups[key] ??= { physicsType, instances: [] };
             groups[key].instances.push(inst);
-        }
+        });
         return groups;
     }, [instances]);
 
+    const contextValue = useMemo(() => ({ addInstance, removeInstance }), [addInstance, removeInstance]);
+
     return (
-        <GameInstanceContext.Provider
-            value={{
-                addInstance,
-                removeInstance,
-                instances,
-                meshes: flatMeshes,
-                modelParts
-            }}
-        >
-            {/* Render normal prefab hierarchy (non-instanced objects) */}
+        <GameInstanceContext.Provider value={contextValue}>
             {children}
 
-            {/* Render physics-enabled instanced groups using InstancedRigidBodies */}
-            {Object.entries(grouped).map(([key, group]) => {
-                if (group.physicsType === 'none') return null;
-                const modelKey = group.instances[0].meshPath;
-                const partCount = modelParts[modelKey] || 0;
-                if (partCount === 0) return null;
-
-                return (
-                    <InstancedRigidGroup
-                        key={key}
-                        group={group}
-                        modelKey={modelKey}
-                        partCount={partCount}
-                        flatMeshes={flatMeshes}
-                    />
-                );
-            })}
-
-            {/* Render non-physics instanced visuals using Merged (one per model type) */}
             {Object.entries(grouped).map(([key, group]) => {
-                if (group.physicsType !== 'none') return null;
-
                 const modelKey = group.instances[0].meshPath;
-                const partCount = modelParts[modelKey] || 0;
+                const partCount = partCounts[modelKey] ?? 0;
                 if (partCount === 0) return null;
 
-                // Create mesh subset for this specific model
-                const meshesForModel: Record<string, Mesh> = {};
-                for (let i = 0; i < partCount; i++) {
-                    const partKey = `${modelKey}__${i}`;
-                    meshesForModel[partKey] = flatMeshes[partKey];
+                if (group.physicsType !== 'none') {
+                    return (
+                        <PhysicsInstances
+                            key={key}
+                            instances={group.instances}
+                            physicsType={group.physicsType as RigidBodyProps['type']}
+                            modelKey={modelKey}
+                            partCount={partCount}
+                            meshParts={meshParts}
+                        />
+                    );
                 }
 
+                const modelMeshes = Object.fromEntries(
+                    Array.from({ length: partCount }, (_, i) => [`${modelKey}__${i}`, meshParts[`${modelKey}__${i}`]])
+                );
+
                 return (
-                    <Merged
-                        key={key}
-                        meshes={meshesForModel}
-                        castShadow
-                        receiveShadow
-                    >
-                        {(instancesMap: any) => (
-                            <NonPhysicsInstancedGroup
+                    <Merged key={key} meshes={modelMeshes} castShadow receiveShadow>
+                        {(Components: Record<string, React.ComponentType>) => (
+                            <StaticInstances
+                                instances={group.instances}
                                 modelKey={modelKey}
-                                group={group}
                                 partCount={partCount}
-                                instancesMap={instancesMap}
+                                Components={Components}
                                 onSelect={onSelect}
                                 registerRef={registerRef}
                             />
@@ -197,145 +163,126 @@ export function GameInstanceProvider({
     );
 }
 
-// Render physics-enabled instances using InstancedRigidBodies
-function InstancedRigidGroup({
-    group,
+// --- Physics Instances ---
+// InstancedRigidBodies handles position/rotation/scale via the instances prop.
+// We pass scale in instances and let the library manage matrix updates.
+function PhysicsInstances({
+    instances,
+    physicsType,
     modelKey,
     partCount,
-    flatMeshes
+    meshParts
 }: {
-    group: { physicsType: string, instances: InstanceData[] },
-    modelKey: string,
-    partCount: number,
-    flatMeshes: Record<string, Mesh>
+    instances: InstanceData[];
+    physicsType: RigidBodyProps['type'];
+    modelKey: string;
+    partCount: number;
+    meshParts: Record<string, Mesh>;
 }) {
-    const instances = useMemo(
-        () => group.instances.map(inst => ({
-            key: inst.id,
-            position: inst.position,
-            rotation: inst.rotation,
-            scale: inst.scale,
-        })),
-        [group.instances]
+    // InstancedRigidBodies expects { key, position, rotation, scale }
+    const rigidBodyInstances = useMemo(() =>
+        instances.map(({ id, position, rotation, scale }) => ({ key: id, position, rotation, scale })),
+        [instances]
     );
 
-    const colliders = group.physicsType === 'fixed' ? 'trimesh' : 'hull';
-
     return (
         <InstancedRigidBodies
-            instances={instances}
-            colliders={colliders}
-            type={group.physicsType as 'dynamic' | 'fixed'}
+            instances={rigidBodyInstances}
+            type={physicsType}
+            colliders={physicsType === 'fixed' ? 'trimesh' : 'hull'}
         >
-            {Array.from({ length: partCount }).map((_, i) => {
-                const mesh = flatMeshes[`${modelKey}__${i}`];
-                if (!mesh) return null;
-                return (
+            {Array.from({ length: partCount }, (_, i) => {
+                const mesh = meshParts[`${modelKey}__${i}`];
+                return mesh ? (
                     <instancedMesh
                         key={i}
-                        args={[mesh.geometry, mesh.material, group.instances.length]}
+                        args={[mesh.geometry, mesh.material, instances.length]}
+                        frustumCulled={false}
                         castShadow
                         receiveShadow
-                        frustumCulled={false} // Required: culling first instance hides all
                     />
-                );
+                ) : null;
             })}
         </InstancedRigidBodies>
     );
 }
 
-// Render non-physics instances using Merged's per-instance groups
-function NonPhysicsInstancedGroup({
+// --- Static Instances (non-physics) ---
+function StaticInstances({
+    instances,
     modelKey,
-    group,
     partCount,
-    instancesMap,
+    Components,
     onSelect,
     registerRef
 }: {
+    instances: InstanceData[];
     modelKey: string;
-    group: { physicsType: string, instances: InstanceData[] };
     partCount: number;
-    instancesMap: Record<string, React.ComponentType<any>>;
+    Components: Record<string, React.ComponentType>;
     onSelect?: (id: string | null) => void;
     registerRef?: (id: string, obj: Object3D | null) => void;
 }) {
-    // Pre-compute which Instance components exist for this model
-    const InstanceComponents = useMemo(() =>
-        Array.from({ length: partCount }, (_, i) => instancesMap[`${modelKey}__${i}`]).filter(Boolean),
-        [instancesMap, modelKey, partCount]
+    const Parts = useMemo(() =>
+        Array.from({ length: partCount }, (_, i) => Components[`${modelKey}__${i}`]).filter(Boolean),
+        [Components, modelKey, partCount]
     );
 
     return (
         <>
-            {group.instances.map(inst => (
-                <InstanceGroupItem
-                    key={inst.id}
-                    instance={inst}
-                    InstanceComponents={InstanceComponents}
-                    onSelect={onSelect}
-                    registerRef={registerRef}
-                />
+            {instances.map(inst => (
+                <InstanceItem key={inst.id} instance={inst} Parts={Parts} onSelect={onSelect} registerRef={registerRef} />
             ))}
         </>
     );
 }
 
-// Individual instance item with its own click state
-function InstanceGroupItem({
+// --- Single Instance ---
+function InstanceItem({
     instance,
-    InstanceComponents,
+    Parts,
     onSelect,
     registerRef
 }: {
     instance: InstanceData;
-    InstanceComponents: React.ComponentType<any>[];
+    Parts: React.ComponentType[];
     onSelect?: (id: string | null) => void;
     registerRef?: (id: string, obj: Object3D | null) => void;
 }) {
-    const clickValid = useRef(false);
+    const moved = useRef(false);
 
     return (
         <group
-            ref={(el) => registerRef?.(instance.id, el)}
+            ref={el => registerRef?.(instance.id, el)}
             position={instance.position}
             rotation={instance.rotation}
             scale={instance.scale}
-            onPointerDown={(e) => { e.stopPropagation(); clickValid.current = true; }}
-            onPointerMove={() => { clickValid.current = false; }}
-            onPointerUp={(e) => {
-                if (clickValid.current) {
-                    e.stopPropagation();
-                    onSelect?.(instance.id);
-                }
-                clickValid.current = false;
-            }}
+            onPointerDown={e => { e.stopPropagation(); moved.current = false; }}
+            onPointerMove={() => { moved.current = true; }}
+            onPointerUp={e => { e.stopPropagation(); if (!moved.current) onSelect?.(instance.id); }}
         >
-            {InstanceComponents.map((Instance, i) => <Instance key={i} />)}
+            {Parts.map((Part, i) => <Part key={i} />)}
         </group>
     );
 }
 
-
-// GameInstance component: registers an instance for batch rendering (renders nothing itself)
-export const GameInstance = React.forwardRef<Group, {
-    id: string;
-    modelUrl: string;
-    position: [number, number, number];
-    rotation: [number, number, number];
-    scale: [number, number, number];
-    physics?: { type: 'dynamic' | 'fixed' };
-}>(({
+// --- GameInstance (declarative registration) ---
+export function GameInstance({
     id,
     modelUrl,
     position,
     rotation,
     scale,
-    physics = undefined,
-}, ref) => {
+    physics
+}: {
+    id: string;
+    modelUrl: string;
+    position: [number, number, number];
+    rotation: [number, number, number];
+    scale: [number, number, number];
+    physics?: { type: RigidBodyProps['type'] };
+}) {
     const ctx = useContext(GameInstanceContext);
-    const addInstance = ctx?.addInstance;
-    const removeInstance = ctx?.removeInstance;
 
     const instance = useMemo<InstanceData>(() => ({
         id,
@@ -347,13 +294,10 @@ export const GameInstance = React.forwardRef<Group, {
     }), [id, modelUrl, position, rotation, scale, physics]);
 
     useEffect(() => {
-        if (!addInstance || !removeInstance) return;
-        addInstance(instance);
-        return () => {
-            removeInstance(instance.id);
-        };
-    }, [addInstance, removeInstance, instance]);
-
-    // No visual rendering - provider handles all instanced visuals
+        if (!ctx) return;
+        ctx.addInstance(instance);
+        return () => ctx.removeInstance(id);
+    }, [ctx, instance, id]);
+
     return null;
-});
+}