react-resizable-panels 2.1.1 → 2.1.2

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 2.1.2
+- Suppress invalid layout warning for empty panel groups (#396)
+
 ## 2.1.1
 
 - Fix `onDragging` regression (#391)

package/dist/react-resizable-panels.browser.cjs.js

@@ -1542,7 +1542,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/dist/react-resizable-panels.browser.development.cjs.js

@@ -1601,7 +1601,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.browser.development.esm.js

@@ -1577,7 +1577,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.browser.esm.js

@@ -1518,7 +1518,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/dist/react-resizable-panels.cjs.js

@@ -1544,7 +1544,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/dist/react-resizable-panels.development.cjs.js

@@ -1608,7 +1608,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.development.esm.js

@@ -1584,7 +1584,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.development.node.cjs.js

@@ -1440,7 +1440,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.development.node.esm.js

@@ -1416,7 +1416,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     {

package/dist/react-resizable-panels.esm.js

@@ -1520,7 +1520,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/dist/react-resizable-panels.node.cjs.js

@@ -1386,7 +1386,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/dist/react-resizable-panels.node.esm.js

@@ -1362,7 +1362,7 @@ function validatePanelGroupLayout({
   // Validate layout expectations
   if (nextLayout.length !== panelConstraints.length) {
     throw Error(`Invalid ${panelConstraints.length} panel layout: ${nextLayout.map(size => `${size}%`).join(", ")}`);
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100) && nextLayout.length > 0) {
     for (let index = 0; index < panelConstraints.length; index++) {
       const unsafeSize = nextLayout[index];
       assert(unsafeSize != null, `No layout data found for index ${index}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-resizable-panels",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "React components for resizable panel groups/layouts",
   "author": "Brian Vaughn <brian.david.vaughn@gmail.com>",
   "license": "MIT",
@@ -61,6 +61,9 @@
   },
   "types": "dist/react-resizable-panels.cjs.d.ts",
   "scripts": {
+    "clear": "pnpm run clear:builds & pnpm run clear:node_modules",
+    "clear:builds": "rm -rf ./packages/*/dist",
+    "clear:node_modules": "rm -rf ./node_modules",
     "lint": "eslint \"src/**/*.{ts,tsx}\"",
     "test": "jest --config=jest.config.js",
     "test:watch": "jest --config=jest.config.js --watch",

package/src/PanelGroup.test.tsx

@@ -418,5 +418,26 @@ describe("PanelGroup", () => {
         ref.current?.setLayout([60, 80]);
       });
     });
+
+    it("should warn about an empty layout", () => {
+      act(() => {
+        root.render(
+          <PanelGroup direction="horizontal" id="group-without-handle">
+            <Panel />
+          </PanelGroup>
+        );
+      });
+
+      // Since the layout is empty, no warning is expected (even though the sizes won't total 100%)
+
+      act(() => {
+        root.render(
+          <PanelGroup
+            direction="horizontal"
+            id="group-without-handle"
+          ></PanelGroup>
+        );
+      });
+    });
   });
 });

package/src/utils/validatePanelGroupLayout.ts

@@ -25,7 +25,10 @@ export function validatePanelGroupLayout({
         .map((size) => `${size}%`)
         .join(", ")}`
     );
-  } else if (!fuzzyNumbersEqual(nextLayoutTotalSize, 100)) {
+  } else if (
+    !fuzzyNumbersEqual(nextLayoutTotalSize, 100) &&
+    nextLayout.length > 0
+  ) {
     // This is not ideal so we should warn about it, but it may be recoverable in some cases
     // (especially if the amount is small)
     if (isDevelopment) {