react-resizable-panels 2.1.0 → 2.1.1

package/CHANGELOG.md

@@ -1,8 +1,13 @@
 # Changelog
 
+## 2.1.1
+
+- Fix `onDragging` regression (#391)
+- Fix cursor icon behavior in nested panels (#390)
+
 ## 2.1.0
 
-* Add opt-in support for setting the [`"nonce"` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/nonce) for the global cursor style (#386)
+- Add opt-in support for setting the [`"nonce"` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/nonce) for the global cursor style (#386)
 - Support disabling global cursor styles (#387)
 
 ## 2.0.23

package/dist/react-resizable-panels.browser.cjs.js

@@ -517,7 +517,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1992,7 +1992,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.browser.development.cjs.js

@@ -523,7 +523,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -2098,7 +2098,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.browser.development.esm.js

@@ -499,7 +499,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -2074,7 +2074,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.browser.esm.js

@@ -493,7 +493,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1968,7 +1968,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.cjs.js

@@ -519,7 +519,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1994,7 +1994,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.development.cjs.js

@@ -530,7 +530,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -2105,7 +2105,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.development.esm.js

@@ -506,7 +506,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -2081,7 +2081,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.development.node.cjs.js

@@ -492,7 +492,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1873,7 +1873,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.development.node.esm.js

@@ -468,7 +468,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1849,7 +1849,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.esm.js

@@ -495,7 +495,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1970,7 +1970,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.node.cjs.js

@@ -481,7 +481,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1772,7 +1772,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/dist/react-resizable-panels.node.esm.js

@@ -457,7 +457,7 @@ function handlePointerMove(event) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
     updateResizeHandlerStates("up", event);
   }
@@ -1748,7 +1748,7 @@ function PanelGroupWithForwardedRef({
         // but updating cursor in this scenario would cause a flicker.
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-resizable-panels",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "React components for resizable panel groups/layouts",
   "author": "Brian Vaughn <brian.david.vaughn@gmail.com>",
   "license": "MIT",

package/src/PanelGroup.ts

@@ -676,7 +676,7 @@ function PanelGroupWithForwardedRef({
         if (prevDeltaRef.current != delta) {
           prevDeltaRef.current = delta;
 
-          if (!layoutChanged) {
+          if (!layoutChanged && delta !== 0) {
             // If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
             // This mimics VS Code behavior.
             if (isHorizontal) {

package/src/PanelResizeHandle.test.tsx

@@ -336,13 +336,32 @@ describe("PanelResizeHandle", () => {
     expect(onDraggingLeft).toHaveBeenCalledWith(true);
 
     expect(cursorUtils.resetGlobalCursorStyle).not.toHaveBeenCalled();
-    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalledTimes(1);
+    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalled();
+
+    onDraggingLeft.mockReset();
+
+    act(() => {
+      dispatchPointerEvent("pointermove", leftElement);
+    });
+    expect(onDraggingLeft).not.toHaveBeenCalled();
+
+    act(() => {
+      dispatchPointerEvent("pointerup", leftElement);
+    });
+    expect(onDraggingLeft).toHaveBeenCalledTimes(1);
+    expect(onDraggingLeft).toHaveBeenCalledWith(false);
+
+    onDraggingLeft.mockReset();
+
+    act(() => {
+      dispatchPointerEvent("pointermove", leftElement);
+    });
+    expect(onDraggingLeft).not.toHaveBeenCalled();
 
     act(() => {
       root.unmount();
     });
 
     expect(cursorUtils.resetGlobalCursorStyle).toHaveBeenCalled();
-    expect(cursorUtils.setGlobalCursorStyle).toHaveBeenCalledTimes(1);
   });
 });

package/src/PanelResizeHandleRegistry.ts

@@ -109,7 +109,7 @@ function handlePointerMove(event: PointerEvent) {
 
   // Edge case (see #340)
   // Detect when the pointer has been released outside an iframe on a different domain
-  if (event.buttons === 0) {
+  if (isPointerDown && event.buttons === 0) {
     isPointerDown = false;
 
     updateResizeHandlerStates("up", event);