react-resizable-panels 2.0.16 → 2.0.18

package/src/PanelResizeHandle.test.tsx

@@ -127,18 +127,18 @@ describe("PanelResizeHandle", () => {
         });
 
         act(() => {
-          dispatchPointerEvent("mousemove", leftElement);
+          dispatchPointerEvent("pointermove", leftElement);
         });
         expect(onDragging).not.toHaveBeenCalled();
 
         act(() => {
-          dispatchPointerEvent("mousedown", leftElement);
+          dispatchPointerEvent("pointerdown", leftElement);
         });
         expect(onDragging).toHaveBeenCalledTimes(1);
         expect(onDragging).toHaveBeenCalledWith(true);
 
         act(() => {
-          dispatchPointerEvent("mouseup", leftElement);
+          dispatchPointerEvent("pointerup", leftElement);
         });
         expect(onDragging).toHaveBeenCalledTimes(2);
         expect(onDragging).toHaveBeenCalledWith(false);
@@ -154,20 +154,20 @@ describe("PanelResizeHandle", () => {
         });
 
         act(() => {
-          dispatchPointerEvent("mousemove", leftElement);
+          dispatchPointerEvent("pointermove", leftElement);
         });
         expect(onDraggingLeft).not.toHaveBeenCalled();
         expect(onDraggingRight).not.toHaveBeenCalled();
 
         act(() => {
-          dispatchPointerEvent("mousedown", leftElement);
+          dispatchPointerEvent("pointerdown", leftElement);
         });
         expect(onDraggingLeft).toHaveBeenCalledTimes(1);
         expect(onDraggingLeft).toHaveBeenCalledWith(true);
         expect(onDraggingRight).not.toHaveBeenCalled();
 
         act(() => {
-          dispatchPointerEvent("mouseup", leftElement);
+          dispatchPointerEvent("pointerup", leftElement);
         });
         expect(onDraggingLeft).toHaveBeenCalledTimes(2);
         expect(onDraggingLeft).toHaveBeenCalledWith(false);
@@ -209,7 +209,7 @@ describe("PanelResizeHandle", () => {
       verifyAttribute(rightElement, "data-resize-handle-state", "inactive");
 
       act(() => {
-        dispatchPointerEvent("mousemove", leftElement);
+        dispatchPointerEvent("pointermove", leftElement);
       });
       verifyAttribute(leftElement, "data-resize-handle-active", null);
       verifyAttribute(rightElement, "data-resize-handle-active", null);
@@ -217,7 +217,7 @@ describe("PanelResizeHandle", () => {
       verifyAttribute(rightElement, "data-resize-handle-state", "inactive");
 
       act(() => {
-        dispatchPointerEvent("mousedown", leftElement);
+        dispatchPointerEvent("pointerdown", leftElement);
       });
       verifyAttribute(leftElement, "data-resize-handle-active", "pointer");
       verifyAttribute(rightElement, "data-resize-handle-active", null);
@@ -225,7 +225,7 @@ describe("PanelResizeHandle", () => {
       verifyAttribute(rightElement, "data-resize-handle-state", "inactive");
 
       act(() => {
-        dispatchPointerEvent("mousemove", leftElement);
+        dispatchPointerEvent("pointermove", leftElement);
       });
       verifyAttribute(leftElement, "data-resize-handle-active", "pointer");
       verifyAttribute(rightElement, "data-resize-handle-active", null);
@@ -233,7 +233,7 @@ describe("PanelResizeHandle", () => {
       verifyAttribute(rightElement, "data-resize-handle-state", "inactive");
 
       act(() => {
-        dispatchPointerEvent("mouseup", leftElement);
+        dispatchPointerEvent("pointerup", leftElement);
       });
       verifyAttribute(leftElement, "data-resize-handle-active", null);
       verifyAttribute(rightElement, "data-resize-handle-active", null);
@@ -241,7 +241,7 @@ describe("PanelResizeHandle", () => {
       verifyAttribute(rightElement, "data-resize-handle-state", "inactive");
 
       act(() => {
-        dispatchPointerEvent("mousemove", rightElement);
+        dispatchPointerEvent("pointermove", rightElement);
       });
       verifyAttribute(leftElement, "data-resize-handle-active", null);
       verifyAttribute(rightElement, "data-resize-handle-active", null);

package/src/PanelResizeHandle.ts

@@ -110,6 +110,11 @@ export function PanelResizeHandle({
     }
   }, [disabled, resizeHandleId, registerResizeHandleWithParentGroup]);
 
+  // Extract hit area margins before passing them to the effect's dependency array
+  // so that inline object values won't trigger re-renders
+  const coarseHitAreaMargins = hitAreaMargins?.coarse ?? 15;
+  const fineHitAreaMargins = hitAreaMargins?.fine ?? 5;
+
   useEffect(() => {
     if (disabled || resizeHandler == null) {
       return;
@@ -168,17 +173,16 @@ export function PanelResizeHandle({
       element,
       direction,
       {
-        // Coarse inputs (e.g. finger/touch)
-        coarse: hitAreaMargins?.coarse ?? 15,
-        // Fine inputs (e.g. mouse)
-        fine: hitAreaMargins?.fine ?? 5,
+        coarse: coarseHitAreaMargins,
+        fine: fineHitAreaMargins,
       },
       setResizeHandlerState
     );
   }, [
+    coarseHitAreaMargins,
     direction,
     disabled,
-    hitAreaMargins,
+    fineHitAreaMargins,
     registerResizeHandleWithParentGroup,
     resizeHandleId,
     resizeHandler,

package/src/PanelResizeHandleRegistry.ts

@@ -89,6 +89,7 @@ function handlePointerDown(event: ResizeEvent) {
     updateResizeHandlerStates("down", event);
 
     event.preventDefault();
+    event.stopPropagation();
   }
 }
 
@@ -258,16 +259,13 @@ function updateListeners() {
     const { body } = ownerDocument;
 
     body.removeEventListener("contextmenu", handlePointerUp);
-    body.removeEventListener("mousedown", handlePointerDown);
-    body.removeEventListener("mouseleave", handlePointerMove);
-    body.removeEventListener("mousemove", handlePointerMove);
-    body.removeEventListener("touchmove", handlePointerMove);
-    body.removeEventListener("touchstart", handlePointerDown);
+    body.removeEventListener("pointerdown", handlePointerDown);
+    body.removeEventListener("pointerleave", handlePointerMove);
+    body.removeEventListener("pointermove", handlePointerMove);
   });
 
-  window.removeEventListener("mouseup", handlePointerUp);
-  window.removeEventListener("touchcancel", handlePointerUp);
-  window.removeEventListener("touchend", handlePointerUp);
+  window.removeEventListener("pointerup", handlePointerUp);
+  window.removeEventListener("pointercancel", handlePointerUp);
 
   if (registeredResizeHandlers.size > 0) {
     if (isPointerDown) {
@@ -277,29 +275,23 @@ function updateListeners() {
 
           if (count > 0) {
             body.addEventListener("contextmenu", handlePointerUp);
-            body.addEventListener("mouseleave", handlePointerMove);
-            body.addEventListener("mousemove", handlePointerMove);
-            body.addEventListener("touchmove", handlePointerMove, {
-              passive: false,
-            });
+            body.addEventListener("pointerleave", handlePointerMove);
+            body.addEventListener("pointermove", handlePointerMove);
           }
         });
       }
 
-      window.addEventListener("mouseup", handlePointerUp);
-      window.addEventListener("touchcancel", handlePointerUp);
-      window.addEventListener("touchend", handlePointerUp);
+      window.addEventListener("pointerup", handlePointerUp);
+      window.addEventListener("pointercancel", handlePointerUp);
     } else {
       ownerDocumentCounts.forEach((count, ownerDocument) => {
         const { body } = ownerDocument;
 
         if (count > 0) {
-          body.addEventListener("mousedown", handlePointerDown);
-          body.addEventListener("mousemove", handlePointerMove);
-          body.addEventListener("touchmove", handlePointerMove, {
-            passive: false,
+          body.addEventListener("pointerdown", handlePointerDown, {
+            capture: true,
           });
-          body.addEventListener("touchstart", handlePointerDown);
+          body.addEventListener("pointermove", handlePointerMove);
         }
       });
     }

package/src/types.ts

@@ -1,4 +1,5 @@
 export type Direction = "horizontal" | "vertical";
 
-export type ResizeEvent = KeyboardEvent | MouseEvent | TouchEvent;
+// The "contextmenu" event is not supported as a PointerEvent in all browsers yet, so MouseEvent still need to be handled
+export type ResizeEvent = KeyboardEvent | PointerEvent | MouseEvent;
 export type ResizeHandler = (event: ResizeEvent) => void;

package/src/utils/adjustLayoutByDelta.ts

@@ -200,8 +200,8 @@ export function adjustLayoutByDelta({
 
         if (
           deltaApplied
-            .toFixed(3)
-            .localeCompare(Math.abs(delta).toFixed(3), undefined, {
+            .toPrecision(3)
+            .localeCompare(Math.abs(delta).toPrecision(3), undefined, {
               numeric: true,
             }) >= 0
         ) {

package/src/utils/computePanelFlexBoxStyle.ts

@@ -26,12 +26,13 @@ export function computePanelFlexBoxStyle({
   if (size == null) {
     // Initial render (before panels have registered themselves)
     // In order to support server rendering, fall back to default size if provided
-    flexGrow = defaultSize != undefined ? defaultSize.toFixed(precision) : "1";
+    flexGrow =
+      defaultSize != undefined ? defaultSize.toPrecision(precision) : "1";
   } else if (panelData.length === 1) {
     // Special case: Single panel group should always fill full width/height
     flexGrow = "1";
   } else {
-    flexGrow = size.toFixed(precision);
+    flexGrow = size.toPrecision(precision);
   }
 
   return {

package/src/utils/events/getResizeEventCoordinates.ts

@@ -1,20 +1,19 @@
 import { ResizeEvent } from "../../types";
-import { isMouseEvent, isTouchEvent } from ".";
+import { isMouseEvent, isPointerEvent } from ".";
 
 export function getResizeEventCoordinates(event: ResizeEvent) {
-  if (isMouseEvent(event)) {
+  if (isPointerEvent(event)) {
+    if (event.isPrimary) {
+      return {
+        x: event.clientX,
+        y: event.clientY,
+      };
+    }
+  } else if (isMouseEvent(event)) {
     return {
       x: event.clientX,
       y: event.clientY,
     };
-  } else if (isTouchEvent(event)) {
-    const touch = event.touches[0];
-    if (touch && touch.clientX && touch.clientY) {
-      return {
-        x: touch.clientX,
-        y: touch.clientY,
-      };
-    }
   }
 
   return {

package/src/utils/events/index.ts

@@ -4,10 +4,10 @@ export function isKeyDown(event: ResizeEvent): event is KeyboardEvent {
   return event.type === "keydown";
 }
 
-export function isMouseEvent(event: ResizeEvent): event is MouseEvent {
-  return event.type.startsWith("mouse");
+export function isPointerEvent(event: ResizeEvent): event is PointerEvent {
+  return event.type.startsWith("pointer");
 }
 
-export function isTouchEvent(event: ResizeEvent): event is TouchEvent {
-  return event.type.startsWith("touch");
+export function isMouseEvent(event: ResizeEvent): event is MouseEvent {
+  return event.type.startsWith("mouse");
 }

package/src/utils/test-utils.ts

@@ -24,6 +24,9 @@ export function dispatchPointerEvent(type: string, target: HTMLElement) {
         return clientY;
       },
     },
+    isPrimary: {
+      value: true,
+    },
   });
 
   target.dispatchEvent(event);