react-relay 15.0.0 → 16.0.0

package/lib/relay-hooks/preloadQuery_DEPRECATED.js

@@ -1,14 +1,3 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault")["default"];
@@ -20,10 +9,7 @@ var _require = require('relay-runtime'),
   createOperationDescriptor = _require.createOperationDescriptor,
   getRequest = _require.getRequest,
   getRequestIdentifier = _require.getRequestIdentifier;
-
-// Expire results by this delay after they resolve.
-var DEFAULT_PREFETCH_TIMEOUT = 30 * 1000; // 30 seconds
-
+var DEFAULT_PREFETCH_TIMEOUT = 30 * 1000;
 var WEAKMAP_SUPPORTED = typeof WeakMap === 'function';
 var STORE_OR_NETWORK_DEFAULT = 'store-or-network';
 var pendingQueriesByEnvironment = WEAKMAP_SUPPORTED ? new WeakMap() : new Map();
@@ -33,7 +19,7 @@ function preloadQuery(environment, preloadableRequest, variables, options, envir
     _pendingQueries = new Map();
     pendingQueriesByEnvironment.set(environment, _pendingQueries);
   }
-  var pendingQueries = _pendingQueries; // store in a const for flow
+  var pendingQueries = _pendingQueries;
   var queryEntry = preloadQueryDeduped(environment, pendingQueries, preloadableRequest, variables, options);
   var source = queryEntry.kind === 'network' ? Observable.create(function (sink) {
     var subscription;
@@ -52,8 +38,6 @@ function preloadQuery(environment, preloadableRequest, variables, options, envir
         return;
       }
       setTimeout(function () {
-        // Clear the cache entry after the default timeout
-        // null-check for Flow
         if (queryEntry != null) {
           cleanup(pendingQueries, queryEntry);
         }
@@ -115,15 +99,12 @@ function preloadQueryDeduped(environment, pendingQueries, preloadableRequest, va
     };
     if (!environment.isServer() && prevQueryEntry == null) {
       setTimeout(function () {
-        // Clear the cache entry after the default timeout
-        // null-check for Flow
         if (nextQueryEntry != null) {
           cleanup(pendingQueries, nextQueryEntry);
         }
       }, DEFAULT_PREFETCH_TIMEOUT);
     }
   } else if (prevQueryEntry == null || prevQueryEntry.kind !== 'network') {
-    // Should fetch but we're not already fetching: fetch!
     var source = network.execute(params, variables, networkCacheConfig, null);
     var subject = new ReplaySubject();
     nextQueryEntry = {
@@ -144,8 +125,6 @@ function preloadQueryDeduped(environment, pendingQueries, preloadableRequest, va
           return;
         }
         setTimeout(function () {
-          // Clear the cache entry after the default timeout
-          // null-check for Flow
           if (nextQueryEntry != null) {
             cleanup(pendingQueries, nextQueryEntry);
           }
@@ -169,10 +148,6 @@ function preloadQueryDeduped(environment, pendingQueries, preloadableRequest, va
   return nextQueryEntry;
 }
 function cleanup(pendingQueries, entry) {
-  // Reload the entry by its cache key and only invalidate if its the identical
-  // entry instance. This ensures that if the same query/variables are fetched
-  // successively that a timeout/expiration from an earlier fetch doesn't clear
-  // a subsequent fetch.
   var currentEntry = pendingQueries.get(entry.cacheKey);
   if (currentEntry != null && currentEntry === entry) {
     if (currentEntry.kind === 'network') {

package/lib/relay-hooks/prepareEntryPoint_DEPRECATED.js

@@ -1,21 +1,8 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var preloadQuery = require('./preloadQuery_DEPRECATED');
 function prepareEntryPoint(environmentProvider, entryPoint, entryPointParams) {
-  // Start loading the code for the entrypoint
   if (entryPoint.root.getModuleIfRequired() == null) {
-    // $FlowFixMe[unused-promise]
     entryPoint.root.load();
   }
   var preloadProps = entryPoint.getPreloadProps(entryPointParams);

package/lib/relay-hooks/react-cache/RelayReactCache.js

@@ -1,18 +1,6 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var invariant = require('invariant');
-// $FlowFixMe[prop-missing] These exist in experimental builds but aren't in React's types yet.
 var _require = require('react'),
   unstable_getCacheForType = _require.unstable_getCacheForType,
   unstable_getCacheSignal = _require.unstable_getCacheSignal;

package/lib/relay-hooks/react-cache/getQueryResultOrFetchQuery_REACT_CACHE.js

@@ -1,14 +1,3 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault")["default"];
@@ -102,15 +91,9 @@ function getQueryResultOrFetchQuery_REACT_CACHE(environment, queryOperationDescr
       currentEntry = makeInitialCacheEntry();
       cache.set(environment, cacheKey, currentEntry);
     }
-    // $FlowExpectedError[prop-missing] Extra properties are passed in -- this is fine
     var newStatus = updater(currentEntry);
-    // $FlowExpectedError[cannot-spread-inexact] Flow cannot understand that this is valid...
     cache.set(environment, cacheKey, (0, _objectSpread2["default"])((0, _objectSpread2["default"])({}, currentEntry), newStatus));
-    // ... but we can because QueryCacheEntry spreads QueryCacheEntryStatus, so spreading
-    // a QueryCacheEntryStatus into a QueryCacheEntry will result in a valid QueryCacheEntry.
   }
-
-  // Initiate a query to fetch the data if needed:
   if (RelayFeatureFlags.USE_REACT_CACHE_LEGACY_TIMEOUTS) {
     var _entry;
     if (initialEntry === undefined) {
@@ -144,13 +127,7 @@ function getQueryResultOrFetchQuery_REACT_CACHE(environment, queryOperationDescr
     _entry.suspenseResource.temporaryRetain(environment);
   } else {
     if (initialEntry === undefined) {
-      // This is the behavior we eventually want: We retain the query until the
-      // presiding Cache component unmounts, at which point the AbortSignal
-      // will be triggered.
       onCacheMiss(environment, queryOperationDescriptor, fetchPolicy, renderPolicy, updateCache, options === null || options === void 0 ? void 0 : options.fetchObservable);
-
-      // Since this is the first time rendering, retain the query. React will
-      // trigger the abort signal when this cache entry is no longer needed.
       var retention = environment.retain(queryOperationDescriptor);
       var dispose = function dispose() {
         retention.dispose();
@@ -162,7 +139,7 @@ function getQueryResultOrFetchQuery_REACT_CACHE(environment, queryOperationDescr
       });
     }
   }
-  var entry = cache.get(environment, cacheKey); // could be a different entry now if synchronously resolved
+  var entry = cache.get(environment, cacheKey);
   !(entry !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, 'An entry should have been created by onCacheMiss. This is a bug in Relay.') : invariant(false) : void 0;
   switch (entry.status) {
     case 'pending':
@@ -175,8 +152,6 @@ function getQueryResultOrFetchQuery_REACT_CACHE(environment, queryOperationDescr
   !false ? process.env.NODE_ENV !== "production" ? invariant(false, 'switch statement should be exhaustive') : invariant(false) : void 0;
 }
 function onCacheMiss(environment, operation, fetchPolicy, renderPolicy, updateCache, customFetchObservable) {
-  // NB: Besides checking if the data is available, calling `check` will write missing
-  // data to the store using any missing data handlers specified in the environment.
   var queryAvailability = environment.check(operation);
   var queryStatus = queryAvailability.status;
   var hasFullQuery = queryStatus === 'available';
@@ -240,11 +215,8 @@ function executeOperationAndKeepUpToDate(environment, operation, updateCache, cu
   var promise = new Promise(function (r) {
     resolvePromise = r;
   });
-  // $FlowExpectedError[prop-missing] Expando to annotate Promises.
   promise.displayName = 'Relay(' + operation.request.node.operation.name + ')';
   var isFirstPayload = true;
-
-  // FIXME We may still need to cancel network requests for live queries.
   var fetchObservable = customFetchObservable !== null && customFetchObservable !== void 0 ? customFetchObservable : fetchQueryInternal(environment, operation);
   fetchObservable.subscribe({
     start: function start(subscription) {},
@@ -257,15 +229,12 @@ function executeOperationAndKeepUpToDate(environment, operation, updateCache, cu
           };
         });
       } else {
-        // TODO:T92030819 Remove this warning and actually throw the network error
-        // To complete this task we need to have a way of precisely tracking suspendable points
         process.env.NODE_ENV !== "production" ? warning(false, 'getQueryResultOrFetchQuery: An incremental payload for query `%` returned an error: `%`:`%`.', operation.request.node.operation.name, _error.message, _error.stack) : void 0;
       }
       resolvePromise();
       isFirstPayload = false;
     },
     next: function next(response) {
-      // Stop suspending on the first payload because of streaming, defer, etc.
       updateCache(function (_existing) {
         return {
           status: 'resolved',
@@ -276,10 +245,6 @@ function executeOperationAndKeepUpToDate(environment, operation, updateCache, cu
       isFirstPayload = false;
     }
   });
-
-  // If the above subscription yields a value synchronously, then one of the updates
-  // above will have already happened and we'll now be in a resolved or rejected state.
-  // But in the usual case, we save the promise to the entry here:
   updateCache(function (existing) {
     return existing.status === 'pending' ? {
       status: 'pending',

package/lib/relay-hooks/react-cache/readFragmentInternal_REACT_CACHE.js

@@ -1,14 +1,3 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault")["default"];
@@ -19,6 +8,7 @@ var _require = require('../QueryResource'),
 var invariant = require('invariant');
 var _require2 = require('relay-runtime'),
   fetchQueryInternal = _require2.__internal.fetchQuery,
+  RelayFeatureFlags = _require2.RelayFeatureFlags,
   createOperationDescriptor = _require2.createOperationDescriptor,
   getPendingOperationsForFragment = _require2.getPendingOperationsForFragment,
   getSelector = _require2.getSelector,
@@ -95,14 +85,9 @@ function handlePotentialSnapshotErrorsForState(environment, state) {
 function handleMissingClientEdge(environment, parentFragmentNode, parentFragmentRef, missingClientEdgeRequestInfo, queryOptions) {
   var originalVariables = getVariablesFromFragment(parentFragmentNode, parentFragmentRef);
   var variables = (0, _objectSpread2["default"])((0, _objectSpread2["default"])({}, originalVariables), {}, {
-    id: missingClientEdgeRequestInfo.clientEdgeDestinationID // TODO should be a reserved name
+    id: missingClientEdgeRequestInfo.clientEdgeDestinationID
   });
-
   var queryOperationDescriptor = createOperationDescriptor(missingClientEdgeRequestInfo.request, variables, queryOptions === null || queryOptions === void 0 ? void 0 : queryOptions.networkCacheConfig);
-  // This may suspend. We don't need to do anything with the results; all we're
-  // doing here is started the query if needed and retaining and releasing it
-  // according to the component mount/suspense cycle; QueryResource
-  // already handles this by itself.
   var QueryResource = getQueryResourceForEnvironment(environment);
   return QueryResource.prepare(queryOperationDescriptor, fetchQueryInternal(environment, queryOperationDescriptor), queryOptions === null || queryOptions === void 0 ? void 0 : queryOptions.fetchPolicy);
 }
@@ -133,8 +118,6 @@ function getFragmentState(environment, fragmentSelector) {
     };
   }
 }
-
-// fragmentNode cannot change during the lifetime of the component, though fragmentRef may change.
 function readFragmentInternal_REACT_CACHE(environment, fragmentNode, fragmentRef, hookDisplayName, queryOptions, fragmentKey) {
   var _fragmentNode$metadat, _fragmentNode$metadat2;
   var fragmentSelector = getSelector(fragmentNode, fragmentRef);
@@ -146,9 +129,6 @@ function readFragmentInternal_REACT_CACHE(environment, fragmentNode, fragmentRef
   }
   !(fragmentRef == null || isPlural && Array.isArray(fragmentRef) && fragmentRef.length === 0 || fragmentSelector != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected to receive an object where `...%s` was spread, ' + 'but the fragment reference was not found`. This is most ' + 'likely the result of:\n' + "- Forgetting to spread `%s` in `%s`'s parent's fragment.\n" + '- Conditionally fetching `%s` but unconditionally passing %s prop ' + 'to `%s`. If the parent fragment only fetches the fragment conditionally ' + '- with e.g. `@include`, `@skip`, or inside a `... on SomeType { }` ' + 'spread  - then the fragment reference will not exist. ' + 'In this case, pass `null` if the conditions for evaluating the ' + 'fragment are not met (e.g. if the `@include(if)` value is false.)', fragmentNode.name, fragmentNode.name, hookDisplayName, fragmentNode.name, fragmentKey == null ? 'a fragment reference' : "the `".concat(fragmentKey, "`"), hookDisplayName) : invariant(false) : void 0;
   var state = getFragmentState(environment, fragmentSelector);
-
-  // Handle the queries for any missing client edges; this may suspend.
-  // FIXME handle client edges in parallel.
   var clientEdgeQueries = null;
   if (((_fragmentNode$metadat2 = fragmentNode.metadata) === null || _fragmentNode$metadat2 === void 0 ? void 0 : _fragmentNode$metadat2.hasClientEdges) === true) {
     var missingClientEdges = getMissingClientEdges(state);
@@ -169,16 +149,12 @@ function readFragmentInternal_REACT_CACHE(environment, fragmentNode, fragmentRef
     }
   }
   if (isMissingData(state)) {
-    // Suspend if an active operation bears on this fragment, either the
-    // fragment's owner or some other mutation etc. that could affect it:
     !(fragmentSelector != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'refinement, see invariants above') : invariant(false) : void 0;
     var fragmentOwner = fragmentSelector.kind === 'PluralReaderSelector' ? fragmentSelector.selectors[0].owner : fragmentSelector.owner;
     var pendingOperationsResult = getPendingOperationsForFragment(environment, fragmentNode, fragmentOwner);
     if (pendingOperationsResult) {
       throw pendingOperationsResult.promise;
     }
-    // Report required fields only if we're not suspending, since that means
-    // they're missing even though we are out of options for possibly fetching them:
     handlePotentialSnapshotErrorsForState(environment, state);
   }
   var data;
@@ -191,7 +167,7 @@ function readFragmentInternal_REACT_CACHE(environment, fragmentNode, fragmentRef
       return s.data;
     });
   }
-  if (process.env.NODE_ENV !== "production") {
+  if (RelayFeatureFlags.LOG_MISSING_RECORDS_IN_PROD || process.env.NODE_ENV !== "production") {
     if (fragmentRef != null && (data === undefined || Array.isArray(data) && data.length > 0 && data.every(function (d) {
       return d === undefined;
     }))) {

package/lib/relay-hooks/react-cache/useFragmentInternal_REACT_CACHE.js

@@ -1,14 +1,3 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault")["default"];
@@ -27,6 +16,7 @@ var _require2 = require('react'),
   useState = _require2.useState;
 var _require3 = require('relay-runtime'),
   fetchQueryInternal = _require3.__internal.fetchQuery,
+  RelayFeatureFlags = _require3.RelayFeatureFlags,
   areEqualSelectors = _require3.areEqualSelectors,
   createOperationDescriptor = _require3.createOperationDescriptor,
   getPendingOperationsForFragment = _require3.getPendingOperationsForFragment,
@@ -140,22 +130,14 @@ function handlePotentialSnapshotErrorsForState(environment, state) {
     }
   }
 }
-
-/**
- * Check for updates to the store that occurred concurrently with rendering the given `state` value,
- * returning a new (updated) state if there were updates or null if there were no changes.
- */
 function handleMissedUpdates(environment, state) {
   if (state.kind === 'bailout') {
     return null;
   }
-  // FIXME this is invalid if we've just switched environments.
   var currentEpoch = environment.getStore().getEpoch();
   if (currentEpoch === state.epoch) {
     return null;
   }
-  // The store has updated since we rendered (without us being subscribed yet),
-  // so check for any updates to the data we're rendering:
   if (state.kind === 'singular') {
     var currentSnapshot = environment.lookup(state.snapshot.selector);
     var updatedData = recycleNodesInto(state.snapshot.data, currentSnapshot.data);
@@ -207,14 +189,9 @@ function handleMissedUpdates(environment, state) {
 function handleMissingClientEdge(environment, parentFragmentNode, parentFragmentRef, missingClientEdgeRequestInfo, queryOptions) {
   var originalVariables = getVariablesFromFragment(parentFragmentNode, parentFragmentRef);
   var variables = (0, _objectSpread2["default"])((0, _objectSpread2["default"])({}, originalVariables), {}, {
-    id: missingClientEdgeRequestInfo.clientEdgeDestinationID // TODO should be a reserved name
+    id: missingClientEdgeRequestInfo.clientEdgeDestinationID
   });
-
   var queryOperationDescriptor = createOperationDescriptor(missingClientEdgeRequestInfo.request, variables, queryOptions === null || queryOptions === void 0 ? void 0 : queryOptions.networkCacheConfig);
-  // This may suspend. We don't need to do anything with the results; all we're
-  // doing here is started the query if needed and retaining and releasing it
-  // according to the component mount/suspense cycle; QueryResource
-  // already handles this by itself.
   var QueryResource = getQueryResourceForEnvironment(environment);
   return QueryResource.prepare(queryOperationDescriptor, fetchQueryInternal(environment, queryOperationDescriptor), queryOptions === null || queryOptions === void 0 ? void 0 : queryOptions.fetchPolicy);
 }
@@ -224,11 +201,19 @@ function subscribeToSnapshot(environment, state, setState) {
   } else if (state.kind === 'singular') {
     var disposable = environment.subscribe(state.snapshot, function (latestSnapshot) {
       setState(function (prevState) {
-        // In theory a setState from a subscription could be batched together
-        // with a setState to change the fragment selector. Guard against this
-        // by bailing out of the state update if the selector has changed.
         if (prevState.kind !== 'singular' || prevState.snapshot.selector !== latestSnapshot.selector) {
-          return prevState;
+          var updates = handleMissedUpdates(environment, prevState);
+          if (updates != null) {
+            var dataChanged = updates[0],
+              nextState = updates[1];
+            environment.__log({
+              name: 'useFragment.subscription.missedUpdates',
+              hasDataChanges: dataChanged
+            });
+            return dataChanged ? nextState : prevState;
+          } else {
+            return prevState;
+          }
         }
         return {
           kind: 'singular',
@@ -245,11 +230,19 @@ function subscribeToSnapshot(environment, state, setState) {
       return environment.subscribe(snapshot, function (latestSnapshot) {
         setState(function (prevState) {
           var _prevState$snapshots$;
-          // In theory a setState from a subscription could be batched together
-          // with a setState to change the fragment selector. Guard against this
-          // by bailing out of the state update if the selector has changed.
           if (prevState.kind !== 'plural' || ((_prevState$snapshots$ = prevState.snapshots[index]) === null || _prevState$snapshots$ === void 0 ? void 0 : _prevState$snapshots$.selector) !== latestSnapshot.selector) {
-            return prevState;
+            var updates = handleMissedUpdates(environment, prevState);
+            if (updates != null) {
+              var dataChanged = updates[0],
+                nextState = updates[1];
+              environment.__log({
+                name: 'useFragment.subscription.missedUpdates',
+                hasDataChanges: dataChanged
+              });
+              return dataChanged ? nextState : prevState;
+            } else {
+              return prevState;
+            }
           }
           var updated = (0, _toConsumableArray2["default"])(prevState.snapshots);
           updated[index] = latestSnapshot;
@@ -283,8 +276,6 @@ function getFragmentState(environment, fragmentSelector) {
       kind: 'bailout'
     };
   } else if (fragmentSelector.kind === 'PluralReaderSelector') {
-    // Note that if fragmentRef is an empty array, fragmentSelector will be null so we'll hit the above case.
-    // Null is returned by getSelector if fragmentRef has no non-null items.
     return {
       kind: 'plural',
       snapshots: fragmentSelector.selectors.map(function (s) {
@@ -300,20 +291,18 @@ function getFragmentState(environment, fragmentSelector) {
     };
   }
 }
-
-// fragmentNode cannot change during the lifetime of the component, though fragmentRef may change.
-function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayName, queryOptions, fragmentKey) {
+function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayName, queryOptions) {
   var _fragmentNode$metadat, _fragmentNode$metadat2;
   var fragmentSelector = useMemo(function () {
     return getSelector(fragmentNode, fragmentRef);
   }, [fragmentNode, fragmentRef]);
   var isPlural = (fragmentNode === null || fragmentNode === void 0 ? void 0 : (_fragmentNode$metadat = fragmentNode.metadata) === null || _fragmentNode$metadat === void 0 ? void 0 : _fragmentNode$metadat.plural) === true;
   if (isPlural) {
-    !(fragmentRef == null || Array.isArray(fragmentRef)) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected fragment pointer%s for fragment `%s` to be ' + 'an array, instead got `%s`. Remove `@relay(plural: true)` ' + 'from fragment `%s` to allow the prop to be an object.', fragmentKey != null ? " for key `".concat(fragmentKey, "`") : '', fragmentNode.name, typeof fragmentRef, fragmentNode.name) : invariant(false) : void 0;
+    !(fragmentRef == null || Array.isArray(fragmentRef)) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected fragment pointer%s for fragment `%s` to be ' + 'an array, instead got `%s`. Remove `@relay(plural: true)` ' + 'from fragment `%s` to allow the prop to be an object.', fragmentNode.name, typeof fragmentRef, fragmentNode.name) : invariant(false) : void 0;
   } else {
-    !!Array.isArray(fragmentRef) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected fragment pointer%s for fragment `%s` not to be ' + 'an array, instead got `%s`. Add `@relay(plural: true)` ' + 'to fragment `%s` to allow the prop to be an array.', fragmentKey != null ? " for key `".concat(fragmentKey, "`") : '', fragmentNode.name, typeof fragmentRef, fragmentNode.name) : invariant(false) : void 0;
+    !!Array.isArray(fragmentRef) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected fragment pointer%s for fragment `%s` not to be ' + 'an array, instead got `%s`. Add `@relay(plural: true)` ' + 'to fragment `%s` to allow the prop to be an array.', fragmentNode.name, typeof fragmentRef, fragmentNode.name) : invariant(false) : void 0;
   }
-  !(fragmentRef == null || isPlural && Array.isArray(fragmentRef) && fragmentRef.length === 0 || fragmentSelector != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected to receive an object where `...%s` was spread, ' + 'but the fragment reference was not found`. This is most ' + 'likely the result of:\n' + "- Forgetting to spread `%s` in `%s`'s parent's fragment.\n" + '- Conditionally fetching `%s` but unconditionally passing %s prop ' + 'to `%s`. If the parent fragment only fetches the fragment conditionally ' + '- with e.g. `@include`, `@skip`, or inside a `... on SomeType { }` ' + 'spread  - then the fragment reference will not exist. ' + 'In this case, pass `null` if the conditions for evaluating the ' + 'fragment are not met (e.g. if the `@include(if)` value is false.)', fragmentNode.name, fragmentNode.name, hookDisplayName, fragmentNode.name, fragmentKey == null ? 'a fragment reference' : "the `".concat(fragmentKey, "`"), hookDisplayName) : invariant(false) : void 0;
+  !(fragmentRef == null || isPlural && Array.isArray(fragmentRef) && fragmentRef.length === 0 || fragmentSelector != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'Relay: Expected to receive an object where `...%s` was spread, ' + 'but the fragment reference was not found`. This is most ' + 'likely the result of:\n' + "- Forgetting to spread `%s` in `%s`'s parent's fragment.\n" + '- Conditionally fetching `%s` but unconditionally passing %s prop ' + 'to `%s`. If the parent fragment only fetches the fragment conditionally ' + '- with e.g. `@include`, `@skip`, or inside a `... on SomeType { }` ' + 'spread  - then the fragment reference will not exist. ' + 'In this case, pass `null` if the conditions for evaluating the ' + 'fragment are not met (e.g. if the `@include(if)` value is false.)', fragmentNode.name, fragmentNode.name, hookDisplayName, fragmentNode.name, hookDisplayName) : invariant(false) : void 0;
   var environment = useRelayEnvironment();
   var _useState = useState(function () {
       return getFragmentState(environment, fragmentSelector);
@@ -321,14 +310,9 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
     _state = _useState[0],
     setState = _useState[1];
   var state = _state;
-
-  // This copy of the state we only update when something requires us to
-  // unsubscribe and re-subscribe, namely a changed environment or
-  // fragment selector.
   var _useState2 = useState(state),
     _subscribedState = _useState2[0],
     setSubscribedState = _useState2[1];
-  // FIXME since this is used as an effect dependency, it needs to be memoized.
   var subscribedState = _subscribedState;
   var _useState3 = useState(fragmentSelector),
     previousFragmentSelector = _useState3[0],
@@ -337,40 +321,21 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
     previousEnvironment = _useState4[0],
     setPreviousEnvironment = _useState4[1];
   if (!areEqualSelectors(fragmentSelector, previousFragmentSelector) || environment !== previousEnvironment) {
-    // Enqueue setState to record the new selector and state
     setPreviousFragmentSelector(fragmentSelector);
     setPreviousEnvironment(environment);
     var newState = getFragmentState(environment, fragmentSelector);
     setState(newState);
-    setSubscribedState(newState); // This causes us to form a new subscription
-    // But render with the latest state w/o waiting for the setState. Otherwise
-    // the component would render the wrong information temporarily (including
-    // possibly incorrectly triggering some warnings below).
+    setSubscribedState(newState);
     state = newState;
     subscribedState = newState;
   }
-
-  // The purpose of this is to detect whether we have ever committed, because we
-  // don't suspend on store updates, only when the component either is first trying
-  // to mount or when the our selector changes. The selector change in particular is
-  // how we suspend for pagination and refetech. Also, fragment selector can be null
-  // or undefined, so we use false as a special value to distinguish from all fragment
-  // selectors; false means that the component hasn't mounted yet.
   var committedFragmentSelectorRef = useRef(false);
   useEffect(function () {
     committedFragmentSelectorRef.current = fragmentSelector;
   }, [fragmentSelector]);
-
-  // Handle the queries for any missing client edges; this may suspend.
-  // FIXME handle client edges in parallel.
   if (((_fragmentNode$metadat2 = fragmentNode.metadata) === null || _fragmentNode$metadat2 === void 0 ? void 0 : _fragmentNode$metadat2.hasClientEdges) === true) {
-    // The fragment is validated to be static (in useFragment) and hasClientEdges is
-    // a static (constant) property of the fragment. In practice, this effect will
-    // always or never run for a given invocation of this hook.
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     var clientEdgeQueries = useMemo(function () {
       var missingClientEdges = getMissingClientEdges(state);
-      // eslint-disable-next-line no-shadow
       var clientEdgeQueries;
       if (missingClientEdges !== null && missingClientEdges !== void 0 && missingClientEdges.length) {
         clientEdgeQueries = [];
@@ -389,9 +354,6 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
       }
       return clientEdgeQueries;
     }, [state, environment, fragmentNode, fragmentRef, queryOptions]);
-
-    // See above note
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(function () {
       var QueryResource = getQueryResourceForEnvironment(environment);
       if (clientEdgeQueries !== null && clientEdgeQueries !== void 0 && clientEdgeQueries.length) {
@@ -426,19 +388,13 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
     }, [environment, clientEdgeQueries]);
   }
   if (isMissingData(state)) {
-    // Suspend if a Live Resolver within this fragment is in a suspended state:
     var suspendingLiveResolvers = getSuspendingLiveResolver(state);
     if (suspendingLiveResolvers != null && suspendingLiveResolvers.length > 0) {
       throw Promise.all(suspendingLiveResolvers.map(function (_ref) {
         var liveStateID = _ref.liveStateID;
-        // $FlowFixMe[prop-missing] This is expected to be a LiveResolverStore
         return environment.getStore().getLiveResolverPromise(liveStateID);
       }));
     }
-    // Suspend if an active operation bears on this fragment, either the
-    // fragment's owner or some other mutation etc. that could affect it.
-    // We only suspend when the component is first trying to mount or changing
-    // selectors, not if data becomes missing later:
     if (!committedFragmentSelectorRef.current || !areEqualSelectors(committedFragmentSelectorRef.current, fragmentSelector)) {
       !(fragmentSelector != null) ? process.env.NODE_ENV !== "production" ? invariant(false, 'refinement, see invariants above') : invariant(false) : void 0;
       var fragmentOwner = fragmentSelector.kind === 'PluralReaderSelector' ? fragmentSelector.selectors[0].owner : fragmentSelector.owner;
@@ -447,24 +403,14 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
         throw pendingOperationsResult.promise;
       }
     }
-    // Report required fields only if we're not suspending, since that means
-    // they're missing even though we are out of options for possibly fetching them:
-    handlePotentialSnapshotErrorsForState(environment, state);
   }
+  handlePotentialSnapshotErrorsForState(environment, state);
   useEffect(function () {
-    // Check for updates since the state was rendered
     var currentState = subscribedState;
     var updates = handleMissedUpdates(environment, subscribedState);
     if (updates !== null) {
       var didMissUpdates = updates[0],
         updatedState = updates[1];
-      // TODO: didMissUpdates only checks for changes to snapshot data, but it's possible
-      // that other snapshot properties may have changed that should also trigger a re-render,
-      // such as changed missing resolver fields, missing client edges, etc.
-      // A potential alternative is for handleMissedUpdates() to recycle the entire state
-      // value, and return the new (recycled) state only if there was some change. In that
-      // case the code would always setState if something in the snapshot changed, in addition
-      // to using the latest snapshot to subscribe.
       if (didMissUpdates) {
         setState(updatedState);
       }
@@ -474,17 +420,9 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
   }, [environment, subscribedState]);
   var data;
   if (isPlural) {
-    // Plural fragments require allocating an array of the snasphot data values,
-    // which has to be memoized to avoid triggering downstream re-renders.
-    //
-    // Note that isPlural is a constant property of the fragment and does not change
-    // for a particular useFragment invocation site
-    var fragmentRefIsNullish = fragmentRef == null; // for less sensitive memoization
-    // eslint-disable-next-line react-hooks/rules-of-hooks
+    var fragmentRefIsNullish = fragmentRef == null;
     data = useMemo(function () {
       if (state.kind === 'bailout') {
-        // Bailout state can happen if the fragmentRef is a plural array that is empty or has no
-        // non-null entries. In that case, the compatible behavior is to return [] instead of null.
         return fragmentRefIsNullish ? null : [];
       } else {
         !(state.kind === 'plural') ? process.env.NODE_ENV !== "production" ? invariant(false, 'Expected state to be plural because fragment is plural') : invariant(false) : void 0;
@@ -494,14 +432,12 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
       }
     }, [state, fragmentRefIsNullish]);
   } else if (state.kind === 'bailout') {
-    // This case doesn't allocate a new object so it doesn't have to be memoized
     data = null;
   } else {
-    // This case doesn't allocate a new object so it doesn't have to be memoized
     !(state.kind === 'singular') ? process.env.NODE_ENV !== "production" ? invariant(false, 'Expected state to be singular because fragment is singular') : invariant(false) : void 0;
     data = state.snapshot.data;
   }
-  if (process.env.NODE_ENV !== "production") {
+  if (RelayFeatureFlags.LOG_MISSING_RECORDS_IN_PROD || process.env.NODE_ENV !== "production") {
     if (fragmentRef != null && (data === undefined || Array.isArray(data) && data.length > 0 && data.every(function (d) {
       return d === undefined;
     }))) {
@@ -509,7 +445,6 @@ function useFragmentInternal_REACT_CACHE(fragmentNode, fragmentRef, hookDisplayN
     }
   }
   if (process.env.NODE_ENV !== "production") {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useDebugValue({
       fragment: fragmentNode.name,
       data: data

package/lib/relay-hooks/react-cache/useFragment_REACT_CACHE.js

@@ -1,14 +1,3 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- * @oncall relay
- */
-
 'use strict';
 
 var _require = require('../loadQuery'),
@@ -20,17 +9,13 @@ var _require2 = require('react'),
 var _require3 = require('relay-runtime'),
   getFragment = _require3.getFragment;
 function useFragment(fragment, key) {
-  // We need to use this hook in order to be able to track if
-  // loadQuery was called during render
   useTrackLoadQueryInRender();
   var fragmentNode = getFragment(fragment);
   if (process.env.NODE_ENV !== "production") {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useStaticFragmentNodeWarning(fragmentNode, 'first argument of useFragment()');
   }
   var data = useFragmentInternal(fragmentNode, key, 'useFragment()');
   if (process.env.NODE_ENV !== "production") {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useDebugValue({
       fragment: fragmentNode.name,
       data: data