react-relay 14.0.0 → 14.1.0

package/relay-hooks/react-cache/readFragmentInternal_REACT_CACHE.js.flow

@@ -0,0 +1,297 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @emails oncall+relay
+ * @format
+ */
+
+'use strict';
+
+import type {QueryResult} from '../QueryResource';
+import type {
+  CacheConfig,
+  FetchPolicy,
+  IEnvironment,
+  ReaderFragment,
+  ReaderSelector,
+  SelectorData,
+  Snapshot,
+} from 'relay-runtime';
+import type {MissingClientEdgeRequestInfo} from 'relay-runtime/store/RelayStoreTypes';
+
+const {getQueryResourceForEnvironment} = require('../QueryResource');
+const invariant = require('invariant');
+const {
+  __internal: {fetchQuery: fetchQueryInternal},
+  createOperationDescriptor,
+  getPendingOperationsForFragment,
+  getSelector,
+  getVariablesFromFragment,
+  handlePotentialSnapshotErrors,
+} = require('relay-runtime');
+const warning = require('warning');
+
+type FragmentQueryOptions = {
+  fetchPolicy?: FetchPolicy,
+  networkCacheConfig?: ?CacheConfig,
+};
+
+type FragmentState = $ReadOnly<
+  | {kind: 'bailout'}
+  | {kind: 'singular', snapshot: Snapshot, epoch: number}
+  | {kind: 'plural', snapshots: $ReadOnlyArray<Snapshot>, epoch: number},
+>;
+
+function isMissingData(state: FragmentState): boolean {
+  if (state.kind === 'bailout') {
+    return false;
+  } else if (state.kind === 'singular') {
+    return state.snapshot.isMissingData;
+  } else {
+    return state.snapshots.some(s => s.isMissingData);
+  }
+}
+
+function getMissingClientEdges(
+  state: FragmentState,
+): $ReadOnlyArray<MissingClientEdgeRequestInfo> | null {
+  if (state.kind === 'bailout') {
+    return null;
+  } else if (state.kind === 'singular') {
+    return state.snapshot.missingClientEdges ?? null;
+  } else {
+    let edges = null;
+    for (const snapshot of state.snapshots) {
+      if (snapshot.missingClientEdges) {
+        edges = edges ?? [];
+        for (const edge of snapshot.missingClientEdges) {
+          edges.push(edge);
+        }
+      }
+    }
+    return edges;
+  }
+}
+
+function handlePotentialSnapshotErrorsForState(
+  environment: IEnvironment,
+  state: FragmentState,
+): void {
+  if (state.kind === 'singular') {
+    handlePotentialSnapshotErrors(
+      environment,
+      state.snapshot.missingRequiredFields,
+      state.snapshot.relayResolverErrors,
+    );
+  } else if (state.kind === 'plural') {
+    for (const snapshot of state.snapshots) {
+      handlePotentialSnapshotErrors(
+        environment,
+        snapshot.missingRequiredFields,
+        snapshot.relayResolverErrors,
+      );
+    }
+  }
+}
+
+function handleMissingClientEdge(
+  environment: IEnvironment,
+  parentFragmentNode: ReaderFragment,
+  parentFragmentRef: mixed,
+  missingClientEdgeRequestInfo: MissingClientEdgeRequestInfo,
+  queryOptions?: FragmentQueryOptions,
+): QueryResult {
+  const originalVariables = getVariablesFromFragment(
+    parentFragmentNode,
+    parentFragmentRef,
+  );
+  const variables = {
+    ...originalVariables,
+    id: missingClientEdgeRequestInfo.clientEdgeDestinationID, // TODO should be a reserved name
+  };
+  const queryOperationDescriptor = createOperationDescriptor(
+    missingClientEdgeRequestInfo.request,
+    variables,
+    queryOptions?.networkCacheConfig,
+  );
+  // This may suspend. We don't need to do anything with the results; all we're
+  // doing here is started the query if needed and retaining and releasing it
+  // according to the component mount/suspense cycle; QueryResource
+  // already handles this by itself.
+  const QueryResource = getQueryResourceForEnvironment(environment);
+  return QueryResource.prepare(
+    queryOperationDescriptor,
+    fetchQueryInternal(environment, queryOperationDescriptor),
+    queryOptions?.fetchPolicy,
+  );
+}
+
+function getFragmentState(
+  environment: IEnvironment,
+  fragmentSelector: ?ReaderSelector,
+): FragmentState {
+  if (fragmentSelector == null) {
+    return {kind: 'bailout'};
+  } else if (fragmentSelector.kind === 'PluralReaderSelector') {
+    if (fragmentSelector.selectors.length === 0) {
+      return {kind: 'bailout'};
+    } else {
+      return {
+        kind: 'plural',
+        snapshots: fragmentSelector.selectors.map(s => environment.lookup(s)),
+        epoch: environment.getStore().getEpoch(),
+      };
+    }
+  } else {
+    return {
+      kind: 'singular',
+      snapshot: environment.lookup(fragmentSelector),
+      epoch: environment.getStore().getEpoch(),
+    };
+  }
+}
+
+// fragmentNode cannot change during the lifetime of the component, though fragmentRef may change.
+function readFragmentInternal_REACT_CACHE(
+  environment: IEnvironment,
+  fragmentNode: ReaderFragment,
+  fragmentRef: mixed,
+  hookDisplayName: string,
+  queryOptions?: FragmentQueryOptions,
+  fragmentKey?: string,
+): {
+  +data: ?SelectorData | Array<?SelectorData>,
+  +clientEdgeQueries: ?Array<QueryResult>,
+} {
+  const fragmentSelector = getSelector(fragmentNode, fragmentRef);
+  const isPlural = fragmentNode?.metadata?.plural === true;
+
+  if (isPlural) {
+    invariant(
+      fragmentRef == null || Array.isArray(fragmentRef),
+      'Relay: Expected fragment pointer%s for fragment `%s` to be ' +
+        'an array, instead got `%s`. Remove `@relay(plural: true)` ' +
+        'from fragment `%s` to allow the prop to be an object.',
+      fragmentKey != null ? ` for key \`${fragmentKey}\`` : '',
+      fragmentNode.name,
+      typeof fragmentRef,
+      fragmentNode.name,
+    );
+  } else {
+    invariant(
+      !Array.isArray(fragmentRef),
+      'Relay: Expected fragment pointer%s for fragment `%s` not to be ' +
+        'an array, instead got `%s`. Add `@relay(plural: true)` ' +
+        'to fragment `%s` to allow the prop to be an array.',
+      fragmentKey != null ? ` for key \`${fragmentKey}\`` : '',
+      fragmentNode.name,
+      typeof fragmentRef,
+      fragmentNode.name,
+    );
+  }
+  invariant(
+    fragmentRef == null ||
+      (isPlural && Array.isArray(fragmentRef) && fragmentRef.length === 0) ||
+      fragmentSelector != null,
+    'Relay: Expected to receive an object where `...%s` was spread, ' +
+      'but the fragment reference was not found`. This is most ' +
+      'likely the result of:\n' +
+      "- Forgetting to spread `%s` in `%s`'s parent's fragment.\n" +
+      '- Conditionally fetching `%s` but unconditionally passing %s prop ' +
+      'to `%s`. If the parent fragment only fetches the fragment conditionally ' +
+      '- with e.g. `@include`, `@skip`, or inside a `... on SomeType { }` ' +
+      'spread  - then the fragment reference will not exist. ' +
+      'In this case, pass `null` if the conditions for evaluating the ' +
+      'fragment are not met (e.g. if the `@include(if)` value is false.)',
+    fragmentNode.name,
+    fragmentNode.name,
+    hookDisplayName,
+    fragmentNode.name,
+    fragmentKey == null ? 'a fragment reference' : `the \`${fragmentKey}\``,
+    hookDisplayName,
+  );
+
+  const state = getFragmentState(environment, fragmentSelector);
+
+  // Handle the queries for any missing client edges; this may suspend.
+  // FIXME handle client edges in parallel.
+  let clientEdgeQueries = null;
+  if (fragmentNode.metadata?.hasClientEdges === true) {
+    const missingClientEdges = getMissingClientEdges(state);
+    if (missingClientEdges?.length) {
+      clientEdgeQueries = [];
+      for (const edge of missingClientEdges) {
+        clientEdgeQueries.push(
+          handleMissingClientEdge(
+            environment,
+            fragmentNode,
+            fragmentRef,
+            edge,
+            queryOptions,
+          ),
+        );
+      }
+    }
+  }
+
+  if (isMissingData(state)) {
+    // Suspend if an active operation bears on this fragment, either the
+    // fragment's owner or some other mutation etc. that could affect it:
+    invariant(fragmentSelector != null, 'refinement, see invariants above');
+    const fragmentOwner =
+      fragmentSelector.kind === 'PluralReaderSelector'
+        ? fragmentSelector.selectors[0].owner
+        : fragmentSelector.owner;
+    const pendingOperationsResult = getPendingOperationsForFragment(
+      environment,
+      fragmentNode,
+      fragmentOwner,
+    );
+    if (pendingOperationsResult) {
+      throw pendingOperationsResult.promise;
+    }
+    // Report required fields only if we're not suspending, since that means
+    // they're missing even though we are out of options for possibly fetching them:
+    handlePotentialSnapshotErrorsForState(environment, state);
+  }
+
+  let data: ?SelectorData | Array<?SelectorData>;
+  if (state.kind === 'bailout') {
+    data = isPlural ? [] : null;
+  } else if (state.kind === 'singular') {
+    data = state.snapshot.data;
+  } else {
+    data = state.snapshots.map(s => s.data);
+  }
+
+  if (__DEV__) {
+    if (
+      fragmentRef != null &&
+      (data === undefined ||
+        (Array.isArray(data) &&
+          data.length > 0 &&
+          data.every(d => d === undefined)))
+    ) {
+      warning(
+        false,
+        'Relay: Expected to have been able to read non-null data for ' +
+          'fragment `%s` declared in ' +
+          '`%s`, since fragment reference was non-null. ' +
+          "Make sure that that `%s`'s parent isn't " +
+          'holding on to and/or passing a fragment reference for data that ' +
+          'has been deleted.',
+        fragmentNode.name,
+        hookDisplayName,
+        hookDisplayName,
+      );
+    }
+  }
+
+  return {data, clientEdgeQueries};
+}
+
+module.exports = readFragmentInternal_REACT_CACHE;

package/relay-hooks/react-cache/useFragmentInternal_REACT_CACHE.js.flow

@@ -9,10 +9,9 @@
  * @format
  */
 
-// flowlint ambiguous-object-type:error
-
 'use strict';
 
+import type {QueryResult} from '../QueryResource';
 import type {
   CacheConfig,
   FetchPolicy,
@@ -22,13 +21,17 @@ import type {
   SelectorData,
   Snapshot,
 } from 'relay-runtime';
-import type {MissingClientEdgeRequestInfo} from 'relay-runtime/store/RelayStoreTypes';
+import type {
+  MissingClientEdgeRequestInfo,
+  MissingLiveResolverField,
+} from 'relay-runtime/store/RelayStoreTypes';
 
+const {getQueryResourceForEnvironment} = require('../QueryResource');
 const useRelayEnvironment = require('../useRelayEnvironment');
-const getQueryResultOrFetchQuery = require('./getQueryResultOrFetchQuery_REACT_CACHE');
 const invariant = require('invariant');
 const {useDebugValue, useEffect, useMemo, useRef, useState} = require('react');
 const {
+  __internal: {fetchQuery: fetchQueryInternal},
   areEqualSelectors,
   createOperationDescriptor,
   getPendingOperationsForFragment,
@@ -39,18 +42,17 @@ const {
 } = require('relay-runtime');
 const warning = require('warning');
 
-type FragmentQueryOptions = {|
+type FragmentQueryOptions = {
   fetchPolicy?: FetchPolicy,
   networkCacheConfig?: ?CacheConfig,
-|};
+};
 
 type FragmentState = $ReadOnly<
-  | {|kind: 'bailout'|}
-  | {|kind: 'singular', snapshot: Snapshot, epoch: number|}
-  | {|kind: 'plural', snapshots: $ReadOnlyArray<Snapshot>, epoch: number|},
+  | {kind: 'bailout'}
+  | {kind: 'singular', snapshot: Snapshot, epoch: number}
+  | {kind: 'plural', snapshots: $ReadOnlyArray<Snapshot>, epoch: number},
 >;
 
-type StateUpdater<T> = (T | (T => T)) => void;
 type StateUpdaterFunction<T> = ((T) => T) => void;
 
 function isMissingData(state: FragmentState): boolean {
@@ -84,6 +86,27 @@ function getMissingClientEdges(
   }
 }
 
+function getSuspendingLiveResolver(
+  state: FragmentState,
+): $ReadOnlyArray<MissingLiveResolverField> | null {
+  if (state.kind === 'bailout') {
+    return null;
+  } else if (state.kind === 'singular') {
+    return state.snapshot.missingLiveResolverFields ?? null;
+  } else {
+    let missingFields = null;
+    for (const snapshot of state.snapshots) {
+      if (snapshot.missingLiveResolverFields) {
+        missingFields = missingFields ?? [];
+        for (const edge of snapshot.missingLiveResolverFields) {
+          missingFields.push(edge);
+        }
+      }
+    }
+    return missingFields;
+  }
+}
+
 function handlePotentialSnapshotErrorsForState(
   environment: IEnvironment,
   state: FragmentState,
@@ -190,7 +213,7 @@ function handleMissingClientEdge(
   parentFragmentRef: mixed,
   missingClientEdgeRequestInfo: MissingClientEdgeRequestInfo,
   queryOptions?: FragmentQueryOptions,
-): () => () => void {
+): QueryResult {
   const originalVariables = getVariablesFromFragment(
     parentFragmentNode,
     parentFragmentRef,
@@ -206,16 +229,14 @@ function handleMissingClientEdge(
   );
   // This may suspend. We don't need to do anything with the results; all we're
   // doing here is started the query if needed and retaining and releasing it
-  // according to the component mount/suspense cycle; getQueryResultOrFetchQuery
+  // according to the component mount/suspense cycle; QueryResource
   // already handles this by itself.
-  const [_, effect] = getQueryResultOrFetchQuery(
-    environment,
+  const QueryResource = getQueryResourceForEnvironment(environment);
+  return QueryResource.prepare(
     queryOperationDescriptor,
-    {
-      fetchPolicy: queryOptions?.fetchPolicy,
-    },
+    fetchQueryInternal(environment, queryOperationDescriptor),
+    queryOptions?.fetchPolicy,
   );
-  return effect;
 }
 
 function subscribeToSnapshot(
@@ -227,11 +248,22 @@ function subscribeToSnapshot(
     return () => {};
   } else if (state.kind === 'singular') {
     const disposable = environment.subscribe(state.snapshot, latestSnapshot => {
-      setState(_ => ({
-        kind: 'singular',
-        snapshot: latestSnapshot,
-        epoch: environment.getStore().getEpoch(),
-      }));
+      setState(prevState => {
+        // In theory a setState from a subscription could be batched together
+        // with a setState to change the fragment selector. Guard against this
+        // by bailing out of the state update if the selector has changed.
+        if (
+          prevState.kind !== 'singular' ||
+          prevState.snapshot.selector !== latestSnapshot.selector
+        ) {
+          return prevState;
+        }
+        return {
+          kind: 'singular',
+          snapshot: latestSnapshot,
+          epoch: environment.getStore().getEpoch(),
+        };
+      });
     });
     return () => {
       disposable.dispose();
@@ -239,12 +271,17 @@ function subscribeToSnapshot(
   } else {
     const disposables = state.snapshots.map((snapshot, index) =>
       environment.subscribe(snapshot, latestSnapshot => {
-        setState(existing => {
-          invariant(
-            existing.kind === 'plural',
-            'Cannot go from singular to plural or from bailout to plural.',
-          );
-          const updated = [...existing.snapshots];
+        setState(prevState => {
+          // In theory a setState from a subscription could be batched together
+          // with a setState to change the fragment selector. Guard against this
+          // by bailing out of the state update if the selector has changed.
+          if (
+            prevState.kind !== 'plural' ||
+            prevState.snapshots[index]?.selector !== latestSnapshot.selector
+          ) {
+            return prevState;
+          }
+          const updated = [...prevState.snapshots];
           updated[index] = latestSnapshot;
           return {
             kind: 'plural',
@@ -265,11 +302,12 @@ function subscribeToSnapshot(
 function getFragmentState(
   environment: IEnvironment,
   fragmentSelector: ?ReaderSelector,
-  isPlural: boolean,
 ): FragmentState {
   if (fragmentSelector == null) {
     return {kind: 'bailout'};
   } else if (fragmentSelector.kind === 'PluralReaderSelector') {
+    // Note that if fragmentRef is an empty array, fragmentSelector will be null so we'll hit the above case.
+    // Null is returned by getSelector if fragmentRef has no non-null items.
     return {
       kind: 'plural',
       snapshots: fragmentSelector.selectors.map(s => environment.lookup(s)),
@@ -345,29 +383,17 @@ function useFragmentInternal_REACT_CACHE(
   );
 
   const environment = useRelayEnvironment();
-  const [rawState, setState] = useState<FragmentState>(() =>
-    getFragmentState(environment, fragmentSelector, isPlural),
+  const [_state, setState] = useState<FragmentState>(() =>
+    getFragmentState(environment, fragmentSelector),
   );
-  // On second look this separate rawState may not be needed at all, it can just be
-  // put into getFragmentState. Exception: can we properly handle the case where the
-  // fragmentRef goes from non-null to null?
-  const stateFromRawState = (state: FragmentState) => {
-    if (fragmentRef == null) {
-      return {kind: 'bailout'};
-    } else if (state.kind === 'plural' && state.snapshots.length === 0) {
-      return {kind: 'bailout'};
-    } else {
-      return state;
-    }
-  };
-  let state = stateFromRawState(rawState);
+  let state = _state;
 
   // This copy of the state we only update when something requires us to
   // unsubscribe and re-subscribe, namely a changed environment or
   // fragment selector.
-  const [rawSubscribedState, setSubscribedState] = useState(state);
+  const [_subscribedState, setSubscribedState] = useState(state);
   // FIXME since this is used as an effect dependency, it needs to be memoized.
-  let subscribedState = stateFromRawState(rawSubscribedState);
+  let subscribedState = _subscribedState;
 
   const [previousFragmentSelector, setPreviousFragmentSelector] =
     useState(fragmentSelector);
@@ -379,9 +405,7 @@ function useFragmentInternal_REACT_CACHE(
     // Enqueue setState to record the new selector and state
     setPreviousFragmentSelector(fragmentSelector);
     setPreviousEnvironment(environment);
-    const newState = stateFromRawState(
-      getFragmentState(environment, fragmentSelector, isPlural),
-    );
+    const newState = getFragmentState(environment, fragmentSelector);
     setState(newState);
     setSubscribedState(newState); // This causes us to form a new subscription
     // But render with the latest state w/o waiting for the setState. Otherwise
@@ -391,6 +415,17 @@ function useFragmentInternal_REACT_CACHE(
     subscribedState = newState;
   }
 
+  // The purpose of this is to detect whether we have ever committed, because we
+  // don't suspend on store updates, only when the component either is first trying
+  // to mount or when the our selector changes. The selector change in particular is
+  // how we suspend for pagination and refetech. Also, fragment selector can be null
+  // or undefined, so we use false as a special value to distinguish from all fragment
+  // selectors; false means that the component hasn't mounted yet.
+  const committedFragmentSelectorRef = useRef<false | ?ReaderSelector>(false);
+  useEffect(() => {
+    committedFragmentSelectorRef.current = fragmentSelector;
+  }, [fragmentSelector]);
+
   // Handle the queries for any missing client edges; this may suspend.
   // FIXME handle client edges in parallel.
   if (fragmentNode.metadata?.hasClientEdges === true) {
@@ -398,14 +433,14 @@ function useFragmentInternal_REACT_CACHE(
     // a static (constant) property of the fragment. In practice, this effect will
     // always or never run for a given invocation of this hook.
     // eslint-disable-next-line react-hooks/rules-of-hooks
-    const effects = useMemo(() => {
+    const clientEdgeQueries = useMemo(() => {
       const missingClientEdges = getMissingClientEdges(state);
       // eslint-disable-next-line no-shadow
-      let effects;
+      let clientEdgeQueries;
       if (missingClientEdges?.length) {
-        effects = [];
+        clientEdgeQueries = [];
         for (const edge of missingClientEdges) {
-          effects.push(
+          clientEdgeQueries.push(
             handleMissingClientEdge(
               environment,
               fragmentNode,
@@ -416,41 +451,59 @@ function useFragmentInternal_REACT_CACHE(
           );
         }
       }
-      return effects;
+      return clientEdgeQueries;
     }, [state, environment, fragmentNode, fragmentRef, queryOptions]);
 
     // See above note
     // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(() => {
-      if (effects?.length) {
-        const cleanups = [];
-        for (const effect of effects) {
-          cleanups.push(effect());
+      const QueryResource = getQueryResourceForEnvironment(environment);
+      if (clientEdgeQueries?.length) {
+        const disposables = [];
+        for (const query of clientEdgeQueries) {
+          disposables.push(QueryResource.retain(query));
         }
         return () => {
-          for (const cleanup of cleanups) {
-            cleanup();
+          for (const disposable of disposables) {
+            disposable.dispose();
           }
         };
       }
-    }, [effects]);
+    }, [environment, clientEdgeQueries]);
   }
 
   if (isMissingData(state)) {
+    // Suspend if a Live Resolver within this fragment is in a suspended state:
+    const suspendingLiveResolvers = getSuspendingLiveResolver(state);
+    if (suspendingLiveResolvers != null && suspendingLiveResolvers.length > 0) {
+      throw Promise.all(
+        suspendingLiveResolvers.map(({liveStateID}) => {
+          // $FlowFixMe[prop-missing] This is expected to be a LiveResolverStore
+          return environment.getStore().getLiveResolverPromise(liveStateID);
+        }),
+      );
+    }
     // Suspend if an active operation bears on this fragment, either the
-    // fragment's owner or some other mutation etc. that could affect it:
-    invariant(fragmentSelector != null, 'refinement, see invariants above');
-    const fragmentOwner =
-      fragmentSelector.kind === 'PluralReaderSelector'
-        ? fragmentSelector.selectors[0].owner
-        : fragmentSelector.owner;
-    const pendingOperationsResult = getPendingOperationsForFragment(
-      environment,
-      fragmentNode,
-      fragmentOwner,
-    );
-    if (pendingOperationsResult) {
-      throw pendingOperationsResult.promise;
+    // fragment's owner or some other mutation etc. that could affect it.
+    // We only suspend when the component is first trying to mount or changing
+    // selectors, not if data becomes missing later:
+    if (
+      !committedFragmentSelectorRef.current ||
+      !areEqualSelectors(committedFragmentSelectorRef.current, fragmentSelector)
+    ) {
+      invariant(fragmentSelector != null, 'refinement, see invariants above');
+      const fragmentOwner =
+        fragmentSelector.kind === 'PluralReaderSelector'
+          ? fragmentSelector.selectors[0].owner
+          : fragmentSelector.owner;
+      const pendingOperationsResult = getPendingOperationsForFragment(
+        environment,
+        fragmentNode,
+        fragmentOwner,
+      );
+      if (pendingOperationsResult) {
+        throw pendingOperationsResult.promise;
+      }
     }
     // Report required fields only if we're not suspending, since that means
     // they're missing even though we are out of options for possibly fetching them:
@@ -475,23 +528,7 @@ function useFragmentInternal_REACT_CACHE(
       }
       currentState = updatedState;
     }
-    return subscribeToSnapshot(environment, currentState, updater => {
-      setState(latestState => {
-        if (
-          latestState.snapshot?.selector !== currentState.snapshot?.selector
-        ) {
-          // Ignore updates to the subscription if it's for a previous fragment selector
-          // than the latest one to be rendered. This can happen if the store is updated
-          // after we re-render with a new fragmentRef prop but before the effect fires
-          // in which we unsubscribe to the old one and subscribe to the new one.
-          // (NB: it's safe to compare the selectors by reference because the selector
-          // is recycled into new snapshots.)
-          return latestState;
-        } else {
-          return updater(latestState);
-        }
-      });
-    });
+    return subscribeToSnapshot(environment, currentState, setState);
   }, [environment, subscribedState]);
 
   let data: ?SelectorData | Array<?SelectorData>;
@@ -501,10 +538,13 @@ function useFragmentInternal_REACT_CACHE(
     //
     // Note that isPlural is a constant property of the fragment and does not change
     // for a particular useFragment invocation site
+    const fragmentRefIsNullish = fragmentRef == null; // for less sensitive memoization
     // eslint-disable-next-line react-hooks/rules-of-hooks
     data = useMemo(() => {
       if (state.kind === 'bailout') {
-        return [];
+        // Bailout state can happen if the fragmentRef is a plural array that is empty or has no
+        // non-null entries. In that case, the compatible behavior is to return [] instead of null.
+        return fragmentRefIsNullish ? null : [];
       } else {
         invariant(
           state.kind === 'plural',
@@ -512,7 +552,7 @@ function useFragmentInternal_REACT_CACHE(
         );
         return state.snapshots.map(s => s.data);
       }
-    }, [state]);
+    }, [state, fragmentRefIsNullish]);
   } else if (state.kind === 'bailout') {
     // This case doesn't allocate a new object so it doesn't have to be memoized
     data = null;

package/relay-hooks/react-cache/useFragment_REACT_CACHE.js.flow

@@ -9,8 +9,6 @@
  * @format
  */
 
-// flowlint ambiguous-object-type:error
-
 'use strict';
 
 import type {Fragment, FragmentType, GraphQLTaggedNode} from 'relay-runtime';