react-on-rails-pro 16.3.0 → 16.4.0-rc.1

package/lib/CallbackRegistry.d.ts

@@ -10,6 +10,7 @@ export default class CallbackRegistry<T> {
     set(name: string, item: T): void;
     get(name: string): T;
     has(name: string): boolean;
+    getIfExists(name: string): T | undefined;
     clear(): void;
     getAll(): Map<string, T>;
     getOrWaitForItem(name: string): Promise<T>;

package/lib/CallbackRegistry.js

@@ -72,6 +72,9 @@ export default class CallbackRegistry {
     has(name) {
         return this.registeredItems.has(name);
     }
+    getIfExists(name) {
+        return this.registeredItems.get(name);
+    }
     clear() {
         this.registeredItems.clear();
         this.notUsedItems.clear();

package/lib/ComponentRegistry.js

@@ -20,13 +20,17 @@ const componentRegistry = new CallbackRegistry('component');
  */
 export function register(components) {
     Object.keys(components).forEach((name) => {
-        if (componentRegistry.has(name)) {
-            console.warn('Called register for component that is already registered', name);
-        }
         const component = components[name];
         if (!component) {
             throw new Error(`Called register with null component named ${name}`);
         }
+        // Reference comparison lets HMR re-register the same component silently
+        // while still catching bugs where different components share a name.
+        const existing = componentRegistry.getIfExists(name);
+        if (existing && existing.component !== component) {
+            console.error(`ReactOnRails: Component "${name}" was registered with a different component than previously. ` +
+                'This is likely a bug — ensure each component has a unique registration name.');
+        }
         const renderFunction = isRenderFunction(component);
         const isRenderer = renderFunction && component.length === 3;
         componentRegistry.set(name, {

package/lib/StoreRegistry.js

@@ -21,14 +21,18 @@ const hydratedStoreRegistry = new CallbackRegistry('hydrated store');
  */
 export function register(storeGenerators) {
     Object.keys(storeGenerators).forEach((name) => {
-        if (storeGeneratorRegistry.has(name)) {
-            console.warn('Called registerStore for store that is already registered', name);
-        }
         const storeGenerator = storeGenerators[name];
         if (!storeGenerator) {
             throw new Error('Called ReactOnRails.registerStoreGenerators with a null or undefined as a value ' +
                 `for the store generator with key ${name}.`);
         }
+        // Reference comparison lets HMR re-register the same store silently
+        // while still catching bugs where different stores share a name.
+        const existing = storeGeneratorRegistry.getIfExists(name);
+        if (existing && existing !== storeGenerator) {
+            console.error(`ReactOnRails: Store "${name}" was registered with a different store generator than previously. ` +
+                'This is likely a bug — ensure each store has a unique registration name.');
+        }
         storeGeneratorRegistry.set(name, storeGenerator);
     });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails-pro",
-  "version": "16.3.0",
+  "version": "16.4.0-rc.1",
   "description": "React on Rails Pro package with React Server Components support",
   "main": "lib/ReactOnRails.full.js",
   "type": "module",
@@ -43,7 +43,7 @@
     "./ServerComponentFetchError": "./lib/ServerComponentFetchError.js"
   },
   "dependencies": {
-    "react-on-rails": "16.3.0"
+    "react-on-rails": "16.4.0-rc.1"
   },
   "peerDependencies": {
     "react": ">= 16",
@@ -77,8 +77,6 @@
     "test": "pnpm run test:non-rsc && pnpm run test:rsc",
     "test:non-rsc": "jest tests --testPathIgnorePatterns=\".*(RSC|stream|registerServerComponent|serverRenderReactComponent|SuspenseHydration).*\"",
     "test:rsc": "node scripts/check-react-version.cjs || NODE_CONDITIONS=react-server jest tests/*.rsc.test.*",
-    "type-check": "tsc --noEmit --noErrorTruncation",
-    "yalc:publish": "yalc publish",
-    "yalc": "yalc"
+    "type-check": "tsc --noEmit --noErrorTruncation"
   }
 }