react-on-rails-pro-node-renderer 16.4.0 → 16.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-on-rails-pro-node-renderer",
-  "version": "16.4.0",
+  "version": "16.5.0",
   "protocolVersion": "2.0.0",
   "description": "React on Rails Pro Node Renderer for server-side rendering",
   "main": "lib/ReactOnRailsProNodeRenderer.js",
@@ -60,7 +60,7 @@
     "sentry-testkit": "^5.0.6",
     "touch": "^3.1.0",
     "typescript": "^5.4.3",
-    "react-on-rails": "16.4.0"
+    "react-on-rails": "16.5.0"
   },
   "peerDependencies": {
     "@honeybadger-io/js": ">=4.0.0",
@@ -95,7 +95,7 @@
   "bugs": {
     "url": "https://github.com/shakacode/react_on_rails/issues"
   },
-  "homepage": "https://github.com/shakacode/react_on_rails/tree/master/packages/react-on-rails-pro-node-renderer#readme",
+  "homepage": "https://github.com/shakacode/react_on_rails/tree/main/packages/react-on-rails-pro-node-renderer#readme",
   "jest": {
     "clearMocks": true,
     "moduleNameMapper": {

package/src/ReactOnRailsProNodeRenderer.ts

@@ -6,6 +6,16 @@ const { version: fastifyVersion } = fastifyPackageJson;
 import log from './shared/log.js';
 import { majorVersion } from './shared/utils.js';
 
+export function parseWorkersCount(value: string | null | undefined): number | null {
+  if (value == null) return null;
+  const normalized = value.trim();
+  if (normalized === '') return null;
+  const parsed = Number(normalized);
+  if (Number.isInteger(parsed) && parsed >= 0) return parsed;
+  console.warn(`[react-on-rails] Ignoring invalid worker count "${value}". Expected a non-negative integer.`);
+  return null;
+}
+
 export async function reactOnRailsProNodeRenderer(config: Partial<Config> = {}) {
   const fastify5Supported = majorVersion(process.versions.node) >= 20;
   const fastify5OrNewer = majorVersion(fastifyVersion) >= 5;

package/src/master.ts

@@ -31,17 +31,13 @@ export default function masterRun(runningConfig?: Partial<Config>) {
   if (status === 'valid') {
     log.info('[React on Rails Pro] License validated successfully.');
   } else if (status === 'missing') {
-    logLicenseIssue(
-      '[React on Rails Pro] No license found. Get a license at https://www.shakacode.com/react-on-rails-pro/',
-    );
+    logLicenseIssue('[React on Rails Pro] No license found. Get a license at https://pro.reactonrails.com/');
   } else if (status === 'expired') {
     logLicenseIssue(
-      '[React on Rails Pro] License has expired. Renew your license at https://www.shakacode.com/react-on-rails-pro/',
+      '[React on Rails Pro] License has expired. Renew your license at https://pro.reactonrails.com/',
     );
   } else {
-    logLicenseIssue(
-      '[React on Rails Pro] Invalid license. Get a license at https://www.shakacode.com/react-on-rails-pro/',
-    );
+    logLicenseIssue('[React on Rails Pro] Invalid license. Get a license at https://pro.reactonrails.com/');
   }
 
   // Store config in app state. From now it can be loaded by any module using getConfig():

package/src/shared/configBuilder.ts

@@ -70,13 +70,13 @@ export interface Config {
   gracefulWorkerRestartTimeout: number | undefined;
   // If the rendering request is longer than this, it will be truncated in exception and logging messages
   maxDebugSnippetLength: number;
-  // @deprecated See https://www.shakacode.com/react-on-rails-pro/docs/node-renderer/error-reporting-and-tracing.
+  // @deprecated See https://reactonrails.com/docs/building-features/node-renderer/error-reporting-and-tracing.
   honeybadgerApiKey?: string | null;
-  // @deprecated See https://www.shakacode.com/react-on-rails-pro/docs/node-renderer/error-reporting-and-tracing.
+  // @deprecated See https://reactonrails.com/docs/building-features/node-renderer/error-reporting-and-tracing.
   sentryDsn?: string | null;
-  // @deprecated See https://www.shakacode.com/react-on-rails-pro/docs/node-renderer/error-reporting-and-tracing.
+  // @deprecated See https://reactonrails.com/docs/building-features/node-renderer/error-reporting-and-tracing.
   sentryTracing?: boolean;
-  // @deprecated See https://www.shakacode.com/react-on-rails-pro/docs/node-renderer/error-reporting-and-tracing.
+  // @deprecated See https://reactonrails.com/docs/building-features/node-renderer/error-reporting-and-tracing.
   sentryTracesSampleRate?: string | number;
   // If true, `{set/clear}{Timeout/Interval/Immediate}` and `queueMicrotask` are stubbed out to do nothing.
   stubTimers: boolean;
@@ -305,7 +305,7 @@ export function buildConfig(providedUserConfig?: Partial<Config>): Config {
   ) {
     log.error(
       'honeybadgerApiKey, sentryDsn, sentryTracing, and sentryTracesSampleRate are not used since RoRP 4.0. ' +
-        'See https://www.shakacode.com/react-on-rails-pro/docs/node-renderer/error-reporting-and-tracing.',
+        'See https://reactonrails.com/docs/building-features/node-renderer/error-reporting-and-tracing.',
     );
     process.exit(1);
   }

package/tests/parseWorkersCount.test.ts

@@ -0,0 +1,31 @@
+import { parseWorkersCount } from '../src/ReactOnRailsProNodeRenderer';
+
+describe('parseWorkersCount', () => {
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  it('returns null for missing and blank values', () => {
+    expect(parseWorkersCount(undefined)).toBeNull();
+    expect(parseWorkersCount(null)).toBeNull();
+    expect(parseWorkersCount('')).toBeNull();
+    expect(parseWorkersCount('   ')).toBeNull();
+  });
+
+  it('parses non-negative integers', () => {
+    expect(parseWorkersCount('0')).toBe(0);
+    expect(parseWorkersCount('3')).toBe(3);
+    expect(parseWorkersCount(' 4 ')).toBe(4);
+  });
+
+  it('warns and returns null for invalid values', () => {
+    const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => undefined);
+
+    expect(parseWorkersCount('workers')).toBeNull();
+    expect(parseWorkersCount('3.5')).toBeNull();
+    expect(parseWorkersCount('-1')).toBeNull();
+
+    expect(warnSpy).toHaveBeenCalledTimes(3);
+    expect(warnSpy.mock.calls[0][0]).toContain('Ignoring invalid worker count');
+  });
+});