react-native 0.84.0-nightly-20251202-b0e754bc7 → 0.84.0-nightly-20251204-5bb3a6d68

package/ReactCommon/react/featureflags/ReactNativeFeatureFlagsAccessor.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<dad57f078e433b2fe7fc278f22a0acc9>>
+ * @generated SignedSource<<d6e559e0a0919d0de99a32b27646fbce>>
  */
 
 /**
@@ -35,7 +35,6 @@ class ReactNativeFeatureFlagsAccessor {
   bool commonTestFlag();
   bool cdpInteractionMetricsEnabled();
   bool cxxNativeAnimatedEnabled();
-  bool cxxNativeAnimatedRemoveJsSync();
   bool disableEarlyViewCommandExecution();
   bool disableImageViewPreallocationAndroid();
   bool disableMountItemReorderingAndroid();
@@ -133,12 +132,11 @@ class ReactNativeFeatureFlagsAccessor {
   std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
   bool wasOverridden_;
 
-  std::array<std::atomic<const char*>, 90> accessedFeatureFlags_;
+  std::array<std::atomic<const char*>, 89> accessedFeatureFlags_;
 
   std::atomic<std::optional<bool>> commonTestFlag_;
   std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
   std::atomic<std::optional<bool>> cxxNativeAnimatedEnabled_;
-  std::atomic<std::optional<bool>> cxxNativeAnimatedRemoveJsSync_;
   std::atomic<std::optional<bool>> disableEarlyViewCommandExecution_;
   std::atomic<std::optional<bool>> disableImageViewPreallocationAndroid_;
   std::atomic<std::optional<bool>> disableMountItemReorderingAndroid_;

package/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<5a2e55d5f195183e708dd802dcafcd47>>
+ * @generated SignedSource<<a220c6699baacba2e95d610314d90c67>>
  */
 
 /**
@@ -39,10 +39,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
     return false;
   }
 
-  bool cxxNativeAnimatedRemoveJsSync() override {
-    return false;
-  }
-
   bool disableEarlyViewCommandExecution() override {
     return false;
   }

package/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDynamicProvider.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<db573411b908b6d2ca5a8dad88866535>>
+ * @generated SignedSource<<eef5fb5ff9153cedd8a25b39af0cc49f>>
  */
 
 /**
@@ -72,15 +72,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
     return ReactNativeFeatureFlagsDefaults::cxxNativeAnimatedEnabled();
   }
 
-  bool cxxNativeAnimatedRemoveJsSync() override {
-    auto value = values_["cxxNativeAnimatedRemoveJsSync"];
-    if (!value.isNull()) {
-      return value.getBool();
-    }
-
-    return ReactNativeFeatureFlagsDefaults::cxxNativeAnimatedRemoveJsSync();
-  }
-
   bool disableEarlyViewCommandExecution() override {
     auto value = values_["disableEarlyViewCommandExecution"];
     if (!value.isNull()) {

package/ReactCommon/react/featureflags/ReactNativeFeatureFlagsProvider.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<f055563fdc2085f73eb43a28cd6749af>>
+ * @generated SignedSource<<8d8563ead19635c98fe335864aa1cad0>>
  */
 
 /**
@@ -28,7 +28,6 @@ class ReactNativeFeatureFlagsProvider {
   virtual bool commonTestFlag() = 0;
   virtual bool cdpInteractionMetricsEnabled() = 0;
   virtual bool cxxNativeAnimatedEnabled() = 0;
-  virtual bool cxxNativeAnimatedRemoveJsSync() = 0;
   virtual bool disableEarlyViewCommandExecution() = 0;
   virtual bool disableImageViewPreallocationAndroid() = 0;
   virtual bool disableMountItemReorderingAndroid() = 0;

package/ReactCommon/react/nativemodule/featureflags/NativeReactNativeFeatureFlags.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<3722cc54f167a5f107ae7d1ee611bc26>>
+ * @generated SignedSource<<0e0ea09b8aa2c9649042df278241be28>>
  */
 
 /**
@@ -59,11 +59,6 @@ bool NativeReactNativeFeatureFlags::cxxNativeAnimatedEnabled(
   return ReactNativeFeatureFlags::cxxNativeAnimatedEnabled();
 }
 
-bool NativeReactNativeFeatureFlags::cxxNativeAnimatedRemoveJsSync(
-    jsi::Runtime& /*runtime*/) {
-  return ReactNativeFeatureFlags::cxxNativeAnimatedRemoveJsSync();
-}
-
 bool NativeReactNativeFeatureFlags::disableEarlyViewCommandExecution(
     jsi::Runtime& /*runtime*/) {
   return ReactNativeFeatureFlags::disableEarlyViewCommandExecution();

package/ReactCommon/react/nativemodule/featureflags/NativeReactNativeFeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<a554f3307c6c06e771f56de187fbed93>>
+ * @generated SignedSource<<a9b91d43221aae62d3a6811867a72695>>
  */
 
 /**
@@ -42,8 +42,6 @@ class NativeReactNativeFeatureFlags
 
   bool cxxNativeAnimatedEnabled(jsi::Runtime& runtime);
 
-  bool cxxNativeAnimatedRemoveJsSync(jsi::Runtime& runtime);
-
   bool disableEarlyViewCommandExecution(jsi::Runtime& runtime);
 
   bool disableImageViewPreallocationAndroid(jsi::Runtime& runtime);

package/ReactCommon/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -764,9 +764,7 @@ bool NativeAnimatedNodesManager::onAnimationFrame(double timestamp) {
 
     if (driver->getIsComplete()) {
       hasFinishedAnimations = true;
-      if (ReactNativeFeatureFlags::cxxNativeAnimatedRemoveJsSync()) {
-        finishedAnimationValueNodes.insert(driver->getAnimatedValueTag());
-      }
+      finishedAnimationValueNodes.insert(driver->getAnimatedValueTag());
     }
   }
 
@@ -962,9 +960,7 @@ AnimationMutations NativeAnimatedNodesManager::pullAnimationMutations() {
 
         if (driver->getIsComplete()) {
           hasFinishedAnimations = true;
-          if (ReactNativeFeatureFlags::cxxNativeAnimatedRemoveJsSync()) {
-            finishedAnimationValueNodes.insert(driver->getAnimatedValueTag());
-          }
+          finishedAnimationValueNodes.insert(driver->getAnimatedValueTag());
         }
       }
 

package/ReactCommon/react/renderer/animationbackend/AnimatedPropSerializer.cpp

@@ -0,0 +1,130 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <stdexcept>
+#include "AnimatedPropsSerializer.h"
+
+namespace facebook::react {
+
+namespace {
+
+void packBorderRadiusCorner(
+    folly::dynamic& dyn,
+    const std::string& propName,
+    const std::optional<ValueUnit>& cornerValue) {
+  if (cornerValue.has_value()) {
+    dyn.insert(propName, cornerValue.value().value);
+  }
+}
+
+void packBorderRadii(
+    folly::dynamic& dyn,
+    const AnimatedPropBase& animatedProp) {
+  const auto& borderRadii = get<CascadedBorderRadii>(animatedProp);
+
+  packBorderRadiusCorner(dyn, "borderTopRightRadius", borderRadii.topRight);
+  packBorderRadiusCorner(dyn, "borderTopLeftRadius", borderRadii.topLeft);
+  packBorderRadiusCorner(
+      dyn, "borderBottomRightRadius", borderRadii.bottomRight);
+  packBorderRadiusCorner(dyn, "borderBottomLeftRadius", borderRadii.bottomLeft);
+  packBorderRadiusCorner(dyn, "borderTopStartRadius", borderRadii.topStart);
+  packBorderRadiusCorner(dyn, "borderTopEndRadius", borderRadii.topEnd);
+  packBorderRadiusCorner(
+      dyn, "borderBottomStartRadius", borderRadii.bottomStart);
+  packBorderRadiusCorner(dyn, "borderBottomEndRadius", borderRadii.bottomEnd);
+  packBorderRadiusCorner(dyn, "borderStartStartRadius", borderRadii.startStart);
+  packBorderRadiusCorner(dyn, "borderStartEndRadius", borderRadii.startEnd);
+  packBorderRadiusCorner(dyn, "borderEndStartRadius", borderRadii.endStart);
+  packBorderRadiusCorner(dyn, "borderEndEndRadius", borderRadii.endEnd);
+
+  if (borderRadii.all.has_value()) {
+    dyn.insert("borderRadius", borderRadii.all.value().value);
+  }
+}
+
+void packOpacity(folly::dynamic& dyn, const AnimatedPropBase& animatedProp) {
+  dyn.insert("opacity", get<Float>(animatedProp));
+}
+
+void packTransform(folly::dynamic& dyn, const AnimatedPropBase& animatedProp) {
+  const auto transform = get<Transform>(animatedProp);
+  const auto matrixArray = folly::dynamic::array(
+      transform.matrix[0],
+      transform.matrix[1],
+      transform.matrix[2],
+      transform.matrix[3],
+      transform.matrix[4],
+      transform.matrix[5],
+      transform.matrix[6],
+      transform.matrix[7],
+      transform.matrix[8],
+      transform.matrix[9],
+      transform.matrix[10],
+      transform.matrix[11],
+      transform.matrix[12],
+      transform.matrix[13],
+      transform.matrix[14],
+      transform.matrix[15]);
+  dyn.insert(
+      "transform",
+      folly::dynamic::array(folly::dynamic::object("matrix", matrixArray)));
+}
+
+void packBackgroundColor(
+    folly::dynamic& dyn,
+    const AnimatedPropBase& animatedProp) {
+  const auto& backgroundColor = get<SharedColor>(animatedProp);
+  if (backgroundColor) {
+    dyn.insert("backgroundColor", static_cast<int32_t>(*backgroundColor));
+  }
+}
+
+void packAnimatedProp(
+    folly::dynamic& dyn,
+    const std::unique_ptr<AnimatedPropBase>& animatedProp) {
+  switch (animatedProp->propName) {
+    case OPACITY:
+      packOpacity(dyn, *animatedProp);
+      break;
+
+    case TRANSFORM:
+      packTransform(dyn, *animatedProp);
+      break;
+
+    case BACKGROUND_COLOR:
+      packBackgroundColor(dyn, *animatedProp);
+      break;
+
+    case BORDER_RADII:
+      packBorderRadii(dyn, *animatedProp);
+      break;
+
+    case WIDTH:
+    case HEIGHT:
+    case FLEX:
+      throw std::runtime_error("Tried to synchronously update layout props");
+  }
+}
+
+} // namespace
+
+namespace animationbackend {
+
+folly::dynamic packAnimatedProps(const AnimatedProps& animatedProps) {
+  auto dyn = animatedProps.rawProps ? animatedProps.rawProps->toDynamic()
+                                    : folly::dynamic::object();
+
+  for (auto& animatedProp : animatedProps.props) {
+    packAnimatedProp(dyn, animatedProp);
+  }
+
+  return dyn;
+}
+
+} // namespace animationbackend
+
+} // namespace facebook::react

package/ReactCommon/react/renderer/animationbackend/AnimatedProps.h

@@ -12,7 +12,7 @@
 
 namespace facebook::react {
 
-enum PropName { OPACITY, WIDTH, HEIGHT, BORDER_RADII, FLEX, TRANSFORM };
+enum PropName { OPACITY, WIDTH, HEIGHT, BORDER_RADII, FLEX, TRANSFORM, BACKGROUND_COLOR };
 
 struct AnimatedPropBase {
   PropName propName;
@@ -70,6 +70,10 @@ inline void cloneProp(BaseViewProps &viewProps, const AnimatedPropBase &animated
     case TRANSFORM:
       viewProps.transform = get<Transform>(animatedProp);
       break;
+
+    case BACKGROUND_COLOR:
+      viewProps.backgroundColor = get<SharedColor>(animatedProp);
+      break;
   }
 }
 } // namespace facebook::react

package/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h

@@ -35,6 +35,10 @@ struct AnimatedPropsBuilder {
   {
     props.push_back(std::make_unique<AnimatedProp<Transform>>(TRANSFORM, std::move(t)));
   }
+  void setBackgroundColor(SharedColor value)
+  {
+    props.push_back(std::make_unique<AnimatedProp<SharedColor>>(BACKGROUND_COLOR, value));
+  }
   void storeDynamic(folly::dynamic &d)
   {
     rawProps = std::make_unique<RawProps>(std::move(d));

package/ReactCommon/react/renderer/animationbackend/AnimatedPropsSerializer.h

@@ -0,0 +1,17 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <folly/dynamic.h>
+#include "AnimatedProps.h"
+
+namespace facebook::react::animationbackend {
+
+folly::dynamic packAnimatedProps(const AnimatedProps &animatedProps);
+
+} // namespace facebook::react::animationbackend

package/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp

@@ -6,6 +6,8 @@
  */
 
 #include "AnimationBackend.h"
+#include <react/renderer/animationbackend/AnimatedPropsSerializer.h>
+#include <react/renderer/graphics/Color.h>
 #include <chrono>
 
 namespace facebook::react {
@@ -156,28 +158,10 @@ void AnimationBackend::commitUpdates(
 void AnimationBackend::synchronouslyUpdateProps(
     const std::unordered_map<Tag, AnimatedProps>& updates) {
   for (auto& [tag, animatedProps] : updates) {
-    auto dyn = animatedProps.rawProps ? animatedProps.rawProps->toDynamic()
-                                      : folly::dynamic::object();
-    for (auto& animatedProp : animatedProps.props) {
-      // TODO: We shouldn't repack it into dynamic, but for that a rewrite of
-      // directManipulationCallback_ is needed
-      switch (animatedProp->propName) {
-        case OPACITY:
-          dyn.insert("opacity", get<Float>(animatedProp));
-          break;
-
-        case BORDER_RADII:
-        case TRANSFORM:
-          // TODO: handle other things than opacity
-          break;
-
-        case WIDTH:
-        case HEIGHT:
-        case FLEX:
-          throw "Tried to synchronously update layout props";
-      }
-    }
-    directManipulationCallback_(tag, dyn);
+    // TODO: We shouldn't repack it into dynamic, but for that a rewrite of
+    // directManipulationCallback_ is needed
+    auto dyn = animationbackend::packAnimatedProps(animatedProps);
+    directManipulationCallback_(tag, std::move(dyn));
   }
 }
 

package/ReactCommon/react/runtime/ReactInstance.cpp

@@ -15,7 +15,7 @@
 #include <cxxreact/TraceSection.h>
 #include <glog/logging.h>
 #include <jsi/JSIDynamic.h>
-#include <jsi/hermes.h>
+#include <jsi/hermes-interfaces.h>
 #include <jsi/instrumentation.h>
 #include <jsinspector-modern/HostTarget.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native",
-  "version": "0.84.0-nightly-20251202-b0e754bc7",
+  "version": "0.84.0-nightly-20251204-5bb3a6d68",
   "description": "A framework for building native apps using React",
   "license": "MIT",
   "repository": {
@@ -160,13 +160,13 @@
   },
   "dependencies": {
     "@jest/create-cache-key-function": "^29.7.0",
-    "@react-native/assets-registry": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/codegen": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/community-cli-plugin": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/gradle-plugin": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/js-polyfills": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/normalize-colors": "0.84.0-nightly-20251202-b0e754bc7",
-    "@react-native/virtualized-lists": "0.84.0-nightly-20251202-b0e754bc7",
+    "@react-native/assets-registry": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/codegen": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/community-cli-plugin": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/gradle-plugin": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/js-polyfills": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/normalize-colors": "0.84.0-nightly-20251204-5bb3a6d68",
+    "@react-native/virtualized-lists": "0.84.0-nightly-20251204-5bb3a6d68",
     "abort-controller": "^3.0.0",
     "anser": "^1.4.9",
     "ansi-regex": "^5.0.0",
@@ -175,8 +175,7 @@
     "base64-js": "^1.5.1",
     "commander": "^12.0.0",
     "flow-enums-runtime": "^0.0.6",
-    "glob": "^7.1.1",
-    "hermes-compiler": "0.14.0-commitly-202511181844-5b560d093",
+    "hermes-compiler": "0.14.0-commitly-202512030604-3713fb12a",
     "invariant": "^2.2.4",
     "jest-environment-node": "^29.7.0",
     "memoize-one": "^5.0.0",
@@ -191,6 +190,7 @@
     "scheduler": "0.27.0",
     "semver": "^7.1.3",
     "stacktrace-parser": "^0.1.10",
+    "tinyglobby": "^0.2.15",
     "whatwg-fetch": "^3.0.0",
     "ws": "^7.5.10",
     "yargs": "^17.6.2"

package/scripts/codegen/generate-artifacts-executor/generateSchemaInfos.js

@@ -13,8 +13,8 @@
 const CodegenUtils = require('../codegen-utils');
 const {codegenLog} = require('./utils');
 const fs = require('fs');
-const glob = require('glob');
 const path = require('path');
+const {globSync} = require('tinyglobby');
 
 function generateSchemaInfos(
   libraries /*: $ReadOnlyArray<$FlowFixMe> */,
@@ -57,17 +57,18 @@ function extractSupportedApplePlatforms(
   dependencyPath /*: string */,
 ) /*: ?{[string]: boolean} */ {
   codegenLog('Searching for podspec in the project dependencies.', true);
-  const podspecs = glob.sync('*.podspec', {cwd: dependencyPath});
+  const podspecs = globSync('*.podspec', {
+    cwd: dependencyPath,
+    onlyFiles: true,
+    absolute: true,
+  });
 
   if (podspecs.length === 0) {
     return;
   }
 
   // Take the first podspec found
-  const podspec = fs.readFileSync(
-    path.join(dependencyPath, podspecs[0]),
-    'utf8',
-  );
+  const podspec = fs.readFileSync(podspecs[0], 'utf8');
 
   /**
    * Podspec can have platforms defined in two ways:

package/sdks/hermes-engine/version.properties

@@ -1,2 +1,2 @@
-HERMES_VERSION_NAME=0.14.0-commitly-202511181844-5b560d093
+HERMES_VERSION_NAME=0.14.0-commitly-202512030604-3713fb12a
 HERMES_V1_VERSION_NAME=250829098.0.4

package/src/private/animated/createAnimatedPropsHook.js

@@ -136,8 +136,7 @@ export default function createAnimatedPropsHook(
             // Check 2: this is an animation driven by native.
             // In native driven animations, this callback is only called once the animation completes.
             const shouldRemoveJsSync =
-              ReactNativeFeatureFlags.cxxNativeAnimatedEnabled() &&
-              ReactNativeFeatureFlags.cxxNativeAnimatedRemoveJsSync();
+              ReactNativeFeatureFlags.cxxNativeAnimatedEnabled();
             if (isFabricNode && !shouldRemoveJsSync) {
               // Call `scheduleUpdate` to synchronise Fiber and Shadow tree.
               // Must not be called in Paper.

package/src/private/featureflags/ReactNativeFeatureFlags.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ea0d60a91e71cf1053b02e06f4d283d3>>
+ * @generated SignedSource<<1732204fe9acf34158e7f9e4aec04161>>
  * @flow strict
  * @noformat
  */
@@ -54,7 +54,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
   commonTestFlagWithoutNativeImplementation: Getter<boolean>,
   cdpInteractionMetricsEnabled: Getter<boolean>,
   cxxNativeAnimatedEnabled: Getter<boolean>,
-  cxxNativeAnimatedRemoveJsSync: Getter<boolean>,
   disableEarlyViewCommandExecution: Getter<boolean>,
   disableImageViewPreallocationAndroid: Getter<boolean>,
   disableMountItemReorderingAndroid: Getter<boolean>,
@@ -239,10 +238,6 @@ export const cdpInteractionMetricsEnabled: Getter<boolean> = createNativeFlagGet
  * Use a C++ implementation of Native Animated instead of the platform implementation.
  */
 export const cxxNativeAnimatedEnabled: Getter<boolean> = createNativeFlagGetter('cxxNativeAnimatedEnabled', false);
-/**
- * Removes JS sync at end of native animation
- */
-export const cxxNativeAnimatedRemoveJsSync: Getter<boolean> = createNativeFlagGetter('cxxNativeAnimatedRemoveJsSync', false);
 /**
  * Dispatch view commands in mount item order.
  */

package/src/private/featureflags/specs/NativeReactNativeFeatureFlags.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<755ab323ad2d8bb64d0030c9e77ebfeb>>
+ * @generated SignedSource<<2604998265d9aa6a9b50d78502aa8d10>>
  * @flow strict
  * @noformat
  */
@@ -28,7 +28,6 @@ export interface Spec extends TurboModule {
   +commonTestFlagWithoutNativeImplementation?: () => boolean;
   +cdpInteractionMetricsEnabled?: () => boolean;
   +cxxNativeAnimatedEnabled?: () => boolean;
-  +cxxNativeAnimatedRemoveJsSync?: () => boolean;
   +disableEarlyViewCommandExecution?: () => boolean;
   +disableImageViewPreallocationAndroid?: () => boolean;
   +disableMountItemReorderingAndroid?: () => boolean;