react-native 0.84.0-nightly-20251115-e08abbcb9 → 0.84.0-nightly-20251116-d52b9d2f8

package/Libraries/Core/ReactNativeVersion.js

@@ -29,7 +29,7 @@ export default class ReactNativeVersion {
   static major: number = 0;
   static minor: number = 84;
   static patch: number = 0;
-  static prerelease: string | null = 'nightly-20251115-e08abbcb9';
+  static prerelease: string | null = 'nightly-20251116-d52b9d2f8';
 
   static getVersionString(): string {
     return `${this.major}.${this.minor}.${this.patch}${this.prerelease != null ? `-${this.prerelease}` : ''}`;

package/React/Base/RCTVersion.m

@@ -24,7 +24,7 @@ NSDictionary* RCTGetReactNativeVersion(void)
                   RCTVersionMajor: @(0),
                   RCTVersionMinor: @(84),
                   RCTVersionPatch: @(0),
-                  RCTVersionPrerelease: @"nightly-20251115-e08abbcb9",
+                  RCTVersionPrerelease: @"nightly-20251116-d52b9d2f8",
                   };
   });
   return __rnVersion;

package/ReactAndroid/gradle.properties

@@ -1,4 +1,4 @@
-VERSION_NAME=0.84.0-nightly-20251115-e08abbcb9
+VERSION_NAME=0.84.0-nightly-20251116-d52b9d2f8
 react.internal.publishingGroup=com.facebook.react
 react.internal.hermesPublishingGroup=com.facebook.hermes
 

package/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt

@@ -15,6 +15,6 @@ public object ReactNativeVersion {
     "major" to 0,
     "minor" to 84,
     "patch" to 0,
-    "prerelease" to "nightly-20251115-e08abbcb9"
+    "prerelease" to "nightly-20251116-d52b9d2f8"
   )
 }

package/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -22,7 +22,7 @@ constexpr struct {
   int32_t Major = 0;
   int32_t Minor = 84;
   int32_t Patch = 0;
-  std::string_view Prerelease = "nightly-20251115-e08abbcb9";
+  std::string_view Prerelease = "nightly-20251116-d52b9d2f8";
 } ReactNativeVersion;
 
 } // namespace facebook::react

package/ReactCommon/jsi/jsi/jsi.h

@@ -252,6 +252,12 @@ class JSI_EXPORT NativeState {
   virtual ~NativeState();
 };
 
+// JSI_UNSTABLE gates features that will be released with a Hermes version in
+// the future. Until released, these features may be subject to change. After
+// release, these features will be moved out of JSI_UNSTABLE and become frozen.
+#ifdef JSI_UNSTABLE
+#endif // JSI_UNSTABLE
+
 /// Represents a JS runtime.  Movable, but not copyable.  Note that
 /// this object may not be thread-aware, but cannot be used safely from
 /// multiple threads at once.  The application is responsible for

package/ReactCommon/jsinspector-modern/tracing/TracingCategory.h

@@ -16,11 +16,12 @@
 namespace facebook::react::jsinspector_modern::tracing {
 
 enum class Category {
-  HiddenTimeline, /*     disabled-by-default-devtools.timeline */
-  JavaScriptSampling, /* disabled-by-default-v8.cpu_profiler   */
-  RuntimeExecution, /*   v8.execute                            */
-  Timeline, /*           devtools.timeline                     */
-  UserTiming, /*         blink.user_timing                     */
+  HiddenTimeline, /*     disabled-by-default-devtools.timeline    */
+  JavaScriptSampling, /* disabled-by-default-v8.cpu_profiler      */
+  RuntimeExecution, /*   v8.execute                               */
+  Timeline, /*           devtools.timeline                        */
+  UserTiming, /*         blink.user_timing                        */
+  Screenshot, /*         disabled-by-default-devtools.screenshot  */
 };
 
 inline std::string tracingCategoryToString(const Category &category)
@@ -36,6 +37,8 @@ inline std::string tracingCategoryToString(const Category &category)
       return "disabled-by-default-v8.cpu_profiler";
     case Category::RuntimeExecution:
       return "v8.execute";
+    case Category::Screenshot:
+      return "disabled-by-default-devtools.screenshot";
   }
 }
 
@@ -51,6 +54,8 @@ inline std::optional<Category> getTracingCategoryFromString(const std::string &s
     return Category::JavaScriptSampling;
   } else if (str == "v8.execute") {
     return Category::RuntimeExecution;
+  } else if (str == "disabled-by-default-devtools.screenshot") {
+    return Category::RuntimeExecution;
   } else {
     return std::nullopt;
   }

package/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h

@@ -38,7 +38,6 @@ enum TurboModuleMethodValueKind {
  */
 TurboModuleMethodValueKind getTurboModuleMethodValueKind(jsi::Runtime &rt, const jsi::Value *value);
 
-class TurboCxxModule;
 class TurboModuleBinding;
 
 /**

package/ReactCommon/react/renderer/components/image/ImageProps.cpp

@@ -98,7 +98,7 @@ ImageProps::ImageProps(
                     rawProps,
                     "resizeMethod",
                     sourceProps.resizeMethod,
-                    {})),
+                    {"auto"})),
       resizeMultiplier(
           ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
               ? sourceProps.resizeMultiplier
@@ -107,7 +107,7 @@ ImageProps::ImageProps(
                     rawProps,
                     "resizeMultiplier",
                     sourceProps.resizeMultiplier,
-                    {})),
+                    1)),
       shouldNotifyLoadEvents(
           ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
               ? sourceProps.shouldNotifyLoadEvents

package/ReactCommon/react/renderer/components/image/ImageProps.h

@@ -33,8 +33,8 @@ class ImageProps final : public ViewProps {
   EdgeInsets capInsets{};
   SharedColor tintColor{};
   std::string internal_analyticTag{};
-  std::string resizeMethod{};
-  Float resizeMultiplier{};
+  std::string resizeMethod{"auto"};
+  Float resizeMultiplier{1.f};
   bool shouldNotifyLoadEvents{};
   SharedColor overlayColor{};
   Float fadeDuration{};

package/ReactCommon/react/renderer/components/image/ImageShadowNode.cpp

@@ -65,7 +65,12 @@ void ImageShadowNode::updateStateIfNeeded() {
       imageProps.fadeDuration,
       imageProps.progressiveRenderingEnabled,
       imageProps.loadingIndicatorSource,
-      imageProps.internal_analyticTag
+      imageProps.internal_analyticTag,
+      Size{
+          .width =
+              layoutMetrics_.frame.size.width * layoutMetrics_.pointScaleFactor,
+          .height = layoutMetrics_.frame.size.height *
+              layoutMetrics_.pointScaleFactor}
 #endif
   );
 
@@ -85,7 +90,9 @@ void ImageShadowNode::updateStateIfNeeded() {
          (uri.starts_with("content://") || uri.starts_with("file://")));
     // If we would resize but have no dimensions, skip creating the request
     if (shouldResize &&
-        (newImageSource.size.width == 0 || newImageSource.size.height == 0)) {
+        (newImageSource.size.width == 0 || newImageSource.size.height == 0 ||
+         layoutMetrics_.frame.size.width == 0 ||
+         layoutMetrics_.frame.size.height == 0)) {
       // Keep the old state - don't create a new image request
       return;
     }

package/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageRequestParams.h

@@ -30,7 +30,8 @@ class ImageRequestParams {
       Float fadeDuration,
       bool progressiveRenderingEnabled,
       ImageSource loadingIndicatorSource,
-      std::string analyticTag)
+      std::string analyticTag,
+      Size size)
       : blurRadius(blurRadius),
         defaultSource(std::move(defaultSource)),
         resizeMode(resizeMode),
@@ -42,7 +43,8 @@ class ImageRequestParams {
         fadeDuration(fadeDuration),
         progressiveRenderingEnabled(progressiveRenderingEnabled),
         loadingIndicatorSource(std::move(loadingIndicatorSource)),
-        analyticTag(std::move(analyticTag))
+        analyticTag(std::move(analyticTag)),
+        size(size)
   {
   }
 
@@ -58,6 +60,7 @@ class ImageRequestParams {
   bool progressiveRenderingEnabled{};
   ImageSource loadingIndicatorSource{};
   std::string analyticTag{};
+  Size size{};
 
   bool operator==(const ImageRequestParams &rhs) const
   {
@@ -73,7 +76,8 @@ class ImageRequestParams {
                this->fadeDuration,
                this->progressiveRenderingEnabled,
                this->loadingIndicatorSource,
-               this->analyticTag) ==
+               this->analyticTag,
+               this->size) ==
         std::tie(
                rhs.blurRadius,
                rhs.defaultSource,
@@ -86,7 +90,8 @@ class ImageRequestParams {
                rhs.fadeDuration,
                rhs.progressiveRenderingEnabled,
                rhs.loadingIndicatorSource,
-               rhs.analyticTag);
+               rhs.analyticTag,
+               rhs.size);
   }
 
   bool operator!=(const ImageRequestParams &rhs) const

package/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/conversions.h

@@ -24,8 +24,8 @@ constexpr MapBuffer::Key IS_KEY_DEFAULT_SRC = 1;
 constexpr MapBuffer::Key IS_KEY_RESIZE_MODE = 2;
 constexpr MapBuffer::Key IS_KEY_RESIZE_METHOD = 3;
 constexpr MapBuffer::Key IS_KEY_BLUR_RADIUS = 4;
-constexpr MapBuffer::Key IS_KEY_VIEW_WIDTH = 5;
-constexpr MapBuffer::Key IS_KEY_VIEW_HEIGHT = 6;
+constexpr MapBuffer::Key IS_KEY_IMAGE_WIDTH = 5;
+constexpr MapBuffer::Key IS_KEY_IMAGE_HEIGHT = 6;
 constexpr MapBuffer::Key IS_KEY_RESIZE_MULTIPLIER = 7;
 constexpr MapBuffer::Key IS_KEY_SHOULD_NOTIFY_LOAD_EVENTS = 8;
 constexpr MapBuffer::Key IS_KEY_OVERLAY_COLOR = 9;
@@ -35,16 +35,20 @@ constexpr MapBuffer::Key IS_KEY_PROGRESSIVE_RENDERING_ENABLED = 12;
 constexpr MapBuffer::Key IS_KEY_LOADING_INDICATOR_SRC = 13;
 constexpr MapBuffer::Key IS_KEY_ANALYTIC_TAG = 14;
 constexpr MapBuffer::Key IS_KEY_TAG = 15;
+constexpr MapBuffer::Key IS_KEY_VIEW_WIDTH = 16;
+constexpr MapBuffer::Key IS_KEY_VIEW_HEIGHT = 17;
 
 inline void serializeImageSource(MapBufferBuilder &builder, const ImageSource &imageSource)
 {
   builder.putString(IS_KEY_URI, imageSource.uri);
-  builder.putInt(IS_KEY_VIEW_WIDTH, static_cast<int32_t>(imageSource.size.width));
-  builder.putInt(IS_KEY_VIEW_HEIGHT, static_cast<int32_t>(imageSource.size.height));
+  builder.putInt(IS_KEY_IMAGE_WIDTH, static_cast<int32_t>(imageSource.size.width));
+  builder.putInt(IS_KEY_IMAGE_HEIGHT, static_cast<int32_t>(imageSource.size.height));
 }
 
 inline void serializeImageRequestParams(MapBufferBuilder &builder, const ImageRequestParams &imageRequestParams)
 {
+  builder.putInt(IS_KEY_VIEW_WIDTH, static_cast<int32_t>(imageRequestParams.size.width));
+  builder.putInt(IS_KEY_VIEW_HEIGHT, static_cast<int32_t>(imageRequestParams.size.height));
   builder.putString(IS_KEY_DEFAULT_SRC, imageRequestParams.defaultSource.uri);
   builder.putInt(IS_KEY_RESIZE_MODE, to_underlying(imageRequestParams.resizeMode));
   builder.putString(IS_KEY_RESIZE_METHOD, imageRequestParams.resizeMethod);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native",
-  "version": "0.84.0-nightly-20251115-e08abbcb9",
+  "version": "0.84.0-nightly-20251116-d52b9d2f8",
   "description": "A framework for building native apps using React",
   "license": "MIT",
   "repository": {
@@ -160,13 +160,13 @@
   },
   "dependencies": {
     "@jest/create-cache-key-function": "^29.7.0",
-    "@react-native/assets-registry": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/codegen": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/community-cli-plugin": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/gradle-plugin": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/js-polyfills": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/normalize-colors": "0.84.0-nightly-20251115-e08abbcb9",
-    "@react-native/virtualized-lists": "0.84.0-nightly-20251115-e08abbcb9",
+    "@react-native/assets-registry": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/codegen": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/community-cli-plugin": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/gradle-plugin": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/js-polyfills": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/normalize-colors": "0.84.0-nightly-20251116-d52b9d2f8",
+    "@react-native/virtualized-lists": "0.84.0-nightly-20251116-d52b9d2f8",
     "abort-controller": "^3.0.0",
     "anser": "^1.4.9",
     "ansi-regex": "^5.0.0",
@@ -176,7 +176,7 @@
     "commander": "^12.0.0",
     "flow-enums-runtime": "^0.0.6",
     "glob": "^7.1.1",
-    "hermes-compiler": "0.14.0-commitly-202511080502-bbebefee2",
+    "hermes-compiler": "0.14.0-commitly-202511160156-8b7dd3e16",
     "invariant": "^2.2.4",
     "jest-environment-node": "^29.7.0",
     "memoize-one": "^5.0.0",

package/sdks/hermes-engine/version.properties

@@ -1,2 +1,2 @@
-HERMES_VERSION_NAME=0.14.0-commitly-202511080502-bbebefee2
+HERMES_VERSION_NAME=0.14.0-commitly-202511160156-8b7dd3e16
 HERMES_V1_VERSION_NAME=250829098.0.3

package/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp

@@ -1,212 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#include "TurboCxxModule.h"
-
-#include <vector>
-
-#include <ReactCommon/TurboModuleUtils.h>
-#include <glog/logging.h>
-#include <jsi/JSIDynamic.h>
-
-using namespace facebook;
-using namespace facebook::xplat::module;
-
-namespace facebook::react {
-
-namespace {
-CxxModule::Callback makeTurboCxxModuleCallback(
-    std::weak_ptr<CallbackWrapper> weakWrapper) {
-  return [weakWrapper, wrapperWasCalled = false](
-             const std::vector<folly::dynamic>& args) mutable {
-    if (wrapperWasCalled) {
-      LOG(FATAL) << "callback arg cannot be called more than once";
-    }
-
-    auto strongWrapper = weakWrapper.lock();
-    if (!strongWrapper) {
-      return;
-    }
-
-    strongWrapper->jsInvoker().invokeAsync(
-        [weakWrapper, args](jsi::Runtime& rt) {
-          auto strongWrapper2 = weakWrapper.lock();
-          if (!strongWrapper2) {
-            return;
-          }
-
-          std::vector<jsi::Value> innerArgs;
-          innerArgs.reserve(args.size());
-          for (auto& a : args) {
-            innerArgs.push_back(jsi::valueFromDynamic(rt, a));
-          }
-          strongWrapper2->callback().call(
-              rt, (const jsi::Value*)innerArgs.data(), innerArgs.size());
-
-          strongWrapper2->destroy();
-        });
-
-    wrapperWasCalled = true;
-  };
-}
-} // namespace
-
-TurboCxxModule::TurboCxxModule(
-    std::unique_ptr<CxxModule> cxxModule,
-    std::shared_ptr<CallInvoker> jsInvoker)
-    : TurboModule(cxxModule->getName(), std::move(jsInvoker)),
-      cxxMethods_(cxxModule->getMethods()),
-      cxxModule_(std::move(cxxModule)) {}
-
-jsi::Value TurboCxxModule::create(
-    jsi::Runtime& runtime,
-    const jsi::PropNameID& propName) {
-  std::string propNameUtf8 = propName.utf8(runtime);
-
-  if (propNameUtf8 == "getConstants") {
-    // This is special cased because `getConstants()` is already a part of
-    // CxxModule.
-    return jsi::Function::createFromHostFunction(
-        runtime,
-        propName,
-        0,
-        [this](
-            jsi::Runtime& rt,
-            const jsi::Value& /*thisVal*/,
-            const jsi::Value* /*args*/,
-            size_t /*count*/) {
-          jsi::Object result(rt);
-          auto constants = cxxModule_->getConstants();
-          for (auto& pair : constants) {
-            result.setProperty(
-                rt, pair.first.c_str(), jsi::valueFromDynamic(rt, pair.second));
-          }
-          return result;
-        });
-  } else {
-    for (auto& method : cxxMethods_) {
-      if (method.name == propNameUtf8) {
-        return jsi::Function::createFromHostFunction(
-            runtime,
-            propName,
-            0,
-            [this, propNameUtf8](
-                jsi::Runtime& rt,
-                const jsi::Value& /*thisVal*/,
-                const jsi::Value* args,
-                size_t count) {
-              return invokeMethod(rt, propNameUtf8, args, count);
-            });
-      }
-    }
-  }
-
-  return jsi::Value::undefined();
-}
-
-std::vector<jsi::PropNameID> TurboCxxModule::getPropertyNames(
-    jsi::Runtime& runtime) {
-  std::vector<jsi::PropNameID> result;
-  result.reserve(cxxMethods_.size() + 1);
-  result.push_back(jsi::PropNameID::forUtf8(runtime, "getConstants"));
-  for (auto& cxxMethod : cxxMethods_) {
-    result.push_back(jsi::PropNameID::forUtf8(runtime, cxxMethod.name));
-  }
-  return result;
-}
-
-jsi::Value TurboCxxModule::invokeMethod(
-    jsi::Runtime& runtime,
-    const std::string& methodName,
-    const jsi::Value* args,
-    size_t count) {
-  auto it = cxxMethods_.begin();
-  for (; it != cxxMethods_.end(); it++) {
-    auto method = *it;
-    if (method.name == methodName) {
-      break;
-    }
-  }
-
-  if (it == cxxMethods_.end()) {
-    throw std::runtime_error(
-        "Function '" + methodName + "' cannot be found on cxxmodule: " + name_);
-  }
-
-  auto method = *it;
-
-  if (method.syncFunc) {
-    auto innerArgs = folly::dynamic::array();
-    for (size_t i = 0; i < count; i++) {
-      innerArgs.push_back(jsi::dynamicFromValue(runtime, args[i]));
-    }
-    return jsi::valueFromDynamic(
-        runtime, method.syncFunc(std::move(innerArgs)));
-  } else if (method.func && !method.isPromise) {
-    // Async method.
-    CxxModule::Callback first;
-    CxxModule::Callback second;
-
-    if (count < method.callbacks) {
-      throw std::invalid_argument(
-          "Expected " + std::to_string(method.callbacks) +
-          " callbacks, but only " + std::to_string(count) +
-          " parameters provided");
-    }
-
-    if (method.callbacks == 1) {
-      auto wrapper = CallbackWrapper::createWeak(
-          args[count - 1].getObject(runtime).getFunction(runtime),
-          runtime,
-          jsInvoker_);
-      first = makeTurboCxxModuleCallback(wrapper);
-    } else if (method.callbacks == 2) {
-      auto wrapper1 = CallbackWrapper::createWeak(
-          args[count - 2].getObject(runtime).getFunction(runtime),
-          runtime,
-          jsInvoker_);
-      auto wrapper2 = CallbackWrapper::createWeak(
-          args[count - 1].getObject(runtime).getFunction(runtime),
-          runtime,
-          jsInvoker_);
-      first = makeTurboCxxModuleCallback(wrapper1);
-      second = makeTurboCxxModuleCallback(wrapper2);
-    }
-
-    auto innerArgs = folly::dynamic::array();
-    for (size_t i = 0; i < count - method.callbacks; i++) {
-      innerArgs.push_back(jsi::dynamicFromValue(runtime, args[i]));
-    }
-
-    method.func(std::move(innerArgs), first, second);
-  } else if (method.isPromise) {
-    return createPromiseAsJSIValue(
-        runtime,
-        [method, args, count, this](
-            jsi::Runtime& rt, std::shared_ptr<Promise> promise) {
-          auto resolveWrapper = CallbackWrapper::createWeak(
-              promise->resolve_.getFunction(rt), rt, jsInvoker_);
-          auto rejectWrapper = CallbackWrapper::createWeak(
-              promise->reject_.getFunction(rt), rt, jsInvoker_);
-          CxxModule::Callback resolve =
-              makeTurboCxxModuleCallback(resolveWrapper);
-          CxxModule::Callback reject =
-              makeTurboCxxModuleCallback(rejectWrapper);
-
-          auto innerArgs = folly::dynamic::array();
-          for (size_t i = 0; i < count; i++) {
-            innerArgs.push_back(jsi::dynamicFromValue(rt, args[i]));
-          }
-
-          method.func(std::move(innerArgs), resolve, reject);
-        });
-  }
-
-  return jsi::Value::undefined();
-}
-
-} // namespace facebook::react

package/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.h

@@ -1,40 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#pragma once
-
-#include <memory>
-#include <vector>
-
-#include <cxxreact/CxxModule.h>
-
-#include "TurboModule.h"
-
-namespace facebook::react {
-
-/**
- * A helper class to convert the legacy CxxModule instance to a TurboModule
- * instance. This should be used only for migration purpose (to TurboModule),
- * since it's not very performant due to a lot of back-and-forth value
- * conversions between folly::dynamic and jsi::Value.
- */
-class JSI_EXPORT TurboCxxModule : public TurboModule {
- public:
-  TurboCxxModule(std::unique_ptr<facebook::xplat::module::CxxModule> cxxModule, std::shared_ptr<CallInvoker> jsInvoker);
-
-  facebook::jsi::Value create(facebook::jsi::Runtime &runtime, const facebook::jsi::PropNameID &propName) override;
-
-  std::vector<facebook::jsi::PropNameID> getPropertyNames(facebook::jsi::Runtime &runtime) override;
-
-  jsi::Value invokeMethod(jsi::Runtime &runtime, const std::string &methodName, const jsi::Value *args, size_t count);
-
- private:
-  std::vector<facebook::xplat::module::CxxModule::Method> cxxMethods_;
-  std::unique_ptr<facebook::xplat::module::CxxModule> cxxModule_;
-};
-
-} // namespace facebook::react