react-native 0.84.0-nightly-20251105-5ec5cc3a3 → 0.84.0-nightly-20251107-f8198f662

package/ReactCommon/jsinspector-modern/tests/ConsoleCreateTaskTest.cpp

@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <folly/executors/QueuedImmediateExecutor.h>
+
+#include "JsiIntegrationTest.h"
+#include "engines/JsiIntegrationTestHermesEngineAdapter.h"
+
+#include <jsinspector-modern/ConsoleTaskOrchestrator.h>
+
+using namespace ::testing;
+
+namespace facebook::react::jsinspector_modern {
+
+/**
+ * A test fixture for the console.createTask API.
+ */
+class ConsoleCreateTaskTest : public JsiIntegrationPortableTestBase<
+                                  JsiIntegrationTestHermesEngineAdapter,
+                                  folly::QueuedImmediateExecutor> {};
+
+TEST_F(ConsoleCreateTaskTest, Installed) {
+  auto result = eval("typeof console.createTask");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "function");
+}
+
+TEST_F(ConsoleCreateTaskTest, ReturnsTaskObject) {
+  auto result = eval("typeof console.createTask('test-task')");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "object");
+}
+
+TEST_F(ConsoleCreateTaskTest, TaskObjectHasRunMethod) {
+  auto result = eval("typeof console.createTask('test-task').run");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "function");
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodExecutesFunction) {
+  auto result = eval(R"(
+    let executed = false;
+    const task = console.createTask('test-task');
+    task.run(() => { executed = true; });
+    executed;
+  )");
+  EXPECT_TRUE(result.getBool());
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodReturnsValue) {
+  auto result = eval(R"(
+    const task = console.createTask('test-task');
+    task.run(() => 42);
+  )");
+  EXPECT_EQ(result.getNumber(), 42);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnNoArguments) {
+  EXPECT_THROW(eval("console.createTask()"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnEmptyString) {
+  EXPECT_THROW(eval("console.createTask('')"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnNonStringArgument) {
+  EXPECT_THROW(eval("console.createTask(123)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask(null)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask(undefined)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask({})"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodThrowsOnNoArguments) {
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run();
+  )"),
+      facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodThrowsOnNonFunction) {
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run(123);
+  )"),
+      facebook::jsi::JSError);
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run('not a function');
+  )"),
+      facebook::jsi::JSError);
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run({});
+  )"),
+      facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, MultipleTasksCanBeCreated) {
+  auto result = eval(R"(
+    const task1 = console.createTask('task-1');
+    const task2 = console.createTask('task-2');
+    let count = 0;
+    task1.run(() => { count++; });
+    task2.run(() => { count++; });
+    count;
+  )");
+  EXPECT_EQ(result.getNumber(), 2);
+}
+
+TEST_F(ConsoleCreateTaskTest, TaskCanBeRunMultipleTimes) {
+  auto result = eval(R"(
+    const task = console.createTask('test-task');
+    let count = 0;
+    task.run(() => { count++; });
+    task.run(() => { count++; });
+    task.run(() => { count++; });
+    count;
+  )");
+  EXPECT_EQ(result.getNumber(), 3);
+}
+
+} // namespace facebook::react::jsinspector_modern

package/ReactCommon/jsinspector-modern/tests/ReactInstanceIntegrationTest.cpp

@@ -14,6 +14,7 @@
 #include <glog/logging.h>
 #include <jsinspector-modern/InspectorFlags.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/runtime/JSRuntimeBindings.h>
 #include <react/runtime/hermes/HermesInstance.h>
 
 using namespace ::testing;

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

@@ -187,7 +187,8 @@ void PerformanceTracer::reportMeasure(
     const std::string& name,
     HighResTimeStamp start,
     HighResDuration duration,
-    folly::dynamic&& detail) {
+    folly::dynamic&& detail,
+    std::optional<folly::dynamic> stackTrace) {
   if (!tracingAtomic_) {
     return;
   }
@@ -204,6 +205,7 @@ void PerformanceTracer::reportMeasure(
           .duration = duration,
           .detail = std::move(detail),
           .threadId = getCurrentThreadId(),
+          .stackTrace = std::move(stackTrace),
       });
 }
 
@@ -214,7 +216,8 @@ void PerformanceTracer::reportTimeStamp(
     std::optional<std::string> trackName,
     std::optional<std::string> trackGroup,
     std::optional<ConsoleTimeStampColor> color,
-    std::optional<folly::dynamic> detail) {
+    std::optional<folly::dynamic> detail,
+    std::optional<folly::dynamic> stackTrace) {
   if (!tracingAtomic_) {
     return;
   }
@@ -233,6 +236,7 @@ void PerformanceTracer::reportTimeStamp(
           .trackGroup = std::move(trackGroup),
           .color = std::move(color),
           .detail = std::move(detail),
+          .stackTrace = std::move(stackTrace),
           .threadId = getCurrentThreadId(),
       });
 }
@@ -606,6 +610,10 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
               beginEventArgs =
                   folly::dynamic::object("detail", folly::toJson(event.detail));
             }
+            if (event.stackTrace) {
+              beginEventArgs["data"] = folly::dynamic::object(
+                  "rnStackTrace", std::move(*event.stackTrace));
+            }
 
             auto eventId = ++performanceMeasureCount_;
 
@@ -695,6 +703,9 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
               }
               data["devtools"] = folly::toJson(devtoolsDetail);
             }
+            if (event.stackTrace) {
+              data["rnStackTrace"] = std::move(*event.stackTrace);
+            }
 
             events.emplace_back(
                 TraceEvent{

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h

@@ -81,7 +81,8 @@ class PerformanceTracer {
       const std::string &name,
       HighResTimeStamp start,
       HighResDuration duration,
-      folly::dynamic &&detail = nullptr);
+      folly::dynamic &&detail = nullptr,
+      std::optional<folly::dynamic> stackTrace = nullptr);
 
   /**
    * Record a "TimeStamp" Trace Event - a labelled entry on Performance
@@ -97,7 +98,8 @@ class PerformanceTracer {
       std::optional<std::string> trackName = std::nullopt,
       std::optional<std::string> trackGroup = std::nullopt,
       std::optional<ConsoleTimeStampColor> color = std::nullopt,
-      std::optional<folly::dynamic> detail = std::nullopt);
+      std::optional<folly::dynamic> detail = std::nullopt,
+      std::optional<folly::dynamic> stackTrace = std::nullopt);
 
   /**
    * Record an Event Loop tick, which will be represented as an Event Loop task
@@ -256,6 +258,7 @@ class PerformanceTracer {
     HighResDuration duration;
     folly::dynamic detail;
     ThreadId threadId;
+    std::optional<folly::dynamic> stackTrace;
     HighResTimeStamp createdAt = HighResTimeStamp::now();
   };
 
@@ -267,6 +270,7 @@ class PerformanceTracer {
     std::optional<std::string> trackGroup;
     std::optional<ConsoleTimeStampColor> color;
     std::optional<folly::dynamic> detail;
+    std::optional<folly::dynamic> stackTrace;
     ThreadId threadId;
     HighResTimeStamp createdAt = HighResTimeStamp::now();
   };

package/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec

@@ -48,6 +48,10 @@ Pod::Spec.new do |s|
   s.dependency "React-oscompat"
   s.dependency "React-timing"
 
+  if use_hermes()
+    s.dependency "hermes-engine"
+  end
+
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)
 end

package/ReactCommon/jsinspector-modern/tracing/TargetTracingAgent.h

@@ -27,6 +27,11 @@ class TargetTracingAgent {
     (void)state_;
   }
 
+  bool isRunningInBackgroundMode()
+  {
+    return state_.mode == tracing::Mode::Background;
+  }
+
  protected:
   TraceRecordingState &state_;
 };

package/ReactCommon/jsitooling/React-jsitooling.podspec

@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
   add_dependency(s, "React-jsinspectorcdp", :framework_name => 'jsinspector_moderncdp')
   add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
+  add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
 
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)

package/ReactCommon/jsitooling/react/runtime/JSRuntimeBindings.cpp

@@ -0,0 +1,54 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "JSRuntimeBindings.h"
+
+#include <react/timing/primitives.h>
+
+namespace facebook::react {
+
+void bindNativeLogger(jsi::Runtime& runtime, Logger logger) {
+  runtime.global().setProperty(
+      runtime,
+      "nativeLoggingHook",
+      jsi::Function::createFromHostFunction(
+          runtime,
+          jsi::PropNameID::forAscii(runtime, "nativeLoggingHook"),
+          2,
+          [logger = std::move(logger)](
+              jsi::Runtime& runtime,
+              const jsi::Value& /* this */,
+              const jsi::Value* args,
+              size_t count) {
+            if (count != 2) {
+              throw std::invalid_argument(
+                  "nativeLoggingHook takes 2 arguments");
+            }
+            logger(
+                args[0].asString(runtime).utf8(runtime),
+                static_cast<unsigned int>(args[1].asNumber()));
+            return jsi::Value::undefined();
+          }));
+}
+
+void bindNativePerformanceNow(jsi::Runtime& runtime) {
+  runtime.global().setProperty(
+      runtime,
+      "nativePerformanceNow",
+      jsi::Function::createFromHostFunction(
+          runtime,
+          jsi::PropNameID::forAscii(runtime, "nativePerformanceNow"),
+          0,
+          [](jsi::Runtime& /* runtime */,
+             const jsi::Value& /* this */,
+             const jsi::Value* /* args */,
+             size_t /*count*/) {
+            return HighResTimeStamp::now().toDOMHighResTimeStamp();
+          }));
+}
+
+} // namespace facebook::react

package/ReactCommon/jsitooling/react/runtime/JSRuntimeBindings.h

@@ -0,0 +1,20 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <jsi/jsi.h>
+#include <string>
+
+namespace facebook::react {
+
+using Logger = std::function<void(const std::string &message, unsigned int logLevel)>;
+void bindNativeLogger(jsi::Runtime &runtime, Logger logger);
+
+void bindNativePerformanceNow(jsi::Runtime &runtime);
+
+} // namespace facebook::react

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<6f88454830626622f9b5720ae0395938>>
+ * @generated SignedSource<<a2224b72c2e27abf6a158aa1b4fe9ed0>>
  */
 
 /**
@@ -58,6 +58,10 @@ bool ReactNativeFeatureFlags::disableOldAndroidAttachmentMetricsWorkarounds() {
   return getAccessor().disableOldAndroidAttachmentMetricsWorkarounds();
 }
 
+bool ReactNativeFeatureFlags::disableSubviewClippingAndroid() {
+  return getAccessor().disableSubviewClippingAndroid();
+}
+
 bool ReactNativeFeatureFlags::disableTextLayoutManagerCacheAndroid() {
   return getAccessor().disableTextLayoutManagerCacheAndroid();
 }
@@ -314,10 +318,6 @@ bool ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode() {
   return getAccessor().useNativeViewConfigsInBridgelessMode();
 }
 
-bool ReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid() {
-  return getAccessor().useOptimizedEventBatchingOnAndroid();
-}
-
 bool ReactNativeFeatureFlags::useRawPropsJsiValue() {
   return getAccessor().useRawPropsJsiValue();
 }

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<7e530e01e8c31edb68099a11bc371b89>>
+ * @generated SignedSource<<467f48f2231ceb6772a9a9da9e3badb9>>
  */
 
 /**
@@ -79,6 +79,11 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool disableOldAndroidAttachmentMetricsWorkarounds();
 
+  /**
+   * Force disable subview clipping for ReactViewGroup on Android
+   */
+  RN_EXPORT static bool disableSubviewClippingAndroid();
+
   /**
    * Turns off the global measurement cache used by TextLayoutManager on Android.
    */
@@ -399,11 +404,6 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool useNativeViewConfigsInBridgelessMode();
 
-  /**
-   * Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
-   */
-  RN_EXPORT static bool useOptimizedEventBatchingOnAndroid();
-
   /**
    * Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
    */