react-native 0.83.0-rc.0 → 0.84.0-nightly-20251106-de5141a3d

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

@@ -360,6 +360,41 @@ void PerformanceTracer::reportResourceFinish(
       });
 }
 
+void PerformanceTracer::setLayerTreeId(std::string frame, int layerTreeId) {
+  enqueueEvent(
+      PerformanceTracerSetLayerTreeIdEvent{
+          .frame = std::move(frame),
+          .layerTreeId = layerTreeId,
+          .start = HighResTimeStamp::now(),
+          .threadId = getCurrentThreadId(),
+      });
+}
+
+void PerformanceTracer::reportFrameTiming(
+    int frameSeqId,
+    HighResTimeStamp start,
+    HighResTimeStamp end) {
+  ThreadId threadId = getCurrentThreadId();
+  enqueueEvent(
+      PerformanceTracerFrameBeginDrawEvent{
+          .frameSeqId = frameSeqId,
+          .start = start,
+          .threadId = threadId,
+      });
+  enqueueEvent(
+      PerformanceTracerFrameCommitEvent{
+          .frameSeqId = frameSeqId,
+          .start = start,
+          .threadId = threadId,
+      });
+  enqueueEvent(
+      PerformanceTracerFrameDrawEvent{
+          .frameSeqId = frameSeqId,
+          .start = end,
+          .threadId = threadId,
+      });
+}
+
 /* static */ TraceEvent PerformanceTracer::constructRuntimeProfileTraceEvent(
     RuntimeProfileId profileId,
     ProcessId processId,
@@ -737,6 +772,70 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
                     .args = folly::dynamic::object("data", std::move(data)),
                 });
           },
+          [&](PerformanceTracerSetLayerTreeIdEvent&& event) {
+            folly::dynamic data = folly::dynamic::object("frame", event.frame)(
+                "layerTreeId", event.layerTreeId);
+
+            events.emplace_back(
+                TraceEvent{
+                    .name = "SetLayerTreeId",
+                    .cat = "devtools.timeline",
+                    .ph = 'I',
+                    .ts = event.start,
+                    .pid = processId_,
+                    .s = 't',
+                    .tid = event.threadId,
+                    .args = folly::dynamic::object("data", std::move(data)),
+                });
+          },
+          [&](PerformanceTracerFrameBeginDrawEvent&& event) {
+            folly::dynamic data = folly::dynamic::object(
+                "frameSeqId", event.frameSeqId)("layerTreeId", 1);
+
+            events.emplace_back(
+                TraceEvent{
+                    .name = "BeginFrame",
+                    .cat = "devtools.timeline",
+                    .ph = 'I',
+                    .ts = event.start,
+                    .pid = processId_,
+                    .s = 't',
+                    .tid = event.threadId,
+                    .args = std::move(data),
+                });
+          },
+          [&](PerformanceTracerFrameCommitEvent&& event) {
+            folly::dynamic data = folly::dynamic::object(
+                "frameSeqId", event.frameSeqId)("layerTreeId", 1);
+
+            events.emplace_back(
+                TraceEvent{
+                    .name = "Commit",
+                    .cat = "devtools.timeline",
+                    .ph = 'I',
+                    .ts = event.start,
+                    .pid = processId_,
+                    .s = 't',
+                    .tid = event.threadId,
+                    .args = std::move(data),
+                });
+          },
+          [&](PerformanceTracerFrameDrawEvent&& event) {
+            folly::dynamic data = folly::dynamic::object(
+                "frameSeqId", event.frameSeqId)("layerTreeId", 1);
+
+            events.emplace_back(
+                TraceEvent{
+                    .name = "DrawFrame",
+                    .cat = "devtools.timeline",
+                    .ph = 'I',
+                    .ts = event.start,
+                    .pid = processId_,
+                    .s = 't',
+                    .tid = event.threadId,
+                    .args = std::move(data),
+                });
+          },
       },
       std::move(event));
 }

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h

@@ -161,6 +161,19 @@ class PerformanceTracer {
       int encodedDataLength,
       int decodedBodyLength);
 
+  /**
+   * Sets the active layer tree ID in Chrome DevTools. This is needed in
+   * order for frames to be parsed.
+   *
+   * https://chromedevtools.github.io/devtools-protocol/tot/LayerTree/
+   */
+  void setLayerTreeId(std::string frame, int layerTreeId);
+
+  /**
+   * Reports the required frame CDP events for a given native frame.
+   */
+  void reportFrameTiming(int frameSeqId, HighResTimeStamp start, HighResTimeStamp end);
+
   /**
    * Creates "Profile" Trace Event.
    *
@@ -290,6 +303,35 @@ class PerformanceTracer {
     HighResTimeStamp createdAt = HighResTimeStamp::now();
   };
 
+  struct PerformanceTracerSetLayerTreeIdEvent {
+    std::string frame;
+    int layerTreeId;
+    HighResTimeStamp start;
+    ThreadId threadId;
+    HighResTimeStamp createdAt = HighResTimeStamp::now();
+  };
+
+  struct PerformanceTracerFrameBeginDrawEvent {
+    int frameSeqId;
+    HighResTimeStamp start;
+    ThreadId threadId;
+    HighResTimeStamp createdAt = HighResTimeStamp::now();
+  };
+
+  struct PerformanceTracerFrameCommitEvent {
+    int frameSeqId;
+    HighResTimeStamp start;
+    ThreadId threadId;
+    HighResTimeStamp createdAt = HighResTimeStamp::now();
+  };
+
+  struct PerformanceTracerFrameDrawEvent {
+    int frameSeqId;
+    HighResTimeStamp start;
+    ThreadId threadId;
+    HighResTimeStamp createdAt = HighResTimeStamp::now();
+  };
+
   using PerformanceTracerEvent = std::variant<
       PerformanceTracerEventTimeStamp,
       PerformanceTracerEventEventLoopTask,
@@ -298,7 +340,11 @@ class PerformanceTracer {
       PerformanceTracerEventMeasure,
       PerformanceTracerResourceSendRequest,
       PerformanceTracerResourceReceiveResponse,
-      PerformanceTracerResourceFinish>;
+      PerformanceTracerResourceFinish,
+      PerformanceTracerSetLayerTreeIdEvent,
+      PerformanceTracerFrameBeginDrawEvent,
+      PerformanceTracerFrameCommitEvent,
+      PerformanceTracerFrameDrawEvent>;
 
 #pragma mark - Private fields and methods
 

package/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec

@@ -48,6 +48,10 @@ Pod::Spec.new do |s|
   s.dependency "React-oscompat"
   s.dependency "React-timing"
 
+  if use_hermes()
+    s.dependency "hermes-engine"
+  end
+
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)
 end

package/ReactCommon/jsitooling/React-jsitooling.podspec

@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
   add_dependency(s, "React-jsinspectorcdp", :framework_name => 'jsinspector_moderncdp')
   add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
+  add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
 
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<5d596cc470e66861d7c1b2ffbb15b268>>
+ * @generated SignedSource<<a2224b72c2e27abf6a158aa1b4fe9ed0>>
  */
 
 /**
@@ -58,6 +58,10 @@ bool ReactNativeFeatureFlags::disableOldAndroidAttachmentMetricsWorkarounds() {
   return getAccessor().disableOldAndroidAttachmentMetricsWorkarounds();
 }
 
+bool ReactNativeFeatureFlags::disableSubviewClippingAndroid() {
+  return getAccessor().disableSubviewClippingAndroid();
+}
+
 bool ReactNativeFeatureFlags::disableTextLayoutManagerCacheAndroid() {
   return getAccessor().disableTextLayoutManagerCacheAndroid();
 }
@@ -286,10 +290,6 @@ bool ReactNativeFeatureFlags::skipActivityIdentityAssertionOnHostPause() {
   return getAccessor().skipActivityIdentityAssertionOnHostPause();
 }
 
-bool ReactNativeFeatureFlags::sweepActiveTouchOnChildNativeGesturesAndroid() {
-  return getAccessor().sweepActiveTouchOnChildNativeGesturesAndroid();
-}
-
 bool ReactNativeFeatureFlags::traceTurboModulePromiseRejectionsOnAndroid() {
   return getAccessor().traceTurboModulePromiseRejectionsOnAndroid();
 }
@@ -318,10 +318,6 @@ bool ReactNativeFeatureFlags::useNativeViewConfigsInBridgelessMode() {
   return getAccessor().useNativeViewConfigsInBridgelessMode();
 }
 
-bool ReactNativeFeatureFlags::useOptimizedEventBatchingOnAndroid() {
-  return getAccessor().useOptimizedEventBatchingOnAndroid();
-}
-
 bool ReactNativeFeatureFlags::useRawPropsJsiValue() {
   return getAccessor().useRawPropsJsiValue();
 }

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<41492e85e1feeb20d2e3e60b6cc6cbe7>>
+ * @generated SignedSource<<467f48f2231ceb6772a9a9da9e3badb9>>
  */
 
 /**
@@ -79,6 +79,11 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool disableOldAndroidAttachmentMetricsWorkarounds();
 
+  /**
+   * Force disable subview clipping for ReactViewGroup on Android
+   */
+  RN_EXPORT static bool disableSubviewClippingAndroid();
+
   /**
    * Turns off the global measurement cache used by TextLayoutManager on Android.
    */
@@ -330,7 +335,7 @@ class ReactNativeFeatureFlags {
   RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();
 
   /**
-   * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
+   * Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
    */
   RN_EXPORT static bool perfIssuesEnabled();
 
@@ -364,11 +369,6 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool skipActivityIdentityAssertionOnHostPause();
 
-  /**
-   * A flag to tell Fabric to sweep active touches from JSTouchDispatcher in Android when a child native gesture is started.
-   */
-  RN_EXPORT static bool sweepActiveTouchOnChildNativeGesturesAndroid();
-
   /**
    * Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
    */
@@ -404,11 +404,6 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool useNativeViewConfigsInBridgelessMode();
 
-  /**
-   * Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
-   */
-  RN_EXPORT static bool useOptimizedEventBatchingOnAndroid();
-
   /**
    * Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
    */