react-native 0.83.0-rc.0 → 0.83.0-rc.2

package/ReactCommon/jsinspector-modern/HostAgent.h

@@ -79,6 +79,12 @@ class HostAgent final {
    */
   void emitExternalTraceRecording(tracing::TraceRecordingState traceRecording) const;
 
+  /**
+   * Emits a system state changed event when the number of ReactHost instances
+   * changes.
+   */
+  void emitSystemStateChanged(bool isSingleHost) const;
+
  private:
   // We use the private implementation idiom to ensure this class has the same
   // layout regardless of whether REACT_NATIVE_DEBUGGER_ENABLED is defined. The

package/ReactCommon/jsinspector-modern/HostTarget.h

@@ -320,6 +320,11 @@ class JSINSPECTOR_EXPORT HostTarget : public EnableExecutorFromThis<HostTarget>
    */
   void emitTraceRecordingForFirstFuseboxClient(tracing::TraceRecordingState traceRecording) const;
 
+  /**
+   * Emits a system state changed event to all active sessions.
+   */
+  void emitSystemStateChanged(bool isSingleHost) const;
+
  private:
   /**
    * Constructs a new HostTarget.

package/ReactCommon/jsinspector-modern/InspectorFlags.cpp

@@ -17,6 +17,10 @@ InspectorFlags& InspectorFlags::getInstance() {
   return instance;
 }
 
+bool InspectorFlags::getAssertSingleHostState() const {
+  return loadFlagsAndAssertUnchanged().assertSingleHostState;
+}
+
 bool InspectorFlags::getFuseboxEnabled() const {
   if (fuseboxDisabledForTest_) {
     return false;
@@ -48,6 +52,8 @@ void InspectorFlags::dangerouslyDisableFuseboxForTest() {
 const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
     const {
   InspectorFlags::Values newValues = {
+      .assertSingleHostState =
+          ReactNativeFeatureFlags::fuseboxAssertSingleHostState(),
       .fuseboxEnabled =
 #if defined(REACT_NATIVE_DEBUGGER_ENABLED)
           true,

package/ReactCommon/jsinspector-modern/InspectorFlags.h

@@ -19,6 +19,12 @@ class InspectorFlags {
  public:
   static InspectorFlags &getInstance();
 
+  /**
+   * Flag determining if the inspector backend should strictly assert that only
+   * a single host is registered.
+   */
+  bool getAssertSingleHostState() const;
+
   /**
    * Flag determining if the modern CDP backend should be enabled.
    */
@@ -54,6 +60,7 @@ class InspectorFlags {
 
  private:
   struct Values {
+    bool assertSingleHostState;
     bool fuseboxEnabled;
     bool isProfilingBuild;
     bool networkInspectionEnabled;

package/ReactCommon/jsinspector-modern/InspectorInterfaces.cpp

@@ -7,6 +7,8 @@
 
 #include "InspectorInterfaces.h"
 
+#include "InspectorFlags.h"
+
 #include <cassert>
 #include <list>
 #include <mutex>
@@ -35,6 +37,14 @@ namespace {
 
 class InspectorImpl : public IInspector {
  public:
+  InspectorImpl() {
+    systemStateListener_ = std::make_shared<SystemStateListener>(systemState_);
+    auto& inspectorFlags = InspectorFlags::getInstance();
+    if (inspectorFlags.getAssertSingleHostState()) {
+      registerPageStatusListener(systemStateListener_);
+    }
+  }
+
   int addPage(
       const std::string& description,
       const std::string& vm,
@@ -50,7 +60,21 @@ class InspectorImpl : public IInspector {
   void registerPageStatusListener(
       std::weak_ptr<IPageStatusListener> listener) override;
 
+  InspectorSystemState getSystemState() const override;
+
  private:
+  class SystemStateListener : public IPageStatusListener {
+   public:
+    explicit SystemStateListener(InspectorSystemState& state) : state_(state) {}
+
+    void onPageAdded(int /*pageId*/) override {
+      state_.registeredPagesCount++;
+    }
+
+   private:
+    InspectorSystemState& state_;
+  };
+
   class Page {
    public:
     Page(
@@ -74,6 +98,8 @@ class InspectorImpl : public IInspector {
   int nextPageId_{1};
   std::map<int, Page> pages_;
   std::list<std::weak_ptr<IPageStatusListener>> listeners_;
+  InspectorSystemState systemState_{0};
+  std::shared_ptr<SystemStateListener> systemStateListener_;
 };
 
 InspectorImpl::Page::Page(
@@ -116,6 +142,12 @@ int InspectorImpl::addPage(
       pageId,
       Page{pageId, description, vm, std::move(connectFunc), capabilities});
 
+  for (const auto& listenerWeak : listeners_) {
+    if (auto listener = listenerWeak.lock()) {
+      listener->onPageAdded(pageId);
+    }
+  }
+
   return pageId;
 }
 
@@ -175,6 +207,11 @@ void InspectorImpl::registerPageStatusListener(
   }
   listeners_.push_back(listener);
 }
+
+InspectorSystemState InspectorImpl::getSystemState() const {
+  std::scoped_lock lock(mutex_);
+  return systemState_;
+}
 } // namespace
 
 IInspector& getInspectorInstance() {

package/ReactCommon/jsinspector-modern/InspectorInterfaces.h

@@ -51,6 +51,11 @@ struct InspectorPageDescription {
 // Alias for backwards compatibility.
 using InspectorPage = InspectorPageDescription;
 
+struct InspectorSystemState {
+  /** The total count of pages registered during the app lifetime. */
+  int registeredPagesCount;
+};
+
 /// IRemoteConnection allows the VM to send debugger messages to the client.
 /// IRemoteConnection's methods are safe to call from any thread *if*
 /// InspectorPackagerConnection.cpp is in use.
@@ -78,7 +83,8 @@ class JSINSPECTOR_EXPORT ILocalConnection : public IDestructible {
 class JSINSPECTOR_EXPORT IPageStatusListener : public IDestructible {
  public:
   virtual ~IPageStatusListener() = 0;
-  virtual void onPageRemoved(int pageId) = 0;
+  virtual void onPageAdded(int /*pageId*/) {}
+  virtual void onPageRemoved(int /*pageId*/) {}
 };
 
 /// IInspector tracks debuggable JavaScript targets (pages).
@@ -127,6 +133,11 @@ class JSINSPECTOR_EXPORT IInspector : public IDestructible {
    * when pages are removed.
    */
   virtual void registerPageStatusListener(std::weak_ptr<IPageStatusListener> listener) = 0;
+
+  /**
+   * Get the current \c InspectorSystemState object.
+   */
+  virtual InspectorSystemState getSystemState() const = 0;
 };
 
 class NotImplementedException : public std::exception {

package/ReactCommon/jsinspector-modern/TracingAgent.cpp

@@ -53,7 +53,17 @@ TracingAgent::~TracingAgent() {
 
 bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
   if (req.method == "Tracing.start") {
-    // @cdp Tracing.start support is experimental.
+    auto& inspector = getInspectorInstance();
+    if (inspector.getSystemState().registeredPagesCount > 1) {
+      frontendChannel_(
+          cdp::jsonError(
+              req.id,
+              cdp::ErrorCode::InternalError,
+              "The Tracing domain is unavailable when multiple React Native hosts are registered."));
+
+      return true;
+    }
+
     if (sessionState_.isDebuggerDomainEnabled) {
       frontendChannel_(
           cdp::jsonError(

package/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec

@@ -48,6 +48,10 @@ Pod::Spec.new do |s|
   s.dependency "React-oscompat"
   s.dependency "React-timing"
 
+  if use_hermes()
+    s.dependency "hermes-engine"
+  end
+
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)
 end

package/ReactCommon/jsitooling/React-jsitooling.podspec

@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
   add_dependency(s, "React-jsinspectorcdp", :framework_name => 'jsinspector_moderncdp')
   add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
+  add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
 
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<5d596cc470e66861d7c1b2ffbb15b268>>
+ * @generated SignedSource<<6728f8cada1d0d9d21800b4fefe76b77>>
  */
 
 /**
@@ -146,6 +146,10 @@ bool ReactNativeFeatureFlags::enableInteropViewManagerClassLookUpOptimizationIOS
   return getAccessor().enableInteropViewManagerClassLookUpOptimizationIOS();
 }
 
+bool ReactNativeFeatureFlags::enableIntersectionObserverByDefault() {
+  return getAccessor().enableIntersectionObserverByDefault();
+}
+
 bool ReactNativeFeatureFlags::enableKeyEvents() {
   return getAccessor().enableKeyEvents();
 }
@@ -242,6 +246,10 @@ bool ReactNativeFeatureFlags::fixMappingOfEventPrioritiesBetweenFabricAndReact()
   return getAccessor().fixMappingOfEventPrioritiesBetweenFabricAndReact();
 }
 
+bool ReactNativeFeatureFlags::fuseboxAssertSingleHostState() {
+  return getAccessor().fuseboxAssertSingleHostState();
+}
+
 bool ReactNativeFeatureFlags::fuseboxEnabledRelease() {
   return getAccessor().fuseboxEnabledRelease();
 }

package/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<41492e85e1feeb20d2e3e60b6cc6cbe7>>
+ * @generated SignedSource<<4b8574d0682b5e9644affc89559393ac>>
  */
 
 /**
@@ -189,6 +189,11 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool enableInteropViewManagerClassLookUpOptimizationIOS();
 
+  /**
+   * Enables the IntersectionObserver Web API in React Native.
+   */
+  RN_EXPORT static bool enableIntersectionObserverByDefault();
+
   /**
    * Enables key up/down/press events to be sent to JS from components
    */
@@ -309,6 +314,11 @@ class ReactNativeFeatureFlags {
    */
   RN_EXPORT static bool fixMappingOfEventPrioritiesBetweenFabricAndReact();
 
+  /**
+   * Enable system assertion validating that Fusebox is configured with a single host. When set, the CDP backend will dynamically disable features (Perf and Network) in the event that multiple hosts are registered (undefined behaviour), and broadcast this over `ReactNativeApplication.systemStateChanged`.
+   */
+  RN_EXPORT static bool fuseboxAssertSingleHostState();
+
   /**
    * Flag determining if the React Native DevTools (Fusebox) CDP backend should be enabled in release builds. This flag is global and should not be changed across React Host lifetimes.
    */