react-native 0.76.0-rc.4 → 0.76.0-rc.6

package/Libraries/Core/ReactNativeVersion.js

@@ -17,7 +17,7 @@ const version: $ReadOnly<{
   major: 0,
   minor: 76,
   patch: 0,
-  prerelease: 'rc.4',
+  prerelease: 'rc.6',
 };
 
 module.exports = {version};

package/React/Base/RCTVersion.m

@@ -24,7 +24,7 @@ NSDictionary* RCTGetReactNativeVersion(void)
                   RCTVersionMajor: @(0),
                   RCTVersionMinor: @(76),
                   RCTVersionPatch: @(0),
-                  RCTVersionPrerelease: @"rc.4",
+                  RCTVersionPrerelease: @"rc.6",
                   };
   });
   return __rnVersion;

package/ReactAndroid/api/ReactAndroid.api

@@ -3798,13 +3798,13 @@ public abstract class com/facebook/react/packagerconnection/NotificationOnlyHand
 	public final fun onRequest (Ljava/lang/Object;Lcom/facebook/react/packagerconnection/Responder;)V
 }
 
-public final class com/facebook/react/packagerconnection/PackagerConnectionSettings {
+public class com/facebook/react/packagerconnection/PackagerConnectionSettings {
 	public fun <init> (Landroid/content/Context;)V
 	public final fun getAdditionalOptionsForPackager ()Ljava/util/Map;
-	public final fun getDebugServerHost ()Ljava/lang/String;
+	public fun getDebugServerHost ()Ljava/lang/String;
 	public final fun getPackageName ()Ljava/lang/String;
 	public final fun setAdditionalOptionForPackager (Ljava/lang/String;Ljava/lang/String;)V
-	public final fun setDebugServerHost (Ljava/lang/String;)V
+	public fun setDebugServerHost (Ljava/lang/String;)V
 }
 
 public final class com/facebook/react/packagerconnection/ReconnectingWebSocket : okhttp3/WebSocketListener {

package/ReactAndroid/build.gradle.kts

@@ -557,7 +557,6 @@ android {
         listOf(
             "src/main/res/devsupport",
             "src/main/res/shell",
-            "src/main/res/views/alert",
             "src/main/res/views/modal",
             "src/main/res/views/uimanager"))
     java.exclude("com/facebook/react/processing")

package/ReactAndroid/gradle.properties

@@ -1,4 +1,4 @@
-VERSION_NAME=0.76.0-rc.4
+VERSION_NAME=0.76.0-rc.6
 react.internal.publishingGroup=com.facebook.react
 
 android.useAndroidX=true

package/ReactAndroid/src/main/java/com/facebook/react/bridge/UIManager.kt

@@ -12,6 +12,7 @@ import androidx.annotation.AnyThread
 import androidx.annotation.UiThread
 import com.facebook.infer.annotation.ThreadConfined
 import com.facebook.react.common.annotations.UnstableReactNativeAPI
+import com.facebook.react.uimanager.events.EventDispatcher
 
 @OptIn(UnstableReactNativeAPI::class)
 public interface UIManager : PerformanceCounter {
@@ -78,7 +79,7 @@ public interface UIManager : PerformanceCounter {
   public fun dispatchCommand(reactTag: Int, commandId: String, commandArgs: ReadableArray?)
 
   /** @return the [EventDispatcher] object that is used by this class. */
-  public fun <T> getEventDispatcher(): T
+  public val eventDispatcher: EventDispatcher
 
   /**
    * Used by native animated module to bypass the process of updating the values through the shadow

package/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

@@ -1021,7 +1021,6 @@ public class FabricUIManager
 
   @Override
   @NonNull
-  @SuppressWarnings("unchecked")
   public EventDispatcher getEventDispatcher() {
     return mEventDispatcher;
   }

package/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java

@@ -12,20 +12,11 @@ import android.app.Dialog;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.res.TypedArray;
-import android.os.Build;
 import android.os.Bundle;
-import android.view.LayoutInflater;
-import android.view.View;
-import android.widget.TextView;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AlertDialog;
-import androidx.core.view.AccessibilityDelegateCompat;
-import androidx.core.view.ViewCompat;
-import androidx.core.view.accessibility.AccessibilityNodeInfoCompat;
 import androidx.fragment.app.DialogFragment;
-import com.facebook.infer.annotation.Assertions;
 import com.facebook.infer.annotation.Nullsafe;
-import com.facebook.react.R;
 
 /** A fragment used to display the dialog. */
 @Nullsafe(Nullsafe.Mode.LOCAL)
@@ -75,55 +66,15 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC
     return isAppCompat;
   }
 
-  /**
-   * Creates a custom dialog title View that has the role of "Heading" and focusable for
-   * accessibility purposes.
-   *
-   * @returns accessible TextView title
-   */
-  private static View getAccessibleTitle(Context activityContext, String titleText) {
-    LayoutInflater inflater = LayoutInflater.from(activityContext);
-
-    // This layout matches the sizing and styling of AlertDialog's title_template (minus the icon)
-    // since the whole thing gets tossed out when setting a custom title
-    View titleContainer = inflater.inflate(R.layout.alert_title_layout, null);
-
-    TextView accessibleTitle =
-        Assertions.assertNotNull(titleContainer.findViewById(R.id.alert_title));
-    accessibleTitle.setText(titleText);
-    accessibleTitle.setFocusable(true);
-
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
-      accessibleTitle.setAccessibilityHeading(true);
-    } else {
-      ViewCompat.setAccessibilityDelegate(
-          accessibleTitle,
-          new AccessibilityDelegateCompat() {
-            @Override
-            public void onInitializeAccessibilityNodeInfo(
-                View view, AccessibilityNodeInfoCompat info) {
-              super.onInitializeAccessibilityNodeInfo(accessibleTitle, info);
-              info.setHeading(true);
-            }
-          });
-    }
-
-    return titleContainer;
-  }
-
   /**
    * Creates a dialog compatible only with AppCompat activities. This function should be kept in
    * sync with {@link createAppDialog}.
    */
   private static Dialog createAppCompatDialog(
       Context activityContext, Bundle arguments, DialogInterface.OnClickListener fragment) {
-    AlertDialog.Builder builder = new AlertDialog.Builder(activityContext);
+    AlertDialog.Builder builder =
+        new AlertDialog.Builder(activityContext).setTitle(arguments.getString(ARG_TITLE));
 
-    if (arguments.containsKey(ARG_TITLE)) {
-      String title = Assertions.assertNotNull(arguments.getString(ARG_TITLE));
-      View accessibleTitle = getAccessibleTitle(activityContext, title);
-      builder.setCustomTitle(accessibleTitle);
-    }
     if (arguments.containsKey(ARG_BUTTON_POSITIVE)) {
       builder.setPositiveButton(arguments.getString(ARG_BUTTON_POSITIVE), fragment);
     }
@@ -154,13 +105,10 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC
   @Deprecated(since = "0.75.0", forRemoval = true)
   private static Dialog createAppDialog(
       Context activityContext, Bundle arguments, DialogInterface.OnClickListener fragment) {
-    android.app.AlertDialog.Builder builder = new android.app.AlertDialog.Builder(activityContext);
+    android.app.AlertDialog.Builder builder =
+        new android.app.AlertDialog.Builder(activityContext)
+            .setTitle(arguments.getString(ARG_TITLE));
 
-    if (arguments.containsKey(ARG_TITLE)) {
-      String title = Assertions.assertNotNull(arguments.getString(ARG_TITLE));
-      View accessibleTitle = getAccessibleTitle(activityContext, title);
-      builder.setCustomTitle(accessibleTitle);
-    }
     if (arguments.containsKey(ARG_BUTTON_POSITIVE)) {
       builder.setPositiveButton(arguments.getString(ARG_BUTTON_POSITIVE), fragment);
     }

package/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java

@@ -18,5 +18,5 @@ public class ReactNativeVersion {
       "major", 0,
       "minor", 76,
       "patch", 0,
-      "prerelease", "rc.4");
+      "prerelease", "rc.6");
 }

package/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/PackagerConnectionSettings.kt

@@ -15,13 +15,13 @@ import android.preference.PreferenceManager
 import com.facebook.common.logging.FLog
 import com.facebook.react.modules.systeminfo.AndroidInfoHelpers
 
-public class PackagerConnectionSettings(private val appContext: Context) {
+public open class PackagerConnectionSettings(private val appContext: Context) {
   private val preferences: SharedPreferences =
       PreferenceManager.getDefaultSharedPreferences(appContext)
   public val packageName: String = appContext.packageName
   private val _additionalOptionsForPackager: MutableMap<String, String> = mutableMapOf()
 
-  public var debugServerHost: String
+  public open var debugServerHost: String
     get() {
       // Check host setting first. If empty try to detect emulator type and use default
       // hostname for those

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.kt

@@ -22,7 +22,7 @@ import com.facebook.yoga.YogaConstants
 public abstract class BaseViewManagerDelegate<T : View, U : BaseViewManagerInterface<T>>(
     @Suppress("NoHungarianNotation") @JvmField protected val mViewManager: U
 ) : ViewManagerDelegate<T> {
-  override public fun setProperty(view: T, propName: String, value: Any?) {
+  override public fun setProperty(view: T, propName: String?, value: Any?) {
     when (propName) {
       ViewProps.ACCESSIBILITY_ACTIONS ->
           mViewManager.setAccessibilityActions(view, value as ReadableArray?)
@@ -104,6 +104,6 @@ public abstract class BaseViewManagerDelegate<T : View, U : BaseViewManagerInter
     }
   }
 
-  override public fun receiveCommand(view: T, commandName: String, args: ReadableArray?): Unit =
+  override public fun receiveCommand(view: T, commandName: String?, args: ReadableArray?): Unit =
       Unit
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerDelegate.kt

@@ -18,7 +18,24 @@ import com.facebook.react.bridge.ReadableArray
  * @param <T> the type of the view supported by this delegate </T>
  */
 public interface ViewManagerDelegate<T : View?> {
-  public fun setProperty(view: T, propName: String, value: Any?)
 
-  public fun receiveCommand(view: T, commandName: String, args: ReadableArray?)
+  /**
+   * Sets a property on a view managed by this view manager.
+   *
+   * @param view the view to set the property on
+   * @param propName the name of the property to set (NOTE: should be `String` but is kept as
+   *   `String?` to avoid breaking changes)
+   * @param value the value to set the property to
+   */
+  public fun setProperty(view: T, propName: String?, value: Any?)
+
+  /**
+   * Executes a command from JS to the view
+   *
+   * @param view the view to execute the command on
+   * @param commandName the name of the command to execute (NOTE: should be `String` but is kept as
+   *   `String?` to avoid breaking changes)
+   * @param args the arguments to pass to the command
+   */
+  public fun receiveCommand(view: T, commandName: String?, args: ReadableArray?)
 }

package/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.kt

@@ -26,6 +26,7 @@ import android.view.WindowManager
 import android.view.accessibility.AccessibilityEvent
 import android.widget.FrameLayout
 import androidx.annotation.UiThread
+import com.facebook.common.logging.FLog
 import com.facebook.react.R
 import com.facebook.react.bridge.GuardedRunnable
 import com.facebook.react.bridge.LifecycleEventListener
@@ -33,6 +34,7 @@ import com.facebook.react.bridge.ReactContext
 import com.facebook.react.bridge.UiThreadUtil
 import com.facebook.react.bridge.WritableMap
 import com.facebook.react.bridge.WritableNativeMap
+import com.facebook.react.common.ReactConstants
 import com.facebook.react.common.annotations.VisibleForTesting
 import com.facebook.react.config.ReactFeatureFlags
 import com.facebook.react.uimanager.JSPointerDispatcher
@@ -306,29 +308,37 @@ public class ReactModalHostView(context: ThemedReactContext) :
     val dialogWindow =
         checkNotNull(dialog.window) { "dialog must have window when we call updateProperties" }
     val currentActivity = getCurrentActivity()
-    if (currentActivity == null || currentActivity.isFinishing) {
+    if (currentActivity == null || currentActivity.isFinishing || currentActivity.isDestroyed) {
       // If the activity has disappeared, then we shouldn't update the window associated to the
       // Dialog.
       return
     }
-    val activityWindow = currentActivity.window
-    if (activityWindow != null) {
-      val activityWindowFlags = activityWindow.attributes.flags
-      if ((activityWindowFlags and WindowManager.LayoutParams.FLAG_FULLSCREEN) != 0) {
-        dialogWindow.addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
-      } else {
-        dialogWindow.clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
+    try {
+      val activityWindow = currentActivity.window
+      if (activityWindow != null) {
+        val activityWindowFlags = activityWindow.attributes.flags
+        if ((activityWindowFlags and WindowManager.LayoutParams.FLAG_FULLSCREEN) != 0) {
+          dialogWindow.addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
+        } else {
+          dialogWindow.clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
+        }
       }
-    }
 
-    dialogWindow.setStatusBarTranslucency(statusBarTranslucent)
+      dialogWindow.setStatusBarTranslucency(statusBarTranslucent)
 
-    if (transparent) {
-      dialogWindow.clearFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND)
-    } else {
-      dialogWindow.setDimAmount(0.5f)
-      dialogWindow.setFlags(
-          WindowManager.LayoutParams.FLAG_DIM_BEHIND, WindowManager.LayoutParams.FLAG_DIM_BEHIND)
+      if (transparent) {
+        dialogWindow.clearFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND)
+      } else {
+        dialogWindow.setDimAmount(0.5f)
+        dialogWindow.setFlags(
+            WindowManager.LayoutParams.FLAG_DIM_BEHIND, WindowManager.LayoutParams.FLAG_DIM_BEHIND)
+      }
+    } catch (e: IllegalArgumentException) {
+      // This is to prevent a crash from the following error, without a clear repro steps:
+      // java.lang.IllegalArgumentException: View=DecorView@c94931b[XxxActivity] not attached to
+      // window manager
+      FLog.e(
+          ReactConstants.TAG, "ReactModalHostView: error while setting window flags: ", e.message)
     }
   }
 

package/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -18,7 +18,7 @@ constexpr struct {
   int32_t Major = 0;
   int32_t Minor = 76;
   int32_t Patch = 0;
-  std::string_view Prerelease = "rc.4";
+  std::string_view Prerelease = "rc.6";
 } ReactNativeVersion;
 
 } // namespace facebook::react

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native",
-  "version": "0.76.0-rc.4",
+  "version": "0.76.0-rc.6",
   "description": "A framework for building native apps using React",
   "license": "MIT",
   "repository": {
@@ -109,13 +109,13 @@
   },
   "dependencies": {
     "@jest/create-cache-key-function": "^29.6.3",
-    "@react-native/assets-registry": "0.76.0-rc.4",
-    "@react-native/codegen": "0.76.0-rc.4",
-    "@react-native/community-cli-plugin": "0.76.0-rc.4",
-    "@react-native/gradle-plugin": "0.76.0-rc.4",
-    "@react-native/js-polyfills": "0.76.0-rc.4",
-    "@react-native/normalize-colors": "0.76.0-rc.4",
-    "@react-native/virtualized-lists": "0.76.0-rc.4",
+    "@react-native/assets-registry": "0.76.0-rc.6",
+    "@react-native/codegen": "0.76.0-rc.6",
+    "@react-native/community-cli-plugin": "0.76.0-rc.6",
+    "@react-native/gradle-plugin": "0.76.0-rc.6",
+    "@react-native/js-polyfills": "0.76.0-rc.6",
+    "@react-native/normalize-colors": "0.76.0-rc.6",
+    "@react-native/virtualized-lists": "0.76.0-rc.6",
     "abort-controller": "^3.0.0",
     "anser": "^1.4.9",
     "ansi-regex": "^5.0.0",
@@ -131,8 +131,8 @@
     "jest-environment-node": "^29.6.3",
     "jsc-android": "^250231.0.0",
     "memoize-one": "^5.0.0",
-    "metro-runtime": "^0.81.0-alpha.2",
-    "metro-source-map": "^0.81.0-alpha.2",
+    "metro-runtime": "^0.81.0",
+    "metro-source-map": "^0.81.0",
     "mkdirp": "^0.5.1",
     "nullthrows": "^1.1.1",
     "pretty-format": "^29.7.0",

package/scripts/cocoapods/new_architecture.rb

@@ -12,19 +12,33 @@ class NewArchitectureHelper
     @@NewArchWarningEmitted = false # Used not to spam warnings to the user.
 
     def self.set_clang_cxx_language_standard_if_needed(installer)
+        cxxBuildsettingsName = "CLANG_CXX_LANGUAGE_STANDARD"
         projects = installer.aggregate_targets
             .map{ |t| t.user_project }
             .uniq{ |p| p.path }
 
         projects.each do |project|
-            Pod::UI.puts("Setting CLANG_CXX_LANGUAGE_STANDARD to #{ Helpers::Constants::cxx_language_standard } on #{ project.path }")
+            Pod::UI.puts("Setting #{cxxBuildsettingsName} to #{ Helpers::Constants::cxx_language_standard } on #{ project.path }")
 
             project.build_configurations.each do |config|
-                config.build_settings["CLANG_CXX_LANGUAGE_STANDARD"] = Helpers::Constants::cxx_language_standard
+                config.build_settings[cxxBuildsettingsName] = Helpers::Constants::cxx_language_standard
             end
 
             project.save()
         end
+
+        installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
+            target_installation_result.native_target.build_configurations.each do |config|
+                config.build_settings[cxxBuildsettingsName] = Helpers::Constants::cxx_language_standard
+            end
+        end
+
+        # Override targets that would set spec.xcconfig to define c++ version
+        installer.aggregate_targets.each do |aggregate_target|
+            aggregate_target.xcconfigs.each do |config_name, config_file|
+                config_file.attributes[cxxBuildsettingsName] = Helpers::Constants::cxx_language_standard
+            end
+        end
     end
 
     def self.computeFlags(is_new_arch_enabled)

package/ReactAndroid/src/main/res/views/alert/layout/alert_title_layout.xml

@@ -1,22 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    android:gravity="center_vertical|start"
-    android:orientation="horizontal"
-    android:paddingStart="?android:attr/dialogPreferredPadding"
-    android:paddingTop="18dp"
-    android:paddingEnd="?android:attr/dialogPreferredPadding">
-
-    <TextView
-        android:id="@+id/alert_title"
-        style="?android:attr/windowTitleStyle"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAlignment="viewStart"
-        android:textAppearance="?android:attr/textAppearanceMedium"
-        android:textSize="18sp" />
-
-</LinearLayout>