react-native 0.74.0-rc.1 → 0.74.0-rc.3

package/sdks/hermes-engine/hermes-utils.rb

@@ -7,6 +7,7 @@ require 'net/http'
 require 'rexml/document'
 
 HERMES_GITHUB_URL = "https://github.com/facebook/hermes.git"
+ENV_BUILD_FROM_SOURCE = "RCT_BUILD_HERMES_FROM_SOURCE"
 
 module HermesEngineSourceType
     LOCAL_PREBUILT_TARBALL = :local_prebuilt_tarball
@@ -30,7 +31,7 @@ end
 # - To use a specific tarball, install the dependencies with:
 # `HERMES_ENGINE_TARBALL_PATH=<path_to_tarball> bundle exec pod install`
 # - To force a build from source, install the dependencies with:
-# `BUILD_FROM_SOURCE=true bundle exec pod install`
+# `RCT_BUILD_HERMES_FROM_SOURCE=true bundle exec pod install`
 # If none of the two are provided, Cocoapods will check whether there is a tarball for the current version
 # (either release or nightly). If not, it will fall back to building from source (the latest commit on main).
 #
@@ -85,11 +86,11 @@ def hermes_commit_envvar_defined()
 end
 
 def force_build_from_tag(react_native_path)
-    return ENV['BUILD_FROM_SOURCE'] === 'true' && File.exist?(hermestag_file(react_native_path))
+    return ENV[ENV_BUILD_FROM_SOURCE] === 'true' && File.exist?(hermestag_file(react_native_path))
 end
 
 def force_build_from_main(react_native_path)
-    return ENV['BUILD_FROM_SOURCE'] === 'true' && !File.exist?(hermestag_file(react_native_path))
+    return ENV[ENV_BUILD_FROM_SOURCE] === 'true' && !File.exist?(hermestag_file(react_native_path))
 end
 
 def release_artifact_exists(version)

package/template/package.json

@@ -11,15 +11,15 @@
   },
   "dependencies": {
     "react": "18.2.0",
-    "react-native": "0.74.0-rc.1"
+    "react-native": "0.74.0-rc.3"
   },
   "devDependencies": {
     "@babel/core": "^7.20.0",
     "@babel/preset-env": "^7.20.0",
     "@babel/runtime": "^7.20.0",
-    "@react-native/babel-preset": "0.74.1",
+    "@react-native/babel-preset": "0.74.2",
     "@react-native/eslint-config": "0.74.1",
-    "@react-native/metro-config": "0.74.1",
+    "@react-native/metro-config": "0.74.2",
     "@react-native/typescript-config": "0.74.1",
     "@types/react": "^18.2.6",
     "@types/react-test-renderer": "^18.0.0",

package/Libraries/Components/PopupMenuAndroid/PopupMenuAndroid.android.js

@@ -1,69 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @format
- * @flow strict-local
- */
-
-import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
-import type {SyntheticEvent} from '../../Types/CoreEventTypes';
-import type {RefObject} from 'react';
-
-import PopupMenuAndroidNativeComponent, {
-  Commands,
-} from './PopupMenuAndroidNativeComponent';
-import nullthrows from 'nullthrows';
-import * as React from 'react';
-import {useCallback, useImperativeHandle, useRef} from 'react';
-
-type PopupMenuSelectionEvent = SyntheticEvent<
-  $ReadOnly<{
-    item: number,
-  }>,
->;
-
-export type PopupMenuAndroidInstance = {
-  +show: () => void,
-};
-
-type Props = {
-  menuItems: $ReadOnlyArray<string>,
-  onSelectionChange: number => void,
-  children: React.Node,
-  instanceRef: RefObject<?PopupMenuAndroidInstance>,
-};
-
-export default function PopupMenuAndroid({
-  menuItems,
-  onSelectionChange,
-  children,
-  instanceRef,
-}: Props): React.Node {
-  const nativeRef = useRef<React.ElementRef<HostComponent<mixed>> | null>(null);
-  const _onSelectionChange = useCallback(
-    (event: PopupMenuSelectionEvent) => {
-      onSelectionChange(event.nativeEvent.item);
-    },
-    [onSelectionChange],
-  );
-
-  useImperativeHandle(instanceRef, ItemViewabilityInstance => {
-    return {
-      show() {
-        Commands.show(nullthrows(nativeRef.current));
-      },
-    };
-  });
-
-  return (
-    <PopupMenuAndroidNativeComponent
-      ref={nativeRef}
-      onSelectionChange={_onSelectionChange}
-      menuItems={menuItems}>
-      {children}
-    </PopupMenuAndroidNativeComponent>
-  );
-}

package/Libraries/Components/PopupMenuAndroid/PopupMenuAndroid.d.ts

@@ -1,24 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @format
- */
-
-import type * as React from 'react';
-import {HostComponent} from '../../../types/public/ReactNativeTypes';
-
-type PopupMenuAndroidInstance = {
-  show: () => void;
-};
-
-type Props = {
-  menuItems: Array<string>;
-  onSelectionChange: (number) => void;
-  children: React.ReactNode | undefined;
-  instanceRef: React.ElementRef<HostComponent<PopupMenuAndroidInstance>>;
-};
-
-declare class PopupMenuAndroid extends React.Component<Props> {}

package/Libraries/Components/PopupMenuAndroid/PopupMenuAndroid.js

@@ -1,33 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @format
- * @flow strict-local
- */
-
-import type {RefObject} from 'react';
-import type {Node} from 'react';
-
-import * as React from 'react';
-
-const UnimplementedView = require('../UnimplementedViews/UnimplementedView');
-
-export type PopupMenuAndroidInstance = {
-  +show: () => void,
-};
-
-type Props = {
-  menuItems: $ReadOnlyArray<string>,
-  onSelectionChange: number => void,
-  children: Node,
-  instanceRef: RefObject<?PopupMenuAndroidInstance>,
-};
-
-function PopupMenuAndroid(props: Props): Node {
-  return <UnimplementedView />;
-}
-
-export default PopupMenuAndroid;

package/Libraries/Components/PopupMenuAndroid/PopupMenuAndroidNativeComponent.js

@@ -1,13 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @format
- * @flow strict-local
- */
-
-export * from '../../../src/private/specs/components/PopupMenuAndroidNativeComponent';
-import PopupMenuAndroidNativeComponent from '../../../src/private/specs/components/PopupMenuAndroidNativeComponent';
-export default PopupMenuAndroidNativeComponent;

package/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultBindingsInstaller.kt

@@ -1,20 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.defaults
-
-import com.facebook.jni.annotations.DoNotStrip
-import com.facebook.react.common.annotations.UnstableReactNativeAPI
-import com.facebook.react.runtime.BindingsInstaller
-
-/**
- * A utility class that provides users a default [BindingsInstaller] class that's used to initialize
- * [ReactHostDelegate]
- */
-@DoNotStrip
-@UnstableReactNativeAPI
-public class DefaultBindingsInstaller : BindingsInstaller(null) {}

package/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/interfaces/TurboModule.kt

@@ -1,19 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.internal.turbomodule.core.interfaces
-/** All turbo modules should inherit from this interface */
-public interface TurboModule {
-  /** Initialize the TurboModule. */
-  public fun initialize()
-
-  /**
-   * Called during the turn down process of ReactHost. This method is called before React Native is
-   * stopped. Override this method to clean up resources used by the TurboModule.
-   */
-  public fun invalidate()
-}

package/ReactAndroid/src/main/java/com/facebook/react/views/popupmenu/PopupMenuSelectionEvent.kt

@@ -1,38 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-@file:Suppress("DEPRECATION") // We want to use RCTEventEmitter for interop purposes
-
-package com.facebook.react.views.popupmenu
-
-import com.facebook.react.bridge.Arguments
-import com.facebook.react.bridge.WritableMap
-import com.facebook.react.uimanager.events.Event
-import com.facebook.react.uimanager.events.RCTEventEmitter
-
-public class PopupMenuSelectionEvent(surfaceId: Int, viewId: Int, private val item: Int) :
-    Event<PopupMenuSelectionEvent>(surfaceId, viewId) {
-
-  override fun getEventName(): String {
-    return EVENT_NAME
-  }
-
-  override fun getEventData(): WritableMap {
-    val eventData: WritableMap = Arguments.createMap()
-    eventData.putInt("target", viewTag)
-    eventData.putDouble("item", item.toDouble())
-    return eventData
-  }
-
-  override fun dispatch(rctEventEmitter: RCTEventEmitter) {
-    rctEventEmitter.receiveEvent(viewTag, eventName, eventData)
-  }
-
-  public companion object {
-    public const val EVENT_NAME: String = "topSelectionChange"
-  }
-}

package/ReactAndroid/src/main/java/com/facebook/react/views/popupmenu/ReactPopupMenuContainer.kt

@@ -1,49 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.views.popupmenu
-
-import android.content.Context
-import android.os.Build
-import android.view.Menu
-import android.widget.FrameLayout
-import android.widget.PopupMenu
-import com.facebook.react.bridge.ReactContext
-import com.facebook.react.bridge.ReadableArray
-import com.facebook.react.uimanager.UIManagerHelper
-
-public class ReactPopupMenuContainer(context: Context) : FrameLayout(context) {
-  private var menuItems: ReadableArray? = null
-
-  public fun setMenuItems(items: ReadableArray?) {
-    menuItems = items
-  }
-
-  public fun showPopupMenu() {
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
-      val view = getChildAt(0)
-      val popupMenu = PopupMenu(context, view)
-      var menu = popupMenu.menu
-      val items = menuItems
-      if (items != null) {
-        for (i in 0 until items.size()) {
-          menu.add(Menu.NONE, Menu.NONE, i, items.getString(i))
-        }
-      }
-      popupMenu.setOnMenuItemClickListener { menuItem ->
-        val reactContext = context as ReactContext
-        val eventDispatcher = UIManagerHelper.getEventDispatcherForReactTag(reactContext, id)
-        if (eventDispatcher != null) {
-          val surfaceId = UIManagerHelper.getSurfaceId(reactContext)
-          eventDispatcher.dispatchEvent(PopupMenuSelectionEvent(surfaceId, id, menuItem.order))
-        }
-        true
-      }
-      popupMenu.show()
-    }
-  }
-}

package/ReactAndroid/src/main/java/com/facebook/react/views/popupmenu/ReactPopupMenuManager.kt

@@ -1,54 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.views.popupmenu
-
-import com.facebook.react.bridge.ReadableArray
-import com.facebook.react.module.annotations.ReactModule
-import com.facebook.react.uimanager.ThemedReactContext
-import com.facebook.react.uimanager.ViewGroupManager
-import com.facebook.react.uimanager.annotations.ReactProp
-import com.facebook.react.viewmanagers.AndroidPopupMenuManagerInterface
-
-@ReactModule(name = ReactPopupMenuManager.REACT_CLASS)
-public class ReactPopupMenuManager :
-    ViewGroupManager<ReactPopupMenuContainer>(),
-    AndroidPopupMenuManagerInterface<ReactPopupMenuContainer> {
-  override fun createViewInstance(reactContext: ThemedReactContext): ReactPopupMenuContainer {
-    return ReactPopupMenuContainer(reactContext)
-  }
-
-  @ReactProp(name = "menuItems")
-  override fun setMenuItems(view: ReactPopupMenuContainer, menuItems: ReadableArray?) {
-    view.setMenuItems(menuItems)
-  }
-
-  override fun getName(): String {
-    return REACT_CLASS
-  }
-
-  override fun receiveCommand(
-      view: ReactPopupMenuContainer,
-      commandId: String,
-      items: ReadableArray?
-  ) {
-    when (commandId) {
-      "show" -> show(view)
-      else -> {
-        // no-op
-      }
-    }
-  }
-
-  override fun show(popupMenu: ReactPopupMenuContainer) {
-    popupMenu.showPopupMenu()
-  }
-
-  public companion object {
-    public const val REACT_CLASS: String = "AndroidPopupMenu"
-  }
-}

package/src/private/specs/components/PopupMenuAndroidNativeComponent.js

@@ -1,47 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @flow strict-local
- * @format
- */
-
-import type {ViewProps} from '../../../../Libraries/Components/View/ViewPropTypes';
-import type {HostComponent} from '../../../../Libraries/Renderer/shims/ReactNativeTypes';
-import type {
-  DirectEventHandler,
-  Int32,
-} from '../../../../Libraries/Types/CodegenTypes';
-
-import codegenNativeCommands from '../../../../Libraries/Utilities/codegenNativeCommands';
-import codegenNativeComponent from '../../../../Libraries/Utilities/codegenNativeComponent';
-import * as React from 'react';
-
-type PopupMenuSelectionEvent = $ReadOnly<{
-  item: Int32,
-}>;
-
-type NativeProps = $ReadOnly<{
-  ...ViewProps,
-
-  //Props
-  menuItems?: ?$ReadOnlyArray<string>,
-
-  onSelectionChange?: DirectEventHandler<PopupMenuSelectionEvent>,
-}>;
-
-type ComponentType = HostComponent<NativeProps>;
-
-interface NativeCommands {
-  +show: (viewRef: React.ElementRef<ComponentType>) => void;
-}
-
-export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
-  supportedCommands: ['show'],
-});
-
-export default (codegenNativeComponent<NativeProps>(
-  'AndroidPopupMenu',
-): HostComponent<NativeProps>);