react-native 0.71.6 → 0.72.0-rc.1

package/ReactCommon/react/renderer/components/scrollview/primitives.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <optional>
+
 namespace facebook {
 namespace react {
 
@@ -23,5 +25,20 @@ enum class ContentInsetAdjustmentBehavior {
   Always
 };
 
+class ScrollViewMaintainVisibleContentPosition final {
+ public:
+  int minIndexForVisible{0};
+  std::optional<int> autoscrollToTopThreshold{};
+
+  bool operator==(const ScrollViewMaintainVisibleContentPosition &rhs) const {
+    return std::tie(this->minIndexForVisible, this->autoscrollToTopThreshold) ==
+        std::tie(rhs.minIndexForVisible, rhs.autoscrollToTopThreshold);
+  }
+
+  bool operator!=(const ScrollViewMaintainVisibleContentPosition &rhs) const {
+    return !(*this == rhs);
+  }
+};
+
 } // namespace react
 } // namespace facebook

package/ReactCommon/react/renderer/components/text/BaseTextProps.cpp

@@ -9,9 +9,9 @@
 
 #include <react/renderer/attributedstring/conversions.h>
 #include <react/renderer/core/CoreFeatures.h>
+#include <react/renderer/core/graphicsConversions.h>
 #include <react/renderer/core/propsConversions.h>
 #include <react/renderer/debug/DebugStringConvertibleItem.h>
-#include <react/renderer/graphics/conversions.h>
 
 namespace facebook::react {
 

package/ReactCommon/react/renderer/components/text/BaseTextProps.h

@@ -11,7 +11,6 @@
 #include <react/renderer/core/Props.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/graphics/Color.h>
-#include <react/renderer/graphics/Geometry.h>
 
 namespace facebook {
 namespace react {

package/ReactCommon/react/renderer/components/text/BaseTextShadowNode.cpp

@@ -11,6 +11,7 @@
 #include <react/renderer/components/text/RawTextShadowNode.h>
 #include <react/renderer/components/text/TextProps.h>
 #include <react/renderer/components/text/TextShadowNode.h>
+#include <react/renderer/core/TraitCast.h>
 #include <react/renderer/mounting/ShadowView.h>
 
 namespace facebook::react {

package/ReactCommon/react/renderer/components/text/ParagraphLayoutManager.cpp

@@ -0,0 +1,84 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "ParagraphLayoutManager.h"
+#include <folly/Hash.h>
+#include <react/renderer/core/CoreFeatures.h>
+
+namespace facebook::react {
+
+TextMeasurement ParagraphLayoutManager::measure(
+    AttributedString const &attributedString,
+    ParagraphAttributes const &paragraphAttributes,
+    LayoutConstraints layoutConstraints) const {
+  bool cacheLastTextMeasurement = CoreFeatures::cacheLastTextMeasurement;
+  if (cacheLastTextMeasurement &&
+      (layoutConstraints.maximumSize.width == availableWidth_ ||
+       layoutConstraints.maximumSize.width ==
+           cachedTextMeasurement_.size.width)) {
+    /* Yoga has requested measurement for this size before. Let's use cached
+     * value. `TextLayoutManager` might not have cached this because it could be
+     * using different width to generate cache key. This happens because Yoga
+     * switches between available width and exact width but since we already
+     * know exact width, it is wasteful to calculate it again.
+     */
+    return cachedTextMeasurement_;
+  }
+  if (CoreFeatures::cacheNSTextStorage) {
+    size_t newHash = folly::hash::hash_combine(
+        0,
+        textAttributedStringHashLayoutWise(attributedString),
+        paragraphAttributes);
+
+    if (!hostTextStorage_ || newHash != hash_) {
+      hostTextStorage_ = textLayoutManager_->getHostTextStorage(
+          attributedString, paragraphAttributes, layoutConstraints);
+      hash_ = newHash;
+    }
+  }
+
+  if (cacheLastTextMeasurement) {
+    cachedTextMeasurement_ = textLayoutManager_->measure(
+        AttributedStringBox(attributedString),
+        paragraphAttributes,
+        layoutConstraints,
+        hostTextStorage_);
+
+    availableWidth_ = layoutConstraints.maximumSize.width;
+
+    return cachedTextMeasurement_;
+  } else {
+    return textLayoutManager_->measure(
+        AttributedStringBox(attributedString),
+        paragraphAttributes,
+        layoutConstraints,
+        hostTextStorage_);
+  }
+}
+
+LinesMeasurements ParagraphLayoutManager::measureLines(
+    AttributedString const &attributedString,
+    ParagraphAttributes const &paragraphAttributes,
+    Size size) const {
+  return textLayoutManager_->measureLines(
+      attributedString, paragraphAttributes, size);
+}
+
+void ParagraphLayoutManager::setTextLayoutManager(
+    std::shared_ptr<TextLayoutManager const> textLayoutManager) const {
+  textLayoutManager_ = std::move(textLayoutManager);
+}
+
+std::shared_ptr<TextLayoutManager const>
+ParagraphLayoutManager::getTextLayoutManager() const {
+  return textLayoutManager_;
+}
+
+std::shared_ptr<void> ParagraphLayoutManager::getHostTextStorage() const {
+  return hostTextStorage_;
+}
+} // namespace facebook::react

package/ReactCommon/react/renderer/components/text/ParagraphLayoutManager.h

@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/attributedstring/AttributedString.h>
+#include <react/renderer/attributedstring/ParagraphAttributes.h>
+#include <react/renderer/core/LayoutConstraints.h>
+#include <react/renderer/textlayoutmanager/TextLayoutManager.h>
+
+namespace facebook::react {
+
+/*
+ * Serves as a middle man between `ParagraphShadowNode` and `TextLayoutManager`.
+ * On iOS, caches `NSTextStorage` for individual `ParagraphShadowNode` to make
+ * sure only one `NSTextStorage` is created for every string. `NSTextStorage`
+ * can be re created on native views layer but it is expensive. On Android, this
+ * class does not cache anything.
+ */
+class ParagraphLayoutManager {
+ public:
+  TextMeasurement measure(
+      AttributedString const &attributedString,
+      ParagraphAttributes const &paragraphAttributes,
+      LayoutConstraints layoutConstraints) const;
+
+  LinesMeasurements measureLines(
+      AttributedString const &attributedString,
+      ParagraphAttributes const &paragraphAttributes,
+      Size size) const;
+
+  void setTextLayoutManager(
+      std::shared_ptr<TextLayoutManager const> textLayoutManager) const;
+
+  /*
+   * Returns an opaque pointer to platform-specific `TextLayoutManager`.
+   * Is used on a native views layer to delegate text rendering to the manager.
+   */
+  std::shared_ptr<TextLayoutManager const> getTextLayoutManager() const;
+
+  /*
+   * Returns opaque shared_ptr holding `NSTextStorage`.
+   * May be nullptr.
+   * Is used on a native views layer to prevent `NSTextStorage` from being
+   * created twice.
+   */
+  std::shared_ptr<void> getHostTextStorage() const;
+
+ private:
+  std::shared_ptr<TextLayoutManager const> mutable textLayoutManager_{};
+  std::shared_ptr<void> mutable hostTextStorage_{};
+
+  /* The width Yoga set as maximum width.
+   * Yoga sometimes calls measure twice with two
+   * different maximum width. One if available space.
+   * The other one is exact space needed for the string.
+   * This happens when node is dirtied but its size is not affected.
+   * To deal with this inefficiency, we cache `TextMeasurement` for each
+   * `ParagraphShadowNode`. If Yoga tries to re-measure with available width
+   * or exact width, we provide it with the cached value.
+   */
+  Float mutable availableWidth_{};
+  TextMeasurement mutable cachedTextMeasurement_{};
+
+  size_t mutable hash_{};
+};
+} // namespace facebook::react

package/ReactCommon/react/renderer/components/text/ParagraphProps.cpp

@@ -66,6 +66,8 @@ void ParagraphProps::setProp(
   ViewProps::setProp(context, hash, propName, value);
   BaseTextProps::setProp(context, hash, propName, value);
 
+  static auto defaults = ParagraphProps{};
+
   // ParagraphAttributes has its own switch statement - to keep all
   // of these fields together, and because there are some collisions between
   // propnames parsed here and outside of ParagraphAttributes.
@@ -119,8 +121,8 @@ void ParagraphProps::setProp(
   }
 
   switch (hash) {
-    RAW_SET_PROP_SWITCH_CASE_BASIC(isSelectable, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(onTextLayout, {});
+    RAW_SET_PROP_SWITCH_CASE_BASIC(isSelectable);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(onTextLayout);
   }
 
   /*

package/ReactCommon/react/renderer/components/text/ParagraphShadowNode.cpp

@@ -13,6 +13,7 @@
 #include <react/renderer/attributedstring/AttributedStringBox.h>
 #include <react/renderer/components/view/ViewShadowNode.h>
 #include <react/renderer/components/view/conversions.h>
+#include <react/renderer/core/TraitCast.h>
 #include <react/renderer/graphics/rounding.h>
 #include <react/renderer/telemetry/TransactionTelemetry.h>
 
@@ -94,7 +95,8 @@ Content ParagraphShadowNode::getContentWithMeasuredAttachments(
 void ParagraphShadowNode::setTextLayoutManager(
     std::shared_ptr<TextLayoutManager const> textLayoutManager) {
   ensureUnsealed();
-  textLayoutManager_ = std::move(textLayoutManager);
+  getStateData().paragraphLayoutManager.setTextLayoutManager(
+      std::move(textLayoutManager));
 }
 
 void ParagraphShadowNode::updateStateIfNeeded(Content const &content) {
@@ -102,7 +104,7 @@ void ParagraphShadowNode::updateStateIfNeeded(Content const &content) {
 
   auto &state = getStateData();
 
-  react_native_assert(textLayoutManager_);
+  react_native_assert(state.paragraphLayoutManager.getTextLayoutManager());
 
   if (state.attributedString == content.attributedString) {
     return;
@@ -111,7 +113,7 @@ void ParagraphShadowNode::updateStateIfNeeded(Content const &content) {
   setStateData(ParagraphState{
       content.attributedString,
       content.paragraphAttributes,
-      textLayoutManager_});
+      state.paragraphLayoutManager});
 }
 
 #pragma mark - LayoutableShadowNode
@@ -135,11 +137,9 @@ Size ParagraphShadowNode::measureContent(
     attributedString.appendFragment({string, textAttributes, {}});
   }
 
-  return textLayoutManager_
-      ->measure(
-          AttributedStringBox{attributedString},
-          content.paragraphAttributes,
-          layoutConstraints)
+  return getStateData()
+      .paragraphLayoutManager
+      .measure(attributedString, content.paragraphAttributes, layoutConstraints)
       .size;
 }
 
@@ -156,13 +156,11 @@ void ParagraphShadowNode::layout(LayoutContext layoutContext) {
 
   updateStateIfNeeded(content);
 
-  auto measurement = textLayoutManager_->measure(
-      AttributedStringBox{content.attributedString},
-      content.paragraphAttributes,
-      layoutConstraints);
+  auto measurement = getStateData().paragraphLayoutManager.measure(
+      content.attributedString, content.paragraphAttributes, layoutConstraints);
 
   if (getConcreteProps().onTextLayout) {
-    auto linesMeasurements = textLayoutManager_->measureLines(
+    auto linesMeasurements = getStateData().paragraphLayoutManager.measureLines(
         content.attributedString,
         content.paragraphAttributes,
         measurement.size);
@@ -205,8 +203,8 @@ void ParagraphShadowNode::layout(LayoutContext layoutContext) {
     paragraphShadowNode =
         static_cast<ParagraphShadowNode *>(paragraphOwningShadowNode.get());
 
-    auto &layoutableShadowNode = const_cast<LayoutableShadowNode &>(
-        traitCast<LayoutableShadowNode const &>(*clonedShadowNode));
+    auto &layoutableShadowNode =
+        traitCast<LayoutableShadowNode &>(*clonedShadowNode);
 
     auto attachmentFrame = measurement.attachments[i].frame;
     auto attachmentSize = roundToPixel<&ceil>(

package/ReactCommon/react/renderer/components/text/ParagraphShadowNode.h

@@ -7,16 +7,14 @@
 
 #pragma once
 
-#include <folly/Optional.h>
+#include <react/renderer/components/text/BaseTextShadowNode.h>
 #include <react/renderer/components/text/ParagraphEventEmitter.h>
+#include <react/renderer/components/text/ParagraphLayoutManager.h>
 #include <react/renderer/components/text/ParagraphProps.h>
 #include <react/renderer/components/text/ParagraphState.h>
-#include <react/renderer/components/text/TextShadowNode.h>
 #include <react/renderer/components/view/ConcreteViewShadowNode.h>
-#include <react/renderer/core/ConcreteShadowNode.h>
 #include <react/renderer/core/LayoutContext.h>
 #include <react/renderer/core/ShadowNode.h>
-#include <react/renderer/textlayoutmanager/TextLayoutManager.h>
 
 namespace facebook {
 namespace react {
@@ -97,8 +95,6 @@ class ParagraphShadowNode final : public ConcreteViewShadowNode<
    */
   void updateStateIfNeeded(Content const &content);
 
-  std::shared_ptr<TextLayoutManager const> textLayoutManager_;
-
   /*
    * Cached content of the subtree started from the node.
    */

package/ReactCommon/react/renderer/components/text/ParagraphState.h

@@ -10,15 +10,14 @@
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/attributedstring/AttributedString.h>
 #include <react/renderer/attributedstring/ParagraphAttributes.h>
-#include <react/renderer/textlayoutmanager/TextLayoutManager.h>
+#include <react/renderer/components/text/ParagraphLayoutManager.h>
 
 #ifdef ANDROID
 #include <folly/dynamic.h>
 #include <react/renderer/mapbuffer/MapBuffer.h>
 #endif
 
-namespace facebook {
-namespace react {
+namespace facebook::react {
 
 #ifdef ANDROID
 // constants for Text State serialization
@@ -33,8 +32,7 @@ constexpr static MapBuffer::Key TX_STATE_KEY_MOST_RECENT_EVENT_COUNT = 3;
  * State for <Paragraph> component.
  * Represents what to render and how to render.
  */
-class ParagraphState final {
- public:
+struct ParagraphState {
   /*
    * All content of <Paragraph> component represented as an `AttributedString`.
    */
@@ -47,22 +45,22 @@ class ParagraphState final {
   ParagraphAttributes paragraphAttributes;
 
   /*
-   * `TextLayoutManager` provides a connection to platform-specific
+   * `ParagraphLayoutManager` provides a connection to platform-specific
    * text rendering infrastructure which is capable to render the
    * `AttributedString`.
    * This is not on every platform. This is not used on Android, but is
    * used on the iOS mounting layer.
    */
-  std::weak_ptr<TextLayoutManager const> layoutManager;
+  ParagraphLayoutManager paragraphLayoutManager;
 
 #ifdef ANDROID
   ParagraphState(
       AttributedString const &attributedString,
       ParagraphAttributes const &paragraphAttributes,
-      std::weak_ptr<const TextLayoutManager> const &layoutManager)
+      ParagraphLayoutManager const &paragraphLayoutManager)
       : attributedString(attributedString),
         paragraphAttributes(paragraphAttributes),
-        layoutManager(layoutManager) {}
+        paragraphLayoutManager(paragraphLayoutManager) {}
   ParagraphState() = default;
   ParagraphState(
       ParagraphState const &previousState,
@@ -74,5 +72,4 @@ class ParagraphState final {
 #endif
 };
 
-} // namespace react
-} // namespace facebook
+} // namespace facebook::react

package/ReactCommon/react/renderer/components/text/RawTextShadowNode.h

@@ -29,34 +29,13 @@ class RawTextShadowNode : public ConcreteShadowNode<
   using ConcreteShadowNode::ConcreteShadowNode;
   static ShadowNodeTraits BaseTraits() {
     auto traits = ConcreteShadowNode::BaseTraits();
-    traits.set(ShadowNodeTraits::Trait::RawText);
+    traits.set(IdentifierTrait());
     return traits;
   }
-};
-
-template <>
-inline RawTextShadowNode const &traitCast<RawTextShadowNode const &>(
-    ShadowNode const &shadowNode) {
-  bool castable =
-      shadowNode.getTraits().check(ShadowNodeTraits::Trait::RawText);
-  react_native_assert(castable);
-  (void)castable;
-  return static_cast<RawTextShadowNode const &>(shadowNode);
-}
-
-template <>
-inline RawTextShadowNode const *traitCast<RawTextShadowNode const *>(
-    ShadowNode const *shadowNode) {
-  if (!shadowNode) {
-    return nullptr;
+  static ShadowNodeTraits::Trait IdentifierTrait() {
+    return ShadowNodeTraits::Trait::RawText;
   }
-  bool castable =
-      shadowNode->getTraits().check(ShadowNodeTraits::Trait::RawText);
-  if (!castable) {
-    return nullptr;
-  }
-  return static_cast<RawTextShadowNode const *>(shadowNode);
-}
+};
 
 } // namespace react
 } // namespace facebook

package/ReactCommon/react/renderer/components/text/TextProps.h

@@ -12,7 +12,6 @@
 #include <react/renderer/core/Props.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/graphics/Color.h>
-#include <react/renderer/graphics/Geometry.h>
 
 namespace facebook {
 namespace react {

package/ReactCommon/react/renderer/components/text/TextShadowNode.h

@@ -34,11 +34,15 @@ class TextShadowNode : public ConcreteShadowNode<
 #ifdef ANDROID
     traits.set(ShadowNodeTraits::Trait::FormsView);
 #endif
-    traits.set(ShadowNodeTraits::Trait::Text);
+    traits.set(IdentifierTrait());
 
     return traits;
   }
 
+  static ShadowNodeTraits::Trait IdentifierTrait() {
+    return ShadowNodeTraits::Trait::Text;
+  }
+
   using ConcreteShadowNode::ConcreteShadowNode;
 
 #ifdef ANDROID
@@ -58,27 +62,5 @@ class TextShadowNode : public ConcreteShadowNode<
 #endif
 };
 
-template <>
-inline TextShadowNode const &traitCast<TextShadowNode const &>(
-    ShadowNode const &shadowNode) {
-  bool castable = shadowNode.getTraits().check(ShadowNodeTraits::Trait::Text);
-  react_native_assert(castable);
-  (void)castable;
-  return static_cast<TextShadowNode const &>(shadowNode);
-}
-
-template <>
-inline TextShadowNode const *traitCast<TextShadowNode const *>(
-    ShadowNode const *shadowNode) {
-  if (!shadowNode) {
-    return nullptr;
-  }
-  bool castable = shadowNode->getTraits().check(ShadowNodeTraits::Trait::Text);
-  if (!castable) {
-    return nullptr;
-  }
-  return static_cast<TextShadowNode const *>(shadowNode);
-}
-
 } // namespace react
 } // namespace facebook

package/ReactCommon/react/renderer/components/text/tests/ParagraphLocalDataTest.cpp

@@ -9,7 +9,6 @@
 
 #include <assert.h>
 #include <gtest/gtest.h>
-#include <react/debug/react_native_assert.h>
 #include <react/renderer/attributedstring/AttributedString.h>
 #include <react/renderer/attributedstring/TextAttributes.h>
 #include <react/renderer/attributedstring/primitives.h>
@@ -34,21 +33,19 @@ TEST(ParagraphLocalDataTest, testSomething) {
   text.fontWeight = FontWeight::Thin;
   text.fontVariant = FontVariant::TabularNums;
   fragment.textAttributes = text;
-  attString.prependFragment(fragment);
+  attributedString.prependFragment(fragment);
 
   auto paragraphState = ParagraphState{};
-  paragraphLocalData.attributedString = attributedString;
+  paragraphState.attributedString = attributedString;
 
   auto result = toDynamic(paragraphState)["attributedString"];
 
-  react_native_assert(result["string"] == fragment.string);
+  EXPECT_EQ(result["string"], fragment.string);
   auto textAttribute = result["fragments"][0]["textAttributes"];
-  react_native_assert(
-      textAttribute["foregroundColor"] == toDynamic(text.foregroundColor));
-  react_native_assert(textAttribute["opacity"] == text.opacity);
-  react_native_assert(textAttribute["fontStyle"] == toString(*text.fontStyle));
-  react_native_assert(
-      textAttribute["fontWeight"] == toString(*text.fontWeight));
+  EXPECT_EQ(textAttribute["foregroundColor"], toDynamic(text.foregroundColor));
+  EXPECT_EQ(textAttribute["opacity"], text.opacity);
+  EXPECT_EQ(textAttribute["fontStyle"], toString(*text.fontStyle));
+  EXPECT_EQ(textAttribute["fontWeight"], toString(*text.fontWeight));
 }
 
 #endif

package/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.cpp

@@ -8,8 +8,8 @@
 #include "AndroidTextInputProps.h"
 #include <react/renderer/components/image/conversions.h>
 #include <react/renderer/core/CoreFeatures.h>
+#include <react/renderer/core/graphicsConversions.h>
 #include <react/renderer/core/propsConversions.h>
-#include <react/renderer/graphics/conversions.h>
 
 namespace facebook::react {
 
@@ -269,6 +269,8 @@ void AndroidTextInputProps::setProp(
   ViewProps::setProp(context, hash, propName, value);
   BaseTextProps::setProp(context, hash, propName, value);
 
+  static auto defaults = AndroidTextInputProps{};
+
   // ParagraphAttributes has its own switch statement - to keep all
   // of these fields together, and because there are some collisions between
   // propnames parsed here and outside of ParagraphAttributes. For example,
@@ -323,55 +325,59 @@ void AndroidTextInputProps::setProp(
   }
 
   switch (hash) {
-    RAW_SET_PROP_SWITCH_CASE_BASIC(autoComplete, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(returnKeyLabel, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(numberOfLines, 0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(disableFullscreenUI, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textBreakStrategy, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(underlineColorAndroid, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(inlineImageLeft, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(inlineImagePadding, 0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(importantForAutofill, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(showSoftInputOnFocus, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(autoCapitalize, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(autoCorrect, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(autoFocus, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(allowFontScaling, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(maxFontSizeMultiplier, (Float)0.0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(editable, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(keyboardType, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(returnKeyType, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(maxLength, 0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(multiline, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(placeholder, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(placeholderTextColor, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(secureTextEntry, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(selectionColor, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(selection, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(this->value, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(defaultValue, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(selectTextOnFocus, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(submitBehavior, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(caretHidden, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(contextMenuHidden, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowColor, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowRadius, (Float)0.0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textDecorationLine, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(fontStyle, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowOffset, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(lineHeight, (Float)0.0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textTransform, {});
-    // RAW_SET_PROP_SWITCH_CASE_BASIC(color, {0}); // currently not being parsed
-    RAW_SET_PROP_SWITCH_CASE_BASIC(letterSpacing, (Float)0.0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(fontSize, (Float)0.0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textAlign, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(includeFontPadding, false);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(fontWeight, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(fontFamily, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(textAlignVertical, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(cursorColor, {});
-    RAW_SET_PROP_SWITCH_CASE_BASIC(mostRecentEventCount, 0);
-    RAW_SET_PROP_SWITCH_CASE_BASIC(text, {});
+    RAW_SET_PROP_SWITCH_CASE_BASIC(autoComplete);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(returnKeyLabel);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(numberOfLines);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(disableFullscreenUI);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textBreakStrategy);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(underlineColorAndroid);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(inlineImageLeft);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(inlineImagePadding);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(importantForAutofill);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(showSoftInputOnFocus);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(autoCapitalize);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(autoCorrect);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(autoFocus);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(allowFontScaling);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(maxFontSizeMultiplier);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(editable);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(keyboardType);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(returnKeyType);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(maxLength);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(multiline);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(placeholder);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(placeholderTextColor);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(secureTextEntry);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(selectionColor);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(selection);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(defaultValue);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(selectTextOnFocus);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(submitBehavior);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(caretHidden);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(contextMenuHidden);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowColor);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowRadius);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textDecorationLine);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(fontStyle);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textShadowOffset);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(lineHeight);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textTransform);
+    // RAW_SET_PROP_SWITCH_CASE_BASIC(color);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(letterSpacing);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(fontSize);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textAlign);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(includeFontPadding);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(fontWeight);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(fontFamily);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(textAlignVertical);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(cursorColor);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(mostRecentEventCount);
+    RAW_SET_PROP_SWITCH_CASE_BASIC(text);
+
+    case CONSTEXPR_RAW_PROPS_KEY_HASH("value"): {
+      fromRawValue(context, value, this->value, {});
+      return;
+    }
 
     // Paddings are not parsed at this level of the component (they're parsed in
     // ViewProps) but we do need to know if they're present or not. See