react-native 0.69.1 → 0.70.0-rc.0

package/ReactAndroid/src/main/java/com/facebook/react/views/common/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/java/jsr-305:jsr-305"),
         react_native_dep("third-party/android/androidx:annotation"),

package/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
         react_native_dep("third-party/android/androidx:core"),

package/ReactAndroid/src/main/java/com/facebook/react/views/image/BUCK

@@ -13,6 +13,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
         react_native_dep("third-party/android/androidx:core"),
@@ -41,6 +42,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
         react_native_dep("third-party/android/androidx:core"),

package/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/BUCK

@@ -12,6 +12,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     visibility = [
         "PUBLIC",
     ],
@@ -31,6 +32,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     visibility = [
         "PUBLIC",
     ],

package/ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
     ],

package/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java

@@ -166,7 +166,7 @@ public class ReactModalHostManager extends ViewGroupManager<ReactModalHostView>
 
   @Override
   public Object updateState(
-      ReactModalHostView view, ReactStylesDiffMap props, @Nullable StateWrapper stateWrapper) {
+      ReactModalHostView view, ReactStylesDiffMap props, StateWrapper stateWrapper) {
     view.getFabricViewStateManager().setStateWrapper(stateWrapper);
     Point modalSize = ModalHostHelper.getModalHostSize(view.getContext());
     view.updateState(modalSize.x, modalSize.y);

package/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     visibility = [
         "PUBLIC",
     ],

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
         react_native_dep("third-party/android/androidx:core"),

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java

@@ -25,13 +25,10 @@ import android.view.KeyEvent;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.ViewGroup;
-import android.view.accessibility.AccessibilityEvent;
 import android.widget.HorizontalScrollView;
 import android.widget.OverScroller;
 import androidx.annotation.Nullable;
-import androidx.core.view.AccessibilityDelegateCompat;
 import androidx.core.view.ViewCompat;
-import androidx.core.view.accessibility.AccessibilityNodeInfoCompat;
 import com.facebook.common.logging.FLog;
 import com.facebook.infer.annotation.Assertions;
 import com.facebook.react.common.ReactConstants;
@@ -122,22 +119,7 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
     mReactBackgroundManager = new ReactViewBackgroundManager(this);
     mFpsListener = fpsListener;
 
-    ViewCompat.setAccessibilityDelegate(
-        this,
-        new AccessibilityDelegateCompat() {
-          @Override
-          public void onInitializeAccessibilityEvent(View host, AccessibilityEvent event) {
-            super.onInitializeAccessibilityEvent(host, event);
-            event.setScrollable(mScrollEnabled);
-          }
-
-          @Override
-          public void onInitializeAccessibilityNodeInfo(
-              View host, AccessibilityNodeInfoCompat info) {
-            super.onInitializeAccessibilityNodeInfo(host, info);
-            info.setScrollable(mScrollEnabled);
-          }
-        });
+    ViewCompat.setAccessibilityDelegate(this, new ReactScrollViewAccessibilityDelegate());
 
     mScroller = getOverScrollerFromParent();
     mReactScrollViewScrollState =
@@ -147,6 +129,10 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
                 : ViewCompat.LAYOUT_DIRECTION_LTR);
   }
 
+  public boolean getScrollEnabled() {
+    return mScrollEnabled;
+  }
+
   @Nullable
   private OverScroller getOverScrollerFromParent() {
     OverScroller scroller;
@@ -408,7 +394,7 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
   }
 
   /** Returns whether the given descendent is partially scrolled in view */
-  private boolean isPartiallyScrolledInView(View descendent) {
+  public boolean isPartiallyScrolledInView(View descendent) {
     int scrollDelta = getScrollDelta(descendent);
     descendent.getDrawingRect(mTempRect);
     return scrollDelta != 0 && Math.abs(scrollDelta) < mTempRect.width();
@@ -559,6 +545,16 @@ public class ReactHorizontalScrollView extends HorizontalScrollView
     return super.onTouchEvent(ev);
   }
 
+  @Override
+  public boolean dispatchGenericPointerEvent(MotionEvent ev) {
+    // We do not dispatch the pointer event if its children are not supposed to receive it
+    if (!PointerEvents.canChildrenBeTouchTarget(mPointerEvents)) {
+      return false;
+    }
+
+    return super.dispatchGenericPointerEvent(ev);
+  }
+
   @Override
   public boolean executeKeyEvent(KeyEvent event) {
     int eventKeyCode = event.getKeyCode();

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java

@@ -8,10 +8,12 @@
 package com.facebook.react.views.scroll;
 
 import android.graphics.Color;
+import android.view.View;
 import androidx.annotation.Nullable;
 import androidx.core.view.ViewCompat;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
+import com.facebook.react.bridge.RetryableMountingLayerException;
 import com.facebook.react.module.annotations.ReactModule;
 import com.facebook.react.uimanager.PixelUtil;
 import com.facebook.react.uimanager.PointerEvents;
@@ -66,9 +68,7 @@ public class ReactHorizontalScrollViewManager extends ViewGroupManager<ReactHori
 
   @Override
   public Object updateState(
-      ReactHorizontalScrollView view,
-      ReactStylesDiffMap props,
-      @Nullable StateWrapper stateWrapper) {
+      ReactHorizontalScrollView view, ReactStylesDiffMap props, StateWrapper stateWrapper) {
     view.getFabricViewStateManager().setStateWrapper(stateWrapper);
     return null;
   }
@@ -210,8 +210,15 @@ public class ReactHorizontalScrollViewManager extends ViewGroupManager<ReactHori
   public void scrollToEnd(
       ReactHorizontalScrollView scrollView,
       ReactScrollViewCommandHelper.ScrollToEndCommandData data) {
-    // ScrollView always has one child - the scrollable area
-    int right = scrollView.getChildAt(0).getWidth() + scrollView.getPaddingRight();
+    // ScrollView always has one child - the scrollable area. However, it's possible today that we
+    // execute this method as view command before the child view is mounted. Here we will retry the
+    // view commands as a workaround.
+    @Nullable View child = scrollView.getChildAt(0);
+    if (child == null) {
+      throw new RetryableMountingLayerException(
+          "scrollToEnd called on HorizontalScrollView without child");
+    }
+    int right = child.getWidth() + scrollView.getPaddingRight();
     if (data.mAnimated) {
       scrollView.reactSmoothScrollTo(right, scrollView.getScrollY());
     } else {

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java

@@ -75,6 +75,7 @@ public class ReactScrollView extends ScrollView
   private final @Nullable OverScroller mScroller;
   private final VelocityHelper mVelocityHelper = new VelocityHelper();
   private final Rect mRect = new Rect(); // for reuse to avoid allocation
+  private final Rect mTempRect = new Rect();
   private final Rect mOverflowInset = new Rect();
 
   private boolean mActivelyScrolling;
@@ -120,6 +121,8 @@ public class ReactScrollView extends ScrollView
     mScroller = getOverScrollerFromParent();
     setOnHierarchyChangeListener(this);
     setScrollBarStyle(SCROLLBARS_OUTSIDE_OVERLAY);
+
+    ViewCompat.setAccessibilityDelegate(this, new ReactScrollViewAccessibilityDelegate());
   }
 
   @Override
@@ -191,6 +194,10 @@ public class ReactScrollView extends ScrollView
     mScrollEnabled = scrollEnabled;
   }
 
+  public boolean getScrollEnabled() {
+    return mScrollEnabled;
+  }
+
   public void setPagingEnabled(boolean pagingEnabled) {
     mPagingEnabled = pagingEnabled;
   }
@@ -299,6 +306,19 @@ public class ReactScrollView extends ScrollView
     super.requestChildFocus(child, focused);
   }
 
+  private int getScrollDelta(View descendent) {
+    descendent.getDrawingRect(mTempRect);
+    offsetDescendantRectToMyCoords(descendent, mTempRect);
+    return computeScrollDeltaToGetChildRectOnScreen(mTempRect);
+  }
+
+  /** Returns whether the given descendent is partially scrolled in view */
+  public boolean isPartiallyScrolledInView(View descendent) {
+    int scrollDelta = getScrollDelta(descendent);
+    descendent.getDrawingRect(mTempRect);
+    return scrollDelta != 0 && Math.abs(scrollDelta) < mTempRect.width();
+  }
+
   private void scrollToChild(View child) {
     Rect tempRect = new Rect();
     child.getDrawingRect(tempRect);
@@ -397,6 +417,16 @@ public class ReactScrollView extends ScrollView
     return super.onTouchEvent(ev);
   }
 
+  @Override
+  public boolean dispatchGenericPointerEvent(MotionEvent ev) {
+    // We do not dispatch the pointer event if its children are not supposed to receive it
+    if (!PointerEvents.canChildrenBeTouchTarget(mPointerEvents)) {
+      return false;
+    }
+
+    return super.dispatchGenericPointerEvent(ev);
+  }
+
   @Override
   public boolean executeKeyEvent(KeyEvent event) {
     int eventKeyCode = event.getKeyCode();

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewAccessibilityDelegate.java

@@ -0,0 +1,154 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.views.scroll;
+
+import android.view.View;
+import android.view.ViewGroup;
+import android.view.accessibility.AccessibilityEvent;
+import androidx.core.view.AccessibilityDelegateCompat;
+import androidx.core.view.accessibility.AccessibilityNodeInfoCompat;
+import com.facebook.react.R;
+import com.facebook.react.bridge.AssertionException;
+import com.facebook.react.bridge.ReactSoftExceptionLogger;
+import com.facebook.react.bridge.ReadableMap;
+import com.facebook.react.uimanager.ReactAccessibilityDelegate;
+
+public class ReactScrollViewAccessibilityDelegate extends AccessibilityDelegateCompat {
+  private final String TAG = ReactScrollViewAccessibilityDelegate.class.getSimpleName();
+
+  @Override
+  public void onInitializeAccessibilityEvent(View host, AccessibilityEvent event) {
+    super.onInitializeAccessibilityEvent(host, event);
+    if (host instanceof ReactScrollView || host instanceof ReactHorizontalScrollView) {
+      onInitializeAccessibilityEventInternal(host, event);
+    } else {
+      ReactSoftExceptionLogger.logSoftException(
+          TAG,
+          new AssertionException(
+              "ReactScrollViewAccessibilityDelegate should only be used with ReactScrollView or ReactHorizontalScrollView, not with class: "
+                  + host.getClass().getSimpleName()));
+    }
+  }
+
+  @Override
+  public void onInitializeAccessibilityNodeInfo(View host, AccessibilityNodeInfoCompat info) {
+    super.onInitializeAccessibilityNodeInfo(host, info);
+    if (host instanceof ReactScrollView || host instanceof ReactHorizontalScrollView) {
+      onInitializeAccessibilityNodeInfoInternal(host, info);
+    } else {
+      ReactSoftExceptionLogger.logSoftException(
+          TAG,
+          new AssertionException(
+              "ReactScrollViewAccessibilityDelegate should only be used with ReactScrollView or ReactHorizontalScrollView, not with class: "
+                  + host.getClass().getSimpleName()));
+    }
+  };
+
+  private void onInitializeAccessibilityEventInternal(View view, AccessibilityEvent event) {
+    final ReadableMap accessibilityCollection =
+        (ReadableMap) view.getTag(R.id.accessibility_collection);
+
+    if (accessibilityCollection != null) {
+      event.setItemCount(accessibilityCollection.getInt("itemCount"));
+      View contentView;
+      if (view instanceof ViewGroup) {
+        ViewGroup viewGroup = (ViewGroup) view;
+        contentView = viewGroup.getChildAt(0);
+      } else {
+        return;
+      }
+      Integer firstVisibleIndex = null;
+      Integer lastVisibleIndex = null;
+
+      if (!(contentView instanceof ViewGroup)) {
+        return;
+      }
+
+      for (int index = 0; index < ((ViewGroup) contentView).getChildCount(); index++) {
+        View nextChild = ((ViewGroup) contentView).getChildAt(index);
+        boolean isVisible;
+        if (view instanceof ReactScrollView) {
+          ReactScrollView scrollView = (ReactScrollView) view;
+          isVisible = scrollView.isPartiallyScrolledInView(nextChild);
+        } else if (view instanceof ReactHorizontalScrollView) {
+          ReactHorizontalScrollView scrollView = (ReactHorizontalScrollView) view;
+          isVisible = scrollView.isPartiallyScrolledInView(nextChild);
+        } else {
+          return;
+        }
+        ReadableMap accessibilityCollectionItem =
+            (ReadableMap) nextChild.getTag(R.id.accessibility_collection_item);
+
+        if (!(nextChild instanceof ViewGroup)) {
+          return;
+        }
+
+        int childCount = ((ViewGroup) nextChild).getChildCount();
+
+        // If this child's accessibilityCollectionItem is null, we'll check one more
+        // nested child.
+        // Happens when getItemLayout is not passed in FlatList which adds an additional
+        // View in the hierarchy.
+        if (childCount > 0 && accessibilityCollectionItem == null) {
+          View nestedNextChild = ((ViewGroup) nextChild).getChildAt(0);
+          if (nestedNextChild != null) {
+            ReadableMap nestedChildAccessibility =
+                (ReadableMap) nestedNextChild.getTag(R.id.accessibility_collection_item);
+            if (nestedChildAccessibility != null) {
+              accessibilityCollectionItem = nestedChildAccessibility;
+            }
+          }
+        }
+
+        if (isVisible == true && accessibilityCollectionItem != null) {
+          if (firstVisibleIndex == null) {
+            firstVisibleIndex = accessibilityCollectionItem.getInt("itemIndex");
+          }
+          lastVisibleIndex = accessibilityCollectionItem.getInt("itemIndex");
+        }
+
+        if (firstVisibleIndex != null && lastVisibleIndex != null) {
+          event.setFromIndex(firstVisibleIndex);
+          event.setToIndex(lastVisibleIndex);
+        }
+      }
+    }
+  }
+
+  private void onInitializeAccessibilityNodeInfoInternal(
+      View view, AccessibilityNodeInfoCompat info) {
+    final ReactAccessibilityDelegate.AccessibilityRole accessibilityRole =
+        (ReactAccessibilityDelegate.AccessibilityRole) view.getTag(R.id.accessibility_role);
+
+    if (accessibilityRole != null) {
+      ReactAccessibilityDelegate.setRole(info, accessibilityRole, view.getContext());
+    }
+
+    final ReadableMap accessibilityCollection =
+        (ReadableMap) view.getTag(R.id.accessibility_collection);
+
+    if (accessibilityCollection != null) {
+      int rowCount = accessibilityCollection.getInt("rowCount");
+      int columnCount = accessibilityCollection.getInt("columnCount");
+      boolean hierarchical = accessibilityCollection.getBoolean("hierarchical");
+
+      AccessibilityNodeInfoCompat.CollectionInfoCompat collectionInfoCompat =
+          AccessibilityNodeInfoCompat.CollectionInfoCompat.obtain(
+              rowCount, columnCount, hierarchical);
+      info.setCollectionInfo(collectionInfoCompat);
+    }
+
+    if (view instanceof ReactScrollView) {
+      ReactScrollView scrollView = (ReactScrollView) view;
+      info.setScrollable(scrollView.getScrollEnabled());
+    } else if (view instanceof ReactHorizontalScrollView) {
+      ReactHorizontalScrollView scrollView = (ReactHorizontalScrollView) view;
+      info.setScrollable(scrollView.getScrollEnabled());
+    }
+  }
+};

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java

@@ -285,6 +285,9 @@ public class ReactScrollViewManager extends ViewGroupManager<ReactScrollView>
   @Override
   public void scrollToEnd(
       ReactScrollView scrollView, ReactScrollViewCommandHelper.ScrollToEndCommandData data) {
+    // ScrollView always has one child - the scrollable area. However, it's possible today that we
+    // execute this method as view command before the child view is mounted. Here we will retry the
+    // view commands as a workaround.
     View child = scrollView.getChildAt(0);
     if (child == null) {
       throw new RetryableMountingLayerException("scrollToEnd called on ScrollView without child");
@@ -328,7 +331,7 @@ public class ReactScrollViewManager extends ViewGroupManager<ReactScrollView>
 
   @Override
   public Object updateState(
-      ReactScrollView view, ReactStylesDiffMap props, @Nullable StateWrapper stateWrapper) {
+      ReactScrollView view, ReactStylesDiffMap props, StateWrapper stateWrapper) {
     view.getFabricViewStateManager().setStateWrapper(stateWrapper);
     return null;
   }

package/ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     visibility = [
         "PUBLIC",
     ],

package/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:annotation"),
         react_native_dep("third-party/android/androidx:core"),

package/ReactAndroid/src/main/java/com/facebook/react/views/switchview/BUCK

@@ -9,6 +9,7 @@ rn_android_library(
         "pfh:ReactNative_CommonInfrastructurePlaceholder",
         "supermodule:xplat/default/public.react_native.infra",
     ],
+    language = "JAVA",
     provided_deps = [
         react_native_dep("third-party/android/androidx:appcompat"),
         react_native_dep("third-party/android/androidx:core"),

package/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactFontManager.java

@@ -110,6 +110,16 @@ public class ReactFontManager {
     }
   }
 
+  /**
+   * Equivalent method to {@see addCustomFont(Context, String, int)} which accepts a Typeface
+   * object.
+   */
+  public void addCustomFont(String fontFamily, @Nullable Typeface font) {
+    if (font != null) {
+      mCustomTypefaceCache.put(fontFamily, font);
+    }
+  }
+
   /**
    * Add additional font family, or replace the exist one in the font memory cache.
    *

package/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java

@@ -193,24 +193,25 @@ public abstract class ReactTextAnchorViewManager<T extends View, C extends React
 
   @ReactProp(name = "dataDetectorType")
   public void setDataDetectorType(ReactTextView view, @Nullable String type) {
-    switch (type) {
-      case "phoneNumber":
-        view.setLinkifyMask(Linkify.PHONE_NUMBERS);
-        break;
-      case "link":
-        view.setLinkifyMask(Linkify.WEB_URLS);
-        break;
-      case "email":
-        view.setLinkifyMask(Linkify.EMAIL_ADDRESSES);
-        break;
-      case "all":
-        view.setLinkifyMask(Linkify.ALL);
-        break;
-      case "none":
-      default:
-        view.setLinkifyMask(0);
-        break;
+    if (type != null) {
+      switch (type) {
+        case "phoneNumber":
+          view.setLinkifyMask(Linkify.PHONE_NUMBERS);
+          return;
+        case "link":
+          view.setLinkifyMask(Linkify.WEB_URLS);
+          return;
+        case "email":
+          view.setLinkifyMask(Linkify.EMAIL_ADDRESSES);
+          return;
+        case "all":
+          view.setLinkifyMask(Linkify.ALL);
+          return;
+      }
     }
+
+    // "none" case, default, and null type are equivalent.
+    view.setLinkifyMask(0);
   }
 
   @ReactProp(name = "onInlineViewLayout")

package/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java

@@ -52,25 +52,103 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
       new ViewGroup.LayoutParams(0, 0);
 
   private boolean mContainsImages;
-  private int mDefaultGravityHorizontal;
-  private int mDefaultGravityVertical;
-  private int mTextAlign = Gravity.NO_GRAVITY;
-  private int mNumberOfLines = ViewDefaults.NUMBER_OF_LINES;
-  private TextUtils.TruncateAt mEllipsizeLocation = TextUtils.TruncateAt.END;
-  private boolean mAdjustsFontSizeToFit = false;
-  private int mLinkifyMaskType = 0;
+  private final int mDefaultGravityHorizontal;
+  private final int mDefaultGravityVertical;
+  private int mTextAlign;
+  private int mNumberOfLines;
+  private TextUtils.TruncateAt mEllipsizeLocation;
+  private boolean mAdjustsFontSizeToFit;
+  private int mLinkifyMaskType;
   private boolean mNotifyOnInlineViewLayout;
-  private boolean mTextIsSelectable = false;
+  private boolean mTextIsSelectable;
 
   private ReactViewBackgroundManager mReactBackgroundManager;
   private Spannable mSpanned;
 
   public ReactTextView(Context context) {
     super(context);
-    mReactBackgroundManager = new ReactViewBackgroundManager(this);
+
+    // Get these defaults only during the constructor - these should never be set otherwise
     mDefaultGravityHorizontal =
         getGravity() & (Gravity.HORIZONTAL_GRAVITY_MASK | Gravity.RELATIVE_HORIZONTAL_GRAVITY_MASK);
     mDefaultGravityVertical = getGravity() & Gravity.VERTICAL_GRAVITY_MASK;
+
+    initView();
+  }
+
+  /**
+   * Set all default values here as opposed to in the constructor or field defaults. It is important
+   * that these properties are set during the constructor, but also on-demand whenever an existing
+   * ReactTextView is recycled.
+   */
+  private void initView() {
+    if (mReactBackgroundManager != null) {
+      // make sure old background manager doesn't have any references back to this View
+      mReactBackgroundManager.cleanup();
+    }
+
+    mReactBackgroundManager = new ReactViewBackgroundManager(this);
+
+    mTextAlign = Gravity.NO_GRAVITY;
+    mNumberOfLines = ViewDefaults.NUMBER_OF_LINES;
+    mAdjustsFontSizeToFit = false;
+    mLinkifyMaskType = 0;
+    mTextIsSelectable = false;
+    mEllipsizeLocation = TextUtils.TruncateAt.END;
+
+    mSpanned = null;
+  }
+
+  /* package */ void recycleView() {
+    // Set default field values
+    initView();
+
+    // Defaults for these fields:
+    // https://github.com/aosp-mirror/platform_frameworks_base/blob/master/core/java/android/widget/TextView.java#L1061
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+      setBreakStrategy(Layout.BREAK_STRATEGY_SIMPLE);
+    }
+    setMovementMethod(getDefaultMovementMethod());
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+      setJustificationMode(Layout.JUSTIFICATION_MODE_NONE);
+    }
+
+    // reset text
+    setLayoutParams(EMPTY_LAYOUT_PARAMS);
+    super.setText(null);
+
+    // Call setters to ensure that any super setters are called
+    setGravityHorizontal(mDefaultGravityHorizontal);
+    setGravityVertical(mDefaultGravityVertical);
+    setNumberOfLines(mNumberOfLines);
+    setAdjustFontSizeToFit(mAdjustsFontSizeToFit);
+    setLinkifyMask(mLinkifyMaskType);
+    setTextIsSelectable(mTextIsSelectable);
+
+    // Default true:
+    // https://github.com/aosp-mirror/platform_frameworks_base/blob/master/core/java/android/widget/TextView.java#L9347
+    setIncludeFontPadding(true);
+    setEnabled(true);
+
+    // reset data detectors
+    setLinkifyMask(0);
+
+    setEllipsizeLocation(mEllipsizeLocation);
+
+    // View flags - defaults are here:
+    // https://android.googlesource.com/platform/frameworks/base/+/98e54bb941cb6feb07127b75da37833281951d52/core/java/android/view/View.java#5311
+    //         mViewFlags = SOUND_EFFECTS_ENABLED | HAPTIC_FEEDBACK_ENABLED |
+    // LAYOUT_DIRECTION_INHERIT;
+    setEnabled(true);
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+      setFocusable(View.FOCUSABLE_AUTO);
+    }
+
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+      setHyphenationFrequency(Layout.HYPHENATION_FREQUENCY_NONE);
+    }
+
+    updateView(); // call after changing ellipsizeLocation in particular
   }
 
   private static WritableMap inlineViewJson(