react-native 0.68.2 → 0.69.0-rc.2

package/ReactCommon/hermes/inspector/tools/message_types.txt

@@ -28,8 +28,12 @@ HeapProfiler.heapStatsUpdate
 HeapProfiler.lastSeenObjectId
 HeapProfiler.getObjectByHeapObjectId
 HeapProfiler.getHeapObjectId
+Profiler.start
+Profiler.stop
+Runtime.callFunctionOn
 Runtime.consoleAPICalled
 Runtime.evaluate
 Runtime.executionContextCreated
+Runtime.getHeapUsage
 Runtime.getProperties
 Runtime.runIfWaitingForDebugger

package/ReactCommon/hermes/inspector/tools/msggen/package.json

@@ -12,7 +12,7 @@
     "test": "jest"
   },
   "dependencies": {
-    "devtools-protocol": "0.0.730699",
+    "devtools-protocol": "0.0.959523",
     "yargs": "^14.2.0"
   },
   "devDependencies": {

package/ReactCommon/hermes/inspector/tools/msggen/src/GeneratedHeader.js

@@ -12,5 +12,5 @@
 
 // placeholder token that will be replaced by signedsource script
 export const GeneratedHeader: string =
-  '// Copyright 2004-present Facebook. All Rights Reserved.\n' +
+  '// Copyright (c) Meta Platforms, Inc. and affiliates. All Rights Reserved.\n' +
   '// @generated <<SignedSource::*O*zOeWoEQle#+L!plEphiEmie@IsG>>';

package/ReactCommon/hermes/inspector/tools/msggen/src/ImplementationWriter.js

@@ -266,13 +266,26 @@ export function emitRequestDef(stream: Writable, command: Command) {
     assign(method, obj, "method");\n\n`);
 
   if (props.length > 0) {
-    stream.write('dynamic params = obj.at("params");\n');
+    const optionalParams = props.every(p => p.optional);
+    if (optionalParams) {
+      stream.write(`
+        auto it = obj.find("params");
+        if (it != obj.items().end()) {
+          dynamic params = it->second;
+      `);
+    } else {
+      stream.write('dynamic params = obj.at("params");\n');
+    }
 
     for (const prop of props) {
       const id = prop.getCppIdentifier();
       const name = prop.name;
       stream.write(`assign(${id}, params, "${name}");\n`);
     }
+
+    if (optionalParams) {
+      stream.write('}');
+    }
   }
 
   stream.write('}\n\n');

package/ReactCommon/hermes/inspector/tools/msggen/src/Property.js

@@ -195,7 +195,7 @@ class ArrayProperty extends Property {
 
   getFullCppType(): string {
     let elemType: string = 'folly::dynamic';
-    let recursive = false;
+    let recursive: ?(false | boolean) = false;
 
     if (this.items) {
       if (this.items.type) {

package/ReactCommon/hermes/inspector/tools/msggen/src/index.js

@@ -41,6 +41,7 @@ const proto = mergeDomains(standard, custom);
 function parseDomains(
   domainObjs: Array<any>,
   ignoreExperimental: boolean,
+  includeExperimental: Set<string>,
 ): Descriptor {
   const desc = {
     types: [],
@@ -59,7 +60,12 @@ function parseDomains(
     }
 
     for (const commandObj of obj.commands || []) {
-      const command = Command.create(domain, commandObj, ignoreExperimental);
+      const command = Command.create(
+        domain,
+        commandObj,
+        !includeExperimental.has(`${domain}.${commandObj.name}`) &&
+          ignoreExperimental,
+      );
       if (command) {
         desc.commands.push(command);
       }
@@ -199,18 +205,27 @@ function main() {
     .boolean('e')
     .alias('e', 'ignore-experimental')
     .describe('e', 'ignore experimental commands, props, and types')
+    .alias('i', 'include-experimental')
+    .describe('i', 'experimental commands to include')
     .alias('r', 'roots')
     .describe('r', 'path to a file listing root types, events, and commands')
     .nargs('r', 1)
     .demandCommand(2, 2).argv;
 
   const ignoreExperimental = !!args.e;
+  const includeExperimental = new Set(
+    typeof args.i === 'string' ? args.i.split(',') : [],
+  );
   const [headerPath, implPath] = args._;
 
   const headerStream = fs.createWriteStream(headerPath);
   const implStream = fs.createWriteStream(implPath);
 
-  const desc = parseDomains(proto.domains, ignoreExperimental);
+  const desc = parseDomains(
+    proto.domains,
+    ignoreExperimental,
+    includeExperimental,
+  );
   const graph = buildGraph(desc);
   const roots = parseRoots(desc, String(args.roots));
 

package/ReactCommon/hermes/inspector/tools/msggen/yarn.lock

@@ -2434,10 +2434,10 @@ detect-newline@^3.0.0:
   resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-3.1.0.tgz#576f5dfc63ae1a192ff192d8ad3af6308991b651"
   integrity sha512-TLz+x/vEXm/Y7P7wn1EJFNLxYpUD4TgMosxY6fAVJUnJMbupHBOncxyWUG9OpTaH9EBD7uFI5LfEgmMOc54DsA==
 
-devtools-protocol@0.0.730699:
-  version "0.0.730699"
-  resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.730699.tgz#4d18f6a9b7fb7cf3f1ffe73bfe14aad66cf3b2ef"
-  integrity sha512-dprBpuPzVIIXXL6GevzhvWe2wg836h3d5hY+n6IzzHbKLsUh6QlVmcIy15za0J3MhDFbmEH60s6uYsrw/tgBbw==
+devtools-protocol@0.0.959523:
+  version "0.0.959523"
+  resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.959523.tgz#a7ce62c6b88876081fe5bec866f70e467bc021ba"
+  integrity sha512-taOcAND/oJA5FhJD2I3RA+I8RPdrpPJWwvMBPzTq7Sugev1xTOG3lgtlSfkh5xkjTYw0Ti2CRQq016goFHMoPQ==
 
 diff-sequences@^26.6.2:
   version "26.6.2"

package/ReactCommon/hermes/inspector/tools/run_msggen

@@ -2,24 +2,29 @@
 
 set -e
 
-DIR=$(dirname "${BASH_SOURCE[0]}")
+DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)
+
+MSGTYPES_PATH="${DIR}/message_types.txt"
+HEADER_PATH="${DIR}/../chrome/MessageTypes.h"
+CPP_PATH="${DIR}/../chrome/MessageTypes.cpp"
+
+FBSOURCE=$(hg root)
+CLANG_FORMAT="${FBSOURCE}/tools/third-party/clang-format/clang-format"
+SIGNEDSOURCE="${FBSOURCE}/tools/signedsource"
+
 cd "${DIR}/msggen"
 
 yarn install
 yarn build
 
-FBSOURCE=$(hg root)
-MSGTYPES_PATH="${FBSOURCE}/xplat/js/react-native-github/ReactCommon/hermes/inspector/tools/message_types.txt"
-HEADER_PATH="${FBSOURCE}/xplat/js/react-native-github/ReactCommon/hermes/inspector/chrome/MessageTypes.h"
-CPP_PATH="${FBSOURCE}/xplat/js/react-native-github/ReactCommon/hermes/inspector/chrome/MessageTypes.cpp"
-
 node bin/index.js \
   --ignore-experimental \
-  --roots "$MSGTYPES_PATH" \
-  "$HEADER_PATH" "$CPP_PATH"
+  --include-experimental=Runtime.getHeapUsage \
+  --roots "${MSGTYPES_PATH}" \
+  "${HEADER_PATH}" "${CPP_PATH}"
 
-clang-format -i --style=file "$HEADER_PATH"
-clang-format -i --style=file "$CPP_PATH"
+"${CLANG_FORMAT}" -i --style=file "${HEADER_PATH}"
+"${CLANG_FORMAT}" -i --style=file "${CPP_PATH}"
 
-"${FBSOURCE}/tools/signedsource" sign "$HEADER_PATH"
-"${FBSOURCE}/tools/signedsource" sign "$CPP_PATH"
+"${SIGNEDSOURCE}" sign "${HEADER_PATH}"
+"${SIGNEDSOURCE}" sign "${CPP_PATH}"

package/ReactCommon/jsi/Android.mk

@@ -16,7 +16,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH)
 LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
 
 LOCAL_CFLAGS := -fexceptions -frtti -O3
-LOCAL_SHARED_LIBRARIES := libfolly_json glog
+LOCAL_SHARED_LIBRARIES := libfolly_runtime glog
 
 include $(BUILD_SHARED_LIBRARY)
 
@@ -32,7 +32,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH)
 LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
 
 LOCAL_CFLAGS := -fexceptions -frtti -O3
-LOCAL_SHARED_LIBRARIES := libfolly_json libjsc glog
+LOCAL_SHARED_LIBRARIES := libfolly_runtime libjsc glog
 
 # TODO: Remove this flag when ready.
 # Android has this enabled by default, but the flag is still needed for iOS.

package/ReactCommon/jsi/BUCK

@@ -27,7 +27,10 @@ rn_xplat_cxx_library(
         "-Wglobal-constructors",
         "-Wmissing-prototypes",
     ],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     visibility = ["PUBLIC"],
 )
 
@@ -41,7 +44,10 @@ rn_xplat_cxx_library(
         "jsi/JSIDynamic.h",
     ],
     fbobjc_force_static = True,
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     visibility = [
         "PUBLIC",
     ],
@@ -68,7 +74,10 @@ rn_xplat_cxx_library(
     fbobjc_frameworks = [
         "$SDKROOT/System/Library/Frameworks/JavaScriptCore.framework",
     ],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     platforms = APPLE,
     visibility = ["PUBLIC"],
     xplat_mangled_args = {

package/ReactCommon/jsi/CMakeLists.txt

@@ -0,0 +1,43 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+##################
+###    jsi     ###
+##################
+
+cmake_minimum_required(VERSION 3.13)
+set(CMAKE_VERBOSE_MAKEFILE on)
+
+add_compile_options(
+        -fexceptions
+        -frtti
+        -O3
+        -Wno-unused-lambda-capture
+        -DLOG_TAG=\"ReactNative\")
+
+file(GLOB jsi_SRC CONFIGURE_DEPENDS jsi/*.cpp)
+add_library(jsi SHARED ${jsi_SRC})
+
+target_include_directories(jsi PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
+
+target_link_libraries(jsi
+        folly_runtime
+        glog)
+
+##################
+### jscruntime ###
+##################
+
+add_library(jscruntime STATIC
+        JSCRuntime.h
+        JSCRuntime.cpp)
+
+target_include_directories(jscruntime PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
+
+target_link_libraries(jscruntime folly_runtime jsc glog)
+
+# TODO: Remove this flag when ready.
+# Android has this enabled by default, but the flag is still needed for iOS.
+target_compile_options(jscruntime PRIVATE -DRN_FABRIC_ENABLED)

package/ReactCommon/jsi/JSCRuntime.cpp

@@ -151,6 +151,7 @@ class JSCRuntime : public jsi::Runtime {
   jsi::PropNameID createPropNameIDFromUtf8(const uint8_t *utf8, size_t length)
       override;
   jsi::PropNameID createPropNameIDFromString(const jsi::String &str) override;
+  jsi::PropNameID createPropNameIDFromSymbol(const jsi::Symbol &sym) override;
   std::string utf8(const jsi::PropNameID &) override;
   bool compare(const jsi::PropNameID &, const jsi::PropNameID &) override;
 
@@ -653,6 +654,13 @@ jsi::PropNameID JSCRuntime::createPropNameIDFromString(const jsi::String &str) {
   return createPropNameID(stringRef(str));
 }
 
+jsi::PropNameID JSCRuntime::createPropNameIDFromSymbol(const jsi::Symbol &sym) {
+  // TODO: Support for symbols through the native API in JSC is very limited.
+  // While we could construct a PropNameID here, we would not be able to get a
+  // symbol property through the C++ API.
+  throw std::logic_error("Not implemented");
+}
+
 std::string JSCRuntime::utf8(const jsi::PropNameID &sym) {
   return JSStringToSTLString(stringRef(sym));
 }

package/ReactCommon/jsi/React-jsi.podspec

@@ -27,7 +27,7 @@ Pod::Spec.new do |s|
   s.homepage               = "https://reactnative.dev/"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0" }
+  s.platforms              = { :ios => "12.4" }
   s.source                 = source
   s.source_files           = "**/*.{cpp,h}"
   s.exclude_files          = "**/test/*"

package/ReactCommon/jsi/jsi/decorator.h

@@ -176,6 +176,9 @@ class RuntimeDecorator : public Base, private jsi::Instrumentation {
   PropNameID createPropNameIDFromString(const String& str) override {
     return plain_.createPropNameIDFromString(str);
   };
+  PropNameID createPropNameIDFromSymbol(const Symbol& sym) override {
+    return plain_.createPropNameIDFromSymbol(sym);
+  };
   std::string utf8(const PropNameID& id) override {
     return plain_.utf8(id);
   };

package/ReactCommon/jsi/jsi/jsi.cpp

@@ -30,6 +30,8 @@ std::string kindToString(const Value& v, Runtime* rt = nullptr) {
     return "a number";
   } else if (v.isString()) {
     return "a string";
+  } else if (v.isSymbol()) {
+    return "a symbol";
   } else {
     assert(v.isObject() && "Expecting object.");
     return rt != nullptr && v.getObject(*rt).isFunction(*rt) ? "a function"
@@ -281,6 +283,15 @@ bool Value::strictEquals(Runtime& runtime, const Value& a, const Value& b) {
   return false;
 }
 
+bool Value::asBool() const {
+  if (!isBool()) {
+    throw JSINativeException(
+        "Value is " + kindToString(*this) + ", expected a boolean");
+  }
+
+  return getBool();
+}
+
 double Value::asNumber() const {
   if (!isNumber()) {
     throw JSINativeException(

package/ReactCommon/jsi/jsi/jsi.h

@@ -274,6 +274,7 @@ class JSI_EXPORT Runtime {
       const uint8_t* utf8,
       size_t length) = 0;
   virtual PropNameID createPropNameIDFromString(const String& str) = 0;
+  virtual PropNameID createPropNameIDFromSymbol(const Symbol& sym) = 0;
   virtual std::string utf8(const PropNameID&) = 0;
   virtual bool compare(const PropNameID&, const PropNameID&) = 0;
 
@@ -406,6 +407,7 @@ class JSI_EXPORT PropNameID : public Pointer {
   }
 
   /// Create a PropNameID from utf8 values.  The data is copied.
+  /// Results are undefined if \p utf8 contains invalid code points.
   static PropNameID
   forUtf8(Runtime& runtime, const uint8_t* utf8, size_t length) {
     return runtime.createPropNameIDFromUtf8(utf8, length);
@@ -413,6 +415,7 @@ class JSI_EXPORT PropNameID : public Pointer {
 
   /// Create a PropNameID from utf8-encoded octets stored in a
   /// std::string.  The string data is transformed and copied.
+  /// Results are undefined if \p utf8 contains invalid code points.
   static PropNameID forUtf8(Runtime& runtime, const std::string& utf8) {
     return runtime.createPropNameIDFromUtf8(
         reinterpret_cast<const uint8_t*>(utf8.data()), utf8.size());
@@ -423,6 +426,11 @@ class JSI_EXPORT PropNameID : public Pointer {
     return runtime.createPropNameIDFromString(str);
   }
 
+  /// Create a PropNameID from a JS symbol.
+  static PropNameID forSymbol(Runtime& runtime, const jsi::Symbol& sym) {
+    return runtime.createPropNameIDFromSymbol(sym);
+  }
+
   // Creates a vector of PropNameIDs constructed from given arguments.
   template <typename... Args>
   static std::vector<PropNameID> names(Runtime& runtime, Args&&... args);
@@ -502,14 +510,16 @@ class JSI_EXPORT String : public Pointer {
   }
 
   /// Create a JS string from utf8-encoded octets.  The string data is
-  /// transformed and copied.
+  /// transformed and copied.  Results are undefined if \p utf8 contains invalid
+  /// code points.
   static String
   createFromUtf8(Runtime& runtime, const uint8_t* utf8, size_t length) {
     return runtime.createStringFromUtf8(utf8, length);
   }
 
   /// Create a JS string from utf8-encoded octets stored in a
-  /// std::string.  The string data is transformed and copied.
+  /// std::string.  The string data is transformed and copied.  Results are
+  /// undefined if \p utf8 contains invalid code points.
   static String createFromUtf8(Runtime& runtime, const std::string& utf8) {
     return runtime.createStringFromUtf8(
         reinterpret_cast<const uint8_t*>(utf8.data()), utf8.length());
@@ -982,7 +992,7 @@ class JSI_EXPORT Value {
 
   /// Copies a Symbol lvalue into a new JS value.
   Value(Runtime& runtime, const Symbol& sym) : Value(SymbolKind) {
-    new (&data_.pointer) String(runtime.cloneSymbol(sym.ptr_));
+    new (&data_.pointer) Symbol(runtime.cloneSymbol(sym.ptr_));
   }
 
   /// Copies a String lvalue into a new JS value.
@@ -1068,6 +1078,10 @@ class JSI_EXPORT Value {
     return data_.boolean;
   }
 
+  /// \return the boolean value, or throws JSIException if not a
+  /// boolean.
+  bool asBool() const;
+
   /// \return the number value, or asserts if not a number.
   double getNumber() const {
     assert(isNumber());
@@ -1238,11 +1252,13 @@ class JSI_EXPORT JSIException : public std::exception {
   JSIException(std::string what) : what_(std::move(what)){};
 
  public:
+  JSIException(const JSIException&) = default;
+
   virtual const char* what() const noexcept override {
     return what_.c_str();
   }
 
-  virtual ~JSIException();
+  virtual ~JSIException() override;
 
  protected:
   std::string what_;
@@ -1254,6 +1270,8 @@ class JSI_EXPORT JSINativeException : public JSIException {
  public:
   JSINativeException(std::string what) : JSIException(std::move(what)) {}
 
+  JSINativeException(const JSINativeException&) = default;
+
   virtual ~JSINativeException();
 };
 
@@ -1283,6 +1301,8 @@ class JSI_EXPORT JSError : public JSIException {
   /// but necessary to avoid ambiguity with the above.
   JSError(std::string what, Runtime& rt, Value&& value);
 
+  JSError(const JSError&) = default;
+
   virtual ~JSError();
 
   const std::string& getStack() const {

package/ReactCommon/jsi/jsi/jsilib.h

@@ -15,7 +15,7 @@ namespace jsi {
 class FileBuffer : public Buffer {
  public:
   FileBuffer(const std::string& path);
-  ~FileBuffer();
+  ~FileBuffer() override;
 
   size_t size() const override {
     return size_;

package/ReactCommon/jsi/jsi/test/testlib.cpp

@@ -849,6 +849,8 @@ TEST_P(JSITest, ValueTest) {
   EXPECT_EQ(eval("'str'").getString(rt).utf8(rt), "str");
   EXPECT_TRUE(eval("[]").getObject(rt).isArray(rt));
 
+  EXPECT_TRUE(eval("true").asBool());
+  EXPECT_THROW(eval("123").asBool(), JSIException);
   EXPECT_EQ(eval("456").asNumber(), 456);
   EXPECT_THROW(eval("'word'").asNumber(), JSIException);
   EXPECT_EQ(
@@ -1423,7 +1425,7 @@ TEST_P(JSITest, MultilevelDecoratedHostObject) {
   EXPECT_EQ(1, RD2::numGets);
 }
 
-INSTANTIATE_TEST_CASE_P(
+INSTANTIATE_TEST_SUITE_P(
     Runtimes,
     JSITest,
     ::testing::ValuesIn(runtimeGenerators()));

package/ReactCommon/jsiexecutor/Android.mk

@@ -18,6 +18,6 @@ LOCAL_EXPORT_C_INCLUDES := $(LOCAL_C_INCLUDES)
 LOCAL_CFLAGS := -fexceptions -frtti -O3
 
 LOCAL_STATIC_LIBRARIES := reactnative reactperflogger
-LOCAL_SHARED_LIBRARIES := libfolly_json glog libjsi
+LOCAL_SHARED_LIBRARIES := libfolly_runtime glog libjsi
 
 include $(BUILD_STATIC_LIBRARY)

package/ReactCommon/jsiexecutor/BUCK

@@ -22,7 +22,10 @@ cxx_library(
     ],
     fbobjc_force_static = True,
     fbobjc_header_path_prefix = "",
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     platforms = (ANDROID, APPLE),
     preprocessor_flags = [
         "-DLOG_TAG=\"ReactNative\"",

package/ReactCommon/jsiexecutor/CMakeLists.txt

@@ -0,0 +1,23 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+cmake_minimum_required(VERSION 3.13)
+set(CMAKE_VERBOSE_MAKEFILE on)
+
+add_compile_options(-fexceptions -frtti -O3)
+
+add_library(jsireact
+        STATIC
+        jsireact/JSIExecutor.cpp
+        jsireact/JSINativeModules.cpp)
+
+target_include_directories(jsireact PUBLIC .)
+
+target_link_libraries(jsireact
+        reactnative
+        reactperflogger
+        folly_runtime
+        glog
+        jsi)

package/ReactCommon/jsiexecutor/React-jsiexecutor.podspec

@@ -27,7 +27,7 @@ Pod::Spec.new do |s|
   s.homepage               = "https://reactnative.dev/"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0" }
+  s.platforms              = { :ios => "12.4" }
   s.source                 = source
   s.source_files         = "jsireact/*.{cpp,h}"
   s.compiler_flags         = folly_compiler_flags + ' ' + boost_compiler_flags

package/ReactCommon/jsinspector/BUCK

@@ -27,7 +27,10 @@ rn_xplat_cxx_library(
         prefix = "jsinspector",
     ),
     fbandroid_preferred_linkage = "shared",
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),
     visibility = [
         "PUBLIC",

package/ReactCommon/jsinspector/CMakeLists.txt

@@ -0,0 +1,14 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+cmake_minimum_required(VERSION 3.13)
+set(CMAKE_VERBOSE_MAKEFILE on)
+
+add_compile_options(-fexceptions)
+
+file(GLOB jsinspector_SRC CONFIGURE_DEPENDS *.cpp)
+add_library(jsinspector SHARED ${jsinspector_SRC})
+
+target_include_directories(jsinspector PUBLIC ${REACT_COMMON_DIR})

package/ReactCommon/jsinspector/React-jsinspector.podspec

@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
   s.homepage               = "https://reactnative.dev/"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0" }
+  s.platforms              = { :ios => "12.4" }
   s.source                 = source
   s.source_files           = "*.{cpp,h}"
   s.header_dir             = 'jsinspector'

package/ReactCommon/logger/BUCK

@@ -27,7 +27,10 @@ rn_xplat_cxx_library(
         prefix = "logger",
     ),
     fbandroid_preferred_linkage = "shared",
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),
     visibility = [
         "PUBLIC",

package/ReactCommon/logger/CMakeLists.txt

@@ -0,0 +1,16 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+cmake_minimum_required(VERSION 3.13)
+set(CMAKE_VERBOSE_MAKEFILE on)
+
+add_compile_options(-fexceptions)
+
+file(GLOB logger_SRC CONFIGURE_DEPENDS *.cpp)
+add_library(logger SHARED ${logger_SRC})
+
+target_include_directories(logger PUBLIC .)
+
+target_link_libraries(logger glog)

package/ReactCommon/logger/React-logger.podspec

@@ -28,7 +28,7 @@ Pod::Spec.new do |s|
   s.homepage               = "https://reactnative.dev/"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "11.0", :tvos => "11.0" }
+  s.platforms              = { :ios => "12.4", :tvos => "12.4" }
   s.source                 = source
   s.source_files           = "*.{cpp,h}"
   s.exclude_files          = "SampleCxxModule.*"

package/ReactCommon/microprofiler/BUCK

@@ -12,12 +12,15 @@ cxx_library(
     compiler_flags = [
         "-Wall",
         "-Werror",
-        "-std=c++14",
+        "-std=c++17",
         "-fexceptions",
         "-fno-data-sections",
     ],
     force_static = True,
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholder",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     visibility = [
         "PUBLIC",
     ],