react-native 0.66.0-rc.4 → 0.67.0-rc.1

package/ReactAndroid/src/main/jni/react/perftests/BUCK

@@ -3,10 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "react_native_xplat_target
 rn_xplat_cxx_library(
     name = "perftests",
     srcs = ["OnLoad.cpp"],
-    compiler_flags = [
-        "-fexceptions",
-        "-std=c++1y",
-    ],
     platforms = ANDROID,
     soname = "libnativereactperftests.$(ext)",
     visibility = [

package/ReactAndroid/src/main/third-party/android/androidx/BUCK

@@ -690,20 +690,20 @@ fb_native.remote_file(
 
 fb_native.remote_file(
     name = "test-monitor-binary-aar",
-    sha1 = "d2f75d117c055f35c8ebbd4f96fabc2137df9e4d",
-    url = "mvn:androidx.test:monitor:aar:1.2.0",
+    sha1 = "4f3c15d0a1e0c943b233b0dc5d8f1e690cfe7c0a",
+    url = "mvn:androidx.test:monitor:aar:1.4.0",
 )
 
 fb_native.remote_file(
     name = "test-rules-binary-aar",
-    sha1 = "91904046e724ac82d9b7fe698e5fe92b871c726e",
-    url = "mvn:androidx.test:rules:aar:1.2.0",
+    sha1 = "0984e8b5505f08489993c783702236af7a4a18c8",
+    url = "mvn:androidx.test:rules:aar:1.4.0",
 )
 
 fb_native.remote_file(
     name = "test-runner-binary-aar",
-    sha1 = "237b061c45b3b450f88dd8cde87375ab22b0496a",
-    url = "mvn:androidx.test:runner:aar:1.2.0",
+    sha1 = "44d79420baf7ac208e33b35df8756f0e912ced38",
+    url = "mvn:androidx.test:runner:aar:1.4.0",
 )
 
 fb_native.remote_file(

package/ReactAndroid/src/test/java/com/facebook/react/RootViewTest.java

@@ -16,6 +16,7 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 import static org.mockito.Mockito.when;
 
+import android.graphics.Rect;
 import android.view.MotionEvent;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.CatalystInstance;
@@ -25,7 +26,9 @@ import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReactTestHelper;
 import com.facebook.react.bridge.WritableArray;
+import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.common.SystemClock;
+import com.facebook.react.modules.core.DeviceEventManagerModule.RCTDeviceEventEmitter;
 import com.facebook.react.uimanager.DisplayMetricsHolder;
 import com.facebook.react.uimanager.UIManagerModule;
 import com.facebook.react.uimanager.events.Event;
@@ -37,6 +40,7 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.ArgumentCaptor;
+import org.mockito.Mockito;
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 import org.powermock.api.mockito.PowerMockito;
@@ -209,4 +213,43 @@ public class RootViewTest {
     rootView.unmountReactApplication();
     rootView.startReactApplication(instanceManager, "");
   }
+
+  @Test
+  public void testCheckForKeyboardEvents() {
+    ReactInstanceManager instanceManager = mock(ReactInstanceManager.class);
+    RCTDeviceEventEmitter eventEmitterModuleMock = mock(RCTDeviceEventEmitter.class);
+
+    when(instanceManager.getCurrentReactContext()).thenReturn(mReactContext);
+    when(mReactContext.getJSModule(RCTDeviceEventEmitter.class)).thenReturn(eventEmitterModuleMock);
+
+    ReactRootView rootView =
+        new ReactRootView(mReactContext) {
+          @Override
+          public void getWindowVisibleDisplayFrame(Rect outRect) {
+            if (outRect.bottom == 0) {
+              outRect.bottom += 100;
+              outRect.right += 370;
+            } else {
+              outRect.bottom += 370;
+            }
+          }
+        };
+
+    rootView.startReactApplication(instanceManager, "");
+    rootView.simulateCheckForKeyboardForTesting();
+
+    WritableMap params = Arguments.createMap();
+    WritableMap endCoordinates = Arguments.createMap();
+    double screenHeight = 470.0;
+    double keyboardHeight = 100.0;
+    params.putDouble("duration", 0.0);
+    endCoordinates.putDouble("width", screenHeight - keyboardHeight);
+    endCoordinates.putDouble("screenX", 0.0);
+    endCoordinates.putDouble("height", screenHeight - keyboardHeight);
+    endCoordinates.putDouble("screenY", keyboardHeight);
+    params.putMap("endCoordinates", endCoordinates);
+    params.putString("easing", "keyboard");
+
+    verify(eventEmitterModuleMock, Mockito.times(1)).emit("keyboardDidShow", params);
+  }
 }

package/ReactAndroid/src/test/java/com/facebook/react/modules/clipboard/ClipboardModuleTest.java

@@ -13,6 +13,7 @@ import static org.junit.Assert.assertTrue;
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.text.ClipboardManager;
+import com.facebook.react.bridge.ReactApplicationContext;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -32,7 +33,8 @@ public class ClipboardModuleTest {
 
   @Before
   public void setUp() {
-    mClipboardModule = new ClipboardModule(RuntimeEnvironment.application);
+    mClipboardModule =
+        new ClipboardModule(new ReactApplicationContext(RuntimeEnvironment.application));
     mClipboardManager =
         (ClipboardManager)
             RuntimeEnvironment.application.getSystemService(Context.CLIPBOARD_SERVICE);

package/ReactCommon/React-Fabric.podspec

@@ -20,6 +20,7 @@ folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1
 folly_version = '2021.06.28.00-v2'
 folly_dep_name = 'RCT-Folly/Fabric'
 boost_compiler_flags = '-Wno-documentation'
+react_native_path = ".."
 
 Pod::Spec.new do |s|
   s.name                   = "React-Fabric"
@@ -31,7 +32,6 @@ Pod::Spec.new do |s|
   s.platforms              = { :ios => "11.0" }
   s.source                 = source
   s.source_files           = "dummyFile.cpp"
-  s.library                = "stdc++"
   s.pod_target_xcconfig = { "USE_HEADERMAP" => "YES",
                             "CLANG_CXX_LANGUAGE_STANDARD" => "c++17" }
 
@@ -341,4 +341,12 @@ Pod::Spec.new do |s|
     ss.header_dir           = "react/utils"
     ss.pod_target_xcconfig  = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\" \"$(PODS_ROOT)/RCT-Folly\"" }
   end
+
+  use_react_native_codegen!(s, {
+    :react_native_path => react_native_path,
+    :js_srcs_dir => "#{react_native_path}/Libraries",
+    :library_name => "rncore",
+    :library_type => "components",
+    :output_dir => "#{react_native_path}/ReactCommon",
+  })
 end

package/ReactCommon/better/BUCK

@@ -29,12 +29,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "better",
     ),
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-    ],
     fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
     fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
     force_static = True,

package/ReactCommon/callinvoker/BUCK

@@ -1,4 +1,4 @@
-load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "rn_xplat_cxx_library", "subdir_glob")
+load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "CXX", "rn_xplat_cxx_library", "subdir_glob")
 
 rn_xplat_cxx_library(
     name = "callinvoker",
@@ -10,14 +10,8 @@ rn_xplat_cxx_library(
         ],
         prefix = "ReactCommon",
     ),
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-    ],
     labels = ["supermodule:xplat/default/public.react_native.infra"],
-    platforms = (ANDROID, APPLE),
+    platforms = (ANDROID, APPLE, CXX),
     preferred_linkage = "static",
     preprocessor_flags = [
         "-DLOG_TAG=\"ReactNative\"",

package/ReactCommon/cxxreact/BUCK

@@ -1,11 +1,6 @@
 load("@fbsource//tools/build_defs:glob_defs.bzl", "subdir_glob")
 load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "get_android_inspector_flags", "get_apple_compiler_flags", "get_apple_inspector_flags", "get_preprocessor_flags_for_build_mode", "react_native_xplat_target", "rn_xplat_cxx_library")
 
-CXX_LIBRARY_COMPILER_FLAGS = [
-    "-std=c++17",
-    "-Wall",
-]
-
 rn_xplat_cxx_library(
     name = "module",
     header_namespace = "",
@@ -17,7 +12,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "cxxreact",
     ),
-    compiler_flags = CXX_LIBRARY_COMPILER_FLAGS,
     fbobjc_compiler_flags = get_apple_compiler_flags(),
     force_static = True,
     labels = ["supermodule:xplat/default/public.react_native.infra"],
@@ -39,10 +33,6 @@ rn_xplat_cxx_library(
         [("", "JSBigString.h")],
         prefix = "cxxreact",
     ),
-    compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [
-        "-fexceptions",
-        "-frtti",
-    ],
     fbobjc_compiler_flags = get_apple_compiler_flags(),
     force_static = True,
     labels = ["supermodule:xplat/default/public.react_native.infra"],
@@ -61,9 +51,8 @@ rn_xplat_cxx_library(
     srcs = ["SampleCxxModule.cpp"],
     header_namespace = "",
     exported_headers = ["SampleCxxModule.h"],
-    compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [
+    compiler_flags = [
         "-fno-omit-frame-pointer",
-        "-fexceptions",
     ],
     fbobjc_compiler_flags = get_apple_compiler_flags(),
     labels = ["supermodule:xplat/default/public.react_native.infra"],
@@ -120,10 +109,6 @@ rn_xplat_cxx_library(
         )
         for header in CXXREACT_PUBLIC_HEADERS
     ]),
-    compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [
-        "-fexceptions",
-        "-frtti",
-    ],
     fbandroid_preprocessor_flags = get_android_inspector_flags(),
     fbobjc_compiler_flags = get_apple_compiler_flags(),
     fbobjc_force_static = True,

package/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -16,9 +16,9 @@ namespace facebook::react {
 
 constexpr struct {
   int32_t Major = 0;
-  int32_t Minor = 66;
+  int32_t Minor = 67;
   int32_t Patch = 0;
-  std::string_view Prerelease = "rc.4";
+  std::string_view Prerelease = "rc.1";
 } ReactNativeVersion;
 
 } // namespace facebook::react

package/ReactCommon/hermes/inspector/tools/msggen/package.json

@@ -11,6 +11,10 @@
     "watch": "babel src --out-dir bin --source-maps --watch",
     "test": "jest"
   },
+  "dependencies": {
+    "devtools-protocol": "0.0.730699",
+    "yargs": "^14.2.0"
+  },
   "devDependencies": {
     "@babel/cli": "^7.2.0",
     "@babel/core": "^7.2.0",
@@ -26,13 +30,12 @@
     "sshpk": "1.16.1",
     "webpack": "^4.41.0"
   },
+  "resolutions": {
+    "set-value": "^4.1.0"
+  },
   "jest": {
     "transform": {
       ".*": "<rootDir>/node_modules/babel-jest"
     }
-  },
-  "dependencies": {
-    "devtools-protocol": "0.0.730699",
-    "yargs": "^14.2.0"
   }
 }

package/ReactCommon/hermes/inspector/tools/msggen/yarn.lock

@@ -3324,7 +3324,7 @@ is-number@^7.0.0:
   resolved "https://registry.yarnpkg.com/is-number/-/is-number-7.0.0.tgz#7535345b896734d5f80c4d06c50955527a14f12b"
   integrity sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==
 
-is-plain-object@^2.0.3, is-plain-object@^2.0.4:
+is-plain-object@^2.0.4:
   version "2.0.4"
   resolved "https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-2.0.4.tgz#2c163b3fafb1b606d9d17928f05c2a1c38e07677"
   integrity sha512-h5PpgXkWitc38BBMYawTYMWJHFZJVnBquFE57xFpjB8pJFiF6gZ+bU+WyI/yqXiFR5mdLsgYNaPe8uao6Uv9Og==
@@ -3336,6 +3336,11 @@ is-potential-custom-element-name@^1.0.0:
   resolved "https://registry.yarnpkg.com/is-potential-custom-element-name/-/is-potential-custom-element-name-1.0.1.tgz#171ed6f19e3ac554394edf78caa05784a45bebb5"
   integrity sha512-bCYeRA2rVibKZd+s2625gGnGF/t7DSqDs4dP7CrLA1m7jKWz6pps0LpYLJN8Q64HtmPKJ1hrN3nzPNKFEKOUiQ==
 
+is-primitive@^3.0.1:
+  version "3.0.1"
+  resolved "https://registry.yarnpkg.com/is-primitive/-/is-primitive-3.0.1.tgz#98c4db1abff185485a657fc2905052b940524d05"
+  integrity sha512-GljRxhWvlCNRfZyORiH77FwdFwGcMO620o37EOYC0ORWdq+WYNVqW0w2Juzew4M+L81l6/QS3t5gkkihyRqv9w==
+
 is-stream@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
@@ -5123,15 +5128,13 @@ set-blocking@^2.0.0:
   resolved "https://registry.yarnpkg.com/set-blocking/-/set-blocking-2.0.0.tgz#045f9782d011ae9a6803ddd382b24392b3d890f7"
   integrity sha1-BF+XgtARrppoA93TgrJDkrPYkPc=
 
-set-value@^2.0.0, set-value@^2.0.1:
-  version "2.0.1"
-  resolved "https://registry.yarnpkg.com/set-value/-/set-value-2.0.1.tgz#a18d40530e6f07de4228c7defe4227af8cad005b"
-  integrity sha512-JxHc1weCN68wRY0fhCoXpyK55m/XPHafOmK4UWD7m2CI14GMcFypt4w/0+NV5f/ZMby2F6S2wwA7fgynh9gWSw==
+set-value@^2.0.0, set-value@^2.0.1, set-value@^4.1.0:
+  version "4.1.0"
+  resolved "https://registry.yarnpkg.com/set-value/-/set-value-4.1.0.tgz#aa433662d87081b75ad88a4743bd450f044e7d09"
+  integrity sha512-zTEg4HL0RwVrqcWs3ztF+x1vkxfm0lP+MQQFPiMJTKVceBwEV0A569Ou8l9IYQG8jOZdMVI1hGsc0tmeD2o/Lw==
   dependencies:
-    extend-shallow "^2.0.1"
-    is-extendable "^0.1.1"
-    is-plain-object "^2.0.3"
-    split-string "^3.0.1"
+    is-plain-object "^2.0.4"
+    is-primitive "^3.0.1"
 
 setimmediate@^1.0.4:
   version "1.0.5"
@@ -5303,7 +5306,7 @@ spdx-license-ids@^3.0.0:
   resolved "https://registry.yarnpkg.com/spdx-license-ids/-/spdx-license-ids-3.0.5.tgz#3694b5804567a458d3c8045842a6358632f62654"
   integrity sha512-J+FWzZoynJEXGphVIS+XEh3kFSjZX/1i9gFBaWQcB+/tmpe2qUsSBABpcxqxnAxFdiUFEgAX1bjYGQvIZmoz9Q==
 
-split-string@^3.0.1, split-string@^3.0.2:
+split-string@^3.0.2:
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/split-string/-/split-string-3.1.0.tgz#7cb09dda3a86585705c64b39a6466038682e8fe2"
   integrity sha512-NzNVhJDYpwceVVii8/Hu6DKfD2G+NrQHlS/V/qgv763EYudVwEcMQNxd2lh+0VrUByXN/oJkl5grOhYWvQUYiw==

package/ReactCommon/jsi/BUCK

@@ -14,11 +14,6 @@ rn_xplat_cxx_library(
     ],
     compiler_flags = [
         "-O3",
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-        "-Werror",
         "-Wextra",
         "-Wcast-qual",
         "-Wdelete-non-virtual-dtor",
@@ -45,10 +40,6 @@ rn_xplat_cxx_library(
     exported_headers = [
         "jsi/JSIDynamic.h",
     ],
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-    ],
     fbobjc_force_static = True,
     labels = ["supermodule:xplat/default/public.react_native.infra"],
     visibility = [

package/ReactCommon/jsinspector/BUCK

@@ -26,11 +26,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "jsinspector",
     ),
-    compiler_flags = [
-        "-Wall",
-        "-fexceptions",
-        "-std=c++1y",
-    ],
     fbandroid_preferred_linkage = "shared",
     labels = ["supermodule:xplat/default/public.react_native.infra"],
     platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),

package/ReactCommon/logger/BUCK

@@ -26,11 +26,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "logger",
     ),
-    compiler_flags = [
-        "-Wall",
-        "-fexceptions",
-        "-std=c++17",
-    ],
     fbandroid_preferred_linkage = "shared",
     labels = ["supermodule:xplat/default/public.react_native.infra"],
     platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS),

package/ReactCommon/react/config/BUCK

@@ -18,12 +18,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "react/config",
     ),
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-    ],
     fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
     fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
     force_static = True,

package/ReactCommon/react/debug/BUCK

@@ -29,12 +29,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "react/debug",
     ),
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-    ],
     exported_platform_linker_flags = [
         (
             "^android.*",

package/ReactCommon/react/nativemodule/core/BUCK

@@ -13,10 +13,6 @@ rn_xplat_cxx_library(
         prefix = "ReactCommon",
     ),
     compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
         "-Wno-global-constructors",
     ],
     fbandroid_deps = [
@@ -35,7 +31,6 @@ rn_xplat_cxx_library(
         ],
     ),
     fbobjc_compiler_flags = [
-        "-Wall",
         "-fobjc-arc-exceptions",
     ],
     fbobjc_inherited_buck_flags = get_static_library_ios_flags(),

package/ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModuleManager.mm

@@ -174,7 +174,6 @@ static Class getFallbackClassFromName(const char *name)
   std::mutex _turboModuleHoldersMutex;
   std::atomic<bool> _invalidating;
 
-  RCTModuleRegistry *_moduleRegistry;
   RCTRetainJSCallback _retainJSCallback;
   std::shared_ptr<LongLivedObjectCollection> _longLivedObjectCollection;
 }
@@ -188,9 +187,6 @@ static Class getFallbackClassFromName(const char *name)
     _delegate = delegate;
     _bridge = bridge;
     _invalidating = false;
-    _moduleRegistry = [RCTModuleRegistry new];
-    [_moduleRegistry setBridge:bridge];
-    [_moduleRegistry setTurboModuleRegistry:self];
 
     [[NSNotificationCenter defaultCenter] addObserver:self
                                              selector:@selector(bridgeWillInvalidateModules:)
@@ -426,9 +422,12 @@ static Class getFallbackClassFromName(const char *name)
      */
 
     if ([_delegate respondsToSelector:@selector(getModuleClassFromName:)]) {
-      std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
-
-      moduleClass = [_delegate getModuleClassFromName:moduleName];
+      if (RCTTurboModuleManagerDelegateLockingDisabled()) {
+        moduleClass = [_delegate getModuleClassFromName:moduleName];
+      } else {
+        std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
+        moduleClass = [_delegate getModuleClassFromName:moduleName];
+      }
     }
 
     if (!moduleClass) {
@@ -510,9 +509,12 @@ static Class getFallbackClassFromName(const char *name)
 
   TurboModulePerfLogger::moduleCreateConstructStart(moduleName, moduleId);
   if ([_delegate respondsToSelector:@selector(getModuleInstanceFromClass:)]) {
-    std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
-
-    module = [_delegate getModuleInstanceFromClass:moduleClass];
+    if (RCTTurboModuleManagerDelegateLockingDisabled()) {
+      module = [_delegate getModuleInstanceFromClass:moduleClass];
+    } else {
+      std::lock_guard<std::mutex> delegateGuard(_turboModuleManagerDelegateMutex);
+      module = [_delegate getModuleInstanceFromClass:moduleClass];
+    }
   } else {
     module = [moduleClass new];
   }
@@ -556,25 +558,6 @@ static Class getFallbackClassFromName(const char *name)
     }
   }
 
-  /**
-   * Attach the RCTModuleRegistry to this TurboModule, which allows this TurboModule
-   * To load other NativeModules & TurboModules.
-   *
-   * Usage: In the NativeModule @implementation, include:
-   *   `@synthesize moduleRegistry = _moduleRegistry`
-   */
-  if ([module respondsToSelector:@selector(moduleRegistry)] && _moduleRegistry) {
-    @try {
-      [(id)module setValue:_moduleRegistry forKey:@"moduleRegistry"];
-    } @catch (NSException *exception) {
-      RCTLogError(
-          @"%@ has no setter or ivar for its module registry, which is not "
-           "permitted. You must either @synthesize the moduleRegistry property, "
-           "or provide your own setter method.",
-          RCTBridgeModuleNameForClass([module class]));
-    }
-  }
-
   /**
    * Some modules need their own queues, but don't provide any, so we need to create it for them.
    * These modules typically have the following:
@@ -612,7 +595,7 @@ static Class getFallbackClassFromName(const char *name)
       } @catch (NSException *exception) {
         RCTLogError(
             @"%@ has no setter or ivar for its methodQueue, which is not "
-             "permitted. You must either @synthesize the bridge property, "
+             "permitted. You must either @synthesize the methodQueue property, "
              "or provide your own setter method.",
             RCTBridgeModuleNameForClass([module class]));
       }
@@ -651,7 +634,7 @@ static Class getFallbackClassFromName(const char *name)
   if (_bridge) {
     RCTModuleData *data = [[RCTModuleData alloc] initWithModuleInstance:(id<RCTBridgeModule>)module
                                                                  bridge:_bridge
-                                                         moduleRegistry:_moduleRegistry
+                                                         moduleRegistry:_bridge.moduleRegistry
                                                 viewRegistry_DEPRECATED:nil
                                                           bundleManager:nil
                                                       callableJSModules:nil];

package/ReactCommon/react/nativemodule/samples/BUCK

@@ -12,12 +12,6 @@ rn_xplat_cxx_library(
         ],
         prefix = "ReactCommon",
     ),
-    compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
-    ],
     fbandroid_deps = [
         react_native_target("jni/react/jni:jni"),
         FBJNI_TARGET,
@@ -34,7 +28,6 @@ rn_xplat_cxx_library(
         ],
     ),
     fbobjc_compiler_flags = [
-        "-Wall",
         "-fobjc-arc-exceptions",
     ],
     fbobjc_inherited_buck_flags = get_static_library_ios_flags(),

package/ReactCommon/react/renderer/animations/BUCK

@@ -32,10 +32,6 @@ rn_xplat_cxx_library(
         prefix = "react/renderer/animations",
     ),
     compiler_flags = [
-        "-fexceptions",
-        "-frtti",
-        "-std=c++17",
-        "-Wall",
         "-lm",
     ],
     fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
@@ -62,6 +58,7 @@ rn_xplat_cxx_library(
         react_native_xplat_target("react/debug:debug"),
         react_native_xplat_target("react/renderer/componentregistry:componentregistry"),
         react_native_xplat_target("react/renderer/components/view:view"),
+        react_native_xplat_target("react/renderer/components/image:image"),
         react_native_xplat_target("react/renderer/core:core"),
         react_native_xplat_target("react/renderer/debug:debug"),
         react_native_xplat_target("react/renderer/mounting:mounting"),

package/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h

@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <jsi/jsi.h>
+#include <memory>
+
+namespace facebook {
+namespace react {
+
+class LayoutAnimationCallbackWrapper {
+ public:
+  LayoutAnimationCallbackWrapper(jsi::Function &&callback)
+      : callback_(std::make_shared<jsi::Function>(std::move(callback))) {}
+  LayoutAnimationCallbackWrapper() : callback_(nullptr) {}
+
+  void call(jsi::Runtime &runtime) const {
+    if (callback_) {
+      callback_->call(runtime);
+      callback_.reset();
+    }
+  }
+
+ private:
+  mutable std::shared_ptr<jsi::Function> callback_;
+};
+
+} // namespace react
+} // namespace facebook

package/ReactCommon/react/renderer/animations/LayoutAnimationDriver.cpp

@@ -7,24 +7,10 @@
 
 #include "LayoutAnimationDriver.h"
 
-#include <algorithm>
-#include <chrono>
-
-#include <react/renderer/componentregistry/ComponentDescriptorFactory.h>
-#include <react/renderer/components/view/ViewProps.h>
-#include <react/renderer/core/ComponentDescriptor.h>
-#include <react/renderer/core/LayoutMetrics.h>
-#include <react/renderer/core/LayoutableShadowNode.h>
-#include <react/renderer/core/Props.h>
-#include <react/renderer/mounting/MountingCoordinator.h>
-
-#include <react/renderer/mounting/Differentiator.h>
-#include <react/renderer/mounting/ShadowTreeRevision.h>
-#include <react/renderer/mounting/ShadowView.h>
-#include <react/renderer/mounting/ShadowViewMutation.h>
-
 #include <glog/logging.h>
 #include <react/debug/react_native_assert.h>
+#include <react/renderer/animations/utils.h>
+#include <algorithm>
 
 namespace facebook {
 namespace react {
@@ -70,19 +56,12 @@ void LayoutAnimationDriver::animationMutationsForFrame(
           animationInterpolationFactor, baselineShadowView, finalShadowView);
 
       // Create the mutation instruction
-      auto updateMutation = ShadowViewMutation::UpdateMutation(
-          keyframe.viewPrev, mutatedShadowView);
-
-      // All generated Update mutations must have an "old" and "new"
-      // ShadowView. Checking for nonzero tag doesn't guarantee that the views
-      // are valid/correct, just that something is there.
-      react_native_assert(updateMutation.oldChildShadowView.tag > 0);
-      react_native_assert(updateMutation.newChildShadowView.tag > 0);
+      mutationsList.emplace_back(ShadowViewMutation::UpdateMutation(
+          keyframe.viewPrev, mutatedShadowView));
 
-      mutationsList.push_back(updateMutation);
       PrintMutationInstruction("Animation Progress:", updateMutation);
 
-      keyframe.viewPrev = mutatedShadowView;
+      keyframe.viewPrev = std::move(mutatedShadowView);
 
       if (animationTimeProgressLinear < 1) {
         incompleteAnimations++;