react-native 0.0.0-20220101-2009-e22b760e5 → 0.0.0-20220105-2008-bdd25ed6a

package/Libraries/Components/Pressable/Pressable.js

@@ -22,7 +22,7 @@ import type {
 } from '../View/ViewAccessibility';
 import {PressabilityDebugView} from '../../Pressability/PressabilityDebug';
 import usePressability from '../../Pressability/usePressability';
-import {normalizeRect, type RectOrSize} from '../../StyleSheet/Rect';
+import {type RectOrSize} from '../../StyleSheet/Rect';
 import type {
   LayoutEvent,
   MouseEvent,
@@ -181,6 +181,7 @@ function Pressable(props: Props, forwardedRef): React.Node {
     delayLongPress,
     disabled,
     focusable,
+    hitSlop,
     onHoverIn,
     onHoverOut,
     onLongPress,
@@ -201,8 +202,6 @@ function Pressable(props: Props, forwardedRef): React.Node {
 
   const [pressed, setPressed] = usePressState(testOnly_pressed === true);
 
-  const hitSlop = normalizeRect(props.hitSlop);
-
   const accessibilityState =
     disabled != null
       ? {...props.accessibilityState, disabled}

package/Libraries/Components/View/ViewPropTypes.js

@@ -18,7 +18,7 @@ import type {
   Layout,
   LayoutEvent,
 } from '../../Types/CoreEventTypes';
-import type {EdgeInsetsProp} from '../../StyleSheet/EdgeInsetsPropType';
+import type {EdgeInsetsOrSizeProp} from '../../StyleSheet/EdgeInsetsPropType';
 import type {Node} from 'react';
 import type {ViewStyleProp} from '../../StyleSheet/StyleSheet';
 import type {
@@ -474,7 +474,7 @@ export type ViewProps = $ReadOnly<{|
    *
    * See https://reactnative.dev/docs/view#hitslop
    */
-  hitSlop?: ?EdgeInsetsProp,
+  hitSlop?: ?EdgeInsetsOrSizeProp,
 
   /**
    * Controls whether the `View` can be the target of touch events.

package/Libraries/Core/ReactNativeVersion.js

@@ -13,5 +13,5 @@ exports.version = {
   major: 0,
   minor: 0,
   patch: 0,
-  prerelease: '20220101-2009-e22b760e5',
+  prerelease: '20220105-2008-bdd25ed6a',
 };

package/Libraries/Pressability/PressabilityDebug.js

@@ -10,18 +10,14 @@
 
 import normalizeColor from '../StyleSheet/normalizeColor';
 import type {ColorValue} from '../StyleSheet/StyleSheet';
+import {normalizeRect, type RectOrSize} from '../StyleSheet/Rect';
 
 import View from '../Components/View/View';
 import * as React from 'react';
 
 type Props = $ReadOnly<{|
   color: ColorValue,
-  hitSlop: ?$ReadOnly<{|
-    bottom?: ?number,
-    left?: ?number,
-    right?: ?number,
-    top?: ?number,
-  |}>,
+  hitSlop: ?RectOrSize,
 |}>;
 
 /**
@@ -39,16 +35,16 @@ type Props = $ReadOnly<{|
  *   );
  *
  */
-export function PressabilityDebugView({color, hitSlop}: Props): React.Node {
+export function PressabilityDebugView(props: Props): React.Node {
   if (__DEV__) {
     if (isEnabled()) {
-      const normalizedColor = normalizeColor(color);
+      const normalizedColor = normalizeColor(props.color);
       if (typeof normalizedColor !== 'number') {
         return null;
       }
       const baseColor =
         '#' + (normalizedColor ?? 0).toString(16).padStart(8, '0');
-
+      const hitSlop = normalizeRect(props.hitSlop);
       return (
         <View
           pointerEvents="none"

package/Libraries/ReactNative/getNativeComponentAttributes.js

@@ -94,17 +94,11 @@ function getNativeComponentAttributes(uiViewClassName: string): any {
     directEventTypes,
   });
 
-  if (!hasAttachedDefaultEventTypes) {
-    attachDefaultEventTypes(viewConfig);
-    hasAttachedDefaultEventTypes = true;
-  }
+  attachDefaultEventTypes(viewConfig);
 
   return viewConfig;
 }
 
-// TODO: Figure out how this makes sense. We're using a global boolean to only
-// initialize this on the first eagerly initialized native component.
-let hasAttachedDefaultEventTypes = false;
 function attachDefaultEventTypes(viewConfig: any) {
   // This is supported on UIManager platforms (ex: Android),
   // as lazy view managers are not implemented for all platforms.

package/Libraries/StyleSheet/EdgeInsetsPropType.js

@@ -10,6 +10,9 @@
 
 'use strict';
 
-import type {Rect} from './Rect';
+import type {Rect, RectOrSize} from './Rect';
 
+// TODO: allow all EdgeInsets-like property to be set using a single number
+// and unify EdgeInsetsProp with EdgeInsetsOrSizeProp
 export type EdgeInsetsProp = Rect;
+export type EdgeInsetsOrSizeProp = RectOrSize;

package/React/Base/RCTVersion.m

@@ -24,7 +24,7 @@ NSDictionary* RCTGetReactNativeVersion(void)
                   RCTVersionMajor: @(0),
                   RCTVersionMinor: @(0),
                   RCTVersionPatch: @(0),
-                  RCTVersionPrerelease: @"20220101-2009-e22b760e5",
+                  RCTVersionPrerelease: @"20220105-2008-bdd25ed6a",
                   };
   });
   return __rnVersion;

package/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java

@@ -18,5 +18,5 @@ public class ReactNativeVersion {
       "major", 0,
       "minor", 0,
       "patch", 0,
-      "prerelease", "20220101-2009-e22b760e5");
+      "prerelease", "20220105-2008-bdd25ed6a");
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@@ -429,9 +429,17 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
 
   @Override
   public @Nullable Map<String, Object> getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.<String, Object>builder()
-        .put("topAccessibilityAction", MapBuilder.of("registrationName", "onAccessibilityAction"))
-        .build();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.<String, Object>builder()
+            .put(
+                "topAccessibilityAction",
+                MapBuilder.of("registrationName", "onAccessibilityAction"))
+            .build());
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java

@@ -31,6 +31,7 @@ import com.facebook.react.views.drawer.events.DrawerClosedEvent;
 import com.facebook.react.views.drawer.events.DrawerOpenedEvent;
 import com.facebook.react.views.drawer.events.DrawerSlideEvent;
 import com.facebook.react.views.drawer.events.DrawerStateChangedEvent;
+import java.util.HashMap;
 import java.util.Map;
 
 /** View Manager for {@link ReactDrawerLayout} components. */
@@ -210,12 +211,18 @@ public class ReactDrawerLayoutManager extends ViewGroupManager<ReactDrawerLayout
 
   @Override
   public @Nullable Map getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.of(
-        DrawerSlideEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerSlide"),
-        DrawerOpenedEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerOpen"),
-        DrawerClosedEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerClose"),
-        DrawerStateChangedEvent.EVENT_NAME,
-            MapBuilder.of("registrationName", "onDrawerStateChanged"));
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.of(
+            DrawerSlideEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerSlide"),
+            DrawerOpenedEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerOpen"),
+            DrawerClosedEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDrawerClose"),
+            DrawerStateChangedEvent.EVENT_NAME,
+                MapBuilder.of("registrationName", "onDrawerStateChanged")));
+    return eventTypeConstants;
   }
 
   /**

package/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java

@@ -24,6 +24,7 @@ import com.facebook.react.uimanager.ViewProps;
 import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.annotations.ReactPropGroup;
 import com.facebook.yoga.YogaConstants;
+import java.util.HashMap;
 import java.util.Map;
 
 @ReactModule(name = ReactImageManager.REACT_CLASS)
@@ -245,17 +246,23 @@ public class ReactImageManager extends SimpleViewManager<ReactImageView> {
 
   @Override
   public @Nullable Map getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.of(
-        ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD_START),
-        MapBuilder.of("registrationName", "onLoadStart"),
-        ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_PROGRESS),
-        MapBuilder.of("registrationName", "onProgress"),
-        ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD),
-        MapBuilder.of("registrationName", "onLoad"),
-        ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_ERROR),
-        MapBuilder.of("registrationName", "onError"),
-        ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD_END),
-        MapBuilder.of("registrationName", "onLoadEnd"));
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.of(
+            ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD_START),
+            MapBuilder.of("registrationName", "onLoadStart"),
+            ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_PROGRESS),
+            MapBuilder.of("registrationName", "onProgress"),
+            ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD),
+            MapBuilder.of("registrationName", "onLoad"),
+            ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_ERROR),
+            MapBuilder.of("registrationName", "onError"),
+            ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD_END),
+            MapBuilder.of("registrationName", "onLoadEnd")));
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java

@@ -24,6 +24,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.events.EventDispatcher;
 import com.facebook.react.viewmanagers.ModalHostViewManagerDelegate;
 import com.facebook.react.viewmanagers.ModalHostViewManagerInterface;
+import java.util.HashMap;
 import java.util.Map;
 
 /** View manager for {@link ReactModalHostView} components. */
@@ -137,10 +138,16 @@ public class ReactModalHostManager extends ViewGroupManager<ReactModalHostView>
 
   @Override
   public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.<String, Object>builder()
-        .put(RequestCloseEvent.EVENT_NAME, MapBuilder.of("registrationName", "onRequestClose"))
-        .put(ShowEvent.EVENT_NAME, MapBuilder.of("registrationName", "onShow"))
-        .build();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.<String, Object>builder()
+            .put(RequestCloseEvent.EVENT_NAME, MapBuilder.of("registrationName", "onRequestClose"))
+            .put(ShowEvent.EVENT_NAME, MapBuilder.of("registrationName", "onShow"))
+            .build());
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java

@@ -30,6 +30,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.annotations.ReactPropGroup;
 import com.facebook.yoga.YogaConstants;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -335,7 +336,12 @@ public class ReactScrollViewManager extends ViewGroupManager<ReactScrollView>
 
   @Override
   public @Nullable Map<String, Object> getExportedCustomDirectEventTypeConstants() {
-    return createExportedCustomDirectEventTypeConstants();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(createExportedCustomDirectEventTypeConstants());
+    return eventTypeConstants;
   }
 
   public static Map<String, Object> createExportedCustomDirectEventTypeConstants() {

package/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java

@@ -37,6 +37,7 @@ import com.facebook.yoga.YogaMeasureFunction;
 import com.facebook.yoga.YogaMeasureMode;
 import com.facebook.yoga.YogaMeasureOutput;
 import com.facebook.yoga.YogaNode;
+import java.util.HashMap;
 import java.util.Map;
 
 /**
@@ -246,9 +247,15 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
 
   @Override
   public Map getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.of(
-        ReactSlidingCompleteEvent.EVENT_NAME,
-        MapBuilder.of("registrationName", "onSlidingComplete"));
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.of(
+            ReactSlidingCompleteEvent.EVENT_NAME,
+            MapBuilder.of("registrationName", "onSlidingComplete")));
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/SwipeRefreshLayoutManager.java

@@ -29,6 +29,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.events.EventDispatcher;
 import com.facebook.react.viewmanagers.AndroidSwipeRefreshLayoutManagerDelegate;
 import com.facebook.react.viewmanagers.AndroidSwipeRefreshLayoutManagerInterface;
+import java.util.HashMap;
 import java.util.Map;
 
 /**
@@ -175,9 +176,15 @@ public class SwipeRefreshLayoutManager extends ViewGroupManager<ReactSwipeRefres
 
   @Override
   public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.<String, Object>builder()
-        .put("topRefresh", MapBuilder.of("registrationName", "onRefresh"))
-        .build();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.<String, Object>builder()
+            .put("topRefresh", MapBuilder.of("registrationName", "onRefresh"))
+            .build());
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java

@@ -22,6 +22,7 @@ import com.facebook.react.uimanager.ReactStylesDiffMap;
 import com.facebook.react.uimanager.StateWrapper;
 import com.facebook.react.uimanager.ThemedReactContext;
 import com.facebook.yoga.YogaMeasureMode;
+import java.util.HashMap;
 import java.util.Map;
 
 /**
@@ -152,9 +153,15 @@ public class ReactTextViewManager
 
   @Override
   public @Nullable Map getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.of(
-        "topTextLayout", MapBuilder.of("registrationName", "onTextLayout"),
-        "topInlineViewLayout", MapBuilder.of("registrationName", "onInlineViewLayout"));
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.of(
+            "topTextLayout", MapBuilder.of("registrationName", "onTextLayout"),
+            "topInlineViewLayout", MapBuilder.of("registrationName", "onInlineViewLayout")));
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

@@ -202,48 +202,62 @@ public class ReactTextInputManager extends BaseViewManager<ReactEditText, Layout
   @Nullable
   @Override
   public Map<String, Object> getExportedCustomBubblingEventTypeConstants() {
-    return MapBuilder.<String, Object>builder()
-        .put(
-            "topSubmitEditing",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onSubmitEditing", "captured", "onSubmitEditingCapture")))
-        .put(
-            "topEndEditing",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onEndEditing", "captured", "onEndEditingCapture")))
-        .put(
-            "topTextInput",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onTextInput", "captured", "onTextInputCapture")))
-        .put(
-            "topFocus",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onFocus", "captured", "onFocusCapture")))
-        .put(
-            "topBlur",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onBlur", "captured", "onBlurCapture")))
-        .put(
-            "topKeyPress",
-            MapBuilder.of(
-                "phasedRegistrationNames",
-                MapBuilder.of("bubbled", "onKeyPress", "captured", "onKeyPressCapture")))
-        .build();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants =
+        super.getExportedCustomBubblingEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.<String, Object>builder()
+            .put(
+                "topSubmitEditing",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of(
+                        "bubbled", "onSubmitEditing", "captured", "onSubmitEditingCapture")))
+            .put(
+                "topEndEditing",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of("bubbled", "onEndEditing", "captured", "onEndEditingCapture")))
+            .put(
+                "topTextInput",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of("bubbled", "onTextInput", "captured", "onTextInputCapture")))
+            .put(
+                "topFocus",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of("bubbled", "onFocus", "captured", "onFocusCapture")))
+            .put(
+                "topBlur",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of("bubbled", "onBlur", "captured", "onBlurCapture")))
+            .put(
+                "topKeyPress",
+                MapBuilder.of(
+                    "phasedRegistrationNames",
+                    MapBuilder.of("bubbled", "onKeyPress", "captured", "onKeyPressCapture")))
+            .build());
+    return eventTypeConstants;
   }
 
   @Nullable
   @Override
   public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.<String, Object>builder()
-        .put(
-            ScrollEventType.getJSEventName(ScrollEventType.SCROLL),
-            MapBuilder.of("registrationName", "onScroll"))
-        .build();
+    @Nullable
+    Map<String, Object> baseEventTypeConstants = super.getExportedCustomDirectEventTypeConstants();
+    Map<String, Object> eventTypeConstants =
+        baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
+    eventTypeConstants.putAll(
+        MapBuilder.<String, Object>builder()
+            .put(
+                ScrollEventType.getJSEventName(ScrollEventType.SCROLL),
+                MapBuilder.of("registrationName", "onScroll"))
+            .build());
+    return eventTypeConstants;
   }
 
   @Override

package/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.cpp

@@ -17,6 +17,13 @@ namespace react {
 WritableNativeArray::WritableNativeArray()
     : HybridBase(folly::dynamic::array()) {}
 
+WritableNativeArray::WritableNativeArray(folly::dynamic &&val)
+    : HybridBase(std::move(val)) {
+  if (!array_.isArray()) {
+    throw std::runtime_error("WritableNativeArray value must be an array.");
+  }
+}
+
 local_ref<WritableNativeArray::jhybriddata> WritableNativeArray::initHybrid(
     alias_ref<jclass>) {
   return makeCxxInstance();

package/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.h

@@ -29,6 +29,8 @@ struct WritableNativeArray
       "Lcom/facebook/react/bridge/WritableNativeArray;";
 
   WritableNativeArray();
+  WritableNativeArray(folly::dynamic &&val);
+
   static jni::local_ref<jhybriddata> initHybrid(jni::alias_ref<jclass>);
 
   void pushNull();

package/ReactCommon/cxxreact/ReactNativeVersion.h

@@ -18,7 +18,7 @@ constexpr struct {
   int32_t Major = 0;
   int32_t Minor = 0;
   int32_t Patch = 0;
-  std::string_view Prerelease = "20220101-2009-e22b760e5";
+  std::string_view Prerelease = "20220105-2008-bdd25ed6a";
 } ReactNativeVersion;
 
 } // namespace facebook::react

package/ReactCommon/react/renderer/.clang-tidy

@@ -28,5 +28,17 @@ modernize-use-equals-delete,
 modernize-use-override,
 modernize-use-using,
 modernize-use-transparent-functors,
+performance-faster-string-find,
+performance-for-range-copy,
+performance-implicit-conversion-in-loop,
+performance-inefficient-algorithm,
+performance-inefficient-string-concatenation,
+performance-inefficient-vector-operation,
+performance-move-const-arg,
+performance-move-constructor-init,
+performance-noexcept-move-constructor,
+performance-type-promotion-in-math-fn,
+performance-unnecessary-copy-initialization,
+performance-unnecessary-value-param,
 '
 ...

package/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp

@@ -1075,7 +1075,7 @@ void LayoutAnimationKeyFrameManager::setLayoutAnimationStatusDelegate(
 
 void LayoutAnimationKeyFrameManager::setClockNow(
     std::function<uint64_t()> now) {
-  now_ = now;
+  now_ = std::move(now);
 }
 
 void LayoutAnimationKeyFrameManager::enableSkipInvalidatedKeyFrames() {
@@ -1309,7 +1309,7 @@ void LayoutAnimationKeyFrameManager::
 
   // First, collect all final mutations that could impact this immediate
   // mutation.
-  std::vector<ShadowViewMutation *> candidateMutations{};
+  std::vector<ShadowViewMutation const *> candidateMutations{};
 
   for (auto inflightAnimationIt =
            inflightAnimations_.rbegin() + (skipLastAnimation ? 1 : 0);
@@ -1323,7 +1323,7 @@ void LayoutAnimationKeyFrameManager::
       continue;
     }
 
-    for (auto &animatedKeyFrame : inflightAnimation.keyFrames) {
+    for (auto const &animatedKeyFrame : inflightAnimation.keyFrames) {
       if (animatedKeyFrame.invalidated) {
         continue;
       }
@@ -1334,7 +1334,8 @@ void LayoutAnimationKeyFrameManager::
         continue;
       }
 
-      for (auto &delayedMutation : animatedKeyFrame.finalMutationsForKeyFrame) {
+      for (auto const &delayedMutation :
+           animatedKeyFrame.finalMutationsForKeyFrame) {
         if (delayedMutation.type != ShadowViewMutation::Type::Remove) {
           continue;
         }
@@ -1372,7 +1373,7 @@ void LayoutAnimationKeyFrameManager::
             candidateMutations.begin(),
             candidateMutations.end(),
             [&changed, &mutation, &adjustedDelta, &isRemoveMutation](
-                ShadowViewMutation *candidateMutation) {
+                ShadowViewMutation const *candidateMutation) {
               bool indexConflicts =
                   (candidateMutation->index < mutation.index ||
                    (isRemoveMutation &&

package/ReactCommon/react/renderer/animations/tests/LayoutAnimationTest.cpp

@@ -64,7 +64,8 @@ static void testShadowNodeTreeLifeCycleLayoutAnimations(
   PropsParserContext parserContext{-1, *contextContainer};
 
   // Create a RuntimeExecutor
-  RuntimeExecutor runtimeExecutor = [](std::function<void(jsi::Runtime &)>) {};
+  RuntimeExecutor runtimeExecutor =
+      [](std::function<void(jsi::Runtime &)> const &) {};
 
   // Create component descriptor registry for animation driver
   auto providerRegistry =

package/ReactCommon/react/renderer/attributedstring/AttributedStringBox.cpp

@@ -54,7 +54,7 @@ std::shared_ptr<void> AttributedStringBox::getOpaquePointer() const {
 }
 
 AttributedStringBox &AttributedStringBox::operator=(
-    AttributedStringBox &&other) {
+    AttributedStringBox &&other) noexcept {
   if (this != &other) {
     mode_ = other.mode_;
     value_ = std::move(other.value_);

package/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h

@@ -43,7 +43,7 @@ class AttributedStringBox final {
   AttributedStringBox(AttributedStringBox const &other) = default;
   AttributedStringBox(AttributedStringBox &&other) noexcept;
   AttributedStringBox &operator=(AttributedStringBox const &other) = default;
-  AttributedStringBox &operator=(AttributedStringBox &&other);
+  AttributedStringBox &operator=(AttributedStringBox &&other) noexcept;
 
   /*
    * Getters.

package/ReactCommon/react/renderer/componentregistry/ComponentDescriptorProviderRegistry.cpp

@@ -46,7 +46,8 @@ void ComponentDescriptorProviderRegistry::setComponentDescriptorProviderRequest(
     ComponentDescriptorProviderRequest componentDescriptorProviderRequest)
     const {
   std::shared_lock<butter::shared_mutex> lock(mutex_);
-  componentDescriptorProviderRequest_ = componentDescriptorProviderRequest;
+  componentDescriptorProviderRequest_ =
+      std::move(componentDescriptorProviderRequest);
 }
 
 void ComponentDescriptorProviderRegistry::request(

package/ReactCommon/react/renderer/components/progressbar/android/react/renderer/components/progressbar/AndroidProgressBarMeasurementsManager.cpp

@@ -18,7 +18,7 @@ namespace react {
 
 Size AndroidProgressBarMeasurementsManager::measure(
     SurfaceId surfaceId,
-    AndroidProgressBarProps props,
+    AndroidProgressBarProps const &props,
     LayoutConstraints layoutConstraints) const {
   {
     std::lock_guard<std::mutex> lock(mutex_);

package/ReactCommon/react/renderer/components/progressbar/android/react/renderer/components/progressbar/AndroidProgressBarMeasurementsManager.h

@@ -24,7 +24,7 @@ class AndroidProgressBarMeasurementsManager {
 
   Size measure(
       SurfaceId surfaceId,
-      AndroidProgressBarProps props,
+      AndroidProgressBarProps const &props,
       LayoutConstraints layoutConstraints) const;
 
  private: