react-native 0.0.0-201c10733 → 0.0.0-268efb102

package/ReactCommon/react/renderer/uimanager/primitives.h

@@ -10,11 +10,11 @@
 #include <folly/dynamic.h>
 #include <jsi/JSIDynamic.h>
 #include <jsi/jsi.h>
+#include <react/debug/react_native_assert.h>
 #include <react/renderer/core/EventHandler.h>
 #include <react/renderer/core/ShadowNode.h>
 
-namespace facebook {
-namespace react {
+namespace facebook::react {
 
 using BackgroundExecutor =
     std::function<void(std::function<void()> &&callback)>;
@@ -43,6 +43,10 @@ struct ShadowNodeListWrapper : public jsi::HostObject {
 inline static ShadowNode::Shared shadowNodeFromValue(
     jsi::Runtime &runtime,
     jsi::Value const &value) {
+  if (value.isNull()) {
+    return nullptr;
+  }
+
   return value.getObject(runtime)
       .getHostObject<ShadowNodeWrapper>(runtime)
       ->shadowNode;
@@ -63,6 +67,34 @@ inline static SharedShadowNodeUnsharedList shadowNodeListFromValue(
       ->shadowNodeList;
 }
 
+inline static ShadowNode::UnsharedListOfShared shadowNodeListFromWeakList(
+    ShadowNode::UnsharedListOfWeak const &weakShadowNodeList) {
+  auto result = std::make_shared<ShadowNode::ListOfShared>();
+  for (auto const &weakShadowNode : *weakShadowNodeList) {
+    auto sharedShadowNode = weakShadowNode.lock();
+    if (!sharedShadowNode) {
+      return nullptr;
+    }
+    result->push_back(sharedShadowNode);
+  }
+  return result;
+}
+
+inline static ShadowNode::UnsharedListOfWeak weakShadowNodeListFromValue(
+    jsi::Runtime &runtime,
+    jsi::Value const &value) {
+  auto shadowNodeList = value.getObject(runtime)
+                            .getHostObject<ShadowNodeListWrapper>(runtime)
+                            ->shadowNodeList;
+
+  auto weakShadowNodeList = std::make_shared<ShadowNode::ListOfWeak>();
+  for (auto const &shadowNode : *shadowNodeList) {
+    weakShadowNodeList->push_back(shadowNode);
+  }
+
+  return weakShadowNodeList;
+}
+
 inline static jsi::Value valueFromShadowNodeList(
     jsi::Runtime &runtime,
     const SharedShadowNodeUnsharedList &shadowNodeList) {
@@ -70,16 +102,20 @@ inline static jsi::Value valueFromShadowNodeList(
       runtime, std::make_unique<ShadowNodeListWrapper>(shadowNodeList));
 }
 
+inline static Tag tagFromValue(jsi::Value const &value) {
+  return (Tag)value.getNumber();
+}
+
 inline static SharedEventTarget eventTargetFromValue(
     jsi::Runtime &runtime,
     jsi::Value const &eventTargetValue,
     jsi::Value const &tagValue) {
+  react_native_assert(!eventTargetValue.isNull());
+  if (eventTargetValue.isNull()) {
+    return nullptr;
+  }
   return std::make_shared<EventTarget>(
-      runtime, eventTargetValue, tagValue.getNumber());
-}
-
-inline static Tag tagFromValue(jsi::Runtime &runtime, jsi::Value const &value) {
-  return (Tag)value.getNumber();
+      runtime, eventTargetValue, tagFromValue(tagValue));
 }
 
 inline static SurfaceId surfaceIdFromValue(
@@ -88,6 +124,19 @@ inline static SurfaceId surfaceIdFromValue(
   return (SurfaceId)value.getNumber();
 }
 
+inline static int displayModeToInt(DisplayMode const value) {
+  // the result of this method should be in sync with
+  // Libraries/ReactNative/DisplayMode.js
+  switch (value) {
+    case DisplayMode::Visible:
+      return 1;
+    case DisplayMode::Suspended:
+      return 2;
+    case DisplayMode::Hidden:
+      return 3;
+  }
+}
+
 inline static std::string stringFromValue(
     jsi::Runtime &runtime,
     jsi::Value const &value) {
@@ -100,5 +149,4 @@ inline static folly::dynamic commandArgsFromValue(
   return jsi::dynamicFromValue(runtime, value);
 }
 
-} // namespace react
-} // namespace facebook
+} // namespace facebook::react

package/ReactCommon/react/test_utils/BUCK

@@ -0,0 +1,57 @@
+load(
+    "//tools/build_defs/oss:rn_defs.bzl",
+    "ANDROID",
+    "APPLE",
+    "CXX",
+    "get_apple_compiler_flags",
+    "get_apple_inspector_flags",
+    "get_preprocessor_flags_for_build_mode",
+    "react_native_xplat_target",
+    "rn_xplat_cxx_library",
+    "subdir_glob",
+)
+
+APPLE_COMPILER_FLAGS = get_apple_compiler_flags()
+
+rn_xplat_cxx_library(
+    name = "test_utils",
+    srcs = [],
+    headers = glob(
+        ["**/*.h"],
+        exclude = glob(["tests/**/*.h"]),
+    ),
+    header_namespace = "",
+    exported_headers = subdir_glob(
+        [
+            ("", "*.h"),
+        ],
+        prefix = "react/test_utils",
+    ),
+    compiler_flags = [
+        "-fexceptions",
+        "-frtti",
+        "-std=c++17",
+        "-Wall",
+    ],
+    fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
+    fbobjc_frameworks = ["Foundation"],
+    fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
+    force_static = True,
+    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    macosx_tests_override = [],
+    platforms = (ANDROID, APPLE, CXX),
+    preprocessor_flags = [
+        "-DLOG_TAG=\"ReactNative\"",
+        "-DWITH_FBSYSTRACE=1",
+    ],
+    tests = [],
+    visibility = ["PUBLIC"],
+    deps = [
+        "//xplat/jsi:jsi",
+        react_native_xplat_target("better:better"),
+        react_native_xplat_target("react/debug:debug"),
+    ],
+    exported_deps = [
+        "//xplat/third-party/gmock:gmock",
+    ],
+)

package/ReactCommon/react/{renderer/mounting/tests → test_utils}/Entropy.h

@@ -75,6 +75,10 @@ class Entropy final {
     result = generator() % 10000 < 10000 * ratio;
   }
 
+  void generateRandomValue(Generator &generator, int &result) const {
+    result = generator();
+  }
+
   void generateRandomValue(Generator &generator, int &result, int min, int max)
       const {
     std::uniform_int_distribution<int> distribution(min, max);

package/ReactCommon/react/test_utils/MockClock.h

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <chrono>
+
+class MockClock {
+ public:
+  typedef std::chrono::
+      time_point<std::chrono::steady_clock, std::chrono::nanoseconds>
+          time_point;
+
+  static time_point now() noexcept {
+    return time_;
+  }
+
+  template <typename TDuration>
+  static void advance_by(const TDuration duration) {
+    time_ += duration;
+  }
+
+ private:
+  static time_point time_;
+};

package/ReactCommon/react/{renderer/components/picker/iospicker/PickerEventEmitter.h → test_utils/MockSurfaceHandler.h}

@@ -7,21 +7,18 @@
 
 #pragma once
 
-#include <react/renderer/components/view/ViewEventEmitter.h>
+#include <gmock/gmock.h>
+
+#include <react/renderer/scheduler/SurfaceHandler.h>
 
 namespace facebook {
 namespace react {
 
-class PickerEventEmitter : public ViewEventEmitter {
+class MockSurfaceHandler : public SurfaceHandler {
  public:
-  using ViewEventEmitter::ViewEventEmitter;
-
-  struct PickerIOSChangeEvent {
-    std::string newValue;
-    int newIndex;
-  };
+  MockSurfaceHandler() : SurfaceHandler("moduleName", 0){};
 
-  void onChange(PickerIOSChangeEvent event) const;
+  MOCK_QUALIFIED_METHOD1(setDisplayMode, const noexcept, void(DisplayMode));
 };
 
 } // namespace react

package/ReactCommon/react/{renderer/mounting/tests → test_utils}/shadowTreeGeneration.h

@@ -13,6 +13,7 @@
 #include <memory>
 #include <random>
 
+#include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/mounting/Differentiator.h>
 #include <react/renderer/mounting/stubs.h>
 
@@ -116,12 +117,16 @@ static inline ShadowNode::Unshared messWithChildren(
        std::make_shared<ShadowNode::ListOfShared const>(children)});
 }
 
-static inline ShadowNode::Unshared messWithLayotableOnlyFlag(
+static inline ShadowNode::Unshared messWithLayoutableOnlyFlag(
     Entropy const &entropy,
     ShadowNode const &shadowNode) {
   auto oldProps = shadowNode.getProps();
+
+  ContextContainer contextContainer{};
+  PropsParserContext parserContext{-1, contextContainer};
+
   auto newProps = shadowNode.getComponentDescriptor().cloneProps(
-      oldProps, RawProps(folly::dynamic::object()));
+      parserContext, oldProps, RawProps(folly::dynamic::object()));
 
   auto &viewProps =
       const_cast<ViewProps &>(static_cast<ViewProps const &>(*newProps));
@@ -150,7 +155,7 @@ static inline ShadowNode::Unshared messWithLayotableOnlyFlag(
   }
 
   if (entropy.random<bool>(0.1)) {
-    viewProps.zIndex = entropy.random<bool>() ? 1 : 0;
+    viewProps.zIndex = entropy.random<int>();
   }
 
   if (entropy.random<bool>(0.1)) {
@@ -163,6 +168,51 @@ static inline ShadowNode::Unshared messWithLayotableOnlyFlag(
                                                  : Transform::Perspective(42);
   }
 
+  if (entropy.random<bool>(0.1)) {
+    viewProps.elevation = entropy.random<bool>() ? 1 : 0;
+  }
+
+  return shadowNode.clone({newProps});
+}
+
+// Similar to `messWithLayoutableOnlyFlag` but has a 50/50 chance of flattening
+// (or unflattening) a node's children.
+static inline ShadowNode::Unshared messWithNodeFlattenednessFlags(
+    Entropy const &entropy,
+    ShadowNode const &shadowNode) {
+  ContextContainer contextContainer{};
+  PropsParserContext parserContext{-1, contextContainer};
+
+  auto oldProps = shadowNode.getProps();
+  auto newProps = shadowNode.getComponentDescriptor().cloneProps(
+      parserContext, oldProps, RawProps(folly::dynamic::object()));
+
+  auto &viewProps =
+      const_cast<ViewProps &>(static_cast<ViewProps const &>(*newProps));
+
+  if (entropy.random<bool>(0.5)) {
+    viewProps.nativeId = "";
+    viewProps.collapsable = true;
+    viewProps.backgroundColor = SharedColor();
+    viewProps.foregroundColor = SharedColor();
+    viewProps.shadowColor = SharedColor();
+    viewProps.accessible = false;
+    viewProps.zIndex = {};
+    viewProps.pointerEvents = PointerEventsMode::Auto;
+    viewProps.transform = Transform::Identity();
+    viewProps.elevation = 0;
+  } else {
+    viewProps.nativeId = "42";
+    viewProps.backgroundColor = whiteColor();
+    viewProps.foregroundColor = blackColor();
+    viewProps.shadowColor = blackColor();
+    viewProps.accessible = true;
+    viewProps.zIndex = {entropy.random<int>()};
+    viewProps.pointerEvents = PointerEventsMode::None;
+    viewProps.transform = Transform::Perspective(entropy.random<int>());
+    viewProps.elevation = entropy.random<int>();
+  }
+
   return shadowNode.clone({newProps});
 }
 
@@ -189,9 +239,12 @@ static inline ShadowNode::Unshared messWithYogaStyles(
     }
   }
 
+  ContextContainer contextContainer{};
+  PropsParserContext parserContext{-1, contextContainer};
+
   auto oldProps = shadowNode.getProps();
   auto newProps = shadowNode.getComponentDescriptor().cloneProps(
-      oldProps, RawProps(dynamic));
+      parserContext, oldProps, RawProps(dynamic));
   return shadowNode.clone({newProps});
 }
 
@@ -221,8 +274,11 @@ static inline void alterShadowTree(
 
 static SharedViewProps generateDefaultProps(
     ComponentDescriptor const &componentDescriptor) {
+  ContextContainer contextContainer{};
+  PropsParserContext parserContext{-1, contextContainer};
+
   return std::static_pointer_cast<ViewProps const>(
-      componentDescriptor.cloneProps(nullptr, RawProps{}));
+      componentDescriptor.cloneProps(parserContext, nullptr, RawProps{}));
 }
 
 static inline ShadowNode::Shared generateShadowNodeTree(

package/ReactCommon/react/utils/Android.mk

@@ -11,15 +11,20 @@ LOCAL_MODULE := react_utils
 
 LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
 
-LOCAL_C_INCLUDES := $(LOCAL_PATH)
+LOCAL_C_INCLUDES := $(LOCAL_PATH) $(LOCAL_PATH)/../../
 LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../../
 
 LOCAL_CFLAGS := \
   -DLOG_TAG=\"Fabric\"
 
-LOCAL_CFLAGS += -fexceptions -frtti -std=c++14 -Wall
+LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall
 
 LOCAL_STATIC_LIBRARIES :=
-LOCAL_SHARED_LIBRARIES :=
+LOCAL_SHARED_LIBRARIES := libreact_debug libreact_render_mapbuffer libglog libglog_init
 
 include $(BUILD_SHARED_LIBRARY)
+
+$(call import-module,react/debug)
+$(call import-module,fbgloginit)
+$(call import-module,glog)
+$(call import-module,react/renderer/mapbuffer)

package/ReactCommon/react/utils/BUCK

@@ -1,4 +1,3 @@
-load("@fbsource//tools/build_defs/apple:flag_defs.bzl", "get_preprocessor_flags_for_build_mode")
 load(
     "//tools/build_defs/oss:rn_defs.bzl",
     "ANDROID",
@@ -6,6 +5,8 @@ load(
     "CXX",
     "get_apple_compiler_flags",
     "get_apple_inspector_flags",
+    "get_preprocessor_flags_for_build_mode",
+    "react_native_target",
     "react_native_xplat_target",
     "rn_xplat_cxx_library",
     "subdir_glob",
@@ -36,9 +37,13 @@ rn_xplat_cxx_library(
     compiler_flags = [
         "-fexceptions",
         "-frtti",
-        "-std=c++14",
+        "-std=c++17",
         "-Wall",
     ],
+    fbandroid_deps = [
+        react_native_target("java/com/facebook/react/common/mapbuffer/jni:jni"),
+        react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"),
+    ],
     fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
     fbobjc_frameworks = ["Foundation"],
     fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
@@ -53,11 +58,13 @@ rn_xplat_cxx_library(
     tests = [],
     visibility = ["PUBLIC"],
     deps = [
+        "//third-party/glog:glog",
         "//xplat/folly:container_evicting_cache_map",
         "//xplat/folly:headers_only",
         "//xplat/folly:memory",
         "//xplat/folly:molly",
         "//xplat/jsi:jsi",
         react_native_xplat_target("better:better"),
+        react_native_xplat_target("react/debug:debug"),
     ],
 )

package/ReactCommon/react/utils/CalledOnceMovableOnlyFunction.h

@@ -7,6 +7,8 @@
 
 #include <functional>
 
+#include <react/debug/react_native_assert.h>
+
 namespace facebook {
 namespace react {
 
@@ -31,7 +33,7 @@ class CalledOnceMovableOnlyFunction {
   }
 
   ~CalledOnceMovableOnlyFunction() {
-    assert(
+    react_native_assert(
         (wasCalled_ || wasMovedFrom_) &&
         "`CalledOnceMovableOnlyFunction` is destroyed before being called.");
   }
@@ -57,7 +59,7 @@ class CalledOnceMovableOnlyFunction {
 
   CalledOnceMovableOnlyFunction &operator=(
       CalledOnceMovableOnlyFunction &&other) noexcept {
-    assert(
+    react_native_assert(
         (wasCalled_ || wasMovedFrom_) &&
         "`CalledOnceMovableOnlyFunction` is re-assigned before being called.");
     wasCalled_ = false;
@@ -71,10 +73,10 @@ class CalledOnceMovableOnlyFunction {
    * Callable.
    */
   ReturnT operator()(ArgumentT... args) {
-    assert(
+    react_native_assert(
         !wasMovedFrom_ &&
         "`CalledOnceMovableOnlyFunction` is called after being moved from.");
-    assert(
+    react_native_assert(
         !wasCalled_ &&
         "`CalledOnceMovableOnlyFunction` is called more than once.");
 

package/ReactCommon/react/utils/ContextContainer.h

@@ -15,6 +15,9 @@
 #include <better/mutex.h>
 #include <better/optional.h>
 
+#include <react/debug/flags.h>
+#include <react/debug/react_native_assert.h>
+
 namespace facebook {
 namespace react {
 
@@ -42,10 +45,6 @@ class ContextContainer final {
     std::unique_lock<better::shared_mutex> lock(mutex_);
 
     instances_.insert({key, std::make_shared<T>(instance)});
-
-#ifndef NDEBUG
-    typeNames_.insert({key, typeid(T).name()});
-#endif
   }
 
   /*
@@ -56,10 +55,6 @@ class ContextContainer final {
     std::unique_lock<better::shared_mutex> lock(mutex_);
 
     instances_.erase(key);
-
-#ifndef NDEBUG
-    typeNames_.erase(key);
-#endif
   }
 
   /*
@@ -73,11 +68,6 @@ class ContextContainer final {
     for (auto const &pair : contextContainer.instances_) {
       instances_.erase(pair.first);
       instances_.insert(pair);
-#ifndef NDEBUG
-      typeNames_.erase(pair.first);
-      typeNames_.insert(
-          {pair.first, contextContainer.typeNames_.at(pair.first)});
-#endif
     }
   }
 
@@ -90,12 +80,9 @@ class ContextContainer final {
   T at(std::string const &key) const {
     std::shared_lock<better::shared_mutex> lock(mutex_);
 
-    assert(
+    react_native_assert(
         instances_.find(key) != instances_.end() &&
         "ContextContainer doesn't have an instance for given key.");
-    assert(
-        typeNames_.at(key) == typeid(T).name() &&
-        "ContextContainer stores an instance of different type for given key.");
     return *std::static_pointer_cast<T>(instances_.at(key));
   }
 
@@ -113,10 +100,6 @@ class ContextContainer final {
       return {};
     }
 
-    assert(
-        typeNames_.at(key) == typeid(T).name() &&
-        "ContextContainer stores an instance of different type for given key.");
-
     return *std::static_pointer_cast<T>(iterator->second);
   }
 
@@ -124,9 +107,6 @@ class ContextContainer final {
   mutable better::shared_mutex mutex_;
   // Protected by mutex_`.
   mutable better::map<std::string, std::shared_ptr<void>> instances_;
-#ifndef NDEBUG
-  mutable better::map<std::string, std::string> typeNames_;
-#endif
 };
 
 } // namespace react

package/ReactCommon/react/utils/LayoutManager.h

@@ -10,6 +10,11 @@
 #include <react/jni/ReadableNativeMap.h>
 #include <react/renderer/core/LayoutPrimitives.h>
 #include <react/renderer/core/conversions.h>
+#ifdef ANDROID
+#include <react/common/mapbuffer/ReadableMapBuffer.h>
+#include <react/renderer/mapbuffer/MapBuffer.h>
+#include <react/renderer/mapbuffer/MapBufferBuilder.h>
+#endif
 #include <string>
 
 namespace facebook {
@@ -88,6 +93,57 @@ Size measureAndroidComponent(
   return size;
 }
 
+Size measureAndroidComponentMapBuffer(
+    const ContextContainer::Shared &contextContainer,
+    Tag rootTag,
+    std::string componentName,
+    MapBuffer &localData,
+    MapBuffer &props,
+    float minWidth,
+    float maxWidth,
+    float minHeight,
+    float maxHeight,
+    jfloatArray attachmentPositions) {
+  const jni::global_ref<jobject> &fabricUIManager =
+      contextContainer->at<jni::global_ref<jobject>>("FabricUIManager");
+  auto componentNameRef = make_jstring(componentName);
+
+  static auto measure =
+      jni::findClassStatic("com/facebook/react/fabric/FabricUIManager")
+          ->getMethod<jlong(
+              jint,
+              jstring,
+              ReadableMapBuffer::javaobject,
+              ReadableMapBuffer::javaobject,
+              jfloat,
+              jfloat,
+              jfloat,
+              jfloat,
+              jfloatArray)>("measureMapBuffer");
+
+  auto localDataMap =
+      ReadableMapBuffer::createWithContents(std::move(localData));
+  auto propsMap = ReadableMapBuffer::createWithContents(std::move(props));
+
+  auto size = yogaMeassureToSize(measure(
+      fabricUIManager,
+      rootTag,
+      componentNameRef.get(),
+      localDataMap.get(),
+      propsMap.get(),
+      minWidth,
+      maxWidth,
+      minHeight,
+      maxHeight,
+      attachmentPositions));
+
+  // Explicitly release smart pointers to free up space faster in JNI tables
+  componentNameRef.reset();
+  localDataMap.reset();
+  propsMap.reset();
+  return size;
+}
+
 #endif
 
 } // namespace react

package/ReactCommon/react/utils/ManagedObjectWrapper.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/debug/react_native_assert.h>
+
 #if defined(__OBJC__) && defined(__cplusplus)
 #if TARGET_OS_MAC && TARGET_OS_IPHONE
 
@@ -65,7 +67,7 @@ inline std::shared_ptr<void> wrapManagedObjectWeakly(id object) noexcept
 inline id unwrapManagedObjectWeakly(std::shared_ptr<void> const &object) noexcept
 {
   RCTInternalGenericWeakWrapper *weakWrapper = (RCTInternalGenericWeakWrapper *)unwrapManagedObject(object);
-  assert(weakWrapper && "`RCTInternalGenericWeakWrapper` instance must not be `nil`.");
+  react_native_assert(weakWrapper && "`RCTInternalGenericWeakWrapper` instance must not be `nil`.");
   return weakWrapper.object;
 }
 

package/ReactCommon/react/utils/RunLoopObserver.cpp

@@ -7,7 +7,7 @@
 
 #include "RunLoopObserver.h"
 
-#include <cassert>
+#include <react/debug/react_native_assert.h>
 
 namespace facebook {
 namespace react {
@@ -19,8 +19,9 @@ RunLoopObserver::RunLoopObserver(
 
 void RunLoopObserver::setDelegate(Delegate const *delegate) const noexcept {
   // We need these constraints to ensure basic thread-safety.
-  assert(delegate && "A delegate must not be `nullptr`.");
-  assert(!delegate_ && "`RunLoopObserver::setDelegate` must be called once.");
+  react_native_assert(delegate && "A delegate must not be `nullptr`.");
+  react_native_assert(
+      !delegate_ && "`RunLoopObserver::setDelegate` must be called once.");
   delegate_ = delegate;
 }
 
@@ -47,7 +48,7 @@ void RunLoopObserver::activityDidChange(Activity activity) const noexcept {
     return;
   }
 
-  assert(
+  react_native_assert(
       !owner_.expired() &&
       "`owner_` is null. The caller must `lock` the owner and check it for being not null.");
 

package/ReactCommon/reactperflogger/Android.mk

@@ -13,7 +13,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH)/reactperflogger
 # Header search path for modules that depend on this module
 LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
 
-LOCAL_CFLAGS += -fexceptions -frtti -std=c++14 -Wall
+LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall
 
 # Name of this module.
 LOCAL_MODULE := reactperflogger

package/ReactCommon/reactperflogger/BUCK

@@ -11,7 +11,7 @@ rn_xplat_cxx_library(
     compiler_flags = [
         "-fexceptions",
         "-frtti",
-        "-std=c++14",
+        "-std=c++17",
         "-Wall",
         "-Wno-global-constructors",
     ],