react-native-zcash 0.4.0 → 0.4.2

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # React Native Zcash
 
+## 0.4.2 (2023-09-14)
+
+- changed: Always return memos array with transactions
+- changed: Simplify compactMap transform
+
+## 0.4.1 (2023-09-13)
+
+- fixed: Update checkpoint path (Android)
+- fixed: Fix view key derivation (Android)
+- fixed: Fix `getTransactions` early exit (Android)
+- fixed: Fix hex string handling (Android)
+- fixed: Fix recipient address availability assumption (iOS)
+
 ## 0.4.0 (2023-09-04)
 
 - changed: Upgrade zcash-android-sdk to v1.20.0-beta01

package/android/src/main/assets/co.electriccoin.zcash/checkpoint/mainnet/2220000.json

@@ -0,0 +1,8 @@
+{
+  "network": "main",
+  "height": "2220000",
+  "hash": "000000000172b493b91a2bf8da492818f469abaf367f0a34c6088d7384bf438d",
+  "time": 1694189265,
+  "saplingTree": "01e1fdb4fbf39470312e2ee698bbadaae6a6f600630704ce828f624092d419eb2b01bb2e754503afcbeba2f5f351cde44316015799935827d50086a09347b9aa72281a019cc2cee08afd6df6cbc2d89a3a7f5381c466fc8718a52e6db6e6fa44063db24000000000017e8553f04eb329f93a9882e2656a7d9772a7d12098932e9fc10b094844d4675701de3681f6095e049db159b1b3f7058a80bf8178e7dcc36de3e3eb11a2abc3584001fc25e0cec13e3f59891b069f75fd51f2caa60f501e23b3afdf6209faf71edf1b00000001d177df23a29c4acfa477b94c55bf3baa5b4f43dc65bf94ed65cf3ac7b2d753300001055bb26ddf3a7a7efa91af3ba8c040cf4f373d366b3bb01a778cc54fc31ab32a01cf666e6ab15724fcad98c1eaf7d0b555e9cfa4132c4152a5946256421eda496101ba391f92d9f6f13ffa0a9be8f09e113dd528f28d64e3fa82a9841c3871f5711e000001d8ccea507421a590ed38116b834189cdc22421b4764179fa4e364803dfa66d56018cf6f5034a55fed59d1d832620916a43c756d2379e50ef9440fc4c3e7a29aa2300011619f99023a69bb647eab2d2aa1a73c3673c74bb033c3c4930eacda19e6fd93b0000000160272b134ca494b602137d89e528c751c06d3ef4a87a45f33af343c15060cc1e",
+  "orchardTree": "01e9654f2f2065ea7222b509f367053c8c60335abd1fef4d4a8cc8f1b6e4c2a133011093acb8712c698913d117410839280fe234942db8fec4830c6544b3d97da0361f0000015cfab442f440115599554959ca560451d1da80cfa1fac8031be6c091c9eb79110001bf4c6e2c88cb1b29df8cbe2ab268c40e3d2a2d26155a3ebfc3a9d450954c6d050001b8c991defe192f04816e611cbeff67ba630aba4e68cb9a01d8a15861d6d5460001463c8512a48687e5827657cefbc11b0495302ca787760ef02346bdb91922c10801a23a492db19a8b6962c4f58d478dcc81a3b22f59914a8dbaced764f53e923e3700000177fe87edaf3267ef297756a3b204b4920001f2db983b35a9a122e79b4a90bb2c011c624f6c2160a85fc2821643724e4ecb61ac64738e0fb36a51933a83e8618c260162cb5b712202981670217893d510e9464364f9e7e3084b43f0450d1f91a85e00000001cf3bf92f69798e68555548afcce1648add1fb2548d64fa9a1ec22a3e26e7890101e637281deb58dff0c44ba13149b784a95da1b493005efd057e6f4ac20ef5d81d000001cc2dcaa338b312112db04b435a706d63244dd435238f0aa1e9e1598d35470810012dcc4273c8a0ed2337ecf7879380a07e7d427c7f9d82e538002bd1442978402c01daf63debf5b40df902dae98dadc029f281474d190cddecef1b10653248a234150001e2bca6a8d987d668defba89dc082196a922634ed88e065c669e526bb8815ee1b000000000000"
+}

package/android/src/main/java/app/edge/rnzcash/RNZcashModule.kt

@@ -116,6 +116,8 @@ class RNZcashModule(private val reactContext: ReactApplicationContext) :
             if (tx.memoCount > 0) {
                 val memos = runBlocking { wallet.getMemos(tx).take(tx.memoCount).toList() }
                 map.putArray("memos", Arguments.fromList(memos))
+            } else {
+                map.putArray("memos", Arguments.createArray())
             }
             return map
         }
@@ -126,7 +128,7 @@ class RNZcashModule(private val reactContext: ReactApplicationContext) :
             val nativeArray = Arguments.createArray()
             if (numTxs == 0) {
                 promise.resolve(nativeArray)
-                this.coroutineContext.cancel()
+                return@launch
             }
             runBlocking {
                 wallet.transactions.onEach {
@@ -157,8 +159,9 @@ class RNZcashModule(private val reactContext: ReactApplicationContext) :
     }
 
     @ReactMethod
-    fun deriveViewingKey(seedBytesHex: String, network: String = "mainnet", promise: Promise) {
-        var keys = runBlocking { DerivationTool.getInstance().deriveUnifiedFullViewingKeys(seedBytesHex.fromHex(), networks.getOrDefault(network, ZcashNetwork.Mainnet), DerivationTool.DEFAULT_NUMBER_OF_ACCOUNTS)[0] }
+    fun deriveViewingKey(seed: String, network: String = "mainnet", promise: Promise) {
+        var seedPhrase = SeedPhrase.new(seed)
+        var keys = runBlocking { DerivationTool.getInstance().deriveUnifiedFullViewingKeys(seedPhrase.toByteArray(), networks.getOrDefault(network, ZcashNetwork.Mainnet), DerivationTool.DEFAULT_NUMBER_OF_ACCOUNTS)[0] }
         promise.resolve(keys.encoding)
     }
 
@@ -241,8 +244,8 @@ class RNZcashModule(private val reactContext: ReactApplicationContext) :
                 if (tx == null) throw Exception("transaction failed")
 
                 val map = Arguments.createMap()
-                map.putString("txId", tx.rawId.toString())
-                if (tx.raw != null) map.putString("raw", tx.raw.toString())
+                map.putString("txId", tx.rawId.byteArray.toHexReversed())
+                if (tx.raw != null) map.putString("raw", tx.raw?.byteArray?.toHex())
                 promise.resolve(map)
             } catch (t: Throwable) {
                 promise.reject("Err", t)

package/ios/RNZcash.swift

@@ -11,7 +11,7 @@ struct ConfirmedTx {
   var rawTransactionId: String
   var blockTimeInSeconds: Int
   var value: String
-  var memo: Array<String>?
+  var memos: Array<String>?
   var dictionary: [String: Any?] {
     return [
       "minedHeight": minedHeight,
@@ -19,7 +19,7 @@ struct ConfirmedTx {
       "rawTransactionId": rawTransactionId,
       "blockTimeInSeconds": blockTimeInSeconds,
       "value": value,
-      "memo": memo,
+      "memos": memos ?? [],
     ]
   }
   var nsDictionary: NSDictionary {
@@ -270,19 +270,17 @@ class RNZcash: RCTEventEmitter {
                     return nil
                   }
                 }
-                confTx.toAddress = addresses.first!.stringEncoded
+                if addresses.count > 0 {
+                  confTx.toAddress = addresses.first!.stringEncoded
+                }
               }
             }
             if tx.memoCount > 0 {
               let memos = (try? await wallet.synchronizer.getMemos(for: tx)) ?? []
               let textMemos = memos.compactMap {
-                if case let .text(memo) = $0 {
-                  return memo.string
-                } else {
-                  return nil
-                }
+                return $0.toString()
               }
-              confTx.memo = textMemos
+              confTx.memos = textMemos
             }
             out.append(confTx.nsDictionary)
           }

package/ios/ZCashLightClientKit/Resources/checkpoints/mainnet/2220000.json

@@ -0,0 +1,8 @@
+{
+  "network": "main",
+  "height": "2220000",
+  "hash": "000000000172b493b91a2bf8da492818f469abaf367f0a34c6088d7384bf438d",
+  "time": 1694189265,
+  "saplingTree": "01e1fdb4fbf39470312e2ee698bbadaae6a6f600630704ce828f624092d419eb2b01bb2e754503afcbeba2f5f351cde44316015799935827d50086a09347b9aa72281a019cc2cee08afd6df6cbc2d89a3a7f5381c466fc8718a52e6db6e6fa44063db24000000000017e8553f04eb329f93a9882e2656a7d9772a7d12098932e9fc10b094844d4675701de3681f6095e049db159b1b3f7058a80bf8178e7dcc36de3e3eb11a2abc3584001fc25e0cec13e3f59891b069f75fd51f2caa60f501e23b3afdf6209faf71edf1b00000001d177df23a29c4acfa477b94c55bf3baa5b4f43dc65bf94ed65cf3ac7b2d753300001055bb26ddf3a7a7efa91af3ba8c040cf4f373d366b3bb01a778cc54fc31ab32a01cf666e6ab15724fcad98c1eaf7d0b555e9cfa4132c4152a5946256421eda496101ba391f92d9f6f13ffa0a9be8f09e113dd528f28d64e3fa82a9841c3871f5711e000001d8ccea507421a590ed38116b834189cdc22421b4764179fa4e364803dfa66d56018cf6f5034a55fed59d1d832620916a43c756d2379e50ef9440fc4c3e7a29aa2300011619f99023a69bb647eab2d2aa1a73c3673c74bb033c3c4930eacda19e6fd93b0000000160272b134ca494b602137d89e528c751c06d3ef4a87a45f33af343c15060cc1e",
+  "orchardTree": "01e9654f2f2065ea7222b509f367053c8c60335abd1fef4d4a8cc8f1b6e4c2a133011093acb8712c698913d117410839280fe234942db8fec4830c6544b3d97da0361f0000015cfab442f440115599554959ca560451d1da80cfa1fac8031be6c091c9eb79110001bf4c6e2c88cb1b29df8cbe2ab268c40e3d2a2d26155a3ebfc3a9d450954c6d050001b8c991defe192f04816e611cbeff67ba630aba4e68cb9a01d8a15861d6d5460001463c8512a48687e5827657cefbc11b0495302ca787760ef02346bdb91922c10801a23a492db19a8b6962c4f58d478dcc81a3b22f59914a8dbaced764f53e923e3700000177fe87edaf3267ef297756a3b204b4920001f2db983b35a9a122e79b4a90bb2c011c624f6c2160a85fc2821643724e4ecb61ac64738e0fb36a51933a83e8618c260162cb5b712202981670217893d510e9464364f9e7e3084b43f0450d1f91a85e00000001cf3bf92f69798e68555548afcce1648add1fb2548d64fa9a1ec22a3e26e7890101e637281deb58dff0c44ba13149b784a95da1b493005efd057e6f4ac20ef5d81d000001cc2dcaa338b312112db04b435a706d63244dd435238f0aa1e9e1598d35470810012dcc4273c8a0ed2337ecf7879380a07e7d427c7f9d82e538002bd1442978402c01daf63debf5b40df902dae98dadc029f281474d190cddecef1b10653248a234150001e2bca6a8d987d668defba89dc082196a922634ed88e065c669e526bb8815ee1b000000000000"
+}

package/lib/src/types.d.ts

@@ -60,5 +60,5 @@ export interface ConfirmedTransaction {
     minedHeight: number;
     value: string;
     toAddress?: string;
-    memo?: string;
+    memos: string[];
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-zcash",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "description": "Zcash library for React Native",
   "homepage": "https://github.com/EdgeApp/react-native-zcash",
   "repository": {

package/src/types.ts

@@ -79,5 +79,5 @@ export interface ConfirmedTransaction {
   minedHeight: number
   value: string
   toAddress?: string
-  memo?: string
+  memos: string[]
 }