react-native-worklets 0.10.3 → 0.10.4

package/Common/cpp/worklets/RunLoop/AsyncQueueImpl.cpp

@@ -9,11 +9,40 @@
 #include <thread>
 #include <utility>
 
+#if __APPLE__
+extern "C" {
+void *objc_autoreleasePoolPush(void);
+void objc_autoreleasePoolPop(void *pool);
+}
+#endif // __APPLE__
+
 namespace worklets {
 
 using namespace facebook;
 
+#if __APPLE__
+namespace {
+
+class ScopedAutoreleasePool {
+ public:
+  ScopedAutoreleasePool() : pool_(objc_autoreleasePoolPush()) {}
+  ~ScopedAutoreleasePool() {
+    objc_autoreleasePoolPop(pool_);
+  }
+  ScopedAutoreleasePool(const ScopedAutoreleasePool &) = delete;
+  ScopedAutoreleasePool &operator=(const ScopedAutoreleasePool &) = delete;
+
+ private:
+  void *const pool_;
+};
+
+} // namespace
+#endif // __APPLE__
+
 void AsyncQueueImpl::runLoop(const std::shared_ptr<AsyncQueueState> &state) {
+#if __APPLE__
+  const ScopedAutoreleasePool threadAutoreleasePool;
+#endif // __APPLE__
   while (state->running) {
     std::unique_lock<std::mutex> lock(state->mutex);
     state->cv.wait(lock, [state] { return !state->queue.empty() || !state->running; });
@@ -26,6 +55,9 @@ void AsyncQueueImpl::runLoop(const std::shared_ptr<AsyncQueueState> &state) {
     auto job = std::move(state->queue.front());
     state->queue.pop();
     lock.unlock();
+#if __APPLE__
+    const ScopedAutoreleasePool autoreleasePool;
+#endif // __APPLE__
     job();
   }
 }

package/android/src/networking/com/swmansion/worklets/WorkletsModule.kt

@@ -14,7 +14,6 @@ import com.facebook.react.turbomodule.core.CallInvokerHolderImpl
 import com.facebook.soloader.SoLoader
 import com.swmansion.worklets.runloop.AnimationFrameCallback
 import com.swmansion.worklets.runloop.AnimationFrameQueue
-import java.util.concurrent.atomic.AtomicBoolean
 
 @Suppress("KotlinJniMissingFunction")
 @ReactModule(name = WorkletsModule.NAME)
@@ -50,7 +49,8 @@ class WorkletsModule(
      * Invalidating concurrently could be fatal. It shouldn't happen in a normal flow, but it doesn't
      * cost us much to add synchronization for extra safety.
      */
-    private val mInvalidated = AtomicBoolean(false)
+    private val mInvalidationLock = Any()
+    private var mInvalidated = false
 
     @OptIn(FrameworkAPI::class)
     private external fun initHybrid(
@@ -161,9 +161,17 @@ class WorkletsModule(
         return mSlowAnimationsEnabled
     }
 
+    override fun initialize() {
+        reactApplicationContext.addLifecycleEventListener(this)
+    }
+
     override fun invalidate() {
-        if (mInvalidated.getAndSet(true)) {
-            return
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mInvalidated = true
+            reactApplicationContext.removeLifecycleEventListener(this)
         }
         if (mHybridData != null && mHybridData!!.isValid) {
             invalidateCpp()
@@ -176,11 +184,21 @@ class WorkletsModule(
     private external fun startCpp()
 
     override fun onHostResume() {
-        mAnimationFrameQueue.resume()
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mAnimationFrameQueue.resume()
+        }
     }
 
     override fun onHostPause() {
-        mAnimationFrameQueue.pause()
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mAnimationFrameQueue.pause()
+        }
     }
 
     override fun onHostDestroy() {}

package/android/src/no-networking/com/swmansion/worklets/WorkletsModule.kt

@@ -11,7 +11,6 @@ import com.facebook.react.turbomodule.core.CallInvokerHolderImpl
 import com.facebook.soloader.SoLoader
 import com.swmansion.worklets.runloop.AnimationFrameCallback
 import com.swmansion.worklets.runloop.AnimationFrameQueue
-import java.util.concurrent.atomic.AtomicBoolean
 
 @Suppress("KotlinJniMissingFunction")
 @ReactModule(name = WorkletsModule.NAME)
@@ -46,7 +45,8 @@ class WorkletsModule(
      * Invalidating concurrently could be fatal. It shouldn't happen in a normal flow, but it doesn't
      * cost us much to add synchronization for extra safety.
      */
-    private val mInvalidated = AtomicBoolean(false)
+    private val mInvalidationLock = Any()
+    private var mInvalidated = false
 
     @OptIn(FrameworkAPI::class)
     private external fun initHybrid(
@@ -117,9 +117,17 @@ class WorkletsModule(
         return mSlowAnimationsEnabled
     }
 
+    override fun initialize() {
+        reactApplicationContext.addLifecycleEventListener(this)
+    }
+
     override fun invalidate() {
-        if (mInvalidated.getAndSet(true)) {
-            return
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mInvalidated = true
+            reactApplicationContext.removeLifecycleEventListener(this)
         }
         if (mHybridData != null && mHybridData!!.isValid) {
             invalidateCpp()
@@ -132,11 +140,21 @@ class WorkletsModule(
     private external fun startCpp()
 
     override fun onHostResume() {
-        mAnimationFrameQueue.resume()
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mAnimationFrameQueue.resume()
+        }
     }
 
     override fun onHostPause() {
-        mAnimationFrameQueue.pause()
+        synchronized(mInvalidationLock) {
+            if (mInvalidated) {
+                return
+            }
+            mAnimationFrameQueue.pause()
+        }
     }
 
     override fun onHostDestroy() {}

package/lib/module/debug/jsVersion.js

@@ -5,5 +5,5 @@
  * version used to build the native part of the library in runtime. Remember to
  * keep this in sync with the version declared in `package.json`
  */
-export const jsVersion = '0.10.3';
+export const jsVersion = '0.10.4';
 //# sourceMappingURL=jsVersion.js.map

package/lib/typescript/debug/jsVersion.d.ts

@@ -3,5 +3,5 @@
  * version used to build the native part of the library in runtime. Remember to
  * keep this in sync with the version declared in `package.json`
  */
-export declare const jsVersion = "0.10.3";
+export declare const jsVersion = "0.10.4";
 //# sourceMappingURL=jsVersion.d.ts.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-worklets",
-  "version": "0.10.3",
+  "version": "0.10.4",
   "description": "The React Native multithreading library",
   "keywords": [
     "react-native",

package/src/debug/jsVersion.ts

@@ -5,4 +5,4 @@
  * version used to build the native part of the library in runtime. Remember to
  * keep this in sync with the version declared in `package.json`
  */
-export const jsVersion = '0.10.3';
+export const jsVersion = '0.10.4';