react-native-windows 0.77.0 → 0.78.0-preview.2

package/PropertySheets/React.Cpp.props

@@ -73,6 +73,9 @@
       -->
       <PreprocessorDefinitions>_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR;%(PreprocessorDefinitions)</PreprocessorDefinitions>
     </ClCompile>
+    <Midl>
+      <PreprocessorDefinitions Condition="'$(UseFabric)' == 'true'">USE_FABRIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+    </Midl>
   </ItemDefinitionGroup>
 
   <PropertyGroup>

package/PropertySheets/WebView2.props

@@ -2,6 +2,6 @@
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup Label="WebView2 versioning">
       <!-- WinAppSDK 1.6+ has a dependency on Microsoft.Web.WebView2, there are a few places we need to pull in this package explicitly. -->
-      <WebView2PackageVersion>1.0.2651.64</WebView2PackageVersion>
+      <WebView2PackageVersion>1.0.2792.45</WebView2PackageVersion>
   </PropertyGroup>
 </Project>

package/PropertySheets/WinUI.props

@@ -4,15 +4,16 @@
 
     <!-- 
       Internal versions are located at: https://microsoft.visualstudio.com/DefaultCollection/ProjectReunion/_artifacts/feed/Project.Reunion.nuget.internal/NuGet/Microsoft.WindowsAppSDK/versions
-      For local testing of internal versions, modify the WinUI3Version, and comment out the addition nuget source in NuGet.Config
+      For local testing of internal versions, modify WinUI3ExperimentalVersion, and comment out the addition nuget source in NuGet.Config
     -->
-    <!-- This value is also used by the CLI, see /packages/@react-native-windows/generate-windows -->
-    <WinUI3Version Condition="'$(WinUI3Version)'=='' AND '$(UseExperimentalWinUI3)'=='true'">1.6.240701003-experimental2</WinUI3Version>
+    <WinUI3ExperimentalVersion Condition="'$(WinUI3ExperimentalVersion)'==''">1.7.250109001-experimental2</WinUI3ExperimentalVersion>
+    <!-- This value is also used by the CLI, see /packages/@react-native-windows/cli/.../autolinkWindows.ts -->
+    <WinUI3Version Condition="'$(WinUI3Version)'=='' AND '$(UseExperimentalWinUI3)'=='true'">$(WinUI3ExperimentalVersion)</WinUI3Version>
     <WinUI3Version Condition="'$(WinUI3Version)'==''">1.6.240923002</WinUI3Version>
   </PropertyGroup>
 
   <PropertyGroup Label="WinUI2x versioning">
-		<!--This value is also used by the CLI, see /packages/@react-native-windows/generate-windows -->
+		<!--This value is also used by the CLI, see /packages/@react-native-windows/cli/.../autolinkWindows.ts -->
     <WinUI2xVersion Condition="'$(WinUI2xVersion)'==''">2.8.0</WinUI2xVersion>
   </PropertyGroup>
 

package/ReactCommon/ReactCommon.vcxproj

@@ -114,7 +114,7 @@
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\NativeToJsBridge.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\ReactMarker.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\RecoverableError.h" />
-    <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\SystraceSection.h" />
+    <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\TraceSection.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\jsiexecutor\jsireact\JSIExecutor.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\jsiexecutor\jsireact\JSINativeModules.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\InspectorInterfaces.h" />
@@ -140,6 +140,7 @@
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsiexecutor\jsireact\JSIExecutor.cpp" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsiexecutor\jsireact\JSINativeModules.cpp" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\InspectorInterfaces.cpp" />
+    <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\InspectorFlags.cpp" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\logger\react_native_log.cpp" />
     <CLCompile Include="$(ReactNativeDir)\ReactCommon\reactperflogger\fusebox\FuseboxTracer.cpp" />
     <CLCompile Include="$(ReactNativeDir)\ReactCommon\reactperflogger\reactperflogger\BridgeNativeModulePerfLogger.cpp" />
@@ -192,6 +193,9 @@
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\runtimescheduler\RuntimeScheduler_Modern.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\core\PropsParserContext.h" />
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\components\textinput\basePrimitives.h" />
+    <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\components\textinput\TextInputState.h" />
+    <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\components\textlayoutmanager\TextLayoutManager.h" />
+    <ClInclude Include="$(ReactNativeDir)\ReactCommon\react\renderer\imagemanager\platform\cxx\react\renderer\imagemanager\ImageRequestParams.h" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\react\bridging\LongLivedObject.cpp" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\react\nativemodule\core\ReactCommon\TurboCxxModule.cpp" />
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\react\nativemodule\core\ReactCommon\TurboModule.cpp" />

package/ReactCommon/ReactCommon.vcxproj.filters

@@ -267,7 +267,7 @@
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\RecoverableError.h">
       <Filter>cxxreact</Filter>
     </ClInclude>
-    <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\SystraceSection.h">
+    <ClInclude Include="$(ReactNativeDir)\ReactCommon\cxxreact\TraceSection.h">
       <Filter>cxxreact</Filter>
     </ClInclude>
     <ClInclude Include="$(ReactNativeDir)\ReactCommon\jsiexecutor\jsireact\JSIExecutor.h">

package/ReactCommon/TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.cpp

@@ -11,9 +11,9 @@
 
 #include <folly/Conv.h>
 #include <jsinspector-modern/ReactCdp.h>
-#include <jsinspector-modern/ConsoleMessage.h>
+#include <react/timing/primitives.h>
 
-#include <reactperflogger/ReactPerfLogger.h>
+#include <chrono>
 
 namespace facebook::react {
 
@@ -27,7 +27,7 @@ std::string JSExecutor::getSyntheticBundlePath(
 }
 
 double JSExecutor::performanceNow() {
-  return ReactPerfLogger::performanceNow();
+  return chronoToDOMHighResTimeStamp(std::chrono::steady_clock::now());
 }
 
 void JSExecutor::addConsoleMessage(jsi::Runtime& runtime, jsinspector_modern::ConsoleMessage message){

package/ReactCommon/TEMP_UntilReactCommonUpdate/cxxreact/NativeToJsBridge.cpp

@@ -21,7 +21,7 @@
 #include "ModuleRegistry.h"
 #include "MoveWrapper.h"
 #include "RAMBundleRegistry.h"
-#include "SystraceSection.h"
+#include "TraceSection.h"
 
 #include <memory>
 
@@ -194,7 +194,7 @@ void NativeToJsBridge::callFunction(
 #ifdef WITH_FBSYSTRACE
     FbSystraceAsyncFlow::end(
         TRACE_TAG_REACT_CXX_BRIDGE, "JSCall", systraceCookie);
-    SystraceSection s(
+    TraceSection s(
         "NativeToJsBridge::callFunction", "module", module, "method", method);
 #else
     (void)(systraceCookie);
@@ -229,7 +229,7 @@ void NativeToJsBridge::invokeCallback(
 #ifdef WITH_FBSYSTRACE
         FbSystraceAsyncFlow::end(
             TRACE_TAG_REACT_CXX_BRIDGE, "<callback>", systraceCookie);
-        SystraceSection s("NativeToJsBridge::invokeCallback");
+        TraceSection s("NativeToJsBridge::invokeCallback");
 #else
         (void)(systraceCookie);
 #endif

package/ReactCommon/TEMP_UntilReactCommonUpdate/jsi/jsi/test/testlib.cpp

@@ -1611,6 +1611,97 @@ TEST_P(JSITest, UTF16Test) {
 }
 Windows] */
 
+/*
+[Windows 
+TEST_P(JSITest, GetStringDataTest) {
+  // This Runtime Decorator is used to test the default getStringData
+  // implementation for VMs that do not provide their own implementation
+  class RD : public RuntimeDecorator<Runtime, Runtime> {
+   public:
+    RD(Runtime& rt) : RuntimeDecorator(rt) {}
+
+    void getStringData(
+        const String& str,
+        void* ctx,
+        void (*cb)(void* ctx, bool ascii, const void* data, size_t num))
+        override {
+      Runtime::getStringData(str, ctx, cb);
+    }
+  };
+
+  RD rd = RD(rt);
+  String str = String::createFromUtf8(rd, "hello👋");
+
+  std::u16string buf;
+  auto cb = [&buf](bool ascii, const void* data, size_t num) {
+    assert(!ascii && "Default implementation is always utf16");
+    buf.append((const char16_t*)data, num);
+  };
+
+  str.getStringData(rd, cb);
+  EXPECT_EQ(buf, str.utf16(rd));
+}
+
+TEST_P(JSITest, ObjectSetPrototype) {
+  // This Runtime Decorator is used to test the default implementation of
+  // Object.setPrototypeOf
+  class RD : public RuntimeDecorator<Runtime, Runtime> {
+   public:
+    explicit RD(Runtime& rt) : RuntimeDecorator(rt) {}
+
+    void setPrototypeOf(const Object& object, const Value& prototype) override {
+      return Runtime::setPrototypeOf(object, prototype);
+    }
+
+    Value getPrototypeOf(const Object& object) override {
+      return Runtime::getPrototypeOf(object);
+    }
+  };
+
+  RD rd = RD(rt);
+  Object child(rd);
+
+  // Tests null value as prototype
+  child.setPrototype(rd, Value::null());
+  EXPECT_TRUE(child.getPrototype(rd).isNull());
+
+  Object prototypeObj(rd);
+  prototypeObj.setProperty(rd, "someProperty", 123);
+  Value prototype(rd, prototypeObj);
+
+  child.setPrototype(rd, prototype);
+  EXPECT_EQ(child.getProperty(rd, "someProperty").getNumber(), 123);
+
+  auto getPrototypeRes = child.getPrototype(rd).asObject(rd);
+  EXPECT_EQ(getPrototypeRes.getProperty(rd, "someProperty").getNumber(), 123);
+}
+
+TEST_P(JSITest, ObjectCreateWithPrototype) {
+  // This Runtime Decorator is used to test the default implementation of
+  // Object.create(prototype)
+  class RD : public RuntimeDecorator<Runtime, Runtime> {
+   public:
+    RD(Runtime& rt) : RuntimeDecorator(rt) {}
+
+    Object createObjectWithPrototype(const Value& prototype) override {
+      return Runtime::createObjectWithPrototype(prototype);
+    }
+  };
+
+  RD rd = RD(rt);
+  Object prototypeObj(rd);
+  prototypeObj.setProperty(rd, "someProperty", 123);
+  Value prototype(rd, prototypeObj);
+
+  Object child = Object::create(rd, prototype);
+  EXPECT_EQ(child.getProperty(rd, "someProperty").getNumber(), 123);
+
+  // Tests null value as prototype
+  child = Object::create(rd, Value::null());
+  EXPECT_TRUE(child.getPrototype(rd).isNull());
+}
+Windows] */
+
 INSTANTIATE_TEST_CASE_P(
     Runtimes,
     JSITest,

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/componentregistry/ComponentDescriptorRegistry.cpp

@@ -9,7 +9,6 @@
 
 #include "componentNameByReactViewName.h"
 
-#include <react/config/ReactNativeConfig.h>
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
 #include <react/renderer/components/legacyviewmanagerinterop/UnstableLegacyViewManagerAutomaticComponentDescriptor.h>
@@ -85,17 +84,7 @@ const ComponentDescriptor& ComponentDescriptorRegistry::at(
 
   if (it == _registryByName.end()) {
   // [Windows ##14204
-    auto reactNativeConfig_ =
-        contextContainer_->at<std::shared_ptr<const ReactNativeConfig>>(
-            "ReactNativeConfig");
-    if (reactNativeConfig_->getBool(
-            "react_fabric:enabled_automatic_interop_android")) {
-      auto componentDescriptor = std::make_shared<
-          const UnstableLegacyViewManagerAutomaticComponentDescriptor>(
-          parameters_, unifiedComponentName);
-      registerComponentDescriptor(componentDescriptor);
-      return *_registryByName.find(unifiedComponentName)->second;
-    } else if (_fallbackComponentDescriptor == nullptr) {
+    if (_fallbackComponentDescriptor == nullptr) {
       throw std::invalid_argument(
           ("Unable to find componentDescriptor for " + unifiedComponentName)
               .c_str());

package/{Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputState.h → ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/textinput/TextInputState.h}

@@ -1,35 +1,48 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
 
 #pragma once
 
-#include <folly/dynamic.h>
-#include <react/renderer/attributedstring/AttributedString.h>
+#include <react/renderer/attributedstring/AttributedStringBox.h>
 #include <react/renderer/attributedstring/ParagraphAttributes.h>
-#include <react/renderer/mapbuffer/MapBuffer.h>
-#include <react/renderer/mapbuffer/MapBufferBuilder.h>
 #include <react/renderer/textlayoutmanager/TextLayoutManager.h>
 
+#ifdef ANDROID
+#include <folly/dynamic.h>
+#include <react/renderer/mapbuffer/MapBuffer.h>
+#endif
+
 namespace facebook::react {
 
 /*
- * State for <WindowsTextInput> component.
+ * State for <TextInput> component.
  */
-class WindowsTextInputState final {
+class TextInputState final {
  public:
-  int64_t mostRecentEventCount{0};
+  TextInputState() = default;
 
-  /**
-   * Stores an opaque cache ID used on the Java side to refer to a specific
-   * AttributedString for measurement purposes only.
-   */
-  int64_t cachedAttributedStringId{0};
+  TextInputState(
+      AttributedStringBox attributedStringBox,
+      AttributedString reactTreeAttributedString,
+      ParagraphAttributes paragraphAttributes,
+      int64_t mostRecentEventCount);
+
+#ifdef ANDROID
+  TextInputState(
+      const TextInputState& previousState,
+      const folly::dynamic& data);
+  folly::dynamic getDynamic() const;
+  MapBuffer getMapBuffer() const;
+#endif
 
   /*
-   * All content of <TextInput> component represented as an `AttributedString`.
-   * Only set if changed from the React tree's perspective.
+   * All content of <TextInput> component.
    */
-  AttributedString attributedString{};
+  AttributedStringBox attributedStringBox;
 
   /*
    * All content of <TextInput> component represented as an `AttributedString`.
@@ -44,28 +57,17 @@ class WindowsTextInputState final {
    * Represents all visual attributes of a paragraph of text represented as
    * a ParagraphAttributes.
    */
-  ParagraphAttributes paragraphAttributes{};
+  ParagraphAttributes paragraphAttributes;
+
+  int64_t mostRecentEventCount{0};
+
 
   /**
-   * Communicates Android theme padding back to the ShadowNode / Component
-   * Descriptor for layout.
+   * Stores an opaque cache ID used on the Java side to refer to a specific
+   * AttributedString for measurement purposes only.
    */
-  double defaultThemePaddingStart{NAN};
-  double defaultThemePaddingEnd{NAN};
-  double defaultThemePaddingTop{NAN};
-  double defaultThemePaddingBottom{NAN};
-
-  WindowsTextInputState(
-      int64_t mostRecentEventCount,
-      AttributedString attributedString,
-      AttributedString reactTreeAttributedString,
-      ParagraphAttributes paragraphAttributes,
-      double defaultThemePaddingStart,
-      double defaultThemePaddingEnd,
-      double defaultThemePaddingTop,
-      double defaultThemePaddingBottom);
+  int64_t cachedAttributedStringId{0};
 
-  WindowsTextInputState() = default;
 };
 
 } // namespace facebook::react

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/AccessibilityPrimitives.h

@@ -70,6 +70,7 @@ struct AccessibilityState {
   std::optional<bool> selected{std::nullopt}; // [Windows] - Do not remove; required for Windows ISelectionItemProvider Implementation
   bool busy{false};
   std::optional<bool> expanded{std::nullopt};
+  std::optional<bool> readOnly{std::nullopt}; // [Windows] - Do not remove; required for Windows IRangeValueProvider and IValueProvider Implementation
   std::optional<bool> multiselectable{std::nullopt}; // [Windows] - Do not remove; required for Windows ISelectionProvider Implementation
   std::optional<bool> required{std::nullopt}; // [Windows] - Do not remove; required for Windows ISelectionProvider Implementation
   enum { Unchecked, Checked, Mixed, None } checked{None};

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/accessibilityPropsConversions.h

@@ -171,6 +171,10 @@ inline void fromRawValue(
     fromRawValue(context, expanded->second, result.expanded);
   }
   // [Windows] - DO NOT REMOVE - required for Windows ISelectionProvider Implementation
+  auto readOnly = map.find("readOnly");
+  if (readOnly != map.end()) {
+    fromRawValue(context, readOnly->second, result.readOnly);
+  }
   auto multiselectable = map.find("multiselectable");
   if (multiselectable != map.end()) {
     fromRawValue(context, multiselectable->second, result.multiselectable);

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/imagemanager/ImageRequestParams.h

@@ -0,0 +1,30 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/graphics/Float.h>
+
+namespace facebook::react {
+
+class ImageRequestParams {
+ public:
+  ImageRequestParams() = default;
+  explicit ImageRequestParams(Float blurRadius) : blurRadius(blurRadius) {}
+
+  Float blurRadius{};
+
+  bool operator==(const ImageRequestParams& rhs) const {
+    return this->blurRadius == rhs.blurRadius;
+  }
+
+  bool operator!=(const ImageRequestParams& rhs) const {
+    return !(*this == rhs);
+  }
+};
+
+} // namespace facebook::react

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/runtimescheduler/SchedulerPriorityUtils.h

@@ -31,10 +31,9 @@ static inline SchedulerPriority fromRawValue(double value) {
       return SchedulerPriority::LowPriority;
     case 5:
       return SchedulerPriority::IdlePriority;
-    default:
-      react_native_assert(false && "Unsupported SchedulerPriority value");
-      return SchedulerPriority::NormalPriority;
   }
+  react_native_assert(false && "Unsupported SchedulerPriority value");
+  return SchedulerPriority::NormalPriority;
 }
 
 static inline std::chrono::milliseconds timeoutForSchedulerPriority(
@@ -54,6 +53,8 @@ static inline std::chrono::milliseconds timeoutForSchedulerPriority(
       react_native_assert(false && "Unsupported SchedulerPriority value");
       return std::chrono::seconds(5);
   }
+  react_native_assert(false && "Unsupported SchedulerPriority value");
+  return std::chrono::seconds(5);
 }
 
 } // namespace facebook::react

package/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/uimanager/primitives.h

@@ -0,0 +1,179 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+ #pragma once
+
+ #include <folly/dynamic.h>
+ #include <jsi/JSIDynamic.h>
+ #include <jsi/jsi.h>
+ #include <react/debug/react_native_assert.h>
+ #include <react/renderer/core/ShadowNode.h>
+ 
+ namespace facebook::react {
+ 
+ using BackgroundExecutor =
+     std::function<void(std::function<void()>&& callback)>;
+ 
+ struct ShadowNodeListWrapper : public jsi::NativeState {
+   ShadowNodeListWrapper(ShadowNode::UnsharedListOfShared shadowNodeList)
+       : shadowNodeList(std::move(shadowNodeList)) {}
+ 
+   // The below method needs to be implemented out-of-line in order for the class
+   // to have at least one "key function" (see
+   // https://itanium-cxx-abi.github.io/cxx-abi/abi.html#vague-vtable)
+   ~ShadowNodeListWrapper() override;
+ 
+   ShadowNode::UnsharedListOfShared shadowNodeList;
+ };
+ 
+ inline static ShadowNode::Shared shadowNodeFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   if (value.isNull()) {
+     return nullptr;
+   }
+ 
+   return value.getObject(runtime)
+       .getNativeState<ShadowNodeWrapper>(runtime)
+       ->shadowNode;
+ }
+ 
+ inline static jsi::Value valueFromShadowNode(
+     jsi::Runtime& runtime,
+     ShadowNode::Shared shadowNode,
+     bool assignRuntimeShadowNodeReference = false) {
+   // Wrap the shadow node so that we can update JS references from native
+   auto wrappedShadowNode =
+       std::make_shared<ShadowNodeWrapper>(std::move(shadowNode));
+ 
+   if (assignRuntimeShadowNodeReference) {
+     wrappedShadowNode->shadowNode->setRuntimeShadowNodeReference(
+         wrappedShadowNode);
+   }
+ 
+   jsi::Object obj(runtime);
+   obj.setNativeState(runtime, std::move(wrappedShadowNode));
+   return obj;
+ }
+ 
+ // TODO: once we no longer need to mutate the return value (appendChildToSet)
+ // make this a SharedListOfShared
+ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   // TODO: cleanup when passChildrenWhenCloningPersistedNodes is rolled out
+   jsi::Object object = value.asObject(runtime);
+   if (object.isArray(runtime)) {
+     auto jsArray = std::move(object).asArray(runtime);
+     size_t jsArrayLen = jsArray.length(runtime);
+     if (jsArrayLen > 0) {
+       auto shadowNodeArray = std::make_shared<ShadowNode::ListOfShared>();
+       shadowNodeArray->reserve(jsArrayLen);
+ 
+       for (size_t i = 0; i < jsArrayLen; i++) {
+         shadowNodeArray->push_back(
+             shadowNodeFromValue(runtime, jsArray.getValueAtIndex(runtime, i)));
+       }
+       return shadowNodeArray;
+     } else {
+       // TODO: return ShadowNode::emptySharedShadowNodeSharedList()
+       return std::make_shared<ShadowNode::ListOfShared>(
+           ShadowNode::ListOfShared({}));
+       ;
+     }
+   } else {
+     return object.getNativeState<ShadowNodeListWrapper>(runtime)
+         ->shadowNodeList;
+   }
+ }
+ 
+ inline static jsi::Value valueFromShadowNodeList(
+     jsi::Runtime& runtime,
+     ShadowNode::UnsharedListOfShared shadowNodeList) {
+   auto wrapper =
+       std::make_shared<ShadowNodeListWrapper>(std::move(shadowNodeList));
+   // Use the wrapper for NativeState too, otherwise we can't implement
+   // the marker interface. Could be simplified to a simple struct wrapper.
+   jsi::Object obj(runtime);
+   obj.setNativeState(runtime, std::move(wrapper));
+   return obj;
+ }
+ 
+ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromWeakList(
+     const ShadowNode::UnsharedListOfWeak& weakShadowNodeList) {
+   auto result = std::make_shared<ShadowNode::ListOfShared>();
+   for (const auto& weakShadowNode : *weakShadowNodeList) {
+     auto sharedShadowNode = weakShadowNode.lock();
+     if (!sharedShadowNode) {
+       return nullptr;
+     }
+     result->push_back(sharedShadowNode);
+   }
+   return result;
+ }
+ 
+ inline static ShadowNode::UnsharedListOfWeak weakShadowNodeListFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   auto shadowNodeList = shadowNodeListFromValue(runtime, value);
+   auto weakShadowNodeList = std::make_shared<ShadowNode::ListOfWeak>();
+   for (const auto& shadowNode : *shadowNodeList) {
+     weakShadowNodeList->push_back(shadowNode);
+   }
+   return weakShadowNodeList;
+ }
+ 
+ inline static Tag tagFromValue(const jsi::Value& value) {
+   return (Tag)value.getNumber();
+ }
+ 
+ inline static InstanceHandle::Shared instanceHandleFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& instanceHandleValue,
+     const jsi::Value& tagValue) {
+   react_native_assert(!instanceHandleValue.isNull());
+   if (instanceHandleValue.isNull()) {
+     return nullptr;
+   }
+   return std::make_shared<InstanceHandle>(
+       runtime, instanceHandleValue, tagFromValue(tagValue));
+ }
+ 
+ inline static SurfaceId surfaceIdFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   return (SurfaceId)value.getNumber();
+ }
+ 
+ inline static int displayModeToInt(const DisplayMode value) {
+   // the result of this method should be in sync with
+   // Libraries/ReactNative/DisplayMode.js
+   switch (value) {
+     case DisplayMode::Visible:
+       return 1;
+     case DisplayMode::Suspended:
+       return 2;
+     case DisplayMode::Hidden:
+       return 3;
+     default:
+       return -1;
+   }
+ }
+ 
+ inline static std::string stringFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   return value.getString(runtime).utf8(runtime);
+ }
+ 
+ inline static folly::dynamic commandArgsFromValue(
+     jsi::Runtime& runtime,
+     const jsi::Value& value) {
+   return jsi::dynamicFromValue(runtime, value);
+ }
+ } // namespace facebook::react
+