react-native-windows 0.73.11 → 0.74.0-preview.2

package/Shared/HermesSamplingProfiler.h

@@ -4,8 +4,8 @@
 #pragma once
 
 #include <ReactHost/React.h>
+#include <winrt/Windows.Foundation.h>
 #include <atomic>
-#include <future>
 #include <string>
 
 namespace Microsoft::ReactNative {
@@ -13,13 +13,14 @@ namespace Microsoft::ReactNative {
 class HermesSamplingProfiler final {
  public:
   static winrt::fire_and_forget Start(Mso::CntPtr<Mso::React::IReactContext> const &reactContext) noexcept;
-  static std::future<std::string> Stop(Mso::CntPtr<Mso::React::IReactContext> const &reactContext) noexcept;
-  static std::string GetLastTraceFilePath() noexcept;
+  static winrt::Windows::Foundation::IAsyncOperation<winrt::hstring> Stop(
+      Mso::CntPtr<Mso::React::IReactContext> const &reactContext) noexcept;
+  static winrt::hstring GetLastTraceFilePath() noexcept;
   static bool IsStarted() noexcept;
 
  private:
   static std::atomic_bool s_isStarted;
-  static std::string s_lastTraceFilePath;
+  static winrt::hstring s_lastTraceFilePath;
 };
 
 } // namespace Microsoft::ReactNative

package/Shared/IDevSupportManager.h

@@ -3,8 +3,7 @@
 
 #pragma once
 
-#include "DevServerHelper.h"
-
+#include <cxxreact/JSExecutor.h>
 #include <functional>
 #include <memory>
 #include <string>
@@ -12,6 +11,9 @@
 namespace facebook {
 namespace react {
 
+using JSECreator =
+    std::function<std::unique_ptr<JSExecutor>(std::shared_ptr<ExecutorDelegate>, std::shared_ptr<MessageQueueThread>)>;
+
 struct DevSettings;
 
 struct IDevSupportManager {

package/Shared/InstanceManager.cpp

@@ -11,18 +11,17 @@
 
 #include <cxxreact/Instance.h>
 
-namespace facebook {
-namespace react {
-
-namespace {
+namespace Microsoft::ReactNative {
 
-const std::shared_ptr<IDevSupportManager> &GetSharedDevManager() noexcept {
-  static std::shared_ptr<IDevSupportManager> s_devManager(CreateDevSupportManager());
+const std::shared_ptr<facebook::react::IDevSupportManager> &GetSharedDevManager() noexcept {
+  static std::shared_ptr<facebook::react::IDevSupportManager> s_devManager(facebook::react::CreateDevSupportManager());
 
   return s_devManager;
 }
+} // namespace Microsoft::ReactNative
 
-} // namespace
+namespace facebook {
+namespace react {
 
 std::shared_ptr<InstanceWrapper> CreateReactInstance(
     std::shared_ptr<Instance> &&instance,
@@ -41,12 +40,13 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
       std::move(jsBundleBasePath),
       std::move(cxxModules),
       std::move(turboModuleRegistry),
-      nullptr,
+      nullptr, // longLivedObjectCollection
+      nullptr, // PropertyBag
       std::move(callback),
       std::move(jsQueue),
       std::move(nativeQueue),
       std::move(devSettings),
-      GetSharedDevManager());
+      ::Microsoft::ReactNative::GetSharedDevManager());
 
   return inner;
 }
@@ -59,6 +59,7 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
         &&cxxModules,
     std::shared_ptr<TurboModuleRegistry> turboModuleRegistry,
     std::shared_ptr<facebook::react::LongLivedObjectCollection> longLivedObjectCollection,
+    const winrt::Microsoft::ReactNative::IReactPropertyBag &propertyBag,
     std::unique_ptr<InstanceCallback> &&callback,
     std::shared_ptr<MessageQueueThread> jsQueue,
     std::shared_ptr<MessageQueueThread> nativeQueue,
@@ -70,11 +71,12 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
       std::move(cxxModules),
       std::move(turboModuleRegistry),
       std::move(longLivedObjectCollection),
+      propertyBag,
       std::move(callback),
       std::move(jsQueue),
       std::move(nativeQueue),
       std::move(devSettings),
-      GetSharedDevManager());
+      ::Microsoft::ReactNative::GetSharedDevManager());
 
   return inner;
 }
@@ -102,7 +104,7 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
       std::move(jsQueue),
       std::move(nativeQueue),
       std::move(devSettings),
-      GetSharedDevManager());
+      ::Microsoft::ReactNative::GetSharedDevManager());
 
   return inner;
 }

package/Shared/InstanceManager.h

@@ -12,15 +12,14 @@
 #include <string>
 #include <vector>
 #include "DevSettings.h"
+#include "IDevSupportManager.h"
 #include "IReactRootView.h"
 
 namespace folly {
 struct dynamic;
 }
 
-namespace facebook {
-
-namespace react {
+namespace facebook::react {
 
 class Instance;
 struct InstanceCallback;
@@ -28,6 +27,7 @@ class MessageQueueThread;
 class ModuleRegistry;
 class IUIManager;
 class TurboModuleRegistry;
+class RuntimeScheduler;
 
 struct InstanceWrapper {
   virtual const std::shared_ptr<Instance> &GetInstance() const noexcept = 0;
@@ -52,19 +52,6 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
     std::shared_ptr<MessageQueueThread> nativeQueue,
     std::shared_ptr<DevSettings> devSettings) noexcept;
 
-std::shared_ptr<InstanceWrapper> CreateReactInstance(
-    std::shared_ptr<Instance> &&instance,
-    std::string &&jsBundleRelativePath,
-    std::vector<
-        std::tuple<std::string, facebook::xplat::module::CxxModule::Provider, std::shared_ptr<MessageQueueThread>>>
-        &&cxxModules,
-    std::shared_ptr<TurboModuleRegistry> turboModuleRegistry,
-    std::shared_ptr<facebook::react::LongLivedObjectCollection> longLivedObjectCollection,
-    std::unique_ptr<InstanceCallback> &&callback,
-    std::shared_ptr<MessageQueueThread> jsQueue,
-    std::shared_ptr<MessageQueueThread> nativeQueue,
-    std::shared_ptr<DevSettings> devSettings) noexcept;
-
 std::shared_ptr<InstanceWrapper> CreateReactInstance(
     std::shared_ptr<Instance> &&instance,
     std::string &&jsBundleBasePath,
@@ -78,5 +65,8 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
     std::shared_ptr<MessageQueueThread> nativeQueue,
     std::shared_ptr<DevSettings> devSettings) noexcept;
 
-} // namespace react
-} // namespace facebook
+} // namespace facebook::react
+
+namespace Microsoft::ReactNative {
+const std::shared_ptr<facebook::react::IDevSupportManager> &GetSharedDevManager() noexcept;
+}

package/Shared/JSI/ChakraRuntime.cpp

@@ -9,6 +9,7 @@
 
 #include <cxxreact/MessageQueueThread.h>
 
+#include <strsafe.h>
 #include <cstring>
 #include <limits>
 #include <mutex>
@@ -84,6 +85,7 @@ void ChakraRuntime::Init() noexcept {
   m_propertyId.enumerable = JsRefHolder{GetPropertyIdFromName(L"enumerable")};
   m_propertyId.get = JsRefHolder{GetPropertyIdFromName(L"get")};
   m_propertyId.getOwnPropertyDescriptor = JsRefHolder{GetPropertyIdFromName(L"getOwnPropertyDescriptor")};
+  m_propertyId.has = JsRefHolder{GetPropertyIdFromName(L"has")};
   m_propertyId.hostFunctionSymbol = JsRefHolder{GetPropertyIdFromSymbol(L"hostFunctionSymbol")};
   m_propertyId.hostObjectSymbol = JsRefHolder{GetPropertyIdFromSymbol(L"hostObjectSymbol")};
   m_propertyId.length = JsRefHolder{GetPropertyIdFromName(L"length")};
@@ -97,9 +99,22 @@ void ChakraRuntime::Init() noexcept {
   m_propertyId.writable = JsRefHolder{GetPropertyIdFromName(L"writable")};
 
   m_undefinedValue = JsRefHolder{GetUndefinedValue()};
+
+  JsValueRef global = GetGlobalObject();
+  JsValueRef weakMapPropertyId = GetPropertyIdFromName(L"WeakMap");
+  JsValueRef weakMapConstructor = GetProperty(global, weakMapPropertyId);
+  JsValueRef weakMapPrototype = GetProperty(weakMapConstructor, m_propertyId.prototype);
+  m_weakMapGet = JsRefHolder{GetProperty(weakMapPrototype, m_propertyId.get)};
+  m_weakMapHas = JsRefHolder{GetProperty(weakMapPrototype, m_propertyId.has)};
+  m_weakMapSet = JsRefHolder{GetProperty(weakMapPrototype, m_propertyId.set)};
+  m_nativeStateMap = JsRefHolder{ConstructObject(weakMapConstructor, Span<JsValueRef>{m_undefinedValue})};
 }
 
 /*virtual*/ ChakraRuntime::~ChakraRuntime() noexcept {
+  m_nativeStateMap = {};
+  m_weakMapSet = {};
+  m_weakMapHas = {};
+  m_weakMapGet = {};
   m_undefinedValue = {};
   m_propertyId = {};
   m_proxyConstructor = {};
@@ -189,8 +204,8 @@ facebook::jsi::Value ChakraRuntime::evaluateJavaScript(
     auto genPreparedScript = generatePreparedScript(sourceURL, *sharedScriptBuffer);
     if (!genPreparedScript)
       std::terminate(); // Cache generation can't fail unless something really
-                        // wrong. but we should get rid of this abort before
-                        // shipping.
+    // wrong. but we should get rid of this abort before
+    // shipping.
 
     sharedPreparedScript = std::shared_ptr<const facebook::jsi::Buffer>(std::move(genPreparedScript));
     runtimeArgs().preparedScriptStore->persistPreparedScript(
@@ -345,16 +360,25 @@ facebook::jsi::String ChakraRuntime::bigintToString(const facebook::jsi::BigInt
   throw facebook::jsi::JSINativeException("Not implemented");
 }
 
-bool ChakraRuntime::hasNativeState(const facebook::jsi::Object &) {
-  throw facebook::jsi::JSINativeException("Not implemented");
+bool ChakraRuntime::hasNativeState(const facebook::jsi::Object &obj) {
+  return BooleanToBool(CallFunction(m_weakMapHas, {m_nativeStateMap, GetJsRef(obj)}));
 }
 
-std::shared_ptr<facebook::jsi::NativeState> ChakraRuntime::getNativeState(const facebook::jsi::Object &) {
-  throw facebook::jsi::JSINativeException("Not implemented");
+std::shared_ptr<facebook::jsi::NativeState> ChakraRuntime::getNativeState(const facebook::jsi::Object &obj) {
+  JsValueRef stateWrapper = CallFunction(m_weakMapGet, {m_nativeStateMap, GetJsRef(obj)});
+  if (GetValueType(stateWrapper) == JsValueType::JsObject) {
+    return *static_cast<std::shared_ptr<facebook::jsi::NativeState> *>(GetExternalData(stateWrapper));
+  } else {
+    return nullptr;
+  }
 }
 
-void ChakraRuntime::setNativeState(const facebook::jsi::Object &, std::shared_ptr<facebook::jsi::NativeState> state) {
-  throw facebook::jsi::JSINativeException("Not implemented");
+void ChakraRuntime::setNativeState(
+    const facebook::jsi::Object &obj,
+    std::shared_ptr<facebook::jsi::NativeState> state) {
+  JsValueRef stateWrapper =
+      CreateExternalObject(std::make_unique<std::shared_ptr<facebook::jsi::NativeState>>(std::move(state)));
+  CallFunction(m_weakMapSet, {m_nativeStateMap, GetJsRef(obj), stateWrapper});
 }
 
 facebook::jsi::ArrayBuffer ChakraRuntime::createArrayBuffer(std::shared_ptr<facebook::jsi::MutableBuffer> buffer) {
@@ -655,6 +679,10 @@ bool ChakraRuntime::instanceOf(const facebook::jsi::Object &obj, const facebook:
   return InstanceOf(GetJsRef(obj), GetJsRef(func));
 }
 
+void ChakraRuntime::setExternalMemoryPressure(const facebook::jsi::Object & /*obj*/, size_t /*amount*/) {
+  // TODO: implement
+}
+
 #pragma endregion Functions_inherited_from_Runtime
 
 // Sets variable in the constructor and then restores its value in the destructor.
@@ -698,8 +726,37 @@ void ChakraRuntime::RewriteErrorMessage(JsValueRef jsError) {
     JsGetAndClearException(&ignoreJSError);
   } else if (GetValueType(message) == JsValueType::JsString) {
     // JSI unit tests expect V8 or JSC like message for stack overflow.
-    if (StringToPointer(message) == L"Out of stack space") {
+    std::wstring_view errorMessage = StringToPointer(message);
+    if (errorMessage == L"Out of stack space") {
       SetProperty(jsError, m_propertyId.message, PointerToString(L"RangeError : Maximum call stack size exceeded"));
+    } else if (errorMessage == L"Syntax error") {
+      JsValueRef result;
+      JsPropertyIdRef property;
+
+      JsGetPropertyIdFromName(L"line", &property);
+      if (JsGetProperty(jsError, property, &result) != JsNoError) {
+        // If the 'line' property getter throws, clear the exception and ignore it.
+        JsValueRef ignoreJSError{JS_INVALID_REFERENCE};
+        JsGetAndClearException(&ignoreJSError);
+        return;
+      }
+
+      // Line numbers start from zero
+      const int32_t line = NumberToInt(result) + 1;
+      wchar_t buf[1024] = {};
+
+      JsGetPropertyIdFromName(L"column", &property);
+      if (JsGetProperty(jsError, property, &result) != JsNoError) {
+        // If the 'column' property getter throws, clear the exception and ignore it.
+        JsValueRef ignoreJSError{JS_INVALID_REFERENCE};
+        JsGetAndClearException(&ignoreJSError);
+        StringCchPrintf(buf, std::size(buf), L"Syntax error at line %i", line);
+      } else {
+        const int32_t column = NumberToInt(result);
+        StringCchPrintf(buf, std::size(buf), L"Syntax error at line %i column %i", line, column);
+      }
+
+      SetProperty(jsError, m_propertyId.message, PointerToString(buf));
     }
   }
 }

package/Shared/JSI/ChakraRuntime.h

@@ -153,6 +153,8 @@ class ChakraRuntime : public facebook::jsi::Runtime, public ChakraApi, ChakraApi
 
   bool instanceOf(const facebook::jsi::Object &obj, const facebook::jsi::Function &func) override;
 
+  void setExternalMemoryPressure(const facebook::jsi::Object &obj, size_t amount) override;
+
 #pragma endregion Functions_inherited_from_Runtime
 
  protected:
@@ -463,6 +465,7 @@ class ChakraRuntime : public facebook::jsi::Runtime, public ChakraApi, ChakraApi
     JsRefHolder enumerable;
     JsRefHolder get;
     JsRefHolder getOwnPropertyDescriptor;
+    JsRefHolder has;
     JsRefHolder hostFunctionSymbol;
     JsRefHolder hostObjectSymbol;
     JsRefHolder length;
@@ -480,6 +483,11 @@ class ChakraRuntime : public facebook::jsi::Runtime, public ChakraApi, ChakraApi
   JsRefHolder m_proxyConstructor;
   JsRefHolder m_hostObjectProxyHandler;
 
+  JsRefHolder m_weakMapGet;
+  JsRefHolder m_weakMapHas;
+  JsRefHolder m_weakMapSet;
+  JsRefHolder m_nativeStateMap;
+
   static std::once_flag s_runtimeVersionInitFlag;
   static uint64_t s_runtimeVersion;
 

package/Shared/JSI/JSExecutorFactoryDelegate.h

@@ -0,0 +1,12 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+#include <functional>
+#include <memory>
+
+namespace facebook::react {
+class CallInvoker;
+class JSExecutorFactory;
+using JSExecutorFactoryDelegate =
+    std::function<std::shared_ptr<JSExecutorFactory>(std::shared_ptr<CallInvoker> const &callInvoker)>;
+} // namespace facebook::react

package/Shared/JSI/JSExecutorFactorySettings.cpp

@@ -0,0 +1,30 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+#include "JSExecutorFactorySettings.h"
+
+namespace Microsoft::JSI::JSExecutorFactorySettings {
+
+winrt::Microsoft::ReactNative::ReactPropertyId<
+    winrt::Microsoft::ReactNative::ReactNonAbiValue<facebook::react::JSExecutorFactoryDelegate>>
+JSExecutorFactoryDelegateProperty() noexcept {
+  winrt::Microsoft::ReactNative::ReactPropertyId<
+      winrt::Microsoft::ReactNative::ReactNonAbiValue<facebook::react::JSExecutorFactoryDelegate>>
+      propId{L"ReactNative.JSI", L"JSExecutorFactory"};
+  return propId;
+}
+void SetJSExecutorFactoryDelegate(
+    winrt::Microsoft::ReactNative::ReactPropertyBag properties,
+    facebook::react::JSExecutorFactoryDelegate const &value) noexcept {
+  properties.Set(JSExecutorFactoryDelegateProperty(), value);
+}
+
+const facebook::react::JSExecutorFactoryDelegate GetJSExecutorFactoryDelegate(
+    winrt::Microsoft::ReactNative::ReactPropertyBag properties) noexcept {
+  const auto jsExecutorFactoryDelegate = properties.Get(JSExecutorFactoryDelegateProperty());
+  if (!jsExecutorFactoryDelegate)
+    return nullptr;
+  return jsExecutorFactoryDelegate.Value();
+}
+
+} // namespace Microsoft::JSI::JSExecutorFactorySettings

package/Shared/JSI/JSExecutorFactorySettings.h

@@ -0,0 +1,21 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+#pragma once
+
+#include "JSExecutorFactoryDelegate.h"
+#include "ReactPropertyBag.h"
+
+namespace facebook::react {
+class JSExecutorFactory;
+}
+
+namespace Microsoft::JSI::JSExecutorFactorySettings {
+
+void SetJSExecutorFactoryDelegate(
+    winrt::Microsoft::ReactNative::ReactPropertyBag properties,
+    facebook::react::JSExecutorFactoryDelegate const &value) noexcept;
+const facebook::react::JSExecutorFactoryDelegate GetJSExecutorFactoryDelegate(
+    winrt::Microsoft::ReactNative::ReactPropertyBag properties) noexcept;
+
+} // namespace Microsoft::JSI::JSExecutorFactorySettings

package/Shared/Modules/BlobModule.h

@@ -3,7 +3,7 @@
 
 #pragma once
 
-#include <NativeBlobModuleSpec.g.h>
+#include <codegen/NativeBlobModuleSpec.g.h>
 
 #include <Networking/IBlobResource.h>
 

package/Shared/Modules/FileReaderModule.h

@@ -3,7 +3,7 @@
 
 #pragma once
 
-#include <NativeFileReaderModuleSpec.g.h>
+#include <codegen/NativeFileReaderModuleSpec.g.h>
 
 #include <IFileReaderResource.h>
 #include <NativeModules.h>

package/Shared/Modules/HttpModule.h

@@ -3,7 +3,7 @@
 
 #pragma once
 
-#include <NativeNetworkingIOSSpec.g.h>
+#include <codegen/NativeNetworkingIOSSpec.g.h>
 #include <NativeModules.h>
 #include <Networking/IHttpResource.h>
 

package/Shared/Modules/WebSocketTurboModule.h

@@ -3,7 +3,7 @@
 
 #pragma once
 
-#include <NativeWebSocketModuleSpec.g.h>
+#include <codegen/NativeWebSocketModuleSpec.g.h>
 #include <Modules/IWebSocketModuleProxy.h>
 #include <NativeModules.h>
 #include <Networking/IWebSocketResource.h>