react-native-windows 0.72.14 → 0.73.0-preview.1

package/ReactCommon/packages.lock.json

@@ -0,0 +1,30 @@
+{
+  "version": 1,
+  "dependencies": {
+    "native,Version=v0.0": {
+      "boost": {
+        "type": "Direct",
+        "requested": "[1.76.0, )",
+        "resolved": "1.76.0",
+        "contentHash": "p+w3YvNdXL8Cu9Fzrmexssu0tZbWxuf6ywsQqHjDlKFE5ojXHof1HIyMC3zDLfLnh80dIeFcEUAuR2Asg/XHRA=="
+      },
+      "fmt": {
+        "type": "Project"
+      },
+      "folly": {
+        "type": "Project",
+        "dependencies": {
+          "boost": "[1.76.0, )",
+          "fmt": "[1.0.0, )"
+        }
+      }
+    },
+    "native,Version=v0.0/win10-arm": {},
+    "native,Version=v0.0/win10-arm-aot": {},
+    "native,Version=v0.0/win10-arm64-aot": {},
+    "native,Version=v0.0/win10-x64": {},
+    "native,Version=v0.0/win10-x64-aot": {},
+    "native,Version=v0.0/win10-x86": {},
+    "native,Version=v0.0/win10-x86-aot": {}
+  }
+}

package/Scripts/NuGetRestoreForceEvaluateAllSolutions.ps1

@@ -0,0 +1,22 @@
+param(
+)
+
+[string] $RepoRoot = Resolve-Path "$PSScriptRoot\..\.."
+
+$StartingLocation = Get-Location
+Set-Location -Path $RepoRoot
+
+try
+{
+    $packagesSolutions = Get-ChildItem -File -Recurse -Path packages *.sln | Where-Object { !$_.FullName.Contains('node_modules') -and !$_.FullName.Contains('e2etest') }
+    $vnextSolutions = Get-ChildItem -File -Path vnext *.sln
+
+    $($packagesSolutions; $vnextSolutions) | Foreach {
+        Write-Host Restoring $_.FullName
+        & msbuild /t:Restore /p:RestoreForceEvaluate=true $_.FullName
+    }
+}
+finally
+{
+    Set-Location -Path "$StartingLocation"
+}

package/Scripts/OfficeReact.Win32.nuspec

@@ -46,6 +46,7 @@
     <file src="$nugetroot$\inc\stubs\**\*.*" target="inc" />
 
     <file src="$nugetroot$\inc\Shared\AbiSafe.h" target="inc"/>
+    <file src="$nugetroot$\inc\Shared\Composition\AutoDraw.h" target="inc"/>
     <file src="$nugetroot$\inc\Shared\Composition\CompositionSwitcher.interop.h" target="inc"/>
     <file src="$nugetroot$\inc\Shared\DevSettings.h" target="inc"/>
     <file src="$nugetroot$\inc\ReactWin32\INativeUIManagerLegacy.h" target="inc"/>

package/Scripts/rnw-dependencies.ps1

@@ -81,6 +81,8 @@ $vsWorkloads = @('Microsoft.VisualStudio.Workload.ManagedDesktop',
 $vsAll = ($vsComponents + $vsWorkloads);
 
 # The minimum VS version to check for
+# Note: For install to work, whatever min version you specify here must be met by the current package available on choco.
+# I.E. Do NOT specify a Preview version here because choco doesn't have VS Preview packages.
 $vsver = "17.3";
 
 # The exact .NET SDK version to check for
@@ -177,30 +179,52 @@ function CheckVS {
     return $result;
 }
 
+function GetVSChannelAndProduct {
+    param(
+        [string]$VsWhere
+    )
+    
+    if ($VsWhere -ne $null) {
+        $channelId = & $VsWhere -version $vsver -property channelId;
+        $productId = & $VsWhere -version $vsver -property productId;
+        
+        # Channel/product not found, check one more time for pre-release
+        if (($channelId -eq $null) -or ($productId -eq $null)) {
+            $channelId = & $VsWhere -version $vsver -property channelId -prerelease;
+            $productId = & $VsWhere -version $vsver -property productId -prerelease;
+        }
+        
+        return $channelId, $productId;
+    }
+    
+    return $null, $null;
+}
+
 function InstallVS {
     $vsWhere = Get-VSWhere;
-
-    if ($vsWhere -ne $null) {
-        $channelId = & $vsWhere -version $vsver -property channelId;
-        $productId = & $vsWhere -version $vsver -property productId;
-    }
+    
+    $channelId, $productId = GetVSChannelAndProduct -VsWhere $vsWhere
 
     if (($vsWhere -eq $null) -or ($channelId -eq $null) -or ($productId -eq $null)) {
-        # No VSWhere / VS_Installer
+        # No VSWhere / VS_Installer, try to install
 
         EnsureChocoForInstall;
         
         if ($Enterprise) {
             # The CI machines need the enterprise version of VS as that is what is hardcoded in all the scripts
-            & choco install -y visualstudio2022enterprise;
+            ChocoInstall visualstudio2022enterprise;
         } else {
-            & choco install -y visualstudio2022community;
+            ChocoInstall visualstudio2022community;
         }
 
         $vsWhere = Get-VSWhere;
 
-        $channelId = & $vsWhere -version $vsver -property channelId;
-        $productId = & $vsWhere -version $vsver -property productId;
+        $channelId, $productId = GetVSChannelAndProduct -VsWhere $vsWhere
+    }
+    
+    # Final check before attempting install
+    if (($vsWhere -eq $null) -or ($channelId -eq $null) -or ($productId -eq $null)) {
+        throw "Unable to find or install a compatible version of Visual Studio >= ($vsver).";
     }
 
     $vsInstaller = Join-Path -Path (Split-Path -Parent $vsWhere) -ChildPath "vs_installer.exe";
@@ -215,7 +239,7 @@ function CheckNode {
         $nodeVersion = (Get-Command node -ErrorAction Stop).Version;
         Write-Verbose "Node version found: $nodeVersion";
         $v = $nodeVersion.Major;
-        return ($v -ge 16) -and (($v % 2) -eq 0);
+        return ($v -ge 18) -and (($v % 2) -eq 0);
     } catch { Write-Debug $_ }
 
     Write-Verbose "Node not found.";
@@ -399,7 +423,7 @@ $requirements = @(
         Name = 'Git';
         Tags = @('rnwDev');
         Valid = { try { (Get-Command git.exe -ErrorAction Stop) -ne $null } catch { $false }; }
-        Install = { choco install -y git };
+        Install = { ChocoInstall git };
         InstallsWithChoco = $true;
     },
     @{
@@ -412,10 +436,10 @@ $requirements = @(
     },
     @{
         Id=[CheckId]::Node;
-        Name = 'Node.js (LTS, >= 16.0)';
+        Name = 'Node.js (LTS, >= 18.0)';
         Tags = @('appDev');
         Valid = { CheckNode; }
-        Install = { choco install -y nodejs-lts };
+        Install = { ChocoInstall nodejs-lts };
         InstallsWithChoco = $true;
         HasVerboseOutput = $true;
     },
@@ -424,7 +448,7 @@ $requirements = @(
         Name = 'Yarn';
         Tags = @('appDev');
         Valid = { CheckYarn }
-        Install = { choco install -y yarn };
+        Install = { ChocoInstall yarn };
         InstallsWithChoco = $true;
         HasVerboseOutput = $true;
     },
@@ -449,7 +473,7 @@ $requirements = @(
         Tags = @('rnwDev');
         Valid = { ( cmd "/c assoc .binlog 2>nul" ) -ne $null; }
         Install = {
-            choco install -y msbuild-structured-log-viewer;
+            ChocoInstall msbuild-structured-log-viewer;
             $slv = gci ${env:LocalAppData}\MSBuildStructuredLogViewer\StructuredLogViewer.exe -Recurse | select FullName | Sort-Object -Property FullName -Descending | Select-Object -First 1
             cmd /c "assoc .binlog=MSBuildLog >nul";
             cmd /c "ftype MSBuildLog=$($slv.FullName) %1 >nul";
@@ -463,7 +487,7 @@ $requirements = @(
         Name = 'Windows ADK';
         Tags = @('buildLab');
         Valid = { (Test-Path "${env:ProgramFiles(x86)}\Windows Kits\10\Windows Performance Toolkit\wpr.exe"); };
-        Install = { choco install -y windows-adk };
+        Install = { ChocoInstall windows-adk };
         InstallsWithChoco = $true;
         Optional = $true;
     },
@@ -491,32 +515,61 @@ $requirements = @(
         Name = ".NET SDK (LTS, = $dotnetver)";
         Tags = @('appDev');
         Valid = { CheckDotNetCore; };
-        Install = { & choco install -y dotnet-$dotnetver-sdk };
+        Install = { ChocoInstall dotnet-$dotnetver-sdk };
         InstallsWithChoco = $true;
         HasVerboseOutput = $true;
     }
 );
 
+$ChocoCmd = ""; # This should get set when EnsureChocoForInstall is called
+
 function EnsureChocoForInstall {
-    Write-Verbose "Checking for Choco...";
+    Write-Verbose "Checking for Chocolatey...";
     try {
-        $chocoCmd = (Get-Command choco -ErrorAction Stop);
-        if ($chocoCmd -ne $null) {
-            Write-Verbose "Choco found.";
+        # Check if choco.exe is in PATH
+        if (Get-Command "choco.exe" -CommandType Application -ErrorAction Ignore) {
+            Set-Variable -Name "ChocoCmd" -Value "choco.exe" -Scope Script
+            Write-Verbose "Chocolatey found in PATH.";
+            return;
+        }
+
+        # Check for choco.exe in usual install location (taken from https://chocolatey.org/install.ps1)
+        $checkPath = if ($env:ChocolateyInstall) { $env:ChocolateyInstall } else { "$env:PROGRAMDATA\chocolatey" }
+
+        $FullPath = Join-Path $checkPath "bin\choco.exe";
+
+        if (Test-Path $FullPath) {
+            Set-Variable -Name "ChocoCmd" -Value $FullPath -Scope Script
+            Write-Verbose "Chocolatey found at $ChocoCmd.";
             return;
         }
+
     } catch { Write-Debug $_ }
 
-    Write-Verbose "Choco not found.";
+    Write-Verbose "Chocolatey not found.";
 
-    if (!$NoPrompt -and (Read-Host "Choco is necessary to install this component. Do you want to install Choco? [y/N]").ToUpperInvariant() -eq 'Y') {
-        Write-Host "Installing Choco...";
+    if (!$NoPrompt -and (Read-Host "This script uses Chocolatey to install this component. Do you want to install Chocolatey? [y/N]").ToUpperInvariant() -eq 'Y') {
+        Write-Host "Installing Chocolatey...";
         [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072;
         iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'));
+        EnsureChocoForInstall;
         return;
     }
 
-    throw "Choco needed to install.";
+    throw "Chocolatey needed to install.";
+}
+
+function ChocoInstall {
+    param(
+        [string]$ChocoPackage
+    )
+
+    if ($ChocoCmd -eq "") {
+        throw "`$ChocoCmd is not set, did you call EnsureChocoForInstall?";
+    }
+
+    Write-Verbose "Executing `"$ChocoCmd`" install -y `"$ChocoPackage`"";
+    & "$ChocoCmd" install -y "$ChocoPackage"
 }
 
 function IsElevated {

package/Shared/BaseScriptStoreImpl.cpp

@@ -4,6 +4,7 @@
 #include "pch.h"
 
 #include "BaseScriptStoreImpl.h"
+#include "Hasher.h"
 #include "MemoryMappedBuffer.h"
 
 #include <CppRuntimeOptions.h>
@@ -92,6 +93,7 @@ struct PreparedScriptPrefix {
   jsi::ScriptVersion_t scriptVersion;
   jsi::JSRuntimeVersion_t runtimeVersion;
   uint64_t sizeInBytes;
+  std::uint8_t hash[32];
 };
 
 struct PreparedScriptSuffix {
@@ -197,40 +199,40 @@ std::string BasePreparedScriptStoreImpl::getPreparedScriptFileName(
   // Essentially, we are trying to construct,
   // prep_<source_url>_<runtime_id>_<preparation_tag>.cache
 
-  std::string prparedScriptFileName("prep_");
+  std::string preparedScriptFileName("prep_");
 
   const std::string &scriptUrl = scriptSignature.url;
 
   // As a crude heuristic we choose the last 64 characters of the source url.
   constexpr int MAXLENGTH = 64;
-  prparedScriptFileName.append(
+  preparedScriptFileName.append(
       scriptUrl.begin() + ((scriptUrl.size() < MAXLENGTH) ? 0 : (scriptUrl.size() - MAXLENGTH)), scriptUrl.end());
 
   // Make a valid file name.
-  std::replace(prparedScriptFileName.begin(), prparedScriptFileName.end(), '\\', '_');
-  std::replace(prparedScriptFileName.begin(), prparedScriptFileName.end(), '/', '_');
-  std::replace(prparedScriptFileName.begin(), prparedScriptFileName.end(), ':', '_');
-  std::replace(prparedScriptFileName.begin(), prparedScriptFileName.end(), '.', '_');
+  std::replace(preparedScriptFileName.begin(), preparedScriptFileName.end(), '\\', '_');
+  std::replace(preparedScriptFileName.begin(), preparedScriptFileName.end(), '/', '_');
+  std::replace(preparedScriptFileName.begin(), preparedScriptFileName.end(), ':', '_');
+  std::replace(preparedScriptFileName.begin(), preparedScriptFileName.end(), '.', '_');
 
   if (runtimeSignature.runtimeName.empty()) {
     std::terminate();
   }
 
-  prparedScriptFileName.append("_");
-  prparedScriptFileName.append(runtimeSignature.runtimeName);
+  preparedScriptFileName.append("_");
+  preparedScriptFileName.append(runtimeSignature.runtimeName);
 
   if (prepareTag) {
-    prparedScriptFileName.append("_");
-    prparedScriptFileName.append(prepareTag);
+    preparedScriptFileName.append("_");
+    preparedScriptFileName.append(prepareTag);
   }
 
-  // TODO :: Need to constuct a hash. ref:
+  // TODO :: Need to construct a hash. ref:
   // https://en.wikipedia.org/wiki/Base64#Filenames
 
   // extension
-  prparedScriptFileName.append(".cache");
+  preparedScriptFileName.append(".cache");
 
-  return prparedScriptFileName;
+  return preparedScriptFileName;
 }
 
 std::shared_ptr<const jsi::Buffer> BasePreparedScriptStoreImpl::tryGetPreparedScript(
@@ -269,6 +271,24 @@ std::shared_ptr<const jsi::Buffer> BasePreparedScriptStoreImpl::tryGetPreparedSc
     return nullptr;
   }
 
+  std::optional<std::vector<std::uint8_t>> hashBuffer = Microsoft::ReactNative::GetSHA256Hash(
+      reinterpret_cast<const std::uint8_t *>(buffer->data()) + sizeof(PreparedScriptPrefix),
+      static_cast<size_t>(prefix->sizeInBytes));
+  if (!hashBuffer) {
+    // Hashing failed.
+    return nullptr;
+  }
+
+  if (hashBuffer.value().size() < sizeof(prefix->hash)) {
+    // Unexpected hash size.
+    return nullptr;
+  }
+
+  if (memcmp(hashBuffer.value().data(), prefix->hash, sizeof(prefix->hash)) != 0) {
+    // Hash doesn't match. Store is possibly corrupted. It is safer to bail out.
+    return nullptr;
+  }
+
   const PreparedScriptSuffix *suffix = reinterpret_cast<const PreparedScriptSuffix *>(
       buffer->data() + sizeof(PreparedScriptPrefix) + prefix->sizeInBytes);
   if (strncmp(suffix->eof, PERSIST_EOF, sizeof(suffix->eof)) != 0) {
@@ -297,6 +317,15 @@ void BasePreparedScriptStoreImpl::persistPreparedScript(
   prefix->runtimeVersion = runtimeMetadata.version;
   prefix->sizeInBytes = preparedScript->size();
 
+  std::optional<std::vector<std::uint8_t>> hashBuffer =
+      Microsoft::ReactNative::GetSHA256Hash(preparedScript->data(), preparedScript->size());
+  if (!hashBuffer) {
+    // Hashing failed.
+    std::terminate();
+  }
+
+  memcpy_s(prefix->hash, sizeof(prefix->hash), hashBuffer.value().data(), hashBuffer.value().size());
+
   memcpy_s(
       newBuffer->data() + sizeof(PreparedScriptPrefix),
       newBuffer->size() - sizeof(PreparedScriptPrefix),

package/Shared/BaseScriptStoreImpl.h

@@ -73,7 +73,7 @@ class BasePreparedScriptStoreImpl : public facebook::jsi::PreparedScriptStore {
 };
 
 // Dead simple script store implementation assuming that the script url is a
-// local filesystam path and assuming the script version is the script size, but
+// local filesystem path and assuming the script version is the script size, but
 // with extension point to provide custom version provider.
 class BaseScriptStoreImpl : public facebook::jsi::ScriptStore {
  public:

package/Shared/Composition/AutoDraw.h

@@ -0,0 +1,36 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+#include <winrt/Microsoft.ReactNative.Composition.h>
+
+namespace Microsoft::ReactNative::Composition {
+
+class AutoDrawDrawingSurface {
+ public:
+  AutoDrawDrawingSurface(
+      winrt::Microsoft::ReactNative::Composition::IDrawingSurfaceBrush &drawingSurface,
+      POINT *offset) noexcept {
+    drawingSurface.as(m_drawingSurfaceInterop);
+    m_drawingSurfaceInterop->BeginDraw(m_d2dDeviceContext.put(), offset);
+  }
+
+  ~AutoDrawDrawingSurface() noexcept {
+    if (m_d2dDeviceContext) {
+      m_drawingSurfaceInterop->EndDraw();
+    }
+  }
+
+  operator ID2D1DeviceContext *() noexcept {
+    return m_d2dDeviceContext.get();
+  }
+
+  ID2D1DeviceContext *GetRenderTarget() noexcept {
+    return m_d2dDeviceContext.get();
+  }
+
+ private:
+  winrt::com_ptr<ICompositionDrawingSurfaceInterop> m_drawingSurfaceInterop;
+  winrt::com_ptr<ID2D1DeviceContext> m_d2dDeviceContext;
+};
+
+} // namespace Microsoft::ReactNative::Composition

package/Shared/CxxMessageQueue.cpp

@@ -223,7 +223,7 @@ class CxxMessageQueue::QueueRunner {
 CxxMessageQueue::CxxMessageQueue() : qr_(new QueueRunner()) {}
 
 CxxMessageQueue::~CxxMessageQueue() {
-  // TODO(cjhopman): Add detach() so that the queue doesn't have to be
+  // TODO(@cjhopman): Add detach() so that the queue doesn't have to be
   // explicitly stopped.
   if (!qr_->isStopped()) {
     LOG(FATAL) << "Queue not stopped.";

package/Shared/DevSettings.h

@@ -102,6 +102,9 @@ struct DevSettings {
 
   // Transitory. Used to indicate whether or not to load networking types in the default Cxx module registry.
   bool omitNetworkingCxxModules{false};
+
+  // OC:8368383 - Memory leak under investigation.
+  bool useWebSocketTurboModule{false};
 };
 
 } // namespace react

package/Shared/DevSupportManager.h

@@ -50,7 +50,7 @@ class DevSupportManager final : public facebook::react::IDevSupportManager {
   virtual void StopPollingLiveReload() override;
 
   virtual void EnsureHermesInspector(const std::string &packagerHost, const uint16_t packagerPort) noexcept override;
-  virtual void UpdateBundleStatus(bool isLastDownloadSucess, int64_t updateTimestamp) noexcept override;
+  virtual void UpdateBundleStatus(bool isLastDownloadSuccess, int64_t updateTimestamp) noexcept override;
 
  private:
   std::atomic_bool m_cancellation_token;

package/Shared/Hasher.cpp

@@ -0,0 +1,64 @@
+#include "pch.h"
+#include "Hasher.h"
+
+#ifndef NT_SUCCESS
+#define NT_SUCCESS(Status) ((NTSTATUS)(Status) >= 0)
+#endif // NT_SUCCESS
+
+#define CheckNTSuccess(s)      \
+  do {                         \
+    NTSTATUS status = (s);     \
+    if (!NT_SUCCESS(status)) { \
+      throw status;            \
+    }                          \
+  } while (false)
+
+namespace Microsoft::ReactNative {
+
+std::optional<std::vector<std::uint8_t>> GetSHA256Hash(const void *pb, size_t cb) {
+  try {
+    SHA256Hasher hasher;
+    hasher.HashData(pb, cb);
+    return hasher.GetHashValue();
+  } catch (...) {
+    return std::nullopt;
+  }
+}
+
+SHA256Hasher::SHA256Hasher() {
+  CheckNTSuccess(BCryptOpenAlgorithmProvider(&m_hAlg, BCRYPT_SHA256_ALGORITHM, NULL, 0));
+
+  DWORD cbObject;
+  DWORD cbData;
+  CheckNTSuccess(BCryptGetProperty(m_hAlg, BCRYPT_OBJECT_LENGTH, (PBYTE)&cbObject, sizeof(DWORD), &cbData, 0));
+
+  m_hashObject.resize(cbObject);
+  CheckNTSuccess(
+      BCryptCreateHash(m_hAlg, &m_hHash, m_hashObject.data(), static_cast<ULONG>(m_hashObject.size()), NULL, 0, 0));
+}
+
+SHA256Hasher::~SHA256Hasher() {
+  BCryptDestroyHash(m_hHash);
+  BCryptCloseAlgorithmProvider(m_hAlg, 0);
+}
+
+void SHA256Hasher::HashData(const void *pb, size_t cb) {
+  if (cb > LONG_MAX) {
+    // Input too large
+    throw E_INVALIDARG;
+  }
+
+  CheckNTSuccess(BCryptHashData(m_hHash, (PBYTE)pb, (DWORD)cb, 0));
+}
+
+std::vector<std::uint8_t> SHA256Hasher::GetHashValue() {
+  DWORD hashLength;
+  DWORD cbData;
+  CheckNTSuccess(BCryptGetProperty(m_hAlg, BCRYPT_HASH_LENGTH, (PBYTE)&hashLength, sizeof(DWORD), &cbData, 0));
+
+  std::vector<uint8_t> hashValue(hashLength, 0);
+  CheckNTSuccess(BCryptFinishHash(m_hHash, &hashValue[0], static_cast<ULONG>(hashValue.size()), 0));
+
+  return hashValue;
+}
+} // namespace Microsoft::ReactNative

package/Shared/Hasher.h

@@ -0,0 +1,24 @@
+#include <bcrypt.h>
+#include <optional>
+#include <vector>
+
+namespace Microsoft::ReactNative {
+std::optional<std::vector<std::uint8_t>> GetSHA256Hash(const void *pb, size_t cb);
+
+class SHA256Hasher {
+ public:
+  SHA256Hasher();
+  ~SHA256Hasher();
+
+  SHA256Hasher(const SHA256Hasher &) = delete;
+  SHA256Hasher &operator=(const SHA256Hasher &) = delete;
+
+  std::vector<std::uint8_t> GetHashValue();
+  void HashData(const void *pb, size_t cb);
+
+ private:
+  BCRYPT_ALG_HANDLE m_hAlg;
+  BCRYPT_HASH_HANDLE m_hHash;
+  std::vector<std::uint8_t> m_hashObject;
+};
+} // namespace Microsoft::ReactNative

package/Shared/HermesRuntimeHolder.cpp

@@ -38,7 +38,7 @@ void NAPI_CDECL removeInspectorPage(int32_t pageId) noexcept;
 
 class HermesFuncResolver : public IFuncResolver {
  public:
-  HermesFuncResolver() : libHandle_(LoadLibraryAsPeerFirst(L"hermes.dll")) {}
+  HermesFuncResolver() : libHandle_(SafeLoadLibrary(L"hermes.dll")) {}
 
   FuncPtr getFuncPtr(const char *funcName) override {
     return reinterpret_cast<FuncPtr>(GetProcAddress(libHandle_, funcName));
@@ -233,11 +233,11 @@ class HermesScriptCache {
 class HermesLocalConnection : public facebook::react::ILocalConnection {
  public:
   HermesLocalConnection(
-      std::unique_ptr<facebook::react::IRemoteConnection> remoteConneciton,
+      std::unique_ptr<facebook::react::IRemoteConnection> remoteConnection,
       void *connectFunc) noexcept {
     CRASH_ON_ERROR(getHermesApi().hermes_create_local_connection(
         connectFunc,
-        reinterpret_cast<hermes_remote_connection>(remoteConneciton.release()),
+        reinterpret_cast<hermes_remote_connection>(remoteConnection.release()),
         &OnRemoteConnectionSendMessage,
         &OnRemoteConnectionDisconnect,
         &OnRemoteConnectionDelete,
@@ -279,9 +279,9 @@ int32_t NAPI_CDECL addInspectorPage(const char *title, const char *vm, void *con
       title,
       vm,
       [connectFunc,
-       hermesApi = HermesApi::current()](std::unique_ptr<facebook::react::IRemoteConnection> remoteConneciton) {
+       hermesApi = HermesApi::current()](std::unique_ptr<facebook::react::IRemoteConnection> remoteConnection) {
         HermesApi::Scope apiScope(hermesApi);
-        return std::make_unique<HermesLocalConnection>(std::move(remoteConneciton), connectFunc);
+        return std::make_unique<HermesLocalConnection>(std::move(remoteConnection), connectFunc);
       });
 }
 
@@ -359,7 +359,7 @@ void HermesRuntimeHolder::crashHandler(int fileDescriptor) noexcept {
 }
 
 void HermesRuntimeHolder::teardown() noexcept {
-  // TODO: (vmoroz) Implement
+  // TODO: (@vmoroz) Implement
 }
 
 std::shared_ptr<HermesRuntimeHolder> HermesRuntimeHolder::loadFrom(

package/Shared/IDevSupportManager.h

@@ -23,7 +23,7 @@ struct IDevSupportManager {
   virtual void StopPollingLiveReload() = 0;
 
   virtual void EnsureHermesInspector(const std::string &packagerHost, const uint16_t packagerPort) noexcept = 0;
-  virtual void UpdateBundleStatus(bool isLastDownloadSucess, int64_t updateTimestamp) noexcept = 0;
+  virtual void UpdateBundleStatus(bool isLastDownloadSuccess, int64_t updateTimestamp) noexcept = 0;
 };
 
 std::shared_ptr<IDevSupportManager> CreateDevSupportManager();

package/Shared/JSI/ChakraApi.cpp

@@ -96,7 +96,7 @@ ChakraApi::JsRefHolder::~JsRefHolder() noexcept {
 }
 
 /*static*/ void ChakraApi::DisposeRuntime(JsRuntimeHandle runtime) {
-  ChakraVerifyElseThrow(JsDisposeRuntime(runtime) == JsErrorCode::JsNoError, "Cannot dispaose Chakra runtime.");
+  ChakraVerifyElseThrow(JsDisposeRuntime(runtime) == JsErrorCode::JsNoError, "Cannot dispose Chakra runtime.");
 }
 
 /*static*/ uint32_t ChakraApi::AddRef(JsRef ref) {

package/Shared/JSI/ChakraRuntime.cpp

@@ -124,16 +124,16 @@ void ChakraRuntime::PromiseContinuation(JsValueRef funcRef) noexcept {
   }
 }
 
-JsValueRef ChakraRuntime::CreatePropertyDescriptor(JsValueRef value, PropertyAttibutes attrs) {
+JsValueRef ChakraRuntime::CreatePropertyDescriptor(JsValueRef value, PropertyAttributes attrs) {
   JsValueRef descriptor = CreateObject();
   SetProperty(descriptor, m_propertyId.value, value);
-  if (!(attrs & PropertyAttibutes::ReadOnly)) {
+  if (!(attrs & PropertyAttributes::ReadOnly)) {
     SetProperty(descriptor, m_propertyId.writable, BoolToBoolean(true));
   }
-  if (!(attrs & PropertyAttibutes::DontEnum)) {
+  if (!(attrs & PropertyAttributes::DontEnum)) {
     SetProperty(descriptor, m_propertyId.enumerable, BoolToBoolean(true));
   }
-  if (!(attrs & PropertyAttibutes::DontDelete)) {
+  if (!(attrs & PropertyAttributes::DontDelete)) {
     // The JavaScript 'configurable=true' allows property to be deleted.
     SetProperty(descriptor, m_propertyId.configurable, BoolToBoolean(true));
   }
@@ -607,7 +607,7 @@ facebook::jsi::Function ChakraRuntime::createFunctionFromHostFunction(
   DefineProperty(
       function,
       m_propertyId.hostFunctionSymbol,
-      CreatePropertyDescriptor(hostFunctionHolder, PropertyAttibutes::DontEnumAndFrozen));
+      CreatePropertyDescriptor(hostFunctionHolder, PropertyAttributes::DontEnumAndFrozen));
 
   return MakePointer<facebook::jsi::Object>(function).getFunction(*this);
 }
@@ -763,7 +763,7 @@ JsValueRef ChakraRuntime::CreateExternalFunction(
   DefineProperty(
       function,
       m_propertyId.length,
-      CreatePropertyDescriptor(IntToNumber(paramCount), PropertyAttibutes::DontEnumAndFrozen));
+      CreatePropertyDescriptor(IntToNumber(paramCount), PropertyAttributes::DontEnumAndFrozen));
   return function;
 }
 
@@ -773,14 +773,14 @@ JsValueRef CALLBACK ChakraRuntime::HostFunctionCall(
     JsValueRef *args,
     unsigned short argCount,
     void *callbackState) {
-  HostFunctionWrapper *hostFuncWraper = static_cast<HostFunctionWrapper *>(callbackState);
-  ChakraRuntime &chakraRuntime = hostFuncWraper->GetRuntime();
+  HostFunctionWrapper *hostFuncWrapper = static_cast<HostFunctionWrapper *>(callbackState);
+  ChakraRuntime &chakraRuntime = hostFuncWrapper->GetRuntime();
   return chakraRuntime.HandleCallbackExceptions([&]() {
     ChakraVerifyElseThrow(argCount > 0, "There must be at least 'this' argument.");
     const JsiValueView jsiThisArg{*args};
     const JsiValueViewArgs jsiArgs{args + 1, argCount - 1u};
 
-    const facebook::jsi::HostFunctionType &hostFunc = hostFuncWraper->GetHostFunction();
+    const facebook::jsi::HostFunctionType &hostFunc = hostFuncWrapper->GetHostFunction();
     return RunInMethodContext("HostFunction", [&]() {
       return chakraRuntime.ToJsValueRef(hostFunc(chakraRuntime, jsiThisArg, jsiArgs.Data(), jsiArgs.Size()));
     });
@@ -913,7 +913,7 @@ JsValueRef CALLBACK ChakraRuntime::HostFunctionCall(
       const PropNameIDView propertyId{GetPropertyIdFromName(StringToPointer(propertyName).data())};
       return RunInMethodContext("HostObject::getOwnPropertyDescriptor", [&]() {
         auto value = chakraRuntime->ToJsValueRef(hostObject->get(*chakraRuntime, propertyId));
-        auto descriptor = chakraRuntime->CreatePropertyDescriptor(value, PropertyAttibutes::None);
+        auto descriptor = chakraRuntime->CreatePropertyDescriptor(value, PropertyAttributes::None);
         return descriptor;
       });
     }