react-native-windows 0.69.4 → 0.69.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1,5 +1,6 @@
1
1
  // Copyright (c) Microsoft Corporation.
2
2
  // Licensed under the MIT License.
3
+ //
3
4
  // IMPORTANT: Before updating this file
4
5
  // please read react-native-windows repo:
5
6
  // vnext/Microsoft.ReactNative.Cxx/README.md
@@ -21,6 +22,7 @@ using namespace winrt;
21
22
  using namespace Windows::Foundation;
22
23
 
23
24
  namespace winrt::Microsoft::ReactNative {
25
+
24
26
  /*-------------------------------------------------------------------------------
25
27
  TurboModuleBuilder
26
28
  -------------------------------------------------------------------------------*/
@@ -56,10 +58,17 @@ struct TurboModuleBuilder : winrt::implements<TurboModuleBuilder, IReactModuleBu
56
58
  }
57
59
 
58
60
  public:
59
- std::unordered_map<std::string, TurboModuleMethodInfo> m_methods;
60
- std::unordered_map<std::string, SyncMethodDelegate> m_syncMethods;
61
- std::vector<ConstantProviderDelegate> m_constantProviders;
62
- bool m_constantsEvaluated{false};
61
+ const std::unordered_map<std::string, TurboModuleMethodInfo> &Methods() const noexcept {
62
+ return m_methods;
63
+ }
64
+
65
+ const std::unordered_map<std::string, SyncMethodDelegate> &SyncMethods() const noexcept {
66
+ return m_syncMethods;
67
+ }
68
+
69
+ const std::vector<ConstantProviderDelegate> &ConstantProviders() const noexcept {
70
+ return m_constantProviders;
71
+ }
63
72
 
64
73
  private:
65
74
  void EnsureMemberNotSet(const std::string &key, bool checkingMethod) noexcept {
@@ -72,6 +81,10 @@ struct TurboModuleBuilder : winrt::implements<TurboModuleBuilder, IReactModuleBu
72
81
 
73
82
  private:
74
83
  IReactContext m_reactContext;
84
+ std::unordered_map<std::string, TurboModuleMethodInfo> m_methods;
85
+ std::unordered_map<std::string, SyncMethodDelegate> m_syncMethods;
86
+ std::vector<ConstantProviderDelegate> m_constantProviders;
87
+ bool m_constantsEvaluated{false};
75
88
  };
76
89
 
77
90
  /*-------------------------------------------------------------------------------
@@ -84,11 +97,13 @@ class TurboModuleImpl : public facebook::react::TurboModule {
84
97
  const IReactContext &reactContext,
85
98
  const std::string &name,
86
99
  const std::shared_ptr<facebook::react::CallInvoker> &jsInvoker,
100
+ std::weak_ptr<facebook::react::LongLivedObjectCollection> longLivedObjectCollection,
87
101
  const ReactModuleProvider &reactModuleProvider)
88
102
  : facebook::react::TurboModule(name, jsInvoker),
89
103
  m_reactContext(reactContext),
90
- m_moduleBuilder(winrt::make<TurboModuleBuilder>(reactContext)),
91
- m_providedModule(reactModuleProvider(m_moduleBuilder)) {
104
+ m_longLivedObjectCollection(std::move(longLivedObjectCollection)),
105
+ m_moduleBuilder(winrt::make_self<TurboModuleBuilder>(reactContext)),
106
+ m_providedModule(reactModuleProvider(m_moduleBuilder.as<IReactModuleBuilder>())) {
92
107
  if (auto hostObject = m_providedModule.try_as<IJsiHostObject>()) {
93
108
  m_hostObjectWrapper = std::make_shared<implementation::HostObjectWrapper>(hostObject);
94
109
  }
@@ -99,12 +114,23 @@ class TurboModuleImpl : public facebook::react::TurboModule {
99
114
  return m_hostObjectWrapper->getPropertyNames(rt);
100
115
  }
101
116
 
102
- auto turboModuleBuilder = m_moduleBuilder.as<TurboModuleBuilder>();
103
117
  std::vector<facebook::jsi::PropNameID> propertyNames;
104
- propertyNames.reserve(turboModuleBuilder->m_methods.size());
105
- for (auto &methodInfo : turboModuleBuilder->m_methods) {
118
+ propertyNames.reserve(
119
+ m_moduleBuilder->Methods().size() + m_moduleBuilder->SyncMethods().size() +
120
+ (m_moduleBuilder->ConstantProviders().empty() ? 0 : 1));
121
+
122
+ for (auto &methodInfo : m_moduleBuilder->Methods()) {
106
123
  propertyNames.push_back(facebook::jsi::PropNameID::forAscii(rt, methodInfo.first));
107
124
  }
125
+
126
+ for (auto &syncMethodInfo : m_moduleBuilder->SyncMethods()) {
127
+ propertyNames.push_back(facebook::jsi::PropNameID::forAscii(rt, syncMethodInfo.first));
128
+ }
129
+
130
+ if (!m_moduleBuilder->ConstantProviders().empty()) {
131
+ propertyNames.push_back(facebook::jsi::PropNameID::forAscii(rt, "getConstants"));
132
+ }
133
+
108
134
  return propertyNames;
109
135
  };
110
136
 
@@ -114,24 +140,23 @@ class TurboModuleImpl : public facebook::react::TurboModule {
114
140
  }
115
141
 
116
142
  // it is not safe to assume that "runtime" never changes, so members are not cached here
117
- auto moduleBuilder = m_moduleBuilder.as<TurboModuleBuilder>();
118
143
  std::string key = propName.utf8(runtime);
119
144
 
120
- if (key == "getConstants" && !moduleBuilder->m_constantProviders.empty()) {
145
+ if (key == "getConstants" && !m_moduleBuilder->ConstantProviders().empty()) {
121
146
  // try to find getConstants if there is any constant
122
147
  return facebook::jsi::Function::createFromHostFunction(
123
148
  runtime,
124
149
  propName,
125
150
  0,
126
- [moduleBuilder](
151
+ [moduleBuilder = m_moduleBuilder](
127
152
  facebook::jsi::Runtime &rt,
128
- const facebook::jsi::Value &thisVal,
129
- const facebook::jsi::Value *args,
130
- size_t count) {
153
+ const facebook::jsi::Value & /*thisVal*/,
154
+ const facebook::jsi::Value * /*args*/,
155
+ size_t /*count*/) {
131
156
  // collect all constants to an object
132
157
  auto writer = winrt::make<JsiWriter>(rt);
133
158
  writer.WriteObjectBegin();
134
- for (auto constantProvider : moduleBuilder->m_constantProviders) {
159
+ for (auto const &constantProvider : moduleBuilder->ConstantProviders()) {
135
160
  constantProvider(writer);
136
161
  }
137
162
  writer.WriteObjectEnd();
@@ -141,21 +166,21 @@ class TurboModuleImpl : public facebook::react::TurboModule {
141
166
 
142
167
  {
143
168
  // try to find a Method
144
- auto it = moduleBuilder->m_methods.find(key);
145
- if (it != moduleBuilder->m_methods.end()) {
146
- TurboModuleMethodInfo methodInfo = it->second;
169
+ auto it = m_moduleBuilder->Methods().find(key);
170
+ if (it != m_moduleBuilder->Methods().end()) {
171
+ TurboModuleMethodInfo const &methodInfo = it->second;
147
172
  switch (methodInfo.ReturnType) {
148
173
  case MethodReturnType::Void:
149
174
  return facebook::jsi::Function::createFromHostFunction(
150
175
  runtime,
151
176
  propName,
152
177
  0,
153
- [methodInfo](
178
+ [method = methodInfo.Method](
154
179
  facebook::jsi::Runtime &rt,
155
180
  const facebook::jsi::Value & /*thisVal*/,
156
181
  const facebook::jsi::Value *args,
157
182
  size_t argCount) {
158
- methodInfo.Method(winrt::make<JsiReader>(rt, args, argCount), nullptr, nullptr, nullptr);
183
+ method(winrt::make<JsiReader>(rt, args, argCount), nullptr, nullptr, nullptr);
159
184
  return facebook::jsi::Value::undefined();
160
185
  });
161
186
  case MethodReturnType::Callback:
@@ -163,17 +188,22 @@ class TurboModuleImpl : public facebook::react::TurboModule {
163
188
  runtime,
164
189
  propName,
165
190
  0,
166
- [jsDispatcher = m_reactContext.JSDispatcher(), methodInfo](
191
+ [jsDispatcher = m_reactContext.JSDispatcher(),
192
+ method = methodInfo.Method,
193
+ longLivedObjectCollection = m_longLivedObjectCollection](
167
194
  facebook::jsi::Runtime &rt,
168
195
  const facebook::jsi::Value & /*thisVal*/,
169
196
  const facebook::jsi::Value *args,
170
197
  size_t argCount) {
171
198
  VerifyElseCrash(argCount > 0);
172
- methodInfo.Method(
173
- winrt::make<JsiReader>(rt, args, argCount - 1),
174
- winrt::make<JSDispatcherWriter>(jsDispatcher, rt),
175
- MakeCallback(rt, {rt, args[argCount - 1]}),
176
- nullptr);
199
+ if (auto strongLongLivedObjectCollection = longLivedObjectCollection.lock()) {
200
+ auto jsiRuntimeHolder = LongLivedJsiRuntime::CreateWeak(strongLongLivedObjectCollection, rt);
201
+ method(
202
+ winrt::make<JsiReader>(rt, args, argCount - 1),
203
+ winrt::make<JSDispatcherWriter>(jsDispatcher, jsiRuntimeHolder),
204
+ MakeCallback(rt, strongLongLivedObjectCollection, args[argCount - 1]),
205
+ nullptr);
206
+ }
177
207
  return facebook::jsi::Value::undefined();
178
208
  });
179
209
  case MethodReturnType::TwoCallbacks:
@@ -181,17 +211,22 @@ class TurboModuleImpl : public facebook::react::TurboModule {
181
211
  runtime,
182
212
  propName,
183
213
  0,
184
- [jsDispatcher = m_reactContext.JSDispatcher(), methodInfo](
214
+ [jsDispatcher = m_reactContext.JSDispatcher(),
215
+ method = methodInfo.Method,
216
+ longLivedObjectCollection = m_longLivedObjectCollection](
185
217
  facebook::jsi::Runtime &rt,
186
218
  const facebook::jsi::Value & /*thisVal*/,
187
219
  const facebook::jsi::Value *args,
188
220
  size_t argCount) {
189
221
  VerifyElseCrash(argCount > 1);
190
- methodInfo.Method(
191
- winrt::make<JsiReader>(rt, args, argCount - 2),
192
- winrt::make<JSDispatcherWriter>(jsDispatcher, rt),
193
- MakeCallback(rt, {rt, args[argCount - 2]}),
194
- MakeCallback(rt, {rt, args[argCount - 1]}));
222
+ if (auto strongLongLivedObjectCollection = longLivedObjectCollection.lock()) {
223
+ auto jsiRuntimeHolder = LongLivedJsiRuntime::CreateWeak(strongLongLivedObjectCollection, rt);
224
+ method(
225
+ winrt::make<JsiReader>(rt, args, argCount - 2),
226
+ winrt::make<JSDispatcherWriter>(jsDispatcher, jsiRuntimeHolder),
227
+ MakeCallback(rt, strongLongLivedObjectCollection, args[argCount - 2]),
228
+ MakeCallback(rt, strongLongLivedObjectCollection, args[argCount - 1]));
229
+ }
195
230
  return facebook::jsi::Value::undefined();
196
231
  });
197
232
  case MethodReturnType::Promise:
@@ -199,52 +234,66 @@ class TurboModuleImpl : public facebook::react::TurboModule {
199
234
  runtime,
200
235
  propName,
201
236
  0,
202
- [jsDispatcher = m_reactContext.JSDispatcher(), methodInfo](
237
+ [jsDispatcher = m_reactContext.JSDispatcher(),
238
+ method = methodInfo.Method,
239
+ longLivedObjectCollection = m_longLivedObjectCollection](
203
240
  facebook::jsi::Runtime &rt,
204
241
  const facebook::jsi::Value & /*thisVal*/,
205
242
  const facebook::jsi::Value *args,
206
243
  size_t count) {
207
- auto argReader = winrt::make<JsiReader>(rt, args, count);
208
- auto argWriter = winrt::make<JSDispatcherWriter>(jsDispatcher, rt);
209
- return facebook::react::createPromiseAsJSIValue(
210
- rt,
211
- [methodInfo, argReader, argWriter](
212
- facebook::jsi::Runtime &runtime, std::shared_ptr<facebook::react::Promise> promise) {
213
- methodInfo.Method(
214
- argReader,
215
- argWriter,
216
- [promise](const IJSValueWriter &writer) {
217
- writer.as<JSDispatcherWriter>()->WithResultArgs([promise](
218
- facebook::jsi::Runtime &runtime,
219
- facebook::jsi::Value const *args,
220
- size_t argCount) {
221
- VerifyElseCrash(argCount == 1);
222
- promise->resolve(args[0]);
244
+ if (auto strongLongLivedObjectCollection = longLivedObjectCollection.lock()) {
245
+ auto jsiRuntimeHolder = LongLivedJsiRuntime::CreateWeak(strongLongLivedObjectCollection, rt);
246
+ auto argReader = winrt::make<JsiReader>(rt, args, count);
247
+ auto argWriter = winrt::make<JSDispatcherWriter>(jsDispatcher, jsiRuntimeHolder);
248
+ return facebook::react::createPromiseAsJSIValue(
249
+ rt,
250
+ [method, argReader, argWriter, strongLongLivedObjectCollection](
251
+ facebook::jsi::Runtime &runtime, std::shared_ptr<facebook::react::Promise> promise) {
252
+ method(
253
+ argReader,
254
+ argWriter,
255
+ [weakResolve = LongLivedJsiFunction::CreateWeak(
256
+ strongLongLivedObjectCollection, runtime, std::move(promise->resolve_))](
257
+ const IJSValueWriter &writer) {
258
+ writer.as<JSDispatcherWriter>()->WithResultArgs([weakResolve](
259
+ facebook::jsi::Runtime &runtime,
260
+ facebook::jsi::Value const *args,
261
+ size_t argCount) {
262
+ VerifyElseCrash(argCount == 1);
263
+ if (auto resolveHolder = weakResolve.lock()) {
264
+ resolveHolder->Value().call(runtime, args[0]);
265
+ }
266
+ });
267
+ },
268
+ [weakReject = LongLivedJsiFunction::CreateWeak(
269
+ strongLongLivedObjectCollection, runtime, std::move(promise->reject_))](
270
+ const IJSValueWriter &writer) {
271
+ writer.as<JSDispatcherWriter>()->WithResultArgs([weakReject](
272
+ facebook::jsi::Runtime &runtime,
273
+ facebook::jsi::Value const *args,
274
+ size_t argCount) {
275
+ VerifyElseCrash(argCount == 1);
276
+ if (auto rejectHolder = weakReject.lock()) {
277
+ // To match the Android and iOS TurboModule behavior we create the Error object for
278
+ // the Promise rejection the same way as in updateErrorWithErrorData method.
279
+ // See react-native/Libraries/BatchedBridge/NativeModules.js for details.
280
+ auto error = runtime.global()
281
+ .getPropertyAsFunction(runtime, "Error")
282
+ .callAsConstructor(runtime, {});
283
+ auto &errorData = args[0];
284
+ if (errorData.isObject()) {
285
+ runtime.global()
286
+ .getPropertyAsObject(runtime, "Object")
287
+ .getPropertyAsFunction(runtime, "assign")
288
+ .call(runtime, error, errorData.getObject(runtime));
289
+ }
290
+ rejectHolder->Value().call(runtime, args[0]);
291
+ }
292
+ });
223
293
  });
224
- },
225
- [promise](const IJSValueWriter &writer) {
226
- writer.as<JSDispatcherWriter>()->WithResultArgs([promise](
227
- facebook::jsi::Runtime &runtime,
228
- facebook::jsi::Value const *args,
229
- size_t argCount) {
230
- VerifyElseCrash(argCount == 1);
231
- // To match the Android and iOS TurboModule behavior we create the Error object for
232
- // the Promise rejection the same way as in updateErrorWithErrorData method.
233
- // See react-native/Libraries/BatchedBridge/NativeModules.js for details.
234
- auto error = runtime.global()
235
- .getPropertyAsFunction(runtime, "Error")
236
- .callAsConstructor(runtime, {});
237
- auto &errorData = args[0];
238
- if (errorData.isObject()) {
239
- runtime.global()
240
- .getPropertyAsObject(runtime, "Object")
241
- .getPropertyAsFunction(runtime, "assign")
242
- .call(runtime, error, errorData.getObject(runtime));
243
- }
244
- promise->reject_.call(runtime, error);
245
- });
246
- });
247
- });
294
+ });
295
+ }
296
+ return facebook::jsi::Value::undefined();
248
297
  });
249
298
  default:
250
299
  VerifyElseCrash(false);
@@ -254,8 +303,8 @@ class TurboModuleImpl : public facebook::react::TurboModule {
254
303
 
255
304
  {
256
305
  // try to find a SyncMethod
257
- auto it = moduleBuilder->m_syncMethods.find(key);
258
- if (it != moduleBuilder->m_syncMethods.end()) {
306
+ auto it = m_moduleBuilder->SyncMethods().find(key);
307
+ if (it != m_moduleBuilder->SyncMethods().end()) {
259
308
  return facebook::jsi::Function::createFromHostFunction(
260
309
  runtime,
261
310
  propName,
@@ -287,27 +336,34 @@ class TurboModuleImpl : public facebook::react::TurboModule {
287
336
  }
288
337
 
289
338
  private:
290
- static MethodResultCallback MakeCallback(facebook::jsi::Runtime &runtime, facebook::jsi::Value callback) noexcept {
291
- auto sharedCallback =
292
- std::make_shared<facebook::jsi::Function>(std::move(callback).asObject(runtime).asFunction(runtime));
293
- return [sharedCallback = std::move(sharedCallback)](const IJSValueWriter &writer) noexcept {
339
+ static MethodResultCallback MakeCallback(
340
+ facebook::jsi::Runtime &rt,
341
+ const std::shared_ptr<facebook::react::LongLivedObjectCollection> &longLivedObjectCollection,
342
+ const facebook::jsi::Value &callback) noexcept {
343
+ auto weakCallback =
344
+ LongLivedJsiFunction::CreateWeak(longLivedObjectCollection, rt, callback.getObject(rt).getFunction(rt));
345
+ return [weakCallback = std::move(weakCallback)](const IJSValueWriter &writer) noexcept {
294
346
  writer.as<JSDispatcherWriter>()->WithResultArgs(
295
- [sharedCallback](facebook::jsi::Runtime &rt, facebook::jsi::Value const *args, size_t count) {
296
- sharedCallback->call(rt, args, count);
347
+ [weakCallback](facebook::jsi::Runtime &rt, facebook::jsi::Value const *args, size_t count) {
348
+ if (auto callback = weakCallback.lock()) {
349
+ callback->Value().call(rt, args, count);
350
+ }
297
351
  });
298
352
  };
299
353
  }
300
354
 
301
355
  private:
302
356
  IReactContext m_reactContext;
303
- IReactModuleBuilder m_moduleBuilder;
357
+ winrt::com_ptr<TurboModuleBuilder> m_moduleBuilder;
304
358
  IInspectable m_providedModule;
305
359
  std::shared_ptr<implementation::HostObjectWrapper> m_hostObjectWrapper;
360
+ std::weak_ptr<facebook::react::LongLivedObjectCollection> m_longLivedObjectCollection;
306
361
  };
307
362
 
308
363
  /*-------------------------------------------------------------------------------
309
364
  TurboModulesProvider
310
365
  -------------------------------------------------------------------------------*/
366
+
311
367
  std::shared_ptr<facebook::react::TurboModule> TurboModulesProvider::getModule(
312
368
  const std::string &moduleName,
313
369
  const std::shared_ptr<facebook::react::CallInvoker> &callInvoker) noexcept {
@@ -317,7 +373,8 @@ std::shared_ptr<facebook::react::TurboModule> TurboModulesProvider::getModule(
317
373
  return nullptr;
318
374
  }
319
375
 
320
- auto tm = std::make_shared<TurboModuleImpl>(m_reactContext, moduleName, callInvoker, it->second);
376
+ auto tm = std::make_shared<TurboModuleImpl>(
377
+ m_reactContext, moduleName, callInvoker, m_longLivedObjectCollection, /*reactModuleProvider*/ it->second);
321
378
  return tm;
322
379
  }
323
380
 
@@ -348,4 +405,9 @@ void TurboModulesProvider::AddModuleProvider(
348
405
  }
349
406
  }
350
407
 
408
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &
409
+ TurboModulesProvider::LongLivedObjectCollection() noexcept {
410
+ return m_longLivedObjectCollection;
411
+ }
412
+
351
413
  } // namespace winrt::Microsoft::ReactNative
@@ -6,6 +6,7 @@
6
6
 
7
7
  #pragma once
8
8
 
9
+ #include <ReactCommon/LongLivedObject.h>
9
10
  #include <TurboModuleRegistry.h>
10
11
  #include "Base/FollyIncludes.h"
11
12
  #include "winrt/Microsoft.ReactNative.h"
@@ -25,8 +26,12 @@ class TurboModulesProvider final : public facebook::react::TurboModuleRegistry {
25
26
  winrt::hstring const &moduleName,
26
27
  ReactModuleProvider const &moduleProvider,
27
28
  bool overwriteExisting) noexcept;
29
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &LongLivedObjectCollection() noexcept;
28
30
 
29
31
  private:
32
+ // To keep a list of deferred asynchronous callbacks and promises.
33
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> m_longLivedObjectCollection{
34
+ std::make_shared<facebook::react::LongLivedObjectCollection>()};
30
35
  std::unordered_map<std::string, ReactModuleProvider> m_moduleProviders;
31
36
  IReactContext m_reactContext;
32
37
  };
@@ -118,17 +118,22 @@ struct BrushCache {
118
118
  return RegisterBrush(resourceName, brush);
119
119
  }
120
120
 
121
- winrt::IInspectable resource{winrt::Application::Current().Resources().Lookup(winrt::box_value(resourceName))};
122
-
123
- if (auto brush = resource.try_as<xaml::Media::Brush>()) {
124
- return RegisterBrush(resourceName, brush);
125
- } else if (auto color = resource.try_as<winrt::Windows::UI::Color>()) {
126
- auto brush = xaml::Media::SolidColorBrush(color.value());
127
- return RegisterBrush(resourceName, brush);
121
+ const auto appResources{winrt::Application::Current().Resources()};
122
+ const auto boxedResourceName{winrt::box_value(resourceName)};
123
+ if (appResources.HasKey(boxedResourceName)) {
124
+ winrt::IInspectable resource{appResources.Lookup(boxedResourceName)};
125
+
126
+ if (auto brush = resource.try_as<xaml::Media::Brush>()) {
127
+ return RegisterBrush(resourceName, brush);
128
+ } else if (auto color = resource.try_as<winrt::Windows::UI::Color>()) {
129
+ auto brush = xaml::Media::SolidColorBrush(color.value());
130
+ return RegisterBrush(resourceName, brush);
131
+ }
128
132
  }
129
133
 
130
134
  assert(false && "Resource is not a Color or Brush");
131
- return nullptr;
135
+ return xaml::Media::SolidColorBrush(winrt::Colors::Transparent());
136
+ ;
132
137
  }
133
138
 
134
139
  xaml::Media::Brush RegisterBrush(winrt::hstring resourceName, const xaml::Media::Brush &brush) {
@@ -143,7 +143,7 @@ bool ImageViewManager::UpdateProperty(
143
143
  } else if (propertyName == "tintColor") {
144
144
  const auto isValidColorValue = IsValidColorValue(propertyValue);
145
145
  if (isValidColorValue || propertyValue.IsNull()) {
146
- const auto color = isValidColorValue ? ColorFrom(propertyValue) : winrt::Colors::Transparent();
146
+ const auto color = isValidColorValue ? SolidColorBrushFrom(propertyValue).Color() : winrt::Colors::Transparent();
147
147
  reactImage->TintColor(color);
148
148
  }
149
149
  // Override default accessibility behavior
@@ -265,9 +265,11 @@ bool ViewManagerBase::UpdateProperty(
265
265
  const auto iter = pointerEventsMap.find(propertyValue.AsString());
266
266
  if (iter != pointerEventsMap.end()) {
267
267
  nodeToUpdate->m_pointerEvents = iter->second;
268
- if (nodeToUpdate->m_pointerEvents == PointerEventsKind::None) {
269
- if (const auto uiElement = nodeToUpdate->GetView().try_as<xaml::UIElement>()) {
268
+ if (const auto uiElement = nodeToUpdate->GetView().try_as<xaml::UIElement>()) {
269
+ if (nodeToUpdate->m_pointerEvents == PointerEventsKind::None) {
270
270
  uiElement.IsHitTestVisible(false);
271
+ } else {
272
+ uiElement.ClearValue(xaml::UIElement::IsHitTestVisibleProperty());
271
273
  }
272
274
  }
273
275
  } else {
@@ -0,0 +1,84 @@
1
+ // Copyright (c) Microsoft Corporation.
2
+ // Licensed under the MIT License.
3
+ #pragma once
4
+ #ifndef MICROSOFT_REACTNATIVE_JSI_LONGLIVEDJSIVALUE_
5
+ #define MICROSOFT_REACTNATIVE_JSI_LONGLIVEDJSIVALUE_
6
+
7
+ #include <ReactCommon/LongLivedObject.h>
8
+ #include <jsi/jsi.h>
9
+
10
+ namespace winrt::Microsoft::ReactNative {
11
+
12
+ // Wrap up JSI Runtime into a LongLivedObject
13
+ struct LongLivedJsiRuntime : facebook::react::LongLivedObject {
14
+ static std::weak_ptr<LongLivedJsiRuntime> CreateWeak(
15
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &longLivedObjectCollection,
16
+ facebook::jsi::Runtime &runtime) noexcept {
17
+ auto value = std::shared_ptr<LongLivedJsiRuntime>(new LongLivedJsiRuntime(longLivedObjectCollection, runtime));
18
+ longLivedObjectCollection->add(value);
19
+ return value;
20
+ }
21
+
22
+ facebook::jsi::Runtime &Runtime() {
23
+ return runtime_;
24
+ }
25
+
26
+ public: // LongLivedObject overrides
27
+ void allowRelease() override {
28
+ if (auto longLivedObjectCollection = longLivedObjectCollection_.lock()) {
29
+ if (longLivedObjectCollection != nullptr) {
30
+ longLivedObjectCollection->remove(this);
31
+ return;
32
+ }
33
+ }
34
+ LongLivedObject::allowRelease();
35
+ }
36
+
37
+ protected:
38
+ LongLivedJsiRuntime(
39
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &longLivedObjectCollection,
40
+ facebook::jsi::Runtime &runtime)
41
+ : longLivedObjectCollection_(longLivedObjectCollection), runtime_(runtime) {}
42
+
43
+ LongLivedJsiRuntime(LongLivedJsiRuntime const &) = delete;
44
+
45
+ private:
46
+ // Use a weak reference to the collection to avoid reference loops
47
+ std::weak_ptr<facebook::react::LongLivedObjectCollection> longLivedObjectCollection_;
48
+ facebook::jsi::Runtime &runtime_;
49
+ };
50
+
51
+ // Wrap up a JSI Value into a LongLivedObject.
52
+ template <typename TValue>
53
+ struct LongLivedJsiValue : LongLivedJsiRuntime {
54
+ static std::weak_ptr<LongLivedJsiValue<TValue>> CreateWeak(
55
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &longLivedObjectCollection,
56
+ facebook::jsi::Runtime &runtime,
57
+ TValue &&value) noexcept {
58
+ auto valueWrapper = std::shared_ptr<LongLivedJsiValue<TValue>>(
59
+ new LongLivedJsiValue<TValue>(longLivedObjectCollection, runtime, std::forward<TValue>(value)));
60
+ longLivedObjectCollection->add(valueWrapper);
61
+ return valueWrapper;
62
+ }
63
+
64
+ TValue &Value() {
65
+ return value_;
66
+ }
67
+
68
+ protected:
69
+ template <typename TValue2>
70
+ LongLivedJsiValue(
71
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> const &longLivedObjectCollection,
72
+ facebook::jsi::Runtime &runtime,
73
+ TValue2 &&value)
74
+ : LongLivedJsiRuntime(longLivedObjectCollection, runtime), value_(std::forward<TValue2>(value)) {}
75
+
76
+ private:
77
+ TValue value_;
78
+ };
79
+
80
+ using LongLivedJsiFunction = LongLivedJsiValue<facebook::jsi::Function>;
81
+
82
+ } // namespace winrt::Microsoft::ReactNative
83
+
84
+ #endif // MICROSOFT_REACTNATIVE_JSI_LONGLIVEDJSIVALUE_
@@ -38,6 +38,7 @@
38
38
  <ClInclude Include="$(JSI_SourcePath)\jsi\jsi-inl.h" />
39
39
  <ClInclude Include="$(JSI_SourcePath)\jsi\jsi.h" />
40
40
  <ClInclude Include="$(MSBuildThisFileDirectory)DesktopWindowBridge.h" />
41
+ <ClInclude Include="$(MSBuildThisFileDirectory)JSI\LongLivedJsiValue.h" />
41
42
  <ClInclude Include="$(MSBuildThisFileDirectory)JSI\NodeApiJsiRuntime.h" />
42
43
  <ClInclude Include="$(MSBuildThisFileDirectory)TurboModuleProvider.h" />
43
44
  <ClInclude Include="$(CallInvoker_SourcePath)\ReactCommon\CallInvoker.h" />
@@ -151,6 +151,9 @@
151
151
  <Filter>JSI</Filter>
152
152
  </ClInclude>
153
153
  <ClInclude Include="$(Bridging_SourcePath)\CallbackWrapper.h" />
154
+ <ClInclude Include="$(MSBuildThisFileDirectory)JSI\LongLivedJsiValue.h">
155
+ <Filter>TurboModule</Filter>
156
+ </ClInclude>
154
157
  </ItemGroup>
155
158
  <ItemGroup>
156
159
  <Filter Include="JSI">
@@ -289,7 +289,12 @@ void UISchedulerWinRT::AwaitTermination() noexcept {
289
289
  return queue;
290
290
  }
291
291
 
292
- auto dispatcher = DispatcherQueue::GetForCurrentThread();
292
+ decltype(DispatcherQueue::GetForCurrentThread()) dispatcher{nullptr};
293
+ try {
294
+ dispatcher = DispatcherQueue::GetForCurrentThread();
295
+ } catch (winrt::hresult_error const &) {
296
+ }
297
+
293
298
  if (!dispatcher) {
294
299
  return queue;
295
300
  }
@@ -10,10 +10,10 @@
10
10
  -->
11
11
  <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
12
12
  <PropertyGroup>
13
- <ReactNativeWindowsVersion>0.69.4</ReactNativeWindowsVersion>
13
+ <ReactNativeWindowsVersion>0.69.7</ReactNativeWindowsVersion>
14
14
  <ReactNativeWindowsMajor>0</ReactNativeWindowsMajor>
15
15
  <ReactNativeWindowsMinor>69</ReactNativeWindowsMinor>
16
- <ReactNativeWindowsPatch>4</ReactNativeWindowsPatch>
16
+ <ReactNativeWindowsPatch>7</ReactNativeWindowsPatch>
17
17
  <ReactNativeWindowsCanary>false</ReactNativeWindowsCanary>
18
18
  </PropertyGroup>
19
19
  </Project>
@@ -41,6 +41,35 @@ std::shared_ptr<InstanceWrapper> CreateReactInstance(
41
41
  std::move(jsBundleBasePath),
42
42
  std::move(cxxModules),
43
43
  std::move(turboModuleRegistry),
44
+ nullptr,
45
+ std::move(callback),
46
+ std::move(jsQueue),
47
+ std::move(nativeQueue),
48
+ std::move(devSettings),
49
+ GetSharedDevManager());
50
+
51
+ return inner;
52
+ }
53
+
54
+ std::shared_ptr<InstanceWrapper> CreateReactInstance(
55
+ std::shared_ptr<Instance> &&instance,
56
+ std::string &&jsBundleBasePath,
57
+ std::vector<
58
+ std::tuple<std::string, facebook::xplat::module::CxxModule::Provider, std::shared_ptr<MessageQueueThread>>>
59
+ &&cxxModules,
60
+ std::shared_ptr<TurboModuleRegistry> turboModuleRegistry,
61
+ std::shared_ptr<facebook::react::LongLivedObjectCollection> longLivedObjectCollection,
62
+ std::unique_ptr<InstanceCallback> &&callback,
63
+ std::shared_ptr<MessageQueueThread> jsQueue,
64
+ std::shared_ptr<MessageQueueThread> nativeQueue,
65
+ std::shared_ptr<DevSettings> devSettings) noexcept {
66
+ // Now create the instance
67
+ std::shared_ptr<InstanceWrapper> inner = InstanceImpl::MakeNoBundle(
68
+ std::move(instance),
69
+ std::move(jsBundleBasePath),
70
+ std::move(cxxModules),
71
+ std::move(turboModuleRegistry),
72
+ std::move(longLivedObjectCollection),
44
73
  std::move(callback),
45
74
  std::move(jsQueue),
46
75
  std::move(nativeQueue),